- 08 Nov, 2018 40 commits
-
-
Yuki Shiino authored
We've been allowing cross-origin named access on Window just in order to keep the backward compatibility for a while. This patch finally fixes it and ignores cross-origin window name when performing named access on Window. Basically, this is a revert of https://codereview.chromium.org/2753773003 Bug: 538562 Change-Id: I3856bb5c655a9415c2d0b87d1ec4b3743b94d076 Reviewed-on: https://chromium-review.googlesource.com/c/1314021Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606373}
-
John Abd-El-Malek authored
Remove some duplicate code between NavigationURLLoaderImpl and ResourceDispatcherHostImpl::BeginNavigationRequest. Change-Id: I7befae9ca3d332d5d31a5d0424de8eeb355a8810 Reviewed-on: https://chromium-review.googlesource.com/c/1325151 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606372}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c248c0542bc1..2f8889b876d3 git log c248c0542bc1..2f8889b876d3 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1bf18ce9e2ca..448b99f1a580 (1 commits) 2018-11-07 mtklein@google.com Reland "Revert "hide nested hinting enum"" Created with: gclient setdep -r src/third_party/skia@2f8889b876d3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I84d82a9be38b63e9069d494e0f2b4cc26c6a7769 Reviewed-on: https://chromium-review.googlesource.com/c/1325652Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606371}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/991ed76c8331..bd8b72d215eb Created with: gclient setdep -r src-internal@bd8b72d215eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia59d1db40325c22f70f1f86477e9a6b94c2092a2 Reviewed-on: https://chromium-review.googlesource.com/c/1325656Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606370}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Id7ee6f3fae084182f0090ce94b9fabf9a14b72fa Reviewed-on: https://chromium-review.googlesource.com/c/1325654Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5e90efc65a..538b8fbb4875 git log fd5e90efc65a..538b8fbb4875 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dgarrett@google.com repository: Use faster copy for Preload. Created with: gclient setdep -r src/third_party/chromite@538b8fbb4875 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icb554700c85d36cfd67c6e2a2f6dbbb595f8ee01 Reviewed-on: https://chromium-review.googlesource.com/c/1325336Reviewed-by:
-
Yuta Kitamura authored
In some tests, FakeRendererScheduler is used to obtain the IPC task runner. However, FakeRendererScheduler::IPCTaskRunner() just returns nullptr, and there's no real point in using FakeRendererScheduler in those tests. This CL removes those unnecessary FakeRendererSchedulers, and passes nullptr to the arguments where an IPC task runner is expected. This CL is part of the refactoring of WebThreadScheduler. Bug: 826203 Change-Id: Ie6800829b3f30cf19a1c2212e58e4cab505df80b Reviewed-on: https://chromium-review.googlesource.com/c/1319224 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606367}
-
Evan Stade authored
Bug: 797558 Change-Id: I859f90bb23f4a9ff6550d2a2bffcdb71ba73282d Reviewed-on: https://chromium-review.googlesource.com/c/1324148Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606366}
-
Eric Orth authored
Removed a bunch of whitelist entries that were no longer needed, mostly due to completed servicification migrations. Some usage was no-longer-needed includes that I removed, and all of UrlInfo appeared to be no longer used or present in build files so I removed the whole class and tests. Some usage of MDnsClient was just accessing the Get...Endpoint() methods that could easily be moved to net/dns/public and thus no longer require whitelisting. Ensured all remaining whitelist entries were commented with why usage is appropriate or with a TODO and bug for anything still requiring servicification migration. Bug: 846454 Change-Id: I39aeeaa437bd8fe2899e78189ca7ef0adbffd1f6 Reviewed-on: https://chromium-review.googlesource.com/c/1320511 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606365}
-
Matt Falkenhagen authored
No behavior change. According to the Blink C++ style guide, functions that aren't for web-exposed bindings must be uppercase CamelCase(). Also order some functions to match the idl. Change-Id: I7def926826a352929db20d96d7b74460d7e074c0 Reviewed-on: https://chromium-review.googlesource.com/c/1325577Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606364}
-
Leo Zhang authored
Change-Id: Ie4008527ec268b1c67704bdc1e7ede4b60caf17e Reviewed-on: https://chromium-review.googlesource.com/c/1321709Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606363}
-
Matt Falkenhagen authored
It was accidentally removed in r606118. Bug: 901909 Change-Id: I8a3e96b6ed2acc1aac7f71b9de30206771cb8ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1325591Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now Chrome specific origin permissions are handled in extensions::DispatcherDelegate implementation in chrome/renderer/extensions. To share this code with new callers in browser process, this change moves the method to ExtensionsClient so that browser side callers can call it. Bug: 870172 Change-Id: I0a55bd41b0eccb3450c7b6b32bc1fa5105ac3856 Reviewed-on: https://chromium-review.googlesource.com/c/1314018Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#606361}
-
Koji Ishii authored
This patch allows reusing line boxes when it is easy to resolve BFC offset. It was one of the most common criteria that prevents reusing. HandleInFlow resolves BFC for non-empty inline formatting context. The reusability increases by moving the logic to after that. This patch improves line-layout-repeat-append by ~60%. Bug: 636993 Change-Id: I90d63addd934f6966c76baa1e4dd312b68f6df4e Reviewed-on: https://chromium-review.googlesource.com/c/1314076Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606360}
-
Varun Khaneja authored
This should catch the cases when the callback is unexpectedly null and provide a more useful call stack. I'm not convinced this will trigger because the code already de-references callback 2 lines later but I don't have a better lead at the moment. Bug: 889972 Change-Id: If63da6f5eaa611e9369da7c70cfcfc784695f01c Reviewed-on: https://chromium-review.googlesource.com/c/1323721Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606359}
-
Michael Lippautz authored
Use asyncGC instead of window.gc(). Bug: 843903 Change-Id: Id65e65d4b3cd68a1510b3d7aff759232fc6c972b Reviewed-on: https://chromium-review.googlesource.com/c/1324616 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316dba28ff32..991ed76c8331 Created with: gclient setdep -r src-internal@991ed76c8331 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib54f2ca5ca0a1a7a50358163f3dd0e4545e73225 Reviewed-on: https://chromium-review.googlesource.com/c/1325396Reviewed-by:
-
Alexey Baskakov authored
To ensure URL correctness. Bug: 891172 Change-Id: If2fad77d59a3675f30c168e55c376a5c53d43262 Reviewed-on: https://chromium-review.googlesource.com/c/1325573 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606356}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 766678 Change-Id: Ib67286038ee8d3f1db66a095f029e5f6a7f000d4 Reviewed-on: https://chromium-review.googlesource.com/c/1325209Reviewed-by:
-
Scott Graham authored
Bug: 883496 Change-Id: I656ef4172089f65b6febf0ba3075a510bb4e9e11 Reviewed-on: https://chromium-review.googlesource.com/c/1318835 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606354}
-
Nicholas Verne authored
This code now avoids a redundant check of crostini UI allowed. Bug: None Change-Id: I34c15883eccb2446b4cab0388ca479c7203ed65e Reviewed-on: https://chromium-review.googlesource.com/c/1325273Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606353}
-
Lukasz Anforowicz authored
Overview ======== This CL re-enables separate URLLoaderFactories for extensions. This is possible because of AppCache-related fixes described below. Re-enabling is done by effectively reverting r599434. AppCache is important, because it represents the scenarios when RenderFrameHostImpl::CommitNavigation uses a non-network-bound default URLLoaderFactory (e.g. in these scenarios the default factory is *not* created via CreateNetworkServiceDefaultFactoryAndObserve). A regression test for such scenarios is added in CrossOriginReadBlockingExtensionTest.ProgrammaticContentScriptVsAppCache For an overview of separate URLLoaderFactories for extensions, see https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Avoiding cloberring of the default factory ========================================== This CL ensures that the initial injection of a content script doesn't result in cloberring the default URLLoaderFactory, by making sure RenderFrameHostImpl::MarkInitiatorsAsRequiringSeparateURLLoaderFactory is capable of pushing down only the new, initiator-specific factories (without touching the default factory and/or other, untouched initiator-specific factories). This also requires ensuring that RenderFrameHostImpl::CreateInitiatorSpecificURLLoaderFactories takes as input the origins that need new factories (instead of using all the origins that the frame needs initiator-specific factories for). Handling NetworkService crashes =============================== By having RenderFrameHostImpl::CreateInitiatorSpecificURLLoaderFactories call CreateNetworkServiceDefaultFactoryAndObserve instead of CreateNetworkServiceDefaultFactoryInternal, this CL ensures that a NetworkService crash is detected when initiator-specific (network-bound) factories are used (and that the crash is detected even if the default factory is not network-bound). This makes sure that content scripts in the test continue to be able to issue network-bound requests after the crash. Additionally, introducing |recreate_default_url_loader_factory_after_network_service_crash_| field ensures that if the default factory is not network-bound, then it will not get cloberred when handling a network service crash. This helps ensure that the final AppCache request made by the test is successful. Bug: 846346 Change-Id: Ie53710d17526c140ef8ee65a41de5d3312bfae5b Reviewed-on: https://chromium-review.googlesource.com/c/1318082 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#606352}
-
file:///Clifford Cheng authored
Bug: 902942 Change-Id: I4d3bf1c2b8d5c6aee0024f78219ef4ff097e98f6 Reviewed-on: https://chromium-review.googlesource.com/c/1325649 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606351}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1a1b38dabca6..026f83d49289 git log 1a1b38dabca6..026f83d49289 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 nednguyen@google.com Revert "Remove legacy timeline based metrics (TBMv1) & all related code" 2018-11-07 benjhayden@chromium.org Permit lack of value.name in convertChartJson. 2018-11-07 pasko@chromium.org androidStartupMetric: workarund for missing main entry point marker 2018-11-07 sergiyb@chromium.org Decrease timeout only if there is a watchdog timer configured 2018-11-07 nednguyen@google.com Add a fixed mimetypes file to be used by Telemetry's memory_cache_http_server Created with: gclient setdep -r src/third_party/catapult@026f83d49289 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900878,chromium:902391,chromium:899721,chromium:894868 TBR=sullivan@chromium.org Change-Id: I7d6e937f277bb7938ea7b66843d5415b8054f487 Reviewed-on: https://chromium-review.googlesource.com/c/1325373Reviewed-by:
-
Satoshi Niwa authored
USE CASE: Launching a SelectFileDialog from an ARC Android app on ChromeOS (go/arc-file-picker) PROBLEM: SelectFileDialogExtension is shown as a modal to the default browser window [1] when the user specifies owning_window=NULL in SelectFileDialog::SelectFile, even though the method comment says "|owning_window| is the window the dialog is modal to, or NULL for a modeless dialog." [2] SOLUTION: Extend ExtensionDialog::Show with is_modal param and make it launch the dialog with CreateDialogWidget() instead of CreateBrowserModalDialogViews(). SelectFileDialogExtension still passes a non-null |parent_window| to ExtensionDialog::Show for obtaining screen_size, etc. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/select_file_dialog_extension.cc?q=base_window.%5C?&g=0&l=440 [2] https://cs.chromium.org/chromium/src/ui/shell_dialogs/select_file_dialog.h?q=owning_window&g=0&l=174 BUG=b:117912148 TEST=manually tested if non-modal dialog is shown Change-Id: Ie5ef18d7d613cefad544ee9e837f71b22a94bd4c Reviewed-on: https://chromium-review.googlesource.com/c/1304190 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606349}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bda725f7..28451dd1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieeaaf1af76199c54364859b4ac24bac6229fee38 Reviewed-on: https://chromium-review.googlesource.com/c/1325556Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606348}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36b85be49443..c248c0542bc1 git log 36b85be49443..c248c0542bc1 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 reed@google.com Revert "Revert "hide nested hinting enum"" 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 goderbauer@google.com Comment out debug prints in SkFontMgr_custom_directory 2018-11-07 reed@google.com Revert "hide nested hinting enum" 2018-11-07 mtklein@google.com baby steps to GN check correctness 2018-11-07 reed@google.com hide nested hinting enum Created with: gclient setdep -r src/third_party/skia@c248c0542bc1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Ifcc3448042128cd4eaa8e6c70621eb47fa39bb52 Reviewed-on: https://chromium-review.googlesource.com/c/1325129Reviewed-by:
-
Andrew Luo authored
Bug: 902958 Change-Id: I1c8a6fbc21c871ced824c2b387196d2eae856728 Reviewed-on: https://chromium-review.googlesource.com/c/1324991Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#606346}
-
Yoshifumi Inoue authored
This reverts commit 77e3d644. Reason for revert: he test flakiness is caused by bot flakiness. Original change's description: > Mark DialogClientViewTest.ButtonPosition flaky on Mac > > This patch marks DialogClientViewTest.ButtonPosition flaky on Mac. > > TBR=bsep@chromium.org > > Bug: 903000 > Change-Id: I7d533956e437c143e4d4030dd357553fd4caabf1 > Reviewed-on: https://chromium-review.googlesource.com/c/1325592 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606338} TBR=yosin@chromium.org Change-Id: Ib253d9870dcbae3ca12ccba6b7db76d0c34afd7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903000 Reviewed-on: https://chromium-review.googlesource.com/c/1325279Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606345}
-
Yoshifumi Inoue authored
This reverts commit 5f5ef388. Reason for revert: he test flakiness is caused by bot flakiness. Original change's description: > Mark ScrollViewTest.ClipHeightToShortContentHeight flaky on Mac > > This patch marks ScrollViewTest.ClipHeightToShortContentHeight flaky on Mac. > > TBR=kylixrd@chromium.org > > Bug: 903001 > Change-Id: Iccc1792d207b44fe05d8abb3f1d86687a8567eec > Reviewed-on: https://chromium-review.googlesource.com/c/1325275 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606337} TBR=yosin@chromium.org Change-Id: I06d5f420c5fcf8570812aa8b055e259a0861bbe1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903001 Reviewed-on: https://chromium-review.googlesource.com/c/1325278Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit 1724744c. Reason for revert: The test flakiness is caused by bot flakiness. Original change's description: > Mark ViewTest.GetIndexOf flaky on Mac > > This patch marks ViewTest.GetIndexOf flaky on Mac. > > TBR=tfarina@chromium.org, sky@chromium.org > > Bug: 903002 > Change-Id: Ic8a82a9f09de1dab8a201c23452b86a3714f54be > Reviewed-on: https://chromium-review.googlesource.com/c/1325571 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606330} TBR=yosin@chromium.org Change-Id: I2d0fffa6740ab614081632ea6a0bc08e26c6069f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903002 Reviewed-on: https://chromium-review.googlesource.com/c/1325593Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit c1ae026a. Reason for revert: It seems flakiness was caused by bot flakiness. Original change's description: > Mark BubbleFrameViewTest.RemoveFootnoteView flaky on Mac > > This patch marks BubbleFrameViewTest.RemoveFootnoteView flaky on Mac > > TBR=mrefaat@chromium.org > > Bug: 903003 > Change-Id: I7028c038018bf1547b92a5c7fb19b5ddf65c3537 > Reviewed-on: https://chromium-review.googlesource.com/c/1325590 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606328} TBR=yosin@chromium.org Change-Id: I39fc11331c1c794763a00bb8a6b82c17dc0f20c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903003 Reviewed-on: https://chromium-review.googlesource.com/c/1325576Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/75fa8552337b..cf6df902d647 git log 75fa8552337b..cf6df902d647 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dbeam@chromium.org git cl status: Force description encoding to utf-8 to avoid throwing Created with: gclient setdep -r src/third_party/depot_tools@cf6df902d647 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=agable@chromium.org Change-Id: Ie393cafdd79f8633c9e3ef457843100131ea269e Reviewed-on: https://chromium-review.googlesource.com/c/1325334Reviewed-by:
-
Clifford Cheng authored
Bug: 903016 Change-Id: I9800b5fb42cf76982c28be85b557b66167bd3d1d Reviewed-on: https://chromium-review.googlesource.com/c/1325201 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
If the flag is enabled, when pressing Ctrl-Shift-Alt-W, an ash window tree is dumped to the UI log. This CL adds WindowStateType of each window to that log. Bug: none Test: Press Ctrl-Shift-Alt-W and see the type is correctly dumped in log Change-Id: I813539a02378800fb124e133fadd850853b04059 Reviewed-on: https://chromium-review.googlesource.com/c/1322259 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606339}
-
Yoshifumi Inoue authored
This patch marks DialogClientViewTest.ButtonPosition flaky on Mac. TBR=bsep@chromium.org Bug: 903000 Change-Id: I7d533956e437c143e4d4030dd357553fd4caabf1 Reviewed-on: https://chromium-review.googlesource.com/c/1325592Reviewed-by:
-
Yoshifumi Inoue authored
This patch marks ScrollViewTest.ClipHeightToShortContentHeight flaky on Mac. TBR=kylixrd@chromium.org Bug: 903001 Change-Id: Iccc1792d207b44fe05d8abb3f1d86687a8567eec Reviewed-on: https://chromium-review.googlesource.com/c/1325275Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Records metric for the number of clicks to open the help for managed device. Currently only enterprise-managed device shows such button. The variable is made to enum because we are likely to add same button for Family Link managed account. Bug: 885114 Change-Id: Ib508686737c0a17cbf0385a39f4d45b2fef863f7 Reviewed-on: https://chromium-review.googlesource.com/c/1319404Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606336}
-
Yoshifumi Inoue authored
This reverts commit 0b8e0f13. Reason for revert: It seems the flakiness caused by bot flakiness. Original change's description: > Mark BubbleDialogDelegateViewTest.VisibleAnchorChanges flaky > > This patch marks BubbleDialogDelegateViewTest.VisibleAnchorChanges flaky > > TBR=erikchen@chromium.org > > Bug: 903004 > Change-Id: I03f9d1f227dfdb281b04dc3073dbe803518f94e5 > Reviewed-on: https://chromium-review.googlesource.com/c/1325272 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606325} TBR=yosin@chromium.org Change-Id: Ibf71df02f951f45ae43cec1f7428cee98f6da838 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903004 Reviewed-on: https://chromium-review.googlesource.com/c/1325276Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 867065 Change-Id: I05f3b8c4c1f313fa203302a0a27da5b002cedfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1309219Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#606334}
-
