GitLab

Currently, the lint warns against using the hardcoded "sdcard" strings. We
should use Environment.getExternalStorageDirectory().getPath() instead of it,
but the path could be inconsistent depending upon the state of the real or
emulated device upon which we are testing. So this CL adds @SuppressLint to
suppress the warnings.

BUG=327768

Review URL: https://codereview.chromium.org/304633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379875

Review URL: https://codereview.chromium.org/311613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274375 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text fields."

The fix to use OnTextInputTypeChanged in place of OnFocus and OnBlur to resolve focus loss on text field navigation has introduced a number of regressions. As it turns out, the fix is no longer even necessary to address the original bug that it was intended to address (365741).  This patch is a revert of r270818.

BUG=375125,377359,378914

Review URL: https://codereview.chromium.org/302363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274374 0039d316-1c4b-4281-b951-d872f2087c98

(Still to do: switches::kDisableCache.)

This is to make the shell more testable.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/305013015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274373 0039d316-1c4b-4281-b951-d872f2087c98

The logic in BookmarkBarView::HitTestRect() does not depend on
|rect| and only has the purpose of preventing or allowing
event-targeting of itself or its descendants. For this reason,
the logic belongs in an override of
CanProcessEventsWithinSubtree() instead of HitTestRect().

BUG=374340
TEST=none

Review URL: https://codereview.chromium.org/308673011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274372 0039d316-1c4b-4281-b951-d872f2087c98

Add animation for the hiding and showing of the resize button. Add an animation
for sliding the minimize button into the position of the resize button. Delay
changing the size of FrameCaptionButtonContainerView to account for conflicting
layout changes caused by the transition to TouchView.

TEST=FrameCaptionButtonContainerViewTest
TEST=CustomFrameViewAshTest
TES=BrowserNonClientFrameViewAshTest
BUG=363717

Review URL: https://codereview.chromium.org/271913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273710

Review URL: https://codereview.chromium.org/302043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369289

Review URL: https://codereview.chromium.org/291093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274369 0039d316-1c4b-4281-b951-d872f2087c98

and make the bg color of all bubbles match the dialog bg color

BUG=376832

Review URL: https://codereview.chromium.org/309713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274368 0039d316-1c4b-4281-b951-d872f2087c98

Remove undefined behaviors by using offsets instead of pointers
and by checking that offset never exceeds the size of the data.

Update Native Messaging test to use Native Messaging format
instead of Pickle format which accidentally coincided before.

BUG=none

Review URL: https://codereview.chromium.org/290173008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274367 0039d316-1c4b-4281-b951-d872f2087c98

Some overrides of View::HitTestRect() just return 
false in order to force event-targeting to fail for
that view type and its descendants. Because this 
logic is unrelated to hit-testing against a rectangular
region, remove these overrides and instead override 
View::CanProcessEventsWithinSubtree() to just return 
false.

The relevant classes are:

ProfileImageView
ShelfButton::BarView
ShelfButton::IconView
PasswordRow
BoundedLabel
Label (and Link as a result)

BUG=374303
TEST=none

Review URL: https://codereview.chromium.org/287193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274366 0039d316-1c4b-4281-b951-d872f2087c98

This creates a 'Help' submenu with 'Chrome Help Center' and
'Report an Issue...'. This menu will be consistent across platforms.

BUG=371094

Review URL: https://codereview.chromium.org/274973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274365 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Move some sync/notifier to components/invalidation (https://codereview.chromium.org/294123004/)

Reason for revert:
Passed the CQ but broke the buildbot.

Original issue's description:
> Move some sync/notifier to components/invalidation
> 
> Moves many of the files in sync/notifier to components/invalidation.
> 
> This change does not introduce any new dependencies.  The relevant
> dependency rules both before and after this change should be:
> - chrome/browser/invalidation and chrome in general depend on
>   components/invalidation.
> - components/invalidation depends on sync/notifier and sync in
>   general.
> - sync/notifier, components/invalidation, and various parts of
>   chrome all depend on sync/internal_api/public.
> 
> The eventual goal is to move all of sync/notifier into
> components/invalidation.  The invalidation-related parts of
> sync/internal_api/public should be moved to components/invalidation,
> too.  This will allow us to remove the deopendencies from
> components/invalidation to sync, and remove sync's dependencies on
> cacheinvalidation and libjingle.
> 
> This change is a regression in terms of shared library componentization.
> the files in the sync/notifier folder could be built as a shared
> library.  The files in compononents/invalidation do not support this
> yet.  The SYNC_EXPORT declarations in the moved files have been changed
> to INVALIDATION_EXPORT so as to not lose this information, but the
> macros are currently #defined to no-ops.
> 
> This change does not attempt to rename any classes or namespaces.
> Many of the files ported from sync/notifier still use the syncer
> namespace.  Some, like SyncSystemResources, still have names tied
> to their sync heritage.  This will be addressed in future CLs.
> 
> Some non-trivial or non-obvious changes include:
> - invalidator_state.h was moved to sync/internal_api/public/base so it
> could be shared by both sync/ and components/invalidation.  This should
> be fixed in a future CL.
> - FromNotifierReason was split out of invalidator_state.h and moved to
> the newly-created components/invalidator_reason_util.h
> 
> TBR=zea,rtenneti,mallinath,dcheng
> BUG=259559
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274350

TBR=pavely@chromium.org,dcheng@chromium.org,zea@chromium.org,rtenneti@chromium.org,mallinath@chromium.org,maniscalco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=259559

Review URL: https://codereview.chromium.org/308413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274364 0039d316-1c4b-4281-b951-d872f2087c98

Adds about 40MB.

BUG=None
TEST=local
R=sbc@chromium.org, hinoka@chromium.org

Review URL: https://codereview.chromium.org/302083016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379943
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/306013011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274361 0039d316-1c4b-4281-b951-d872f2087c98

Background: We restart adbd between runs because we noticed that the
likelyhood of an adbd hang goes up with the length of time the process
has been running.

Killing was just a convenient way to do that, but it isn't the most robust.
The chromium.perf bots are very frequently going offline now and they
always are getting stuck at the point of the adbd restart. So I'm trying
this gentler method of restarting to see if it improves reliability.

BUG=

Review URL: https://codereview.chromium.org/304053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274360 0039d316-1c4b-4281-b951-d872f2087c98

Saved the current value and restore it when emulation ends. During emulation
the visible viewport is set to the size of the emulated screen.

BUG=370035

Review URL: https://codereview.chromium.org/302193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274359 0039d316-1c4b-4281-b951-d872f2087c98

The test is incorrectly placed as part of the core unit test library
sources instead of with other tests.

Review URL: https://codereview.chromium.org/306203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355154

Review URL: https://codereview.chromium.org/301103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274357 0039d316-1c4b-4281-b951-d872f2087c98

before we add a new session to the active sessions.

R=jar@chromium.org

Review URL: https://codereview.chromium.org/307993011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/306063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274355 0039d316-1c4b-4281-b951-d872f2087c98

We crash because mRefreshButton is null when updateUI() is called.
mRefreshButton is initialized on onCreateOptionsMenu()

According to http://stackoverflow.com/questions/13267030/oncreateoptionsmenu-is-never-called, seems like 
onCreateOptionMenu will never got called on some themes on phones with menu button.

I can repro by overriding the theme to @android:style/Theme.Black.NoTitleBar

The fix is adding a null check.

BUG=364591

Review URL: https://codereview.chromium.org/308793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274354 0039d316-1c4b-4281-b951-d872f2087c98

A regression caused buttons to be rendered above the image.  This fixes
the problem by forcing the image to be the first child of the bottom
view (image is together with the buttons in the bottom view).

BUG=378077,368025

Review URL: https://codereview.chromium.org/305633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/302083015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274352 0039d316-1c4b-4281-b951-d872f2087c98

It's now called enable_websocket_over_spdy and is a member of
HttpNetworkSession::Params.

BUG=372528

Review URL: https://codereview.chromium.org/295383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274351 0039d316-1c4b-4281-b951-d872f2087c98

Moves many of the files in sync/notifier to components/invalidation.

This change does not introduce any new dependencies.  The relevant
dependency rules both before and after this change should be:
- chrome/browser/invalidation and chrome in general depend on
  components/invalidation.
- components/invalidation depends on sync/notifier and sync in
  general.
- sync/notifier, components/invalidation, and various parts of
  chrome all depend on sync/internal_api/public.

The eventual goal is to move all of sync/notifier into
components/invalidation.  The invalidation-related parts of
sync/internal_api/public should be moved to components/invalidation,
too.  This will allow us to remove the deopendencies from
components/invalidation to sync, and remove sync's dependencies on
cacheinvalidation and libjingle.

This change is a regression in terms of shared library componentization.
the files in the sync/notifier folder could be built as a shared
library.  The files in compononents/invalidation do not support this
yet.  The SYNC_EXPORT declarations in the moved files have been changed
to INVALIDATION_EXPORT so as to not lose this information, but the
macros are currently #defined to no-ops.

This change does not attempt to rename any classes or namespaces.
Many of the files ported from sync/notifier still use the syncer
namespace.  Some, like SyncSystemResources, still have names tied
to their sync heritage.  This will be addressed in future CLs.

Some non-trivial or non-obvious changes include:
- invalidator_state.h was moved to sync/internal_api/public/base so it
could be shared by both sync/ and components/invalidation.  This should
be fixed in a future CL.
- FromNotifierReason was split out of invalidator_state.h and moved to
the newly-created components/invalidator_reason_util.h

TBR=zea,rtenneti,mallinath,dcheng
BUG=259559

Review URL: https://codereview.chromium.org/294123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367896

Review URL: https://codereview.chromium.org/252023009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274349 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new tab to the about:sync page to display the latest per-type
counters.  These counters will eventually replace the StatusControllers
that contain much of the same information.

This includes some changes to the C++ SyncInternalsMessageHandler to
register to observe these counters as well as some new WebUI to display
them.

There is a known bug in this code.  The StausCounter update logic has
not been implemented yet, so the item counts will always be zero.  This
will be fixed in a future CL.

BUG=349301

Review URL: https://codereview.chromium.org/290023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274348 0039d316-1c4b-4281-b951-d872f2087c98

Picked up changes:
f6e5bbb Start using computed style instead of default tag actions.
d8575dc Fix UnicodeTokenizer's handling of special characters.
44b5635 Move SAX classes to com.dom_distiller.

BUG=375553,378385

Review URL: https://codereview.chromium.org/309833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379425

Review URL: https://codereview.chromium.org/308303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274345 0039d316-1c4b-4281-b951-d872f2087c98

This test seems to be flaky on some bots and consistently failing on
chromeos.

BUG=379927
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/308793014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274344 0039d316-1c4b-4281-b951-d872f2087c98

This CL is a precursor for https://codereview.chromium.org/289283004/.

BUG=376613

Review URL: https://codereview.chromium.org/309773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274343 0039d316-1c4b-4281-b951-d872f2087c98

These strings can't have placeholders.

Review URL: https://codereview.chromium.org/301173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274342 0039d316-1c4b-4281-b951-d872f2087c98

The crash report is saying that the crash still happens in Aura.
I still don't get the repro steps, but on possibility is that
the parent exists but WindowTreeHost doesn't exist (missing
root windows? I don't even know that is possible though...).

BUG=373522
R=erg@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/304223012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274341 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where overlays that don't push history entries still did when
closing them. Add a browser test to test this case.

BUG=379055
TEST=see bug

Review URL: https://codereview.chromium.org/306993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/303503008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274339 0039d316-1c4b-4281-b951-d872f2087c98

Already marked as retired on bug, suppressions query has no results for
this either.

BUG=258466
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/309533015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274338 0039d316-1c4b-4281-b951-d872f2087c98

Allows skia to remove SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS

NOTRY=True
failures unrelated to this CL

Review URL: https://codereview.chromium.org/308833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274337 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274336 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175159:175308&mode=html

TBR=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/301173008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274335 0039d316-1c4b-4281-b951-d872f2087c98