- 16 Aug, 2018 24 commits
-
-
Wei-Yin Chen (陳威尹) authored
DOM distiller viewer was run in quirks mode, where the body is the scrolling element. Later on, it was run in standard mode, where the scrolling element became document.documentElement, and the scroll positioning logic was broken. Use document.scrollingElement instead to be more standard compliant. See https://developer.mozilla.org/en-US/docs/Web/API/Document/scrollingElement Bug: 874371 Change-Id: I1a0c04f4bc50ff66a9342e9fde8e0369b79cfef1 Reviewed-on: https://chromium-review.googlesource.com/1175681 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583475}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b631742f0bff..cf7258abac89 git log b631742f0bff..cf7258abac89 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 reed@google.com add bench for cubicmap 2018-08-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 21e5e85a4976..c1551dc2a7dc (1 commits) 2018-08-15 caryclark@skia.org fix SkPath documentation 2018-08-15 jvanverth@google.com Add internal tree implementation to EdgeList. 2018-08-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-15 kjlubick@google.com [PathKit] Adding test infrastructure to support Gold output 2018-08-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-15 kjlubick@google.com [PathKit] Fix bindings to account for SkPath methods returning this Created with: gclient setdep -r src/third_party/skia@cf7258abac89 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: If43e98222a5d2afaa41fcd3dabddcf924fe026cf Reviewed-on: https://chromium-review.googlesource.com/1176242Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583474}
-
Wei-Yin Chen (陳威尹) authored
Document-level touch event listeners are treated as passive since M56. These touch event handlers in DOM distiller viewer are indeed intended to block scrolling, so make them non-passive to restore the old behavior. Bug: 870140, b/80346318 Change-Id: I9daa7e46564607a15b0d00f092616da9be2a570e Reviewed-on: https://chromium-review.googlesource.com/1175560Reviewed-by:
-
Philip Rogers authored
This patch adds an expectation for: paint/invalidation/scroll/composited-iframe-scroll-repaint.html This is needed because ancestor clipping layers are not created for BGPT (see: https://crrev.com/556569). images/cross-fade-invalidation.html has been marked as failing and a bug has been filed: https://crbug.com/874672. compositing/rtl/rtl-fixed-overflow-scrolled.html has been marked as failing. This is likely related to https://crrev.com/583398 Two sticky tests started failing. This is likely caused by crrev.com/581763. Filed https://crbug.com/874675 and marked as failing. Bug: 836886 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I973419fb9b9f6738ae8e25c4d0f98820a0335f19 Reviewed-on: https://chromium-review.googlesource.com/1176542 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583472}
-
Martin Kreichgauer authored
This is just the basic sheet; nothing wired up yet. Bug: 849323 Change-Id: I088310de39966895dfa7d3008c631382b990f520 Reviewed-on: https://chromium-review.googlesource.com/1173347 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583471}
-
Yue Cen authored
Bug: 835029 Change-Id: Ie39c2ab0956f01ce51bdf1e2fa0e8de30de51160 Reviewed-on: https://chromium-review.googlesource.com/1144272Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583470}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fc13545ed4c9..5c9b9cb65208 git log fc13545ed4c9..5c9b9cb65208 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 nednguyen@google.com Revert "Redo Telemetry Compatibility Mode." 2018-08-15 simonhatch@chromium.org Remove cq_name 2018-08-15 simonhatch@chromium.org Enable LUCI windows tryserver. 2018-08-15 benjhayden@chromium.org Fix descriptors for huge test suites. 2018-08-15 amyqiu@google.com Make small fixes to metrics visualization tool 2018-08-15 wangge@google.com Redo Telemetry Compatibility Mode. Created with: gclient setdep -r src/third_party/catapult@5c9b9cb65208 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866881,chromium:825433,chromium:866881 TBR=sullivan@chromium.org Change-Id: Ia3f3e9f449f318460d4f3afb528a40b079f69417 Reviewed-on: https://chromium-review.googlesource.com/1176245Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583469}
-
Satoshi Niwa authored
BUG=b:112571387 TEST=Presubmit passed Change-Id: If6fa11b4349cfe5102bfcdd2877b79edc60bcdf8 Reviewed-on: https://chromium-review.googlesource.com/1174193Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583468}
-
yoshiki iguchi authored
This CL makes the lock screen notification feature available for users. To actually show notifications on the lock screen, the user need to explicitly enable this feature on the ChromeOS setting. Bug: b/111391270 Change-Id: Ibbe767f74dd1440dae4047fb1bd74bbe6e849906 Reviewed-on: https://chromium-review.googlesource.com/1166604Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583467}
-
Weidong Guo authored
Background: A crash will happen when a page break item is added between two items with the same position. Changes: Fix the position of items before adding page break item. AppListItemListTest.AddPageBreakItem AppListItemListTest.AddPageBreakItemWithSamePosition Bug: 874619 Test: Change-Id: I7e5c9eac51db0fa7a563cb0097c13ab1777218fa Reviewed-on: https://chromium-review.googlesource.com/1176560Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583466}
-
Nigel Tao authored
Without this, its tests fail when conceptually unrelated code such as https://chromium-review.googlesource.com/c/chromium/src/+/1170145 calls content::BrowserThread::PostAfterStartupTask Change-Id: I7433719ee9721e224db955669b3c8d079cf780dc Reviewed-on: https://chromium-review.googlesource.com/1174577Reviewed-by:
-
Scott Violet authored
This class no longer uses anything in this file. BUG=none TEST=none Change-Id: I82af529c8fb5768bb2cf2108a4e5aa8ddd848104 Reviewed-on: https://chromium-review.googlesource.com/1176394Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583464}
-
Findit authored
This reverts commit 84083630. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 583329 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg0MDgzNjMwYjMyMWExNGY3ZjU2ZWMzZjlmNGQyYmZjYWYzYjdhOTAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/11204 Sample Failed Step: unit_tests Original change's description: > Introduce explicit configuration to CertVerifier > > Presently, CertVerifier::Verify() takes a series of per-verification > flags that express the ways in which certificate verification may be > configured. However, these flags represent overall verifier-wide > configuration, in that they are tied to user preferences or enterprise > policies. These flags are plumbed through the layers by virtue of > SSLConfig, but generally do not change between verifications. > > As part of making the verification configuration opaque to callers, > move the flags from being something passed in each verifier-call to > something that is implicitly handled on the CertVerifier, via the > CertVerifier::Config. All verifications started will share the same > configuration, while allowing callers to focus on the per-verification > parameters that are unique (such as the hostname or certificate). > This sets the stage for moving the CRLSet in as explicit CertVerifier > configuration, rather than passed-per-call, as well as to having the > socket pools more intelligently respond to these configuration changes. > > TBR: zea@chromium.org, pmarko@chromium.org > Bug: 848277, 854635 > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I2098783f1c4100720438e2dea447a24789ebf8c9 > Reviewed-on: https://chromium-review.googlesource.com/1122709 > Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: Nicolas Zea <zea@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583329} Change-Id: I66ddbb6fa85d604bc1fa177f5657008a5e8f0fe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848277, 854635 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1176763 Cr-Commit-Position: refs/heads/master@{#583463}
-
Daniel Zhang authored
Landed functionality separately. Bug: 865543 Change-Id: Ic44263ff2273ef97aec357c7a842a1134d57d061 Reviewed-on: https://chromium-review.googlesource.com/1171342 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583462}
-
David Tseng authored
Bug: 869898 Change-Id: I66d0ac277e0b78ea40b1eff277fbdda61bdee0fb Reviewed-on: https://chromium-review.googlesource.com/1176423Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583461}
-
Zhongyi Shi authored
Change-Id: I1962561658a57be3adfcd88368926dff90091fa8 Reviewed-on: https://chromium-review.googlesource.com/1176189Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583460}
-
Takumi Fujimoto authored
If there is an issue associated with a sink, use the issue text as the status text for the sink. Bug: 874625 Change-Id: I2dd844a851cc58828047dd3305b3fd729ba514e0 Reviewed-on: https://chromium-review.googlesource.com/1176473Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#583459}
-
Ben Smith authored
It is currently enabled via finch for these platforms on 67+. Bug: chromium:821270 Change-Id: Id402c71a8b9d108bbe0d8bca7fc585aff201241a Reviewed-on: https://chromium-review.googlesource.com/1159358Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |IsEditablePosition()| to use |Position:: ComputeContainerNode()| instead of |Position::ParentAnchoredEquivalent()| not to incorporate |EditorIngoreContetns()|, e.g. <hr>, <img>, etc. For "<hr contenteditable>", |IsEditablePosition(<hr>@0)| returns false before this patch. After this patch, it returns true. Bug: 873088 Change-Id: Id75bd2c857dbd85e59f7795d02f3583802347060 Reviewed-on: https://chromium-review.googlesource.com/1172273Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583457}
-
Eric Karl authored
A change earlier in M70 allowed us to more aggressively re-use discardable handles. Unfortunately, as handle IDs (even those with outstanding refs) were re-used as well, leading to issues where the same handle was being used for two textures. This change moves to a globally-incrementing ID system for discardable handles, which removes the possibility of accidentally referencing a deleted but re-used handle. Bug: 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6ba8999d5f90d3ddb9c909cbbbd7f66c30ae6613 Reviewed-on: https://chromium-review.googlesource.com/1176223Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583456}
-
Jun Cai authored
Based on the comment at: https://bugs.chromium.org/p/chromium/issues/detail?id=862176 This CL makes: SecurityExploitBrowserTest.InvalidOriginHeaders ExtensionUnloadBrowserTest.UnloadWithContentScripts early return if network service is enabled. Bug: 862176 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I040ac9615a6deed786825d306a9192d14925a5cc Reviewed-on: https://chromium-review.googlesource.com/1176479Reviewed-by:
-
Danyao Wang authored
TabTest uses the internal NavigationManagerImpl::CommitPendingItem() API. WKBasedNavigationManager's implementation of this API requires a precondition that a WKBackForwardListItem exists for the to be committed pending item. Mocking out WKWebView allows injection of WKBackForwardList item to satisfy this precondition. Parameterized TabTest to test both navigation manager implementations on trybot. Bug: 863026 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f6b2faa94c1c63682a333c9f8c7c2600017cdea Reviewed-on: https://chromium-review.googlesource.com/1176376 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583454}
-
Sonny Sasaka authored
This deprecates BlueZ.ChipLost because we need to filter out suspend/resume events even when adapter is disabled. Corresponding CL where metrics is used: https://crrev.com/c/1176398. BUG=chromium:813390 Change-Id: I8620fdd1c0225a97226d462e234643882f6553a5 Reviewed-on: https://chromium-review.googlesource.com/1176371 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#583453}
-
Anand K. Mistry authored
cros-disks doesn't raise this error. Chrome did for a while, but the last usage was removed in crrev.com/255348 BUG=None Change-Id: I847ccc818f67bb41b4e74f54ac6ed6c52d82858a Reviewed-on: https://chromium-review.googlesource.com/1174580Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
- 15 Aug, 2018 16 commits
-
-
rajendrant authored
This CL adds basic support (behind a flag) for deferring the load of html image elements until the user scrolls near them, in order to reduce network data usage, memory usage, and speed up the loading of other content on the page. LazyLoadImageObserver is created per document and that holds an IntersectionObserver to observe the <img> elements within the document. When the IntersectionObserver detects that the deferred image element is within a specific distance threshold of the viewport, it resumes loading the image. Subsequent CLs will defer CSS background images as well, and configure the hardcoded distance-from-viewport threshold from field trial. See the design docs below for more info. LazyImages design doc: https://docs.google.com/document/d/1jF1eSOhqTEt0L1WBCccGwH9chxLd9d1Ez0zo11obj14/edit LazyLoad design doc: https://docs.google.com/document/d/1e8ZbVyUwgIkQMvJma3kKUDg8UUkLRRdANStqKuOIvHg/edit Bug: 846170 Change-Id: I8c1024a4cdb19f3c6c700ae49eec6369b67b72b4 Reviewed-on: https://chromium-review.googlesource.com/1132573 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#583451}
-
John Budorick authored
Bug: 868525 Change-Id: I65aabb60d4823423d7f0bd4d5b51ea145c665658 Reviewed-on: https://chromium-review.googlesource.com/1176471Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583450}
-
Ehsan Karamad authored
The test is disabled. Since it is Mac only, simply marking it as DISABLED. Also adding a bug reference for the test. TBR=avi@chromium.org Bug: 874417 Change-Id: I32703a9c0a874d15e3b9ea2f550a7d731f56cd3e Reviewed-on: https://chromium-review.googlesource.com/1176295Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#583449}
-
Philip Rogers authored
This patch removes UpdateLayers::BuildPropertyTrees trace events when in layer lists mode which is used by blink gen property trees and slimming paint v2. This patch also cleans up LayerTreeHost::DoUpdateLayers by removing the unused in_update_property_trees_ variable. Bug: 836886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I35e6bd7c59b0384d8c2c62a1d3bdb1eed152353b Reviewed-on: https://chromium-review.googlesource.com/1176357Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583448}
-
Trent Apted authored
Apart from some simple classes (Foo, Adder), the existing test suites really don't share very much code. After https://crrev.com/c/1053338 they will share even less. Split out the threaded tests to their own file to reduce complexity. This is largely a verbatim move (preserving order), apart from whitespace changes. Bug: 842987 Change-Id: I555662a5516add7267abd1608f54fd13cbd7d97c Reviewed-on: https://chromium-review.googlesource.com/1175508Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#583447}
-
Nicolas Norvez authored
biod collects some metrics that aren't taken care of by Chrome (see CL:1166462) for the Chrome-side metrics. Specifically biod knows about the capture/matching latency. We also add the number of fingers that have been enrolled as it's more readily accessible to biod than it is to Chrome. The corresponding Chrome OS CL is CL:1173770 R=xiaoyinh Bug: 862295 Change-Id: I8ae56d278fd9af4494bb969e7ff6e8bb336ad2bb Reviewed-on: https://chromium-review.googlesource.com/1175458Reviewed-by:
-
Kyle Horimoto authored
This CL adds a new set of APIs for getting/setting the states of the multi-device features as well as adding an observer pattern for receiving updates to these feature states. Bug: 824568 Change-Id: If79c713b9737a738bcb9347871f0db913b7abb5b Reviewed-on: https://chromium-review.googlesource.com/1172707 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583445}
-
Mattias Nissler authored
This new notification alerts the user about a pending TPM firmware update for the device and directs them to the about page to trigger update installation. We currently only show the notification for a case where the user has already decided to install the update, but another powerwash is required to clear a vulnerable key that may have remained in some cases. BUG=chromium:872746 TEST=Manual Change-Id: Id0bf5146d411af1741bb35f7e6d4c8d2437a0080 Reviewed-on: https://chromium-review.googlesource.com/1175794Reviewed-by:
-
Zhongyi Shi authored
Change QSF::Job to create a new connection on the alternate network if the original connection fails on the default network before handshake is confirmed. Bug: 790547 Change-Id: I161c09bf97f98540dd8eb6e83c811ca34d31f883 Reviewed-on: https://chromium-review.googlesource.com/1175191Reviewed-by:
-
Dale Curtis authored
See bugs for more detail; this only helps M+ where we're using the callback API now and can get the true error status earlier than we could before. This also adds a log message when onError is called so that we can debug these more easily in the field. BUG=873094, 610523 TEST=none Change-Id: I3fbae95e872fe430f7dd0ddc70b01552492bd64a Reviewed-on: https://chromium-review.googlesource.com/1176168Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583442}
-
Kristi Park authored
<button> is type="submit" by default. Adding type="button" will prevent the Cancel and Delete buttons from triggering the "submit" event. Bug: 874018 Change-Id: Ie72ec07ddbaeccee29588612fc8938f268150f20 Reviewed-on: https://chromium-review.googlesource.com/1174804 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583441}
-
Etienne Bergeron authored
Safe browsing is a low bandwidth category and it worth collecting the information since it may affect system wide performance. Under that caterory, the main important trace events are to detect whether or not the chrome_cleaner tool is scanning or cleaning. We suspect that the cleanup tool is having system wide impact and may explain janks observed in slow-reports. R=oysteine@chromium.org Change-Id: I604fdb89fd2bbbb0b13751c281cc0d936f426848 Reviewed-on: https://chromium-review.googlesource.com/1176264Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583440}
-
Miguel Casas authored
This CL changes the signature of GpuVideoAcceleratorFactories' VideoFrameOutputFormat(size_t bit_depth) to VideoFrameOutputFormat(media::VideoPixelFormat pixel_format) which is needed for the next CL (see also crrev.com/c/1171569). VideoFrame::BitDepth() is extracted to media/base/video_types.cc. Bug: 873345 Change-Id: I0afb480657ffb5ae5c3b01b6384832221476e1e9 Reviewed-on: https://chromium-review.googlesource.com/1174946Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#583439}
-
Findit authored
This reverts commit ec552f22. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 583369 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWM1NTJmMjI5NTM5NzM4NzFjZWExZTYyNWNmNmIzNjZjOGMzNjM0NQw Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71344 Sample Failed Step: mash_browser_tests (with patch) Sample Flaky Test: ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF Original change's description: > Set touch action Auto in MaybeSendSyntheticTapGesture > > The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent, > in which case the TouchActionFilter::allowed_touch_action_ has no value > and will result in a crash. > > This CL set the allowed_touch_action_ to auto to fix the issue. A > browser test is added. > > Bug: 873211 > Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a > Reviewed-on: https://chromium-review.googlesource.com/1169585 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583369} Change-Id: I2b4c4fb6b76a7a904603e7bf1086fe4f42d9f1e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873211, 874667 Reviewed-on: https://chromium-review.googlesource.com/1176503 Cr-Commit-Position: refs/heads/master@{#583438}
-
rbpotter authored
interactive_ui_tests: These tests are flaky on debug builds. browser_tests: These tests are failing on official builds. Bug: 862472 Change-Id: I4ec7ae2c6f42abd3ccaf023dc803d3317faa1434 Reviewed-on: https://chromium-review.googlesource.com/1176206Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583437}
-
Dominik Laskowski authored
This CL turns ShellSurfaceBase::OnSurfaceCommit into a template method to isolate logic for ShellSurface and ClientControlledShellSurface. Bug: b:77972398 Test: exo_unittests Change-Id: Iad359c3754f9955fd34ea372a06e6d53999b8877 Reviewed-on: https://chromium-review.googlesource.com/1176182Reviewed-by:
-
