GitLab

TCMalloc is very slow in debug mode. This may have a substantial improvement
on test cycle time. Theoretically, we shouldn't need to debug TCMalloc
very often.

BUG=388949

Review URL: https://codereview.chromium.org/438963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356483,354553

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287112

Review URL: https://codereview.chromium.org/434693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287225 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287224 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/c6f57840475cb17aa1cf2f50c181d3235b924056..7883132a4e93c8b5e897e271603d3b7122655a51

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bensong@google.com
BUG=

Review URL: https://codereview.chromium.org/434263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=cpu

Review URL: https://codereview.chromium.org/416423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=210525
(for .idl comment change)
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/430563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287221 0039d316-1c4b-4281-b951-d872f2087c98

Likely broke the tree, UserManagerUIBrowserTest.PageLoads

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/43558/steps/browser_tests/logs/PageLoads

> Create a policy for controlling whether or not desktop browser can access guest mode.
> 
> BUG=306322
> TEST=When the policy prohibits guest mode, the option should not be selectable from the User Manager. When no policy or policy permits guest mode, Guest Mode should be selectable.
> 
> Review URL: https://codereview.chromium.org/385073008

TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/437563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287220 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287219 0039d316-1c4b-4281-b951-d872f2087c98

r28: Fix literal-suffix warning when using GCC 4.8.
r31: MIPS: The new ABI should be allowed to use r8 and r9 for syscalls.

R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/435853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398520

Review URL: https://codereview.chromium.org/422393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287217 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287216 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179431:179442&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/436063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397746

Review URL: https://codereview.chromium.org/430383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=306322
TEST=When the policy prohibits guest mode, the option should not be selectable from the User Manager. When no policy or policy permits guest mode, Guest Mode should be selectable.

Review URL: https://codereview.chromium.org/385073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287212 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Re-enable ScreenOrientationListenerTest.java and run locking on UI thread. (https://codereview.chromium.org/434693002/)

Reason for revert:
This broke the following test on the contentshell_instrumentation_tests
on the Android Tests (dbg):

ScreenOrientationListenerTest.testConfigurationListenerFlipLandscape

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20567/steps/contentshell_instrumentation_tests/logs/stdio

Original issue's description:
> Re-enable ScreenOrientationListenerTest.java and run locking on UI thread.
> 
> BUG=356483,354553
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287112

TBR=jdduke@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356483,354553

Review URL: https://codereview.chromium.org/431083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287210 0039d316-1c4b-4281-b951-d872f2087c98

Depends on:
https://codereview.chromium.org/424523002/

BUG=210525

Review URL: https://codereview.chromium.org/429633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287209 0039d316-1c4b-4281-b951-d872f2087c98

Touch text selection controllers are created using ViewsDelegate. So, a
ViewsDelegate implementation is added. Also, changed Athena overview
mode to only show windows of type WINDOW_TYPE_NORMAL.

BUG=386350

Review URL: https://codereview.chromium.org/416243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239141,397066,399852,399853,399854
NOTRY=true
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/427043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/424363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399240

Review URL: https://codereview.chromium.org/432353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287204 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287203 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179329:179430&mode=html
TBR=alancutter@chromium.org,pdr@chromium.org,enne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/433863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287202 0039d316-1c4b-4281-b951-d872f2087c98

Picks up:
r286582 - Update to NSPR 4.10.7 Beta 3.
r287121 - Refactor clang warning flags

BUG=396377
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/423713010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287201 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary for being able to test the File API, or code depending
on it, in the blink unit tests.

BUG=398366
TEST=no webkit_unit_tests crash in https://codereview.chromium.org/434823002/

Review URL: https://codereview.chromium.org/434833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287200 0039d316-1c4b-4281-b951-d872f2087c98

This are the remaining uses of the deprecated webkitNotifications in
Chromium repo.

BUG=None
TEST=None
R=peter@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/418173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393775, 397336, 397339
TEST=Verify that error strings in EasyUnlock setup dialog match expected strings.
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/435083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287198 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330264
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/434523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:868

Review URL: https://codereview.chromium.org/420663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393873
TEST=./third_party/closure_compiler/checker_test.py
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/435053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287195 0039d316-1c4b-4281-b951-d872f2087c98

Root cause of the flakiness is that the StandaloneCastEnvironment, as a
ref-counted object, was being destroyed on a thread other than the one
that created it.  At destruction, it attempted to join on the threads it
owns, but these threads must be joined with the thread that they were
spawned from.

BUG=396480

Review URL: https://codereview.chromium.org/436673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287194 0039d316-1c4b-4281-b951-d872f2087c98

If you try to build with enable_webrtc=0 and remoting=1, gyp will fail:
libjingle.gyp:libpeerconnection#target' when processing
remoting.gyp:remoting_host#target.  This happens because the
libpeerconnnection target is defined inside an enable_webrtc==1 condition.
Therefore, these dependencies in remoting.gyp should be too.

BUG=399413

Review URL: https://codereview.chromium.org/431163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287193 0039d316-1c4b-4281-b951-d872f2087c98

Per creis' request, place the transition page in the same process as the destination page. This is done to avoid the overhead of potentially spawning an extra new renderer for the transition.

The idea behind this was to put the transition page into the same render process as the incoming page. Approach so far was to instantiate a new WebContents in the embedder via a new function createNativeWebContentsWithSharedSiteInstance(source_content_view_core), passing the SiteInstance of the incoming page. The transition ContentViewCore can then be navigated to a blank page and the serialized markup is added to the page. Since the transition and incoming pages share the same SiteInstance, they will be placed in the same process.


Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5
BUG=370696

Review URL: https://codereview.chromium.org/378743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287192 0039d316-1c4b-4281-b951-d872f2087c98

During Finch experiment, for users enrolled in the experimental group,
we don't want to show interstitial for phishing site to them to avoid
confusion. However, the database check is still exercised.

This doesn't affect flywheel protection.

BUG=381896

Review URL: https://codereview.chromium.org/425223007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/437023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287190 0039d316-1c4b-4281-b951-d872f2087c98

Saves us over 1200 files during compilation!!  Also
cleans up media_perftests for a smaller savings.

BUG=302505
TEST=media_unittests is at ~3000 files now.

Review URL: https://codereview.chromium.org/438963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287189 0039d316-1c4b-4281-b951-d872f2087c98

Due to the current experiment setup, this feature will still only be used by a fraction of canary/dev users, but the trybots should now run with this feature enabled.

BUG=114092,295787
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/433213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287188 0039d316-1c4b-4281-b951-d872f2087c98

LockStateController starts its 350 ms pre-lock animation
when the screen is locked via the system tray. When the
animation completes, the controller was incorrectly starting
the lock-fail timer. If the lock screen had already become
ready before this point (possible on a fast system), the
timer would crash the process eight seconds later.

Change LockStateController to only start the timer when
actually requesting that the screen be locked.

BUG=349083

Review URL: https://codereview.chromium.org/435083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287187 0039d316-1c4b-4281-b951-d872f2087c98

Looks like we have to restart the browser if a tab crashes in a browser that
doesn't support tab control.

BUG=337829

Review URL: https://codereview.chromium.org/437443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287186 0039d316-1c4b-4281-b951-d872f2087c98

Move more extensions code from ChromeContentBrowserClient to ChromeContentBrowserClientExtensionsPart.

Review URL: https://codereview.chromium.org/434023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287185 0039d316-1c4b-4281-b951-d872f2087c98