- 16 Feb, 2018 40 commits
-
-
Scott Graham authored
Both from this run: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/16374 Bug: 764015, 811881 Change-Id: If6954f1ded3ad61961dd60c994ef7d1d905351c9 Reviewed-on: https://chromium-review.googlesource.com/923431Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537426}
-
Matthew Jones authored
This change adds a new nine-patch asset for the location bar that is used exclusively in the compositor. This allows us to have stop drawing the location bar as part of the toolbar texture and draw it with correct colors in the compositor. Since the new texture draws the entire location bar instead of just part of it, the 'anonymize' layer is not needed in the modern design (we can now simply draw over the url). These changes correct all the toolbar/compositor related animations. BUG=803098 Change-Id: I90d67967c4d1a0e37b0d504d154b0f6df7bdd656 Reviewed-on: https://chromium-review.googlesource.com/912177 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#537425}
-
wutao authored
This cl highlights the matched search query in Keyboard Shortcut Viewer (KSV). Bug: 768932 Test: Tested on device. Change-Id: I0b3f647ea0cad871c2697a3204de21de2cbfaf83 Reviewed-on: https://chromium-review.googlesource.com/923202Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537424}
-
Tim Volodine authored
This patch updates the AwTracingController to reflect the newly updated Android API. Also moves and extends some logic from the glue layer to chromium. Note: some obsolete bits will be removed in a follow-up patch in order to no break compile. This will happen once chromium rolls downstream and the glue layer is properly updated. BUG=781249 Change-Id: I35d3938560e24c172ae598d11ad2dc0540a9e665 Reviewed-on: https://chromium-review.googlesource.com/922205Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#537423}
-
Gustav Sennton authored
Move MessagePort related functionality from WebViewChromium to SharedWebViewChromium so the support library glue layer can avoid depending on WebViewChromium. Bug: 812657 Change-Id: Iacd6c0e2dd0ffd1e8307ffb06a70cb00a2a71202 Reviewed-on: https://chromium-review.googlesource.com/924207 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537422}
-
Yunlian Jiang authored
We did not use cache-policy when using gold. This fixes a config time error when using gold instead of lld. The error message is You set the variable "cache_policy" here and it was unused before it went out of scope Change-Id: I3dad8850899e3126549fd22fcc5bb8d60ef0d7df Reviewed-on: https://chromium-review.googlesource.com/923398Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Cr-Commit-Position: refs/heads/master@{#537421}
-
Alex Clarke authored
This is an experimental feature subject to change without notice. Change-Id: Ib82560101ba52b058c13120d323988f69f4debb3 Reviewed-on: https://chromium-review.googlesource.com/923944Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537420}
-
Trent Apted authored
- Resurrects shell_dialogs_unittests on Mac - Fixes 2 tests that had regressed since the gn transition. - Tweaks the code to be more robust around complex object lifetimes. - Adds test SelectFileDialogMacTest.Lifetime Bug: 788271 Change-Id: Ice43179a1da3b7bbcd44fb9b0efdf6d84e4d2f5b Reviewed-on: https://chromium-review.googlesource.com/920961Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#537419}
-
Allen Bauer authored
Change-Id: I4b00282d287ae823bd3b9da152bd23365975ff64 Reviewed-on: https://chromium-review.googlesource.com/924266Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#537418}
-
Sergey Ulanov authored
After crrev.com/534819 content_shell_fonts are used on Android, but they were not pulled in data_deps for content shell, so they were not included when running tests on swarming bots. Now content_shell depends //third_party//content_shell_fonts, same as it was on Linux. Also added Android font config files to data_deps on Fuchsia. Bug: 778467, 787020 Change-Id: I23b65f381ac31012d88b9f66b457cfb7496223d4 Reviewed-on: https://chromium-review.googlesource.com/919875Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537417}
-
Sergey Ulanov authored
Also updated test expecations for tests that produce different results with the new font. Bug: 787020 Change-Id: Ib3d057864d9b26ba121b02c9fd5e47fa365e25e0 Reviewed-on: https://chromium-review.googlesource.com/920162 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#537416}
-
wutao authored
This cl adds all shortcuts metadata and strings for Keyboard Shortcut Viewer (KSV). Bug: 768932 Test: KeyboardShortcutViewerMetadataTest and Manually tested on device Change-Id: I0dc85fa4bffb5a9a1f19b86e991faf7b13b75a93 Reviewed-on: https://chromium-review.googlesource.com/922389 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch removes GetDocument() call which loads a large object into memory for every PaintInvalidator::InvalidatePaint call on a LayoutObject. Instead, it stores this value on the paint invalidator and updates it whwnever we encounter a new LocalFrameView during the prepaint walk. On small dom / small invalidation this only has a small benefit, but for complicated dom, my local perf tests show large improvements. R=chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I51139b8f8a802d608b583656d0be8bd2b7f13022 Reviewed-on: https://chromium-review.googlesource.com/924277Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537414}
-
Leonard Grey authored
Bug: 806660 Change-Id: I8c9561b6f456db3fdea0bf31a65bf0af9321cb2c Reviewed-on: https://chromium-review.googlesource.com/924341Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#537413}
-
Yash Malik authored
We assumed that ui_initial_state.web_vr_autopresentation_expected and initial_state.in_web_vr are mutually exclusive, which changed in https://chromium-review.googlesource.com/c/chromium/src/+/790890 Bug: None Change-Id: I3141a75292d40a090166d2e656d559fcadb6cd0d Reviewed-on: https://chromium-review.googlesource.com/924367Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#537412}
-
Tarun Bansal authored
This CL does not remove all of the code. Some of it will be removed in the next couple of CLs. TBR: nasko@chromium.org Change-Id: Iacb7a61900a9982729ecce21830d3f03bbc7b471 Reviewed-on: https://chromium-review.googlesource.com/912553Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537411}
-
https://webrtc.googlesource.com/src.git/+log/ae8a90a1d4db..1c9aa1ea6693 $ git log ae8a90a1d..1c9aa1ea6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I84c21ec0e2436cd55f58c934200843bc7332630c Reviewed-on: https://chromium-review.googlesource.com/923577 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537410}
-
Dave Tu authored
Bug: catapult:#4159, catapult:#4162 Change-Id: I074cada6d35fa3b0908e8a8d9451e228746db47f Reviewed-on: https://chromium-review.googlesource.com/922701 Commit-Queue: David Tu <dtu@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537409}
-
Robert Liao authored
The ExtensionPopup resizes its view dynamically after it can be anchored and shown. This change adds child resize support to BubbleAnchorHelper to accommodate that scenario. BUG=728174 Change-Id: I4422e5b1e0410ef6bed1ec7d1c77961cef061ced Reviewed-on: https://chromium-review.googlesource.com/922785 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
The detection of HLS by the demuxer is propagated through the pipeline via a special error code. This error code is saved by RendererWrapper, and never reset. RW does not propagate errors when it is already has an error status. This means that HLS errors are never fully reported to the pipeline. This CL fixes the issue by reseting RendererWrapper's status on stop. This makes the comments above |status_| accurate again. The CL also fixes a bug in MediaPlayerRenderer, where MEDIA_ERROR_FORMAT errors are dropped, and MEDIA_ERROR_INVALID_CODE errors are propagated. Test: manual tests, added UT Bug: 812465 Change-Id: I281d90104c8f9cb879e90c6d31a99167991c06ab Reviewed-on: https://chromium-review.googlesource.com/920881 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#537407}
-
Jared Saul authored
Bug: 794671 Change-Id: I6be346d595ae86b8c50fe1ad155afe62b0a671c4 Reviewed-on: https://chromium-review.googlesource.com/923168Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537406}
-
Charlie Andrews authored
NOTRY=true TBR=vmiura@chromium.org Bug: 812628 Change-Id: I14bd8253b5ff00f5febe4303ae3745999faa5975 Reviewed-on: https://chromium-review.googlesource.com/923579Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537405}
-
Christian Biesinger authored
R=eae@chromium.org Change-Id: I1de5224ea99e4965858446ce88960c019f21ddcc Reviewed-on: https://chromium-review.googlesource.com/924342Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#537404}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=michaeln@chromium.org Change-Id: Ie7cb617a06ec2faf3ba1eb9d2a110f4c982793f8 Reviewed-on: https://chromium-review.googlesource.com/924167Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537403}
-
Xianzhu Wang authored
The change flags are for the current painting only. Clear them to avoid unnecessary raster invalidation for paint property change in later paintings. Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2aebbd1e6342931d34bd2566983c9c22bdeabfc0 Reviewed-on: https://chromium-review.googlesource.com/920581Reviewed-by:
-
Charlie Andrews authored
TBR=ulan@chromium.org,mythria@chromium.org NOTRY=true Bug: 813165 Change-Id: I95c757b55411c7ab23235dbecc7b439a67fde503 Reviewed-on: https://chromium-review.googlesource.com/924340Reviewed-by:
-
Dave Schuyler authored
This reverts commit 53413b13. Reason for revert: (sheriff) Attempt at addressing failure at: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/66387 Original change's description: > [jumbo] avoid helper function collisions in VisibleUnits*Test.cpp > > This fixes jumbo builds after https://chromium-review.googlesource.com/923604 > > Change-Id: Ib7030da7e0a6acfdad8200564f9375ba218e8ca6 > Reviewed-on: https://chromium-review.googlesource.com/923723 > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> > Cr-Commit-Position: refs/heads/master@{#537278} TBR=yosin@chromium.org,fs@opera.com,mostynb@vewd.com Change-Id: I5b31694096f982e50954ee959b7e5c58d04a77f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/923374Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#537400}
-
Joel Einbinder authored
Live editing scripts can have side effects, even when the content of the script was unchanged. Change-Id: Ie818ad41cac67d9c9f176844d62fe0e62012d167 Reviewed-on: https://chromium-review.googlesource.com/922729Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#537399}
-
Xianzhu Wang authored
*** PLEASE DO NOT REVERT *** Please file a bug blocking crbug.com/771643 cc wangxianzhu@chromium.org chrishtr@chromium.org and vmpstr@chromium.org if you encounter any problem after this CL. After this change: - All blink unit tests and layout tests will run with SPv175 enabled by default; - We no longer have virtual/spv175 and flag-specific/enable-slimming-paint-v175; - We'll still have non-spv175 test coverage: - Many paint related tests still run with multiple configurations; - Several sub-directories of layout tests will be run as virtual/disable-spv175; - We may periodically try all tests with spv175 disabled on bots. Steps to generate this CL (similar to crrev.com/c/893624 which was for RootLayerScrolling, with some differences because we didn't have baselines for SPv175 for platforms other than linux before): 1. Merge FlagExpectations/enable-slimming-paint-v175 into TestExpectations; 2. Remove original virtual/spv175/ prefix for SPv175-specific failures in TestExpectations; 3. Change VirtualTestSuites to change original spv175 virtual suites to disable-spv175 suites using --disable-blink-features=SlimmingPaintV175; 4. Change original virtual/spv175/ failure expectations that were not SPv175 to virtual/disable-spv175/, in TestExpectations, SlowTests and other expectation files; 5. For each baseline files under flag-specific/enable-slimming-paint-v175, search the existing non-spv175 baseline in the order of platform/linux, platform/win and base dir, and overwrite the first found existing baseline with the spv175 one. 6. For each baseline files under virtual/spv175, search the existing non-spv175 baseline in the order of platform/linux, platform/win and base dir, and swap the two baselines; 7. Rename virtual/spv175 to virtual/disable-spv175, and update the README.txt files. 8. Upload the CL, and run webkit-patch rebaseline-cl. 9. When the try jobs finish, examine the try results, and run webkit-patch rebaseline-cl again to rebaseline the tests that failed on windows and mac (for which we didn't have spv175 baselines). Bug: 771643 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iedcdcc881e7ef43bc573a7f4b51ebe2bfbbbc411 Reviewed-on: https://chromium-review.googlesource.com/917226Reviewed-by: -
Torne (Richard Coles) authored
Have the JNI generator generate stubs for the classes used to do reflection in the Java bridge, and call those instead of using the Java bridge's own jni_helper.h functions that reimplement much of the same logic in a different way. Bug: 787557 Change-Id: I72930937ca30abb1139d025ed359f77ea6986cc2 Reviewed-on: https://chromium-review.googlesource.com/922803Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
This patch aims to simplify the layout of ContentSettingBubbleContents by adding a special View for media comboboxes and using BoxLayout for the main content. Also includes some miscellaneous cleanup. The visible changes of this patch are: * The scroll view extends the full width of the dialog. * The "?" button is the same size as versions in other dialogs. Bug: 652031 Change-Id: If920a89eee92ff3a0343be0be07cffe1b1b6084c Reviewed-on: https://chromium-review.googlesource.com/920747Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#537396}
-
https://skia.googlesource.com/skia.git/+log/50d4a6a66190..48b56688e8f5 $ git log 50d4a6a66..48b56688e --date=short --no-merges --format='%ad %ae %s' 2018-02-16 caryclark report ignore attr once only 2018-02-15 jvanverth Add full scaling for color emoji. 2018-02-16 scroggo Ensure all rows of a gif are initialized Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ia17092ecbdf4989a2797983db70fbaf59153fe2a Reviewed-on: https://chromium-review.googlesource.com/924305Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537395}
-
Sergey Ulanov authored
This is a reland of 81325ee9. Fixed issue in base.py: NotoSansCJKkr-Regular.otf -> NotoSansCJKjp-Regular.otf Original change's description: > Add NotoSansCJK font to content_shell_fonts collection. > > Currently the set of fonts used for layout tests on Android and Fuchsia > doesn't include any Chinese, Japanese or Korean fonts, so they render tofu > on the pixel tests that contain text in these languages. Adding NotoSansCJK > so these tests can render properly. > > Bug: 778467, 787020 > Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4 > Reviewed-on: https://chromium-review.googlesource.com/910122 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536920} TBR=sky@chromium.org,dpranke@chromium.org,drott@chromium.org Bug: 778467, 787020 Change-Id: I722cb2989504848a7ecc131ab5a8209fe8cafca6 Reviewed-on: https://chromium-review.googlesource.com/923720Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Bo Liu authored
Bug: 812955 Change-Id: Ice08cc78a2b3f2849d6fdcb1ce4c0e191088fd79 Reviewed-on: https://chromium-review.googlesource.com/923392Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#537393}
-
Istiaque Ahmed authored
The callbacks in FileReader are used as once callbacks, but they are declared to be RepeatingCallbacks. Fix this. Bug: 812717 Change-Id: I89badc6bbd3583fc510d47218bb7bb69d537964a Reviewed-on: https://chromium-review.googlesource.com/919704Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537392}
-
Peter Collingbourne authored
All of these test suites have failing tests on bullhead devices in non-CFI builds, so we won't be able to turn them on yet. Bug: 810907 Change-Id: I8aa8deef10627460e18a12d6ec45c5aa3fade5ef Reviewed-on: https://chromium-review.googlesource.com/923710Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537391}
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=dmurph@chromium.org Change-Id: Ie36fb07ec35d59a1bfbeb21773fe68b04ac14bf1 Reviewed-on: https://chromium-review.googlesource.com/923352Reviewed-by:
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=iclelland@chromium.org Change-Id: I347990cab77ee1c23a63bb2eb9fb924758459621 Reviewed-on: https://chromium-review.googlesource.com/924164Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537389}
-
Tom Anderson authored
BUG=None NOTRY=true Change-Id: I0d0ff41849a4fba978e9e643c5d17ea9121b6b82 Reviewed-on: https://chromium-review.googlesource.com/917283 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Dale Curtis authored
Today if --trace-startup is used and --trace-startup-duration has not elapsed by the time the layout test harness completes, no trace will be recorded. Similarly, if --trace-shutdown is specified no trace will ever be recorded. Both cases are due to the fact that the layout test runner kills the content shell process instead of waiting for it to shutdown in an orderly fashion. This change modifies the layout test harness to wait for driver shutdown when either --trace-startup or --trace-shutdown is specified; it uses the default_driver_stop_timeout() (3s) to wait for shutdown. BUG=none TEST=none Change-Id: Ifcdc600e519058a9c16839fa432a79aa76d7a34e Reviewed-on: https://chromium-review.googlesource.com/915544 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
