GitLab

This implements an (ideally temporary) intervention which allows cookies
that don't specify SameSite and get defaulted into SameSite=Lax mode
(under SameSiteByDefaultCookies) to be sent on requests with "unsafe"
http methods (e.g. POST) in addition to the usual Lax-mode restrictions,
if they are recently-created (within some threshold time delta).

This adds a CookieSameSite enum value LAX_MODE_ALLOW_UNSAFE which is
applied to default-Lax cookies that are recently-creatd. If a cookie has
effective SameSite of LAX_MODE_ALLOW_UNSAFE, it is sent with a request
if it meets all the Lax-mode requirements except for "safe" http method.

Bug: 990439
Change-Id: I5a650383699562a71ddf01447d3e23c6836c6362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734031Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685187}

This way all static initializers that happen before
main() can be estimated.

Bug: 988395
Change-Id: I95bc3edf2052d18b73f6bcf2d76c34815f282839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730899
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685186}

https://chromium.googlesource.com/angle/angle.git/+log/7270a6d578f5..e86a8560f202

git log 7270a6d578f5..e86a8560f202 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 syoussefi@chromium.org Vulkan: Fewer subgroup ops in seamful cubemap emulation

Created with:
  gclient setdep -r src/third_party/angle@e86a8560f202

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: I18912bb38bf94b07468d2773a0ecc529636bd3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685185}

Currently the dialog always prompts for both passwords
(the old one once, and the new one twice).

This change modifies it to only ask for passwords that
were not scraped.

Details:
If no passwords are scraped, both prompts are show immediately.
If the wrong old password is then entered, the same prompts are
shown again with "Incorrect password" next to the old password prompt.

If both passwords are scraped, a spinner is shown immediately.
If the old password scraped then fails to unlock cryptohome, then
the old-password prompt is shown as below.

If only the new password is scraped, then only the old password
prompt is shown. If the wrong old password is then entered, the
same prompt is shown again with "Incorrect password" next to it.

If only the old password is scraped, then only the new password
prompt is shown. Once the new password has been entered consistently,
if the old password scraped then fails to unlock cryptohome, then
the dialog is reshown but now with an old password prompt added.
If the old password is then entered incorrectly, then as usual,
the "Incorrect password" text will be shown next to that prompt.

The dialog is sized appropriately when first shown to make room for
the prompts that it contains. In the case that a new prompt is
added, it resizes itself.

Bug: 930109
Change-Id: I89f326ce50f4b0543c5053af25cae618b0c8ee92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724080
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685184}

This patch adds an extra parameter to PaintWorkletInput which allows
the device scale factor to be used on the worklet thread.

TBR=futhark@chromium.org

Bug: 980594
Change-Id: I60d281b0aeafd2d6522508b8d76bd944ba8f3140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701616
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685183}

- Create a mocked contacts interface that requires user agents to set
the contacts to return when queried.
- Implement the mocked contacts interface for chromium.
- Move chromium web_tests to the wpt folder. I've added one test and
removed one test.

Change-Id: I8fe518eef37eedf2908b4b0ea9bec9df9ea4938f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741915
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685182}

We only need to SetDrawRectangle when we are actually drawing to the
surface. Passing along as a parameter instead of posting a separate
task gives a nice perf win on RendererPerfTest/1.TextureQuads5x5
microbenchmark.

Bug: 974359
Change-Id: I62ccac3b97b5a34745c1583695ab4cdef5b37418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717822Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685181}

This reverts commit e9859ad0.

Reason for revert: Breaks WebRtcAudioDebugRecordingsBrowserTest on some Mac bots. See bug.

Original change's description:
> Add EXPECT_TRUE to NavigateToURL usage in webrtc browsertests.
> 
> This is in preparation for requiring WARN_UNUSED_RESULT on
> NavigateToURL() usage in tests.
> 
> Bug: 425335
> Change-Id: I23137312bd945c012aee424fc43248516595cfbd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742772
> Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Tommi <tommi@chromium.org>
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685098}

TBR=tommi@chromium.org,alexmos@chromium.org

Change-Id: I538d5cb813ee7e55cbfee8508b91d2be7b2249f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 425335, 991935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744346Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685180}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98b6993915c3..d88a2079b485


Created with:
  gclient setdep -r src-internal@d88a2079b485

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ic91e05e063fb6e892ee647f5b80a95789991f910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743016Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685179}

This reverts commit 83d2ffd4.

Reason for revert: The offending CL was found, it should be reverted instead of disabling the test. (See bug.)

Original change's description:
> Sheriff: Disable failing WebRTC browser tests
> 
> TBR=alexmos@chromium.org,tommi@chromium.org
> 
> Bug: 991935
> Change-Id: Id091cd054fd2b8aad837463bef5b7c63489cf248
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742161
> Reviewed-by: Kush Sinha <sinhak@chromium.org>
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685168}

TBR=tommi@chromium.org,alexmos@chromium.org,sinhak@chromium.org

Change-Id: I8eb6e73ac918d0d726962dbe677e6fc05394a585
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 991935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743731Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685178}

There is now a "Linux FYI SkiaRenderer Vulkan (Intel HD 630)" so this change
removes the SkiaRenderer tests (both GL and Vulkan) from the
"Linux FYI Experimental Release (Intel HD 630)" both

Bug: 908932
Change-Id: Ia51600774ee87488aff04cab9dd2cc44450c31fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742837
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685177}

As an additional incognito distinguisher, design added a special
background color for the omnibox in incognito mode.

Bug: 976645
Change-Id: I002db2657f028ee3796d39ed9a715003f7d8a2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744149Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#685176}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/9d6788aeb4b2..67bce690decd

$ git log 9d6788aeb..67bce690d --date=short --no-merges --format='%ad %ae %s'
2019-07-31 junyer Switch from //... to //:all when building with Bazel.
2019-07-26 junyer Get rid of StringAppendF().
2019-07-26 junyer Get rid of SStringPrintf().
2019-07-25 junyer Oops, missed a couple.
2019-07-25 junyer Don't make the arraysize() macro cast to int.
2019-07-24 junyer One more tweak for Python 3.
2019-07-24 junyer Get the Unicode scripts working with Python 3.
2019-07-21 junyer Update Unicode data to 12.1.0.
2019-07-07 junyer Make RE2::Set canonicalize DFA states.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Change-Id: I8a99f9df9983e677229e00a76c385be2a114cfb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743453Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685175}

Previously CustomTabBottomBarDelegate#addOverlayPanelManagerObserver
was called before CompositorViewHolder had a LayoutManager. This meant
that no observer was added and subsequently the bottom bar was not
hidden when an overlay panel was present.

Bug: 990367
Change-Id: I911e1d19347c59e6165b6d6649e709fcff418295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735163Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685174}

ResourcePrefetchPredictor was always using the origin of the initial
page being navigated to in constructing the NetworkIsolationKey.
With this CL, it uses the origin it expects the page to redirect to
instead.

Bug: 987735
Change-Id: Ic66c33bb5f99a9a00485ffe46c70e0947e0e430b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730782Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685173}

Follow-up to address comment at
http://crrev.com/c/17374393/ui/accessibility/ax_position.h#851

Rename:
CreateNextTextAnchorPosition -> CreateNextLeafTextPosition
CreatePreviousTextAnchorPosition -> CreatePreviousLeafTextPosition

Also re-implement renames that were lost in a rebase of
http://crrev.com/c/1735524:
CreateNextTreeAnchorPosition -> CreateNextLeafTreePosition
CreatePreviousTreeAnchorPosition -> CreatePreviousLeafTreePosition

Bug: 928948
Change-Id: I77b81f51ee7160395440e401318dd633365d96dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742949
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685172}

The old UnixDomainSocketAcceptor had an error callout on its delegate,
which was removed when switching to the MachBootstrapAcceptor in
3ddc5f07. Since it appears that there
are still errors that occur in the field, add this functionality to the
MachBootstrapAcceptor.

Bug: 984896, 272577
Change-Id: I2c009611c93b098ccbec7f43c633b57b722360f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741613
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685171}

This adds a flag to disable:
- window.OffscreenCanvas
- Context2DCreation.desynchronize.
- HTMLCanvasElement.transferControlToOffscreen

Bug: 940953
Change-Id: If774e41adbaa6bef94a058f783225b27e5d0669a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736804Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685170}

Bug: 974255
Change-Id: I0315389fc618744a73bd35d44f2fb114a8ec5f6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742136Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685169}

TBR=alexmos@chromium.org,tommi@chromium.org

Bug: 991935
Change-Id: Id091cd054fd2b8aad837463bef5b7c63489cf248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742161Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685168}

... instead of WebLocalFrame.

In order to perform this change, the header (media_stream_video_capturer_source.h)
got moved out of the Blink API directory (public/web/modules/mediastream),
down to renderer/modules/mediastream, now that it is used solely in Blink.

Also, now MediaStreamVideoCaptureSource does not use the InternalState
logic, holding itself a weak reference to LocalFrame.

Last, a TODO about using void* as parameter to SetMediaStreamDispatcherHostForTesting
gets removed too.

BUG=704136
R=guidou@chromium.org

Change-Id: Iea150242ae06bb7c2d44691887c38ca795735a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742117
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685167}

The wiring is done via a Bridge class on the Java side and a one View
class on the native side, which itself is more of a Controller / Bridge.
For now I don't see the need to separate the native side into multiple
classes, however that might be better and / or needed later.

Bug: 983445
Change-Id: I997161df9c2e377d85a5dccd335096cd05a2bb39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736362Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Cr-Commit-Position: refs/heads/master@{#685166}

Using same metric structure as for concurrent sweeping
(https://crrev.com/c/1690970)

Bug: 986235
Change-Id: Iff8b4a049f32500498c89e0b4d8f05a1958faa05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738694
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685165}

Don't require the implementations of the SecurityTokenPinDialogHost
interface to run any callback when CloseSecurityTokenPinDialog() is
called. The caller knows anyway that the dialog is being closed, so it's
just unnecessary and error-prone to rely on every implementation to
notify the caller about the closing.

This is a small refactoring, which should have no effect on the
currently implemented behavior. This change should slightly simplify
writing other implementations of the PIN dialog host - for the
Login/Lock screens.

Bug: 964069
Change-Id: Ied94a1e90bb3f4063081427888d8fcc566719777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743729
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685164}

Compute "the last day" from which we have data for each benchmark/bot
individually. This way, if a benchmark (test_suite) has not run in a
day or two, we fall back to the latest run we can find as the
"reference" value.

Also take the chance to drop a few columns which are not currently in
use.

Bug: 991923
Change-Id: Icc7a806aa5205dfa3dd49e320f66f1e1eae9f034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743629Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685163}

https://chromium.googlesource.com/catapult.git/+log/5508416f1958..bca4ad25f4fd

git log 5508416f1958..bca4ad25f4fd --date=short --no-merges --format='%ad %ae %s'
2019-08-08 perezju@chromium.org [Telemetry] Do not depend on sys.argv to sniff benchmark name

Created with:
  gclient setdep -r src/third_party/catapult@bca4ad25f4fd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:985712
Change-Id: I7312d37dd2f523d615caf2f5bd645bcc54396a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743815Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685162}

This CL introduces mojo DataPipe instead of ReadOnlyBuffer.
With DataPipe, we can reduce memory copy and optimize quota control.

Unfortunately, this CL makes performance slower:
ToT:   147 MB/s
Patch: 128 MB/s
That's because this CL replaces minimize part and we will do
the optimization later on.
If the optimization doesn't go over the original score before
M78 (will be branch cut on Sep 5th), we will revert this change.

Bug: 865001
Change-Id: I28613817e3104af7ca9e347a6a906ee8eaed2dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738011
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685161}

Bug: 917396
Change-Id: I34e93f410c4587944114269eaca5ab661423037f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743268
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685160}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 968047
Change-Id: Iffc349a1cfd3e51e254ae784fbe53f2d62a04b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729211
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685159}

Using wpt-import in Chromium 2f821af7.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Icecc8279870f0fd2a31b8f3e5cdd9d2037d067ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744046Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685158}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pkotwicz@chromium.org

Bug: 968047
Change-Id: Ib0211043f7ac0fdd8b56f6562bcb9880f3e602c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739946
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685157}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pmonette@chromium.org

Bug: 968047
Change-Id: I1bf55db696228a2248ade20a142b5c3015ba8da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739889Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685156}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/619e49fa7df7..98b6993915c3


Created with:
  gclient setdep -r src-internal@98b6993915c3

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I61001531bbf7f69fb5fd4bd25e654cc5f0356d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743813Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685155}

https://chromium.googlesource.com/angle/angle.git/+log/0fec5eabc671..7270a6d578f5

git log 0fec5eabc671..7270a6d578f5 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 kkinnunen@nvidia.com Fix ShaderStorageBufferTest31.LoadAndStoreBooleanVarAndArray to be more correct

Created with:
  gclient setdep -r src/third_party/angle@7270a6d578f5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: I5f199e7aa3f7381633a504bdb0ef13363100f5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743814Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685154}

This will help in diagnosing failures that deposit error messages in the
installer's log file.

BUG=907979

Change-Id: Ib9ddf7d120ab4f29b33cce4d64f866e071dca362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744146
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685153}

This change breaks pausing on start when inspecting a shared worker that
gets reloaded. More detail here: crbug.com/987024

Bug: 882467
Change-Id: I074b547996fd7f11d835fcebfdae32a4f7063a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636110
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685152}

The convention to call native methods from Java has been changed
(see //base/android/jni_generator/README.md). Convert the methods
in AccountTrackerService.java to the new convention.

Bug: 934688
Change-Id: I0075a76653f71a40ae79140b20b425af959f29de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741819Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685151}

It seems we may be hitting a race condition where (1) a BrowserPlugin
is created in a mainframe, but (2) before the browser knows about the
BrowserPlugin it routes an event to a main frame that ends up
targeting the newly created BrowserPlugin. In this scenario the
HandleInput function will correctly return kNotHandled, but the DCHECK
firing really doesn't indicate a problem.

Since BrowserPlugin will go away soon, let's just remove this DCHECK.

Bug: 985944
Change-Id: I6fcaf54a2cecdcc4a53c79cbc7fa260bf6697c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742368Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685150}

Use the public API of IdentityManager, PrimaryAccountMutator, to set the
primary account instead of using IdentityManager's internals
(PrimaryAccountManager).

PrimaryAccountMutatorImpl::SetPrimaryAccount calls PrimaryAccountManager::Signin, with added pre-conditions:
  - Preferences allow the signin
  - There is no primary account already set (IsAuthenticated)
  - AccountTrackerService knows about the account, and it has both a
    valid account_id and email.
If those are not met, SetPrimaryAccount does not call PrimaryAccountManager::SignIn and returns false.

In practice, those are already met or were already required:
  - Most of SignIn calls do check the preferences beforehand. Two
    exceptions: Re-authentication cases (SyncAndServicesPreferences, SignInHelper), SigninFragment.
  - PrimaryAccountManager::Signin and
    PrimaryAccountManager::SetAuthenticatedAccountId also verify that.
    If the user is authenticated, the signin is not completed, no
    notifications are sent. A slight behavior change could happen here
    though: a DCHECK verifies that the same user is re-authenticating.
  - PrimaryAccountManager::SignIn also needs AccountTrackerService to be
    properly initialized with the account.

Bug: 987965
Change-Id: I70f30bcf3536a79bb5983333233c59aeb5b8a5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738696
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685149}

Using wl_display_dispatch is a wrong thing to do as it is a blocking
method (see [1]). It can cause freezes and deadlocks.

Instead, we need to do something like this -

while (wl_display_prepare_read_queue(display, queue) != 0)
        wl_display_dispatch_queue_pending(display, queue);
wl_display_flush(display);

ret = poll(fds, nfds, -1);
if (has_error(ret))
        wl_display_cancel_read(display);
else
        wl_display_read_events(display);

wl_display_dispatch_queue_pending(display, queue);

However, there is no need to do a second poll as long
as we are notified by libevent that the display fd is
non-blocking. However, to ensure we can read, we have
to prepare the queue, which tells other clients we
are going to read from the queue. If prepare fails,
it means there is nothing to read. Thus, we push
the events into the queue and return early instead.

We have also to add an "automatic" flush as part
of the polling mechanism. This poll must ensure
that all the data has been written to the queue.
If not, -1 is returned and EAGAIN is set. In this
case, we have to stop watching the fd for read
access and start watching it for the write access.

As soon as all the data is written, we can get
back to reading.

[1] https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Client/classwl__display.html#a30a9c4f020f3e77581c7a81ecdb4913d

Bug: 987821
Change-Id: I536513034c18a47da079a2b56a75d32f20f72ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730159Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685148}