- 28 Aug, 2014 40 commits
-
-
mfomitchev authored
The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136 Thus we don't need to scale it again when we paint during the overscroll gesture. BUG=402280 Review URL: https://codereview.chromium.org/507083002 Cr-Commit-Position: refs/heads/master@{#292426}
-
joaodasilva authored
This fixes an issue with invalid JSON being generated as example values for policies on Windows, and points to the documentation for complex policies on Windows. BUG=381627 Review URL: https://codereview.chromium.org/511993003 Cr-Commit-Position: refs/heads/master@{#292425}
-
simonhong authored
And it doesn't have its body :) R=brianderson@chromium.org BUG=NONE TEST=NONE(non functional change) Review URL: https://codereview.chromium.org/515573005 Cr-Commit-Position: refs/heads/master@{#292424}
-
ajith.v authored
IME Visibility status check test case is missing when we do long press on different kind of empty and non-empty input fields. This patch takes care of adding missing test cases for the same. BUG= Review URL: https://codereview.chromium.org/516843005 Cr-Commit-Position: refs/heads/master@{#292423}
-
jeremy authored
Telemetry does not account for process death when computing deltas of various process statistics over a browser run. CPU stats are currently stored in a dictionary of POD types aggregated by process type which gives no room for separating dead processes over a run. Ultimately the goal is to report CPU stats in the timeline on a per-process basis. Towards this goal and to fix counting of dead processes, this CL adds an IdleStatsData object which inherits from TimelineData. IdleStatsData keeps track of idle wake ups by PID and is able to omit processes which have died during a run from the final reported result. BUG=343373 Review URL: https://codereview.chromium.org/501813002 Cr-Commit-Position: refs/heads/master@{#292422}
-
andresantoso authored
In r272421, I changed sheet repositioning on window resize to be based on NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification because it tracks window resizing much more smoothly. That caused this problem where if the browser window is vertically maximized (or is in fullscreen), the window size does not change when the bookmark bar is shown or hidden. The old code has a different bug however. If the browser window is not vertically maximized, showing or hiding the bookmark bar does not change the browser content view's frame. It moves up or down to follow the window resize but its frame relative to its superview remains the same. I settled for adding code to explicitly update the sheet's position when the bookmark bar is shown or hidden. BUG=407509 Review URL: https://codereview.chromium.org/502413004 Cr-Commit-Position: refs/heads/master@{#292421}
-
dcheng authored
BUG=110610 TBR=bauerb@chromium.org Review URL: https://codereview.chromium.org/510313002 Cr-Commit-Position: refs/heads/master@{#292420}
-
yzshen authored
The bug in JavaScript encoder that prevented us from doing so has been fixed. BUG=None TEST=None Review URL: https://codereview.chromium.org/509173003 Cr-Commit-Position: refs/heads/master@{#292419}
-
torne authored
The android webview build now uses clang when building for host; update the gyp variables appropriately to make sure we use reasonable compiler flags. BUG=377684 Review URL: https://codereview.chromium.org/516723004 Cr-Commit-Position: refs/heads/master@{#292418}
-
Dana Jansens authored
When removing tiles, we need to remove everything outside the live tiles rect even if it has borders inside the live tiles rect. The DifferenceIterator includes borders when deciding if a tile is in the included rect, so tiles that are only in the included rect with a border were not being removed from the tiling. This lead to us having tiles outside the rect, and to creating a tile that already existed. When adding tiles, the same problem existed. The DifferenceIterator includes borders when deciding which tiles are to be excluded, so a tile that was inside the old live tiles rect with borders only would not have existed, but it would be excluded by the DifferenceIterator. This prevented us from making tiles that were inside the live tiles rect. Depends on: https://codereview.chromium.org/513903002/ R=enne@chromium.org, vmpstr@chromium.org, enne, vmpstr BUG=405427 Review URL: https://codereview.chromium.org/505913003 Cr-Commit-Position: refs/heads/master@{#292417}
-
Sadrul Habib Chowdhury authored
Move PepperPDFHost out of //chrome into the pdf component at //components/pdf. With this change, the IPC messages in the component is used only by the component itself, and nothing outside of the component uses these IPC messages anymore. BUG=401242 R=raymes@chromium.org, senorblanco@chromium.org, sky@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/505243003 Cr-Commit-Position: refs/heads/master@{#292416}
-
vsevik authored
DevTools: Restore embedded devtools manager unit test checks after switching service worker inspection on the main thread. TBR=yurys, horo BUG=404355 Review URL: https://codereview.chromium.org/515593004 Cr-Commit-Position: refs/heads/master@{#292415}
-
machenbach authored
TBR=vogelheim@chromium.org Review URL: https://codereview.chromium.org/512933008 Cr-Commit-Position: refs/heads/master@{#292414}
-
jmadill authored
AppendSwitch was casting all directories to lower case, causing the tests to early-out and return as always passed even before they create the test window. BUG=408251 Review URL: https://codereview.chromium.org/500133005 Cr-Commit-Position: refs/heads/master@{#292413}
-
yoz authored
Make these tests and settings_quota_unittest run in extensions_unittests. Move a test that depends on sync (not available in the extensions module) to settings_sync_unittest. Depends on previous CL: https://chromiumcodereview.appspot.com/461273003/ BUG=397164 Review URL: https://codereview.chromium.org/472343003 Cr-Commit-Position: refs/heads/master@{#292412}
-
tim authored
Revert of NaCl: Update revision in DEPS, r13666 -> r13668 (patchset #1 of https://codereview.chromium.org/513933003/) Reason for revert: attempting to fix compile failures. Original issue's description: > NaCl: Update revision in DEPS, r13666 -> r13668 > > This pulls in the following Native Client changes: > > r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain > r13668: (noelallen) Force rebuild on cmd change. > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > TBR=bradnelson@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/ba2092ce9ac0792098dcca59f9a224e13825dcd5 TBR=bradnelson@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/509413002 Cr-Commit-Position: refs/heads/master@{#292411}
-
sky authored
Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 of https://codereview.chromium.org/512693004/) Reason for revert: I'm reverting this. http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_... should have triggered a compile. Original issue's description: > Changes exception for gyp files to only gyp files in build/ > > I changed analyzer such that if a gyp file (or an included gypi file) > changes all targets in the gyp file are marked as changed. This means > I should no longer have to special case gyp files. I'm leaving the > exception in place for any gyp files in build as any change to those > really needs to recompile the world. > > BUG=109173 > TEST=none > R=thakis@chromium.org > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b TBR=thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=109173 Review URL: https://codereview.chromium.org/512303002 Cr-Commit-Position: refs/heads/master@{#292410}
-
Jun Mukai authored
BUG=None R=oshima@chromium.org TBR=oshima@chromium.org TEST=compile succeeds Review URL: https://codereview.chromium.org/508283003 Cr-Commit-Position: refs/heads/master@{#292409}
-
ankit2.kumar authored
Ime should not be dismissed and Select action bar should be dismissed in case a cut operation is performed on any input field. Add test case to check this. Review URL: https://codereview.chromium.org/508993002 Cr-Commit-Position: refs/heads/master@{#292408}
-
pneubeck authored
Renaming from 'settings' to the more informative 'user_settings'. BUG=NONE Review URL: https://codereview.chromium.org/513143004 Cr-Commit-Position: refs/heads/master@{#292407}
-
nasko authored
This CL adds tracing statement for the navigation functionality within Chrome and modifies some of the existing tracing already in place. Review URL: https://codereview.chromium.org/498883002 Cr-Commit-Position: refs/heads/master@{#292406}
-
perezju authored
Changed implementation to make a single shell call, rather than pushing files and executing several shell calls. When running telemetry unittests on android, reduces total execution time about 12%. BUG=379378 Review URL: https://codereview.chromium.org/514123005 Cr-Commit-Position: refs/heads/master@{#292405}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/512153002 Cr-Commit-Position: refs/heads/master@{#292404}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/512063003 Cr-Commit-Position: refs/heads/master@{#292403}
-
dmazzoni authored
This is a workaround for an Android accessibility bug - when the object with accessibility focus moves, Android doesn't update the bounds of accessibility focus on the screen, even if we send a WINDOW_CONTENT_CHANGED event. With this change, we keep track of the bounding rect of the node with accessibility focus, and if it changes, we move focus to the document and then back to this node, which works around the issue. No visual flicker was observed when testing on multiple devices. Refreshable braille displays flicker briefly. BUG=407871 Review URL: https://codereview.chromium.org/505423002 Cr-Commit-Position: refs/heads/master@{#292402}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/b2f7fce9e034c3b6749e75a129e7836df3529706..dc53701216c0e9f98eacf6c0cda769ebbd200b59 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel TBR=djsollen@google.com Review URL: https://codereview.chromium.org/517643002 Cr-Commit-Position: refs/heads/master@{#292401}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/515093002 Cr-Commit-Position: refs/heads/master@{#292400}
-
gavinp authored
Adds a regression test for bug 317138. This test is interesting because it generates exactly the same stacks that we're seeing in crash reports on that bug. This is a good regression test, so I suggest we land it, as well as look at it for more confidence that our fix to bug 317138 is the right fix. R=ttuttle@chromium.org,jkarlin@chromium.org BUG=317138 Review URL: https://codereview.chromium.org/509973002 Cr-Commit-Position: refs/heads/master@{#292399}
-
timvolodine authored
Adds UMA logging to track how many batteries are reported by the system at the start of Battery Status API. BUG= Review URL: https://codereview.chromium.org/480113003 Cr-Commit-Position: refs/heads/master@{#292398}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#292397}
-
fgorski authored
Extracting GCMConnectionObserver from GCMAppHandler * Updating consuming code: GCMInvalidationBridge * Updating GCMAppHandler overrides * Updating tests for GCMDriverDesktop BUG=407841 R=jianli@chromium.org Review URL: https://codereview.chromium.org/515763002 Cr-Commit-Position: refs/heads/master@{#292396}
-
qinmin authored
Most hardware OEMs provides codecs to support H264 main/high profile. The current way of declaring them as unsupported is too restrictive. BUG=407741 Review URL: https://codereview.chromium.org/506283002 Cr-Commit-Position: refs/heads/master@{#292395}
-
aurimas authored
BUG=163393 Review URL: https://codereview.chromium.org/509753002 Cr-Commit-Position: refs/heads/master@{#292394}
-
fsamuel authored
BUG=none TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/517593002 Cr-Commit-Position: refs/heads/master@{#292393}
-
Scott Violet authored
I changed analyzer such that if a gyp file (or an included gypi file) changes all targets in the gyp file are marked as changed. This means I should no longer have to special case gyp files. I'm leaving the exception in place for any gyp files in build as any change to those really needs to recompile the world. BUG=109173 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/512693004 Cr-Commit-Position: refs/heads/master@{#292392}
-
yiyaoliu authored
BUG=293702 Review URL: https://codereview.chromium.org/469653002 Cr-Commit-Position: refs/heads/master@{#292391}
-
mlamouri authored
Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/) Reason for revert: Creates timeout failures on a lot of inspector/ tests in Blink: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio Original issue's description: > DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events > > Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol. > > BUG=398787 > > Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf TBR=dcheng@chromium.org,caseq@chromium.org,loislo@chromium.org,vsevik@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=398787 Review URL: https://codereview.chromium.org/516963003 Cr-Commit-Position: refs/heads/master@{#292390}
-
acolwell authored
Changing WebMediaPlayerImpl and related media code to use task runners instead of MessageLoopProxy to avoid presubmit errors when moving this code to media/blink. There is no functional change here. Just making the tools happy. :) BUG=408338 Review URL: https://codereview.chromium.org/508293003 Cr-Commit-Position: refs/heads/master@{#292389}
-
Nico Weber authored
brings in https://codereview.chromium.org/515263002 TBR=rnk@chromium.org Review URL: https://codereview.chromium.org/513973004 Cr-Commit-Position: refs/heads/master@{#292388}
-
vsevik authored
BUG=404355 R=yurys, pfeldman-OOO, horo Review URL: https://codereview.chromium.org/479673004 Cr-Commit-Position: refs/heads/master@{#292387}
-