- 22 Nov, 2017 40 commits
-
-
Marc Treib authored
With this change, a tile will also be highlighted when right-clicking its "x" in the top right. This was the previous behavior, but was broken by making the "x" keyboard-focusable in https://crrev.com/c/725659. While we're here, also remove the "-webkit" prefix from the CSS "filter" property, since Chrome doesn't need it anymore. Bug: 785215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b2451b2a33bbf021f2328fbec3733bc20d0f3ab Reviewed-on: https://chromium-review.googlesource.com/779122Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#518606}
-
Rune Lillesveen authored
Split the PASS text of the reference into multiple inlines like the test does. The reference did not match in Blink because of a text shaping bug: https://crbug.com/6122 Bug: 657748, 6122 Change-Id: If9894d45415a8f9ada80c2912abbd552a181b423 Reviewed-on: https://chromium-review.googlesource.com/784933Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#518605}
-
Roman Sorokin authored
Also makes fake_cryptohome_client loads install_attributes from the stub file. It's needed to use install_attributes in fake_authpolicy_client (which uses fake_cryptohome_client). After that would be landed we should point to different repo on the Chrome OS side for that file. TBR=mnissler@chromium.org Bug: 784858 Test: manual Change-Id: I1febe7c278a65ea6c8714875816c1f03e1d6b335 Reviewed-on: https://chromium-review.googlesource.com/768718 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518604}
-
Dominik Röttsches authored
Tbr: asvitkine Bug: 785517 Change-Id: I406718042e7ee595a5597a80ebc8e8250f139a7e Reviewed-on: https://chromium-review.googlesource.com/784932Reviewed-by:
-
Hajime Hoshi authored
Bug: 780378 Change-Id: I69b5822d50b8cd1cbd281ab6486a40f7e459a091 Reviewed-on: https://chromium-review.googlesource.com/784656Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518602}
-
Hiroki Nakagawa authored
This just cleans up referrer tests and doesn't change behavior. Bug: 773921 Change-Id: I790cb392d009792b469a1907c0f2e47da87a07b5 Reviewed-on: https://chromium-review.googlesource.com/784742Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#518601}
-
Alexandr Ilin authored
This CL contains three different changes that are independent but work together to improve page load timing benchmarks results. 1. Preconnect to the main page for all hint origins including HintOrigin::NAVIGATION. 2. Check for possible HSTS redirects before preconnecting. 3. Open minimum 2 sockets for the main page. This change requires a fair amount of plumbing to pass a number of sockets from LoadingPredictor to PreconnectManager. Bug: 699080, 784206 Change-Id: I5301a86989d1e2ecaa5197ebcec526e4d3bf4eae Reviewed-on: https://chromium-review.googlesource.com/778899Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518600}
-
Prashant Malani authored
For the purposes of this class, the semantics of circular_deque and std::deque are the same. Switching to std::deque will make this class easier to re-use outside of Chrome, by reducing its dependency on src/base/containers. BUG=chromium:701005 TEST=MIDI works on Chrome. Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082 Reviewed-on: https://chromium-review.googlesource.com/784010 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#518599}
-
jdoerrie authored
This change removes the deprecated base::Value::IsType() in //components in favor of using is_{none,bool,...}() directly. Bug: 646113 Change-Id: Id03d55287eefbb262aa19da2a9eea01474901d06 Reviewed-on: https://chromium-review.googlesource.com/781663Reviewed-by:Colin Blundell <blundell@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#518598}
-
Vadym Doroshenko authored
1.getElementByNameWithParent is a generic function that's not used password_controller.js anymore, so common is the better place for it (it would also allow to test it). 2.isPassword argument is not needed anymore, so function is simpified. 3.Added a test for it. Bug: 782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida9a6719f1533d36c4dd468100860046a0db809f Reviewed-on: https://chromium-review.googlesource.com/758402 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518597}
-
Darren Shen authored
Currently, StylePropertyMapReadonly.get/getAll/has are virtual functions so that they can be overridden by specific types of style maps (e.g. the computed style map). However, because the whole function is virtual, overriding it requires implementing the function from scratch. This means that there's a lot of logic being duplicated across different style maps (e.g. validation, converting CSSValues to style values). This patch makes get/getAll/has non-virtual. To override behaviour, subclasses just need to override two functions: const CSSValue* GetProperty(CSSPropertyID); const CSSValue* GetCustomProperty(AtomicString); This makes it very easy to define new style maps and significantly reduces amount of duplicate boilerplate code. Future patches will do the same thing for other methods on StylePropertyMap. Bug: 785132 Change-Id: Iae6e43684ff54a317bca0db6a0bf32629c298bc1 Reviewed-on: https://chromium-review.googlesource.com/770606Reviewed-by:nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#518596}
-
Alexandre Courbot authored
libva 2.0 is a major version upgrade, meaning that the library dlopen'ed by Chromium is renamed from libva.so.1 to libva.so.2. Due to the way ChromeOS is built, we may end up with a browser build against the old libva even after the sysroot is upgraded to the new version. For this reason we will keep both versions of the library on the system until all buildbots have caught up to the 2.0 upgrade. This patch makes Chromium capable of loading any of these two versions, by whitelisting the newly-introduced libraries on the rootfs, and loading the correct library depending on the version it has been compiled against. The old libva 1 paths will be removed once the buildbots have all caught up. BUG=chromium:785117 TEST=Made sure that the chrome binary and video_decode_accelerator_unittest were both finding and loading the right library. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3b24ffdd2ac9dcadacab2f3e10dbe62644e9ce01 Reviewed-on: https://chromium-review.googlesource.com/781324Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#518595}
-
Tatiana Gornak authored
This CL implements skeleton view for the autofill on-field popup. Every type of the autofill popup is displayed as a text row after this CL. The implementation is guarded with a feature. Screenshots of some popups are attached to the bug. This CL doesn't implement animation related to the popup, e.g. the row isn't hilighted when the mouse hovers over the row. The separator element isn't displayed. BUG=768881 Change-Id: Ib235a1b811ce0026428fdc03d1eba7f7be27fd0a Reviewed-on: https://chromium-review.googlesource.com/685237 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518594}
-
Hayato Ito authored
This fix is similar to https://chromium-review.googlesource.com/c/chromium/src/+/778648. virtual/incremental-shadow-dom/shadow-dom/nodetree-radio-node-list.html should be fixed with this CL, however, it still crashes due to crbug.com/787717. Once we can rewrite built-in elements so that they don't use Shadow DOM v0 feature, the crash would be gone. Bug: 776656 Change-Id: I0acde37be7688c9875cbbed633f3a527f91b66ed Reviewed-on: https://chromium-review.googlesource.com/784740Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#518593}
-
Christian Dullweber authored
Site engagement entries are currently included in the cookie counter. This creates an entry for every single site visited, which is especially confusing when cookies are turned off. Site engagement doesn't act like a cookie (it can't be read or written by a site), so this CL removes it from the counter. Bug: 782606 Change-Id: Ia0953b8a34b3899d19fe19af1da3c8ec21600f23 Reviewed-on: https://chromium-review.googlesource.com/774283 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#518592}
-
Hiroki Nakagawa authored
Before this CL, ModuleScriptLoader::Fetch() sets the Referrer in ModuleScriptFetchRequest after creating a FetchParameters instance. This doesn't take effect. This CL fixes it by updating the Referrer via FetchParameters::MutableResourceRequest(). Also, this adds WPT tests for the Referrer on module scripts. Bug: 786862 Change-Id: Ib0031407796e1a7e701565094396e5442aa75702 Reviewed-on: https://chromium-review.googlesource.com/780479 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518591}
-
Yuki Shiino authored
Makes callback functions return v8::Maybe so that the call sites handle an exception if any. Also this patch renames |call| function to |Invoke|. For convenience, if the return type of IDL callback function is void, the bindings code generator defines |InvokeAndReportException| that captures and swallows an exception if any. If the return type of IDL callback function is not void, the call sites must check the return value. |InvokeAndReportException| is not defined in non-void case. Bug: 779036 Change-Id: I1057cb2fcd88208310f79e184aaf1b069a0f81f8 Reviewed-on: https://chromium-review.googlesource.com/768259Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518590}
-
Tsuyoshi Horo authored
WorkerScriptLoader is using UTF8 as a default encoding. But currently ServiceWorkerInstalledScriptsManager is using latin1 as a default encoding. Bug: 787736 Change-Id: I5a871fd87b994ad4d439f822e9254ca5df3af76b Reviewed-on: https://chromium-review.googlesource.com/784741Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Before this CL, we installed conditional interface objects, i.e. [SecureContext] attributes, on Window objects if and only if the Window object was created from snapshot. This CL installs them on the Window object regardless if it is created from a snapshot or not. Bug: 786750 Change-Id: I5166340b0d300b7101d5ec04a7f4a5212dd4e43b Reviewed-on: https://chromium-review.googlesource.com/778642 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
The current heuristics: if there is one button on a password form, let's assume that this is the submit button. But some sites have many buttons in a password form (for example show password). Let's improve heuristics: if there are button[type='submit'], let's assume that this is submit buttons (even there are multiple of them), otherwise let's fallback for the initial heuristics. Bug: 715717 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idfe9d9f76e4e1ff5d80719db63fc2a0864f1e3bc Reviewed-on: https://chromium-review.googlesource.com/781866 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Tomasz Mikolajewski authored
The | at the end would match everything. Bug: None Test: None Change-Id: If4ea72e4487571a0a7d40d6673fde4e85f604a8f Reviewed-on: https://chromium-review.googlesource.com/784655Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#518586}
-
Makoto Shimazu authored
After S13nServiceWorker, clients can directly fire events without the browser process, so we need to move some codes which tracks events to the renderer. This patch is to implement the idle timer on the renderer. In this patch, - SWContextClient tracks the number of inflight events by using SWEventTimer which is added by this CL - SWContextClient::OnIdle() is called when 30 seconds passed after the end of the last event, and it requests termination to the corresponding EWInstance - EWInstance stops the worker, or do nothing if there are inflight events which are dispatched just before RequestTermination. Even after moving the idle timer to the renderer, the browser still has the primarily control of the lifecycle of the worker thread. If the worker thread is unresponsive, the browser will detect it by a ping-pong timer and terminate the worker thread. Bug: 774374 Change-Id: I8d9cbb60cbf7583be3eb12a88860f74bbdcc949f Reviewed-on: https://chromium-review.googlesource.com/758314 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#518585}
-
Oskar Sundbom authored
Based on mojoms in issue 2882213002 (http://crrev.com/2882213002#ps1) BUG= Change-Id: I464d2178713a64f35aaec02e0ac365344b821cb1 Reviewed-on: https://chromium-review.googlesource.com/580988Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#518584}
-
Owen Lin authored
The interface is only used for decoding. I am going to remove the usage from Android side. Before that, remove the check of the parameter. BUG=None TEST=None Change-Id: I0038f4971f8cd9afe429ff52ff395423d9c4548e Reviewed-on: https://chromium-review.googlesource.com/778502Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Owen Lin <owenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518583}
-
Michael Lippautz authored
Bug: chromium:780749 Change-Id: Ia9f7c7fb5f011e5f2af93421eb11787778a84ff9 Reviewed-on: https://chromium-review.googlesource.com/783211Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/2707fb2782e7..37e489c985ca $ git log 2707fb278..37e489c98 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie21536881887cb707bf52a55ae21dce25b98dfe3 Reviewed-on: https://chromium-review.googlesource.com/783840Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518581}
-
Peter E Conn authored
NewTabPageTest#testRender captures images of the New Tab Page at its start position and when scrolled. It used to have a timeout checking against the scroll position to ensure it was fully scrolled before the second capture. With the condensed layout on larger screens there is not enough space to scroll that far, so the test was failing with a timeout. This change instead requests that the RecyclerView scrolls to the bottom and the criteria for the timeout is now whether the View can be scrolled any further. Bug: 784598 Change-Id: I696b08dfdae36209a6549141fa31006233dc17a9 Reviewed-on: https://chromium-review.googlesource.com/782120 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#518580}
-
Olga Sharonova authored
This reverts commit 24d1491f. Reason for revert: suspected in breaking webkit_layout_tests virtual/threaded/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-vertical-rl-anchors.html, see https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/12398 Original change's description: > Animation tests: Use rAF instead of setTimeout > > With a debug build, a slow or busy machine, and a demanding animation > (e.g. cross-faded images), > setTimeout might wait indefinitely. > > Using requestAnimationFrame is more effective. > > BUG=248938 > > Change-Id: I8636b17123bb30ef675b8a3aa5cfe2e297aac222 > Reviewed-on: https://chromium-review.googlesource.com/784373 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518561} TBR=ericwilligers@chromium.org,shend@chromium.org Change-Id: I823b5d060863a0a049ce447939b7e2a4570ad752 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 248938 Reviewed-on: https://chromium-review.googlesource.com/784950Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#518579}
-
Sylvain Defresne authored
Convert ITunesLinksObserver to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ia88fe44a99ed762d46894de95e18f8ebde18dd79 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778999 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518578}
-
Jia authored
PowerManagementClient::Observer interface. IdleEventNotifier is the class that will listen to all relevant signals and emit idle events to its observers after certain period of inactivity. The overall user activity event logging sys will contain two components: (i). IdleEventNotifier - This class is responsible for detecting when we should start logging: we should start logging after an idle period. - It will listen to multiple signals (power manager signals, user activity, video activity etc) to determine whether idle event has occurred, see https://docs.google.com/document/d/123eFd0rUTu0140V6hJKkkWmpqibdIfM-zTtUR5a2qaQ/edit# (ii). UserActivityEventLogger - This class is responsible for feature extraction and determining event types, and log the event. This will be implemented as an IdleEventNotifier::Observer in a later cl. Note, UserActivityEventLogger will also implement other observers to listen to power management signals etc. In this cl, we only implement PowerManagementClient::Observer interface for IdleEventNotifier so that we can observe the following signals: - Lid-opened - Power-changed - Suspend (SuspendImminent and SuspendDone) We will add other interfaces to IdleEventNotifier in future cls. Bug: 784232 Change-Id: I66c577efbdb6eda0179a896170dbb3b70b2dc84e Reviewed-on: https://chromium-review.googlesource.com/771052 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#518577}
-
Naoki Fukino authored
There is a chance that VolumeReaderJavaScriptStream::Read() waits a response of ReadChunk forever. The problematic scenario is illustrated in https://bugs.chromium.org/p/chromium/issues/detail?id=457448#c28 VolumeReaderJavaScriptStream can request ReadChunk without a client's request to read ahead. It expects a response through VolumeReaderJavaScriptStream::SetBufferAndSignal, but a response can be ignored in Volume::Volume::ReadChunkDone() if the file for previous Read request is already closed. This can cause Read() to be hanged. Considering the case of reading ahead (without explicit Read requests from client), I think we should always set buffer and signal VolumeReaderJavaScriptStream when ReadChunk is done. scrolling randomly. Bug: 457448 Test: Open a zip file which contains 1000 photos, and browse photos by Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iade702bf06042d9687f0a5793833d2486a3d761a Reviewed-on: https://chromium-review.googlesource.com/784692Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518576}
-
Yoichi Osato authored
It is comparing size_t and enum w/o cast. Bug: 778262 Change-Id: Iec0c159eae06c6450bdeb3f592106216071d797a Reviewed-on: https://chromium-review.googlesource.com/784673 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df985bbc..0001378a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id3cac30642b5434d5474e5df4b140ae28391753d Reviewed-on: https://chromium-review.googlesource.com/784630Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518574}
-
Reilly Grant authored
This patch adds synchronization to the sensorStarted and sensorStopped methods to prevent races between the main thread starting and stopping sensors and the sensor event handler thread processing a sensor error. Bug: 780220 Change-Id: I9ff1f5e24ba59aaeddcda88ea8c63b6cf6f59287 Reviewed-on: https://chromium-review.googlesource.com/783705Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518573}
-
Sergei Datsenko authored
Embed requested resources into tests. This will allow verifying more complicated redirect chains, and also keeping inputs and outputs together makes them more comprehensible. Bug: chromium:787197 Change-Id: I705e0d859ad2cca8b686ea3b6e09b0af182eee30 Reviewed-on: https://chromium-review.googlesource.com/781379Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#518572}
-
Jinsuk Kim authored
Chrome UI had top/bottom browser controls that may shrink Blink's view size. Previously all the info (control height, flag indicating that shrinking should happen) are passed down to generate the view size upon request in content layer. This CL moves the responsibility to embedder(Chrome) so that all the shrinking happens before reaching content layer. With this CL, the view size stored in ViewAndroid already the shrinking affect taken into account. The browser control info are still passed but they are for plumbing, to be used in Blink/cc only. The new shrinking logic lives in CompositorViewHolder/CompositorView that already knows about them. Now browser control update info is fetched through WebContentsDelegate which is overridden per content (i.e. tabbed content, overlay panel content) each of which has its own way of managing the info. Other embedders that do not need dynamic browser control update will use the default implementation. Related discussion is in the bug: https://bugs.chromium.org/p/chromium/issues/detail?id=622847#c30 Follow-up CL's will remove size logic still left in ContentView/ContentViewCore, and also pull the browser control size info out of ResizeParams since they don't have to be in frame-by-frame struct. Bug: 622847 Change-Id: I8b7aa8ba0207b405b83a9c787ec2d8684f2b01fe Reviewed-on: https://chromium-review.googlesource.com/752963 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#518571}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. TBR=jam@chromium.org Bug: 289619 Change-Id: Ie227e64bffecdaf115c5d2aba625d929e7550994 Reviewed-on: https://chromium-review.googlesource.com/781159 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#518570}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/cce013c9b614..acf2f3adbac0 $ git log cce013c9b..acf2f3adb --date=short --no-merges --format='%ad %ae %s' 2017-11-21 jmadill Apply Chromium style fixes. 2017-11-21 jmadill Fix ComputeGenericHash. 2017-11-06 jiawei.shao ES31: Implement creation and attaching geometry shader on OpenGL 2017-11-21 jmadill Reland "Update cq.cfg for new compile-only builders." Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: If8d0894405360d56818ad5145eaedbd126b2e7ef Reviewed-on: https://chromium-review.googlesource.com/784772Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518569}
-
Xiaohan Wang authored
Currently we use StrongBindingSet for mojo interface implementations that needs access to MojoCdmServiceContext. Hence the lifetime of those objects are determined and we should be able to use raw pointers instead of weak pointers. In MojoCdmService, MojoAudioDecoderService and MojoVideoDecoderService we assume the MojoCdmServiceContext always exists. In MojoRendererService, where it is currently also used outside of MediaService (see RenderFrameHostImpl), it's possible that MojoCdmServiceContext can be null, and we have explicit check on that. BUG=786736 TEST=Existing tests pass. Change-Id: Idd7e0a1bb24d109c7a17607e3fd856506432e9ee Reviewed-on: https://chromium-review.googlesource.com/780046Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#518568}
-
Rakina Zata Amni authored
window.event should be undefined if an Event's target is in a shadow tree, because it is leaking information from inside the shadow tree. But we don't know how frequently window.event is used for V0 Shadow DOM. This change adds a use counter for window.event calls where the event's target is in a V0 shadow tree, so that we will know when usage is low and it's safe to remove window.event for V0 Shadow DOM. Support for window.event for V1 Shadow DOM is removed in crrev.com/c/773922 Discussion link: https://github.com/whatwg/dom/issues/334 Bug: 779461 Change-Id: Iadc734ebaeb90f44f832bcbe30f0ac9d0be1cff1 Reviewed-on: https://chromium-review.googlesource.com/780722Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
