- 29 Jan, 2020 40 commits
-
-
Vadym Doroshenko authored
Local NOT_USERNAME prediction is based on a weak signal - that the user ignored the save prompt. So it makes sense to ignore if the server has data. Bug: 959776 Change-Id: If2f186ee47e59b8eef4271c980b6837ffeea6da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023836 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736341}
-
Mikel Astiz authored
Permanent folders (as determined by SyncerProtoUtil::ShouldMaintainPosition() and tombstones do not require position information. Hence, the function can return early. This avoids DLOG(ERROR) spam for missing originator fields, and should otherwise influence no logic. Change-Id: I0c60facfe469fb5412eb044d87c2cd251d185c8d Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027327 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736340}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cabeec8b..a086532c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I08859072901a0e2fd479c1ad4d985137a0ab97ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027587Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736339}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6ff59124ce8..7867592b4950 git log b6ff59124ce8..7867592b4950 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 szuend@chromium.org Introduce more accurate breakpoint decoration waiter for web tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@7867592b4950 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I44f639f621c7e8db91689069bc864e2582d0858f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736338}
-
vitaliii authored
TBR=rakina@chromium.org Bug:1046440 No-Try: true Change-Id: Ibd8c38ab4521f3efb3bda8ac5901a1295de0da6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027470Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736337}
-
Gauthier Ambard authored
This also changes the fieldtrial config to continue testing the disabled configuration. Launch bug 1018740 Change-Id: Ia6c878045d76f4a44738dda1e5a28419bd06e494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019445Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736336}
-
Gauthier Ambard authored
This CL makes sure that the WebContent is taken into account when requesting a page. This allows the WKWebView to know how to react to the JavaScript event. In particular, this changes the navigator.platform property. It adds the corresponding tests. It also adds a new utility to find a string through all the frames of a WebState. Bug: 1031124 Change-Id: I2a794ca2bd8c7878d0676a2a9ec5d4269d68cb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951010 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5d3173be305d..71a77c4b3b31 git log 5d3173be305d..71a77c4b3b31 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 srte@webrtc.org Adds trial to use correct overhead calculation in pacer. 2020-01-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa85f826..dd5a54c2 (736081:736224) Created with: gclient setdep -r src/third_party/webrtc@71a77c4b3b31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I955b906783256d7aafaab16cc457a403c199dbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027569Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f16d6218d1d..c57d8970ed0e Created with: gclient setdep -r src-internal@c57d8970ed0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040143,chromium:596488 Tbr: jbudorick@google.com Change-Id: I8c2c4b7f33129fd5a04d75d2a0001449c1cd6ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027568Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736333}
-
Wez authored
These tests were mistakenly disabled only on Linux, but are actually flaky on Windows, Fuchsia and Linux/TSAN bots. TBR=ccameron Bug: 1044841 Change-Id: I4b9119199860c564a495a8465f7d519e1ba821f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027455Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736332}
-
sreejakshetty@chromium.org authored
Record the number of reloads after a history navigation and number of history navigations for all sites in the scope of the back-forward cache experiment. Add kRecordBackForwardCacheMetricsWithoutEnabling to control the allowed urls when the back-forward cache feature is disabled. Bug: 1035392 Change-Id: I4d4e9496f3142a4b7c1286e877551f1ed631e218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973817 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736331}
-
Jan Scheffler authored
This cl adds a test to prevent regression on crbug.com/1040080. Bug: chromium:1040080 Change-Id: I3611507c042c296e3923434b6ddc269ab63f98da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992425Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#736330}
-
arthursonzogni authored
This patch serves a dual purpose: 1) Fix use after garbage-collected. ----------------------------------- The conservative GC runs when we are under memory pressure, and a GC cannot wait until we go back to an event loop. In this case, the GC scans the native stack and treats the pointers discovered via the native stacks as part of the root set. (That's why raw pointers are used instead of handles on the native stack.) The patch: https://chromium-review.googlesource.com/c/chromium/src/+/1789389 is using a base::Optional<ContentSecurityPolicy*> on the stack with ContentSecurityPolicy* pointing to a GC object. Because of some compiler optimization, the native stack scanner is not able to find the pointer on the stack. Maybe it is stored in a register? Who knows what the compiler might try ¯\_(ツ)_/¯ This is an issue that should be investigated separately. This is fixed by not using base::Optional. 2) Simplify code, make it understandable. ----------------------------------------- A base::Optional<T*> is nullable twice. Once as an optional, once as a pointer. This is generally a bad practise. It would be better to add several boolean with explicit names explaining what "null" means. The first null meant => "loading_url_as_empty_document" The second null meant => "document_blocked_by_CSP" It turns out it is possible to compute "loading_url_as_empty_document_" later. So we don't really need a base::Optional here. -- Bug: 1044331, 1037776, 1038772 Change-Id: I9b11bc45333a2caa5a341509027c1196b8d2049e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027548 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#736329}
-
Maria Kazinova authored
Primarily to let it keep track of fields that have user input. Done via sharing FieldDataManager between AutoFillAgent and PasswordAutofillAgent. It was done to fix the problem of some user input not being saved when the page was changed at the moment of submission. The saving criteria was changed and interaction with FieldDataManager was added to always check for user typed input instead of less trustworthy criteria (i.e. focusability that can be changed at the moment of submission). Fields that had no user typing are not saved anymore. Some browser tests were amended as well as they were written in a way that didn't imitate user typing and did just a JS injection of the input value, which we don't consider to be user-typed input anymore. Bug: 957444, 1006745 Change-Id: I6052a8e0cd4581fef840adea409dac61547c0f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991623 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#736328}
-
Roman Sorokin authored
Show overlay over the whole screen under the Gaia webview when Gaia shows its own overlay. * Also show overlay for the 3rd-party SAML page. * Hide bottom buttons for the 3rd-party SAML page. * Removed show-buttons-overlay property of the oobe-dialog Also refactored code a bit Bug: 1001281, 1024255, 1033399 Change-Id: Ie1dc2f0f8793a031a6225a81698cdd8401944e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000938 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#736327}
-
Gauthier Ambard authored
This reverts commit e04c9b25. Reason for revert: It was probably failing because of the device being in landscape Original change's description: > [iOS] Disable failing Content Suggestions test > > Disables ContentSuggestionsTestCase/testReloadPage which is failing on > iphone-device. > > TBR=gambard@chromium.org > > Bug: 1046258 > Change-Id: I8688122f2daab124b063059b6187f5fe0a7a6026 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024888 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735815} TBR=gambard@chromium.org,javierrobles@chromium.org Change-Id: I7508c1b2b3d983c426855b194eb075972625f7f7 Bug: 1046258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027412Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736326}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/109232bcf479..b6ff59124ce8 git log 109232bcf479..b6ff59124ce8 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 mathias@chromium.org Ensure pseudo-elements are not exposed through $0 etc. 2020-01-29 leese@chromium.org Load scripts from history only once each 2020-01-29 leese@chromium.org Truncate large wasm disassembly Created with: gclient setdep -r src/third_party/devtools-frontend/src@b6ff59124ce8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003022,chromium:1035843 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06c8c32ad9eae3b907bba35b97986321454859e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027224Reviewed-by:
-
Michael Ershov authored
Request full update of a WiFi service state also on removing it from a profile. Also fix FakeShillServiceClient to completely delete VPN service config when it asked to do so (instead of keeping some settings that makes sense for more persistent/real services like wifi or ethernet). Bug: 1032067 Change-Id: I19d6d2cd0e09c86e61af8a0151017fd93a545395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963860Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#736324}
-
Sylvain Defresne authored
Mark "Stars.*" histogram as obsolete since they are no longer recorded in the code (except "Stars.LaunchLocation" on Android which will be cleaned up in followup CLs). Bug: 928484 Change-Id: Iefb54af2240e1899ee6b00bf658eef1a0de610b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024887 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736323}
-
Johannes Kron authored
Bug: chromium:1029737 Change-Id: Ia2800617dd2e6c2dbbbd3c40203cdb79e9bcaed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025109Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736322}
-
Gauthier Ambard authored
This reverts commit b8760c06. Reason for revert: Hit a DCHECK in -[MainController mainBrowser] when running test (on the second run). Reproduced on iOS 13 iPad running settings_egtest. Original change's description: > Use Browser in CrashRestoreHelper instead of TabModel > > TabModel is provided to the CrashRestoreHelper as a SessionWindowRestore > protocol delegate. and it's used to restore sessions from there. Replace > that with browser and use sessionRestorationBrowserAgent from the > CrashRestoreHelper instead. > Also while at it, i changed the members ivars to use trailing underscore > instead of the leading underscore. > > Bug: 1010164 > Change-Id: I53360ac9a34f7f9e42aacd459e233f40c5def60b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024028 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736047} TBR=marq@chromium.org,mrefaat@chromium.org Change-Id: Ie3c6c3517d502d92da7f7154972501ca95f0a355 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027549Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c768c76138f9..9769628aa1d8 git log c768c76138f9..9769628aa1d8 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 phoglund@google.com Use auto instead of google::protobuf in the histogram C++ API. Created with: gclient setdep -r src/third_party/catapult@9769628aa1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: skyostil@google.com Change-Id: I613e2878a11b2fdf7b64152200d6f231f4378380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027223Reviewed-by:
-
Alexandre Courbot authored
CreateOutputBuffers() was not checking that it was running in the right thread. Fix this. BUG=None TEST=VDAtest passes on Hana. Change-Id: Ia159b48ec9ca0a0f51049ff1753bdd213722ab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026837 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736319}
-
Nico Weber authored
TBR=hans Bug: none Change-Id: Icf7e780f1033e58dab17ae352eb50c9cd47390bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026473Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#736318}
-
Alex Chau authored
Bug: 1044600 Change-Id: I6f52e06d655a77bea816341a507153a8967be8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017519Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#736317}
-
Tobias Sargeant authored
Bug: 1045946 Change-Id: I2fa350e40648ca7851e97f2630d262c7c679f3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027467Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#736316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72e996f23962..4f16d6218d1d Created with: gclient setdep -r src-internal@4f16d6218d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0e690594c9261cf7a5b98993ad4940a4600ea3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027222Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ca050d1fdbb..13c44dfeb014 git log 5ca050d1fdbb..13c44dfeb014 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 07a55839eed5..9a80305c0897 (1 commits) 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src e39b5cf6a1b6..ebe1b7497acb (1 commits) 2020-01-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 34e16df059f8..6c3dc3581eaf (2 commits) Created with: gclient setdep -r src/third_party/angle@13c44dfeb014 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I9714105c362dd7253af3603dc8e66211ffd71366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027220Reviewed-by:
-
Alex Clarke authored
The corresponding WebLayer changes are in a follow on CL. The TBR is for the new DEP file which needs content/public/browser. TBR=jam@chromium.org Bug: 1025781 Change-Id: Ie895ba7246761416d52c98ae3d4b241fed62fa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926505 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
arthursonzogni authored
This correspond to step 1.a from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao This merges: - content::CSPSource (removed) - network::mojom::CSPSource (kept) Only the mojo one remains: network::mojom::CSPSource. Future follow-up will apply do the same CSPSourceList, CSPDirective and ContentSecurityPolicy. The goal at the end is to have an unique mojo data structure for representing Content-Security-Policy. Bug: 1021462 Change-Id: I55618bcabed9cd4097f3c9f0dad7a2533084771f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019448 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Wez authored
This reverts commit a597a94d. Reason for revert: Remove unused keymapping argument. Original change's description: > Pumping keymap file > > TBR=agrieve@chromium.org > > Bug: 920824 > Change-Id: I670a64ae13a0d2d5fdbce35c8db037b47e5f7e30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518146 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Commit-Queue: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640134} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920824, 1045960 Change-Id: I9252ba72f8ec1a3456d645b2ba81c03e9f292f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022652Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736311}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=djean@chromium.org Bug: 1042208 Change-Id: Iac7159dd676e9a94a9a671b4f3370c012f8acb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017369 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736310}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py eaabaf7e04fe98990a8177a3e053346395efde1c`. This increases the clang version from 10 to 11. Bug: 1030664 Change-Id: I4c0b5b3d2d36f785b957b25826530da6cf315adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025708 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
This reverts commit d7a7b9b0. Reason for revert: breaks the build of cronet (ios-simulator-cronet) as this stills targets iOS 32-bit platforms. The bot was not run on this CL due to a misconfiguration (which is addressed with the CL https://crrev.com/c/2026570). Original change's description: > Modernize assumptions in foundation_util > > * Assume building with a macOS SDK newer than 10.8 > * Assume C++11 strong enums > * Assume 64-bit compilation > > Bug: 1044838 > Change-Id: I5a21aa1dbd00c5d6999d67ae80f18979c1c49607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025988 > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736187} TBR=avi@chromium.org,mark@chromium.org Change-Id: If2544084068711aae7241483db52b33fac1e94ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027413Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736308}
-
anina koehler authored
modernize-use-equals-default and modernize-use-nullptr. Bug: none Change-Id: I9a3b10a78948d93af5e5b75562840bd115138f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019266Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/master@{#736307}
-
vitaliii authored
This reverts commit cb98eddd. Reason for revert: crbug.com/1046696 Original change's description: > Add legacy TLS interstitial warning > > This adds a new interstitial page for the legacy TLS warning. It > generally follows the SSL interstitial, but with different strings and > a different icon (the (i) info icon). > > The test interstitial is available at chrome://interstitials/legacy-tls > > Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view > > This also refactors the legacy TLS browsertest classes slightly, basing > them on SSLUITest rather than CertVerifierBrowserTest, brings in the > mock cert verifier explicitly. It also adds a SetPolicy() method to > SSLUITestBase (to complement the EnablePolicy() method, but for policies > that take base::Value types, in this case for the SSLVersionMin policy). > Overall, this makes for a slightly simpler class structure and lets us > reuse all of the infrastructure setup by SSLUITest (since > CertVerifierBrowserTest is fairly simple in comparison). > > The new cert error is introduced in https://crrev.com/c/1894616. Support > for the control site list will be added in https://crrev.com/c/1906779. > > Bug: 896013, 1039756 > Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707 > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736197} TBR=meacer@chromium.org,cthomp@chromium.org Change-Id: I56e27cf5c6cc0aa31144e9e200bcaca6dff9b8be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896013, 1039756, 1046696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027330Reviewed-by:
-
Mohamed Amir Yosef authored
Prior to this patch: Sync was checking for the encryption key name upon receiving remote updates and if it doesn't match the expected one, entities were recommitted for reencryption. Since tombstones aren't encrypted, they didn't have an encryption key name, and hence the corresponding entities were always marked for reencryption. After this patch: encryption key names aren't checked for tombstones. This patch in addition adds a histogram test for an existing test to make sure there is only local deletion sent to the server (the original deletion) Bug: 1046309 Change-Id: I3d3a31ad5919f346b8e46390d3633d079b930de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027407 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736305}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ie8c3930498ffd03442ec828ffb34c218f31d87bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026338Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#736304}
-
Torne (Richard Coles) authored
Without explicitly specifying minSdkVersion in these manifests, the manifest merging process merges in permission/feature requirements that are automatically derived from the implied minSdkVersion of 1 (e.g. it adds the requirement for READ_EXTERNAL_STORAGE). Fixed: 1046380 Change-Id: Ia450e4337afdb03c6cb04567db89766c1b1ecaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024179 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
vitaliii authored
This reverts commit 0f668c37. Reason for revert: Fails Linux MSan Tests crbug.com/1046693. Original change's description: > Cleanup base::Optional use in Deep Scanning dialog code > > 2 instances of optional can be removed from DeepScanningDialog* code to > make it more readable: > - The access point no longer needs to be optional since all the access > points have been added to Chrome. A default value is still included > in order to simplify tests calling ShowForWebContents. > > - The state variable in DeepScanningDialogViews is better as an enum > than an optional bool indicanting pending/success/failure, especially > since a timeout state is very likely in the future. > > Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735857} TBR=drubery@chromium.org,domfc@chromium.org Change-Id: Id4814d523935f867ab8fb69942281a6fc8fcf3b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026970Reviewed-by:
-
