- 22 Oct, 2018 40 commits
-
-
Christian Biesinger authored
This reverts commit a7afe430. Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi# Original change's description: > Perfetto: Optimization to avoid string table lookup for _END events > > If we're emitting an _END trace event, we know that the string > table entries for the name and the categories have already been > emitted and so we don't need to check the string table in this > case. > > R=primiano@chromium.org,skyostil@chromium.org > > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f > Reviewed-on: https://chromium-review.googlesource.com/c/1258043 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600183} TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520 Reviewed-on: https://chromium-review.googlesource.com/c/1293612Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601586}
-
Anna Malova authored
Init is potentially heavy call which is run on the UI thread during dynamic module loading. Add UMA to measure its execution time. Change-Id: I09d98f8efcc7183d04846dc694516e2eeb35154f Reviewed-on: https://chromium-review.googlesource.com/c/1291310 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601585}
-
Anna Malova authored
Remove the WeakReference in the LoadModuleCallback. Add check to not create the second loading task if dynamic module if it is currently loading. Bug: 853793 Change-Id: Ie02a7dd63e3f9e8a21e48d18affb3c25d90ab0ed Reviewed-on: https://chromium-review.googlesource.com/c/1286661Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#601584}
-
Nico Weber authored
Bug: 897742 Change-Id: Id980269ea623f9800b62aead3896d107690a64eb Reviewed-on: https://chromium-review.googlesource.com/c/1293559Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7090b273..e696a0e1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie661f39815765357d3aa2e86f8dee2982a1ff645 Reviewed-on: https://chromium-review.googlesource.com/c/1292804Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601582}
-
Matt Falkenhagen authored
Re-enabling with looser expectations so there is still test coverage of this case. The failure was that the preload request came after the fallback request. The order actually might not be guaranteed if they are on different loading pipelines/http connections? Anyway, the important thing is that the page loads and it's not worth investigating more as network fallback from navigation preload is an anti-pattern. Bug: 896230 Change-Id: Idadfc573fbbeb2c0703c3a3ffa1efef14b991614 Reviewed-on: https://chromium-review.googlesource.com/c/1290573Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601581}
-
Yi Gu authored
This reverts commit 3b62417e. Reason for revert: Suspecting this patch caused gclient runhooks failing on ios simulator. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/58250 Original change's description: > [iOS] Updating enable/disable items in the Google Services settings > > "Google activity controls", "Encryption", and "Manage synced data..." > is enabled when the user is authenticated and disabled otherwise. > > Screenshot shared with Chromium accounts: > + Signed out: > https://drive.google.com/open?id=19lXF2SdgpLdHUlTZ4WpxipDBdQNCshbU > + Signed in with consent accepted: > https://drive.google.com/open?id=1SV3HhbG3hAbre5mSe06Dhjda4dJC4cck > + Signed in with consent not accepted: > https://drive.google.com/open?id=1r5umMw6vf8yzh8X7V8V6LzRJVJLq8Rxs > > Bug: 883101 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: I3e2180c83f42adccb2717f2fdb96efa254751bbc > Reviewed-on: https://chromium-review.googlesource.com/c/1290937 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601537} TBR=jlebel@chromium.org,sczs@chromium.org Change-Id: Iac738ad46478cda09124b37b22b8936a8f8d7e20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883101 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1293758Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28c3dd83af31..d8fd32bf4423 Created with: gclient setdep -r src-internal@d8fd32bf4423 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd4b8043eddd9a119df277b20922fbce4c8c0f1c Reviewed-on: https://chromium-review.googlesource.com/c/1293669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601579}
-
Vaclav Brozek authored
Initially, the bug tracked properly separating sync-specific code from the password_manager core. Later, this decision was reversed (details on the bug), and the sync layer was dissolved. The one forgotten TODO comment is obsolete by now, so this CL removes it. Bug: 515108 Change-Id: Iad3d97b4e63a32512075d70452a756333c871eec Reviewed-on: https://chromium-review.googlesource.com/c/1292056 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601578}
-
Mohamed Amir Yosef authored
BookmarkModelTypeProcessor::GetStatusCountersForDebugging() falsely assumed the initial sync is done by the time this method is called which isn't necessarily the case. The bookmark_tracker_ is only instantiated after initial sync is done. This caused reported crashes. This CL address this properly by not emitting counters in that case, but run the callback directly. Bug: 516866 Change-Id: I2a6d605154694d8ab0ddb2a1e7d1ea4c31ddb620 Reviewed-on: https://chromium-review.googlesource.com/c/1291410 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601577}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c98849cf92c3..ff292f30d9a4 git log c98849cf92c3..ff292f30d9a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 magjed@webrtc.org Remove deprecated barcode scanning functionality 2018-10-22 jonasolsson@webrtc.org Compute RTCConnectionState and RTCIceConnectionState. 2018-10-22 srte@webrtc.org Adds support to change transport routes in Scenario tests. 2018-10-22 srte@webrtc.org Adds field trial to do safer reset on route change. Created with: gclient setdep -r src/third_party/webrtc@ff292f30d9a4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a41229a354b1a7e1d0371a93b1c1fa52cf71e3a Reviewed-on: https://chromium-review.googlesource.com/c/1292262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601576}
-
Bryan McQuade authored
The existing implementation for UKM.Sources.SerializedCount ends up counting some sources that don't get serialized. This change fixes that, versions the histogram to reflect the change, and adds SourceIdType-specific breakouts for this histogram. The SourceIdType-specific breakouts are useful because navigation id sources are a more stable representation of the number of distinct navigations being tracked by UKM. Change-Id: I958bc36f6a37a2e7f2e02b6ba05dee939b711298 Reviewed-on: https://chromium-review.googlesource.com/c/1291594Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#601575}
-
Juan Antonio Navarro Perez authored
Disable some stories currently flaking on internal perf bots. TBR=nednguyen@google.com NOTRY=true Bug: 892704 Change-Id: I9d9ddf82c0818598c5c0b655f1813ad341feea49 Reviewed-on: https://chromium-review.googlesource.com/c/1293578Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#601574}
-
Justin Donnelly authored
I'm the only person who currently uses this list and I've been ignoring CLs in these directories unless they touch any of the other omnibox directories. Change-Id: Id85e3e5fa525a151823a353666dbe2571c4a6835 Reviewed-on: https://chromium-review.googlesource.com/c/1293169Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#601573}
-
Michael van Ouwerkerk authored
Bug: 872711 Change-Id: Iec7589f94a4162befce59e2622fba8307fcf12c5 Reviewed-on: https://chromium-review.googlesource.com/c/1291392Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601572}
-
Charlie Harrison authored
This CL adds new breakouts to the existing ContentSettings.Exceptions histograms, for cookies, popups, and subresource-filter settings. Bug: None Change-Id: I2967cd82ba9dd23b73a466f40b980f303ed48373 Reviewed-on: https://chromium-review.googlesource.com/c/1277548Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#601571}
-
Nicolas Ouellet-Payeur authored
This enables the build on Mac OS X, and refactors AlternativeBrowserDriver to work correctly on Mac OS. Bug: 881589 Change-Id: I6e73d33d83af5bc1c0d8bb3ec3e76fcf8409ee2e Reviewed-on: https://chromium-review.googlesource.com/c/1283835Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#601570}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6e85d1a6fc75..20bbfb6f4da6 git log 6e85d1a6fc75..20bbfb6f4da6 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 33432579+alan-baker@users.noreply.github.com Layout checks should recurse through runtime arrays (#1999) 2018-10-22 33432579+alan-baker@users.noreply.github.com Better checking of the index operand (#1992) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@20bbfb6f4da6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8c5827547dc76f931152dce4738dbd85ea39e0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1292259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601569}
-
Stepan Khapugin authored
Creates a collection view, cells, and plumbing for most visited sites in zero-state of omnibox. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifcc5af9806178fc6a53af64587086a504f957aca Reviewed-on: https://chromium-review.googlesource.com/c/1286418 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601568}
-
Yi Gu authored
The newly added test LoggingTest.LogMessageMarkersOnStack caused consistent crash on Win10 Test. Disable it ATM and TBR the owner. TBR=wez@chromium.org NOTRY=true Bug: 897735 Change-Id: Ic775ac5a5cccbe6c5064407ac17534018561468b Reviewed-on: https://chromium-review.googlesource.com/c/1293670Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601567}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a20a50c6f2c7..fa20b7a3bd3c git log a20a50c6f2c7..fa20b7a3bd3c --date=short --no-merges --format='%ad %ae %s' 2018-10-22 fmayer@google.com Merge "profiling: Add tool to verify sampling strategies." 2018-10-22 primiano@google.com Merge "Docs: Fix links" 2018-10-22 primiano@google.com Infra: update perfetto site to mirror github pages Created with: gclient setdep -r src/third_party/perfetto@fa20b7a3bd3c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifbb79f2bd812ae9d9ae76bc18e2abe989a76984f Reviewed-on: https://chromium-review.googlesource.com/c/1292260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601566}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/1293550 fixed an initializer regression. TBR=dpranke Bug: 94925 Change-Id: I5cab9614798588424a97c1fc3635d1d2e0ea398c Reviewed-on: https://chromium-review.googlesource.com/c/1293556Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601565}
-
Victor Costan authored
Change-Id: Ie63379b3002521a1badac056809edbf8b8d40b71 Reviewed-on: https://chromium-review.googlesource.com/c/1292956 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601564}
-
Emily Hanley authored
Regex was fixed in crrev.com/c/1281482 TBR=nednguyen@google.com NOTRY=true Bug: 828917,874803 Change-Id: Ib2ce0867b8096c209bb15e65c8d3623c13f6247c Reviewed-on: https://chromium-review.googlesource.com/c/1292805Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#601563}
-
agrieve authored
And also freshen up the doc in general. Change-Id: Icb783a45d2f418db9147042f6af1977af6eeba29 Reviewed-on: https://chromium-review.googlesource.com/c/1288954 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601562}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc3195e2. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26540 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I005ca69eb700a662043a0d47258fc8232be80932 Reviewed-on: https://chromium-review.googlesource.com/c/1292254 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601561}
-
Yi Gu authored
Test failures were introduced by a WPT patch https://chromium-review.googlesource.com/c/chromium/src/+/1293038 TBR=robertma@chromium.org NOTRY=true Bug: 897719 Change-Id: I10f67a682e8747e745bf12c180356f5ec1674b01 Reviewed-on: https://chromium-review.googlesource.com/c/1292803Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5762a656ef75..28c3dd83af31 Created with: gclient setdep -r src-internal@28c3dd83af31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib3b0e1791025b40de8d111495d690c388cb8569b Reviewed-on: https://chromium-review.googlesource.com/c/1292258Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601559}
-
Peter E Conn authored
The transformation from Origin to Domain and Registry requires native. If we do this while storing the data in the ClientAppDataRegister when native will be loaded (native is required for Trusted Web Activities) we don't need native loaded when reading from the registry. Bug: 888447 Change-Id: Ibbf94ccbf4dad253752648a45e4c0550edc25dd6 Reviewed-on: https://chromium-review.googlesource.com/c/1292568Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601558}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78128866..7090b273 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ca907145831bc5ebe4d0fb4d132cfc7b4e28157 Reviewed-on: https://chromium-review.googlesource.com/c/1292255Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601557}
-
Michael van Ouwerkerk authored
Bug: 897709 TBR: alexmos Change-Id: I9e9a8c1b164b444f839053daa62114d9dbd2504e Reviewed-on: https://chromium-review.googlesource.com/c/1293589Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601556}
-
Lukasz Suder authored
The default error message is displayed, when there is communication problem. Bug: 806868 Change-Id: Ic08594ce1b15535858b05d81406a5edac51150b5 Reviewed-on: https://chromium-review.googlesource.com/c/1256743 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#601555}
-
Michael Lippautz authored
The test checks that the JS wrapper gets collected while the C++ wrappable stays alive. This only worked by accident as wrapper tracing does not see any stack pointers. Adjust test to check that the JS wrapper gets collected as soon as the C++ wrappable is cleared. Bug: 843903 Change-Id: I2041f682f4a94d690f43292f70ea3e8d7fb3fd6b Reviewed-on: https://chromium-review.googlesource.com/c/1293450Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601554}
-
Nico Weber authored
Looks like something removed an initializer. TBR=dpranke Bug: 94925 Change-Id: I6c8d941374b9d4993f6d2eecd4ecc0dcf5105d61 Reviewed-on: https://chromium-review.googlesource.com/c/1293549 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601553}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9acf1c1f5497..c98849cf92c3 git log 9acf1c1f5497..c98849cf92c3 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 devicentepena@webrtc.org AEC3: changes the signal used for deciding when to update the erle so the reverb render signal is now used 2018-10-22 srte@webrtc.org Routing unacknowledged data in TransportFeedbackAdapter. 2018-10-22 kwiberg@webrtc.org Audio codecs API: Remove some weasel words in the docs 2018-10-22 nisse@webrtc.org Delete dead code in webrtc_libyuv.cc Created with: gclient setdep -r src/third_party/webrtc@c98849cf92c3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I12ca21c2e17dbc6ccd1cbfb92eb4bd291cf654fa Reviewed-on: https://chromium-review.googlesource.com/c/1293469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601552}
-
Takuto Ikuta authored
This is follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1286748 Change-Id: Ie1187e045df9e6e943ba957bcd6f8ba7ade0ba07 Reviewed-on: https://chromium-review.googlesource.com/c/1293053 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601551}
-
Daniel Bratell authored
pepper/fullscreen_container.h sometimes appeared twice in the sources list. This confused some other tools so it seems like a good idea to only have it there once. Change-Id: I02d88c68c6581eadb171ca5a5d72f75281c52717 Reviewed-on: https://chromium-review.googlesource.com/c/1293455Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b4db19b7ab88..a20a50c6f2c7 git log b4db19b7ab88..a20a50c6f2c7 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 treehugger-gerrit@google.com Merge "Add d8 binaries" Created with: gclient setdep -r src/third_party/perfetto@a20a50c6f2c7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e8ac329b5248cf8facde6e8dc8e144930dc48f4 Reviewed-on: https://chromium-review.googlesource.com/c/1293470Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601549}
-
Nico Weber authored
Looks like this snuck in while the static initialization scripts got moved around and we didn't notice the regression. Bug: 94925 Change-Id: I35b597cc4cd6b4607306ab242f8594f3eba3d0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1293550Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601548}
-
Christian Biesinger authored
The functions are all trivial R=mstensho@chromium.org Change-Id: Ica0db0344ff13d03a363d7f58e19389fa1ea08d5 Reviewed-on: https://chromium-review.googlesource.com/c/1292888 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601547}
-