GitLab

Was originally a bunch of per-file but I've written half the folder at
this point, so...

Change-Id: I0b2c5e4315a93133ca4294d831503ab1a1bb3e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815666Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698557}

This CL was partially generated by
//base/android/jni_generator/jni_refactorer.py.

Two classes converted in this CL:
  * UrlUtilities.java
  * DevUiModuleProvider.java

The tests were manually refactored to not use robolectric shadows
for UrlUtilities native methods.

Bug: 929661
Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698556}

 * Get rid of MixerServiceConnectionFactory
 * Factor out code common to all (future) types of connections into
   MixerConnection, and rename MixerServiceConnection to OutputStreamConnection
   (which is based on MixerConnection).
 * Move common message-handling code out of OutputStreamConnection into
   MixerSocket.
 * Move type conversion code into a common file.

Bug: internal b/127963522
Test: on device
Merge-With: eureka-internal/313198
Change-Id: I7fa02b1d077a4eb7347728b4673cdea83e4597fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804681
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698555}

This change adds a hard timeout to the class that performs the update
check. This is done to keep the logic running in case update engine dies
or is stuck waiting for network or any other event.

BUG=924762
TEST=Unit tests.

Change-Id: I673dee89fbfef46568741fe82bda76ed9e1c1543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759518Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698554}

This CL:
* Makes |type| a required member of ConfigProperties and fixes the
  existing calls to SetProperties.
* Fixes SetProperties to support setting of EAP properties. Includes
  calling CreateConfiguration instead of SetProperties when necessary.
  This will fix issue 983890.
* Introduces ConfigureNetwork to cros_network_config.mojom using the
  same ConfigProperties dictionary as SetProperties.

Migrating the network configuration WebUI to use ConfigureNetwork will
be done in a follow-up.

For chromeos/user_manager deps addition (indirect dependencies exist):
TBR=xiyuan@chromium.org

Bug: 1001598, 983890
Change-Id: Ib02f6a40dd01ae90db57574d7bbf83e21666541f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808085Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698553}

Now that BlinkGenPropertyTrees has launched, there is no need to track
is_root_for_isolated_group on cc::Layer as it is now tracked using
render surface reasons.

Bug: 993936
Change-Id: Ifa5b0b497392d8cb4020826139a6270c2faaf20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815610
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698552}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: I6f7f0c0de66cb32990d0e3b4e985142d65a5cc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808070
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#698551}

UserCloudPolicyManagerTest uses a lot of login functionality that's
centralized within LoggedInUserMixin. Avoid code duplication by
refactoring UserCloudPolicyManagerTest to use LoggedInUserMixin for
logging in.

Bug: 990909
Change-Id: I929c7182e8fc178191b8cc722ea6bbd6987b3411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796562Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698550}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: Ia350e71825604e5554f74e38f1223e49db2082b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808100
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698549}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5271b8e5167..a4592ef724c8


Created with:
  gclient setdep -r src-internal@a4592ef724c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I116895024f18306d96dc3b82fdd39f7eb9531d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816861Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698548}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: I1d633f24dbc8d146cdcb0991bc15d6fc0dd472da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808073
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698547}

TraceEventHandles (on the stack) contain an ID we use to validate
that the handle is referring to an event in the event stack of the
current ThreadLocalEventSink in TLS. This was previously set by
session_id_ which is increment each time tracing is started but
there are potential race conditions where two sinks are created
with the same session_id_ which causes crashes. Changing this to
be its own explicit id for each created sink.

R=ssid@chromium.org

Bug: 983307
Change-Id: Ibd08c8203f31b394bc6c3d2cb0a5346501d2b049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814669Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698546}

Bug: 1003813
Change-Id: I250c4becaec287ba3e317d69e5afb61e754832a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807701
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698545}

This field isn't used outside of tests and a debug line in an
unmaintained example QUIC proxy.

Bug: 89321, 934009
Change-Id: I579df4e9c7ec5f90d9b3878be6e0828047714819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814663
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698544}

Bug: 82078
Change-Id: Id055fb1600ada645c1782cddd48348e687aa9245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815573
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698543}

See https://docs.google.com/document/d/1tfRRv-kaGUiburkhRp1xCKnM8t6jqauacp8YIqMiZmk/preview for context.

Bug: 977050
Change-Id: I8b3ba1653908e10d1ee2c8698b35d16f4729d6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808196
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698542}

It used to have its special logic. But now it doesn't. Remove it.

Bug: None
Change-Id: I3bd3a35bd1da5fc7b30035dc821a7cb9338b36d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816246Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698541}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: If87e32552f4ffb9fbfb9eb5b4fec918a4d4e694b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808302Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698540}

Rename to AssistantStateClient, and move to c/b/ui/ash/assistant.

Remove obsolete logics and update the unit test.

Bug: b/138679823
Test: Run AssistantStateClientTest.* in unit_tests
Change-Id: I6da13ec34fa8a7e2741f659662456ed145197cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802634
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698539}

TBR=benwells@chromium.org (Mechanical changes)
TBR=estade@chromium.org (Mechanical changes)
TBR=rdevlin.cronin@chromium.org (Mechanical changes)
TBR=sky@chromium.org (Mechanical changes)
TBR=stevenjb@chromium.org (Mechanical changes)

Bug: 489687
Change-Id: I74db7b3463706dda1a61c060bcc5243f8c8dc56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784939
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698538}

Fix for AXPlatformNodeWin::get_IsSelected (ISelectionItemProvider::
get_IsSelected) to return false by default if the node supports
ISelectionItemProvider. Previously, we threw UIA_E_INVALIDOPERATION
for node that supports ISelectionItemProvider but not explicitly
marked as selected.

The motivation behind this change is due to Windows Narrator announcing
"No Item in View" for list items because their ISelectionItemProvider::
get_IsSelected by default returns UIA_E_INVALIDOPERATION and confuses
Narrator.

Bug: 844149
Change-Id: Iafc1c083dd0feb98b8d1a2d3b18c38284105e2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810060
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698537}

Before this change, autofill had its own logic for determining a page
was secure. This CL changes the behavior to match the security state
shown in the omnibox.

Bug: 701018
Change-Id: Idd38fc77f93155412961c29a85f237c42ad21563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808226
Commit-Queue: Aidan Beggs <beggs@google.com>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698536}

Wait to call InstanceIDDriver::GetInstanceID() until necessary. This is
a fix that allows enough time for the CryptAuthGCMManager to add itself
as an app handler for the app ID "com.google.chrome.cryptauth". If
GetInstanceID() is called before this happens, Instance ID data will not
be successfully retrieved from persisted storage and the data risks
being overwritten due to https://crbug.com/1006276.

In future work, we plan to delegate Instance ID tasks to the
CryptAuthGCMManager, but this quick fix works for now.

Bug: 1006280, 899080, 951969
Change-Id: I2ea092d97f2afc1bb995b1582cdc66366f530337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814660
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698535}

Bug: 895821
Change-Id: I9163dfa15df2a91ec9cc1b7882b387f6ac9bd79f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710756Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Sam Burnett <sburnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698534}

If the print scaling option is set to
PP_PRINTSCALINGOPTION_FIT_TO_PAPER, scale the contents to fit the
paper, regardless of the printable area of the paper for the specified
printer.

Bug: 989978
Change-Id: I033f70f60b3e2d05371785291016b21fe428d4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810078
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698533}

Add a basic test for the devtools console working correctly with
portals. For this test to work correctly, I also had to fix an issue
where the document's load event was being sent before the portal's
load event.

Bug: 929356
Change-Id: I61c26edc4078553cfce73e3095b78f3cb25f42fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800479
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698532}

When a renderer has an unload handler (which can be caused by opening
devtools apparently), the browser sends a ClosePage IPC to the renderer
when it requests to be closed, and waits for ClosePage_ACK before
sending the WidgetMsg_Close IPC and closing the tab.

When sending the ClosePage_ACK was moved to RenderViewImpl, the Send()
method was changed when to stop sending IPCs. In RenderWidget it
checked RenderWidget::closing_. But in RenderViewImpl it checks
RenderWidget::is_closing(). These look the same but they were
different, causing the ClosePage_ACK to never be sent. This CL
rectifies the situation by making is_closing() simply return closing_,
which restores the previous behaviour and allows browser-renderer
interactions between the close request and the actual close action.

The is_closing() included the host_will_close_this_ variable, which
exists for a rather convoluted reason. When WebPagePopupImpl requests
to be closed through the RenderWidget, it immediately destroys its Page
object, and its main frame. That means the RenderWidget's WebWidget
(which is the WebPagePopupImpl) becomes crashy and invalid after
requesting to close. All the methods in the WebWidget API early out
when page_ is null to handle this scenario. Except one, the
GetURLForDebugTrace() method, which is called when making a
LayerTreeFrameSink.

To solve this problem in the past, rather than making this method early
out (or whatever other method it was at that time), we made
RenderWidget avoid making a LayerTreeFrameSink once a close has been
requested, to indirectly avoid using the WebWidget.

Now that we understand this area of code more fully, we can solve this
at the site of the problem in WebPagePopupImpl, and early out in
GetURLForDebugTrace() like we do in other WebWidget methods. That means
we don't need host_will_close_this_.

The mistake here was leaking the host_will_close_this_ state out of
RenderWidget and using it for more than it was intended. But since we
don't need the variable at all in its more narrow scope we remove it.

R=avi@chromium.org

Bug: 995123
Change-Id: Iaad83c7e3892908150672d9860a6db4307ffe432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814689Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698531}

Currently we do not show the VPN feature pod unless a VPN is connected.
This fixes that by requesting the list of configured VPNs and showing
the button if any exist.

Bug: 982222
Change-Id: I939f2eb9ee74771c47468aad7256b5884640cc5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815222
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698530}

Add tests for the Hotseat logic added in an earlier CL.

Bug: 1002132
Change-Id: I13e78651c86c2d3f305a46a7e3396d0aac7ea2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812457Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698529}

An array reference allows the creation of a function that will accept
arrays of the desired size. This allows a static_assert with teeth, and
the removal of a magic number. No behavior or correctness change happens
but this makes the code correct by construction.

Change-Id: I6146cb74da391d7970950f705be0a4c82b7d61e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815258
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698528}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/32d64a5d..2425b4f2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I06e8ad1c17fee28812ea26379963f1698549a8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816781Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698527}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b6fa949c4539..44f462b00178

git log b6fa949c4539..44f462b00178 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 sugoi@google.com Fix support for OpKill as non-terminator

Created with:
  gclient setdep -r src/third_party/swiftshader@44f462b00178

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: Ib9a05b47d749c7341c764891eca75ef9dc20cec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816858Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698526}

https://webrtc.googlesource.com/src.git/+log/04fd21513bfa..ef83cc5458bf

git log 04fd21513bfa..ef83cc5458bf --date=short --no-merges --format='%ad %ae %s'
2019-09-20 danilchap@webrtc.org Add fuzzer testing for Dependency Descriptor rtp header extension

Created with:
  gclient setdep -r src/third_party/webrtc@ef83cc5458bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I94062723e221c2591a9df4ed7d3e5a62a5fb87aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816860Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698525}

Change-Id: Ifda5eb576f1b8e7d8b635b319a1d02a661744e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815588Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698524}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: If1168a9566a042902410d902057a09faafc1bc8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808310
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698523}

Change-Id: Iba19664d4e350826ce89b89788bc2e68a5ed1c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815885Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698522}

Changes use of PrintResult to PerfResultReporter in viz_perftests and
whitelists the tests for conversion to histograms before uploading to
the perf dashboard.

Bug: 923564
Change-Id: I078c3094ca44c41b7a33c205a22b8017c3068975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815341Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698521}

A new android bot has been added.
This add the failing tests to the filters.

TBR=lowell@chromium.org

Bug: None.
Change-Id: I4dd4511e8b14cca6d5ae113801bc6f3319769fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816553Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698520}

Remove unused context parameter in HelpAndFeedback's getInstance method.

Also fix presubmit errors in affected files.

Change-Id: I74d7f3bccedbf29f516554ffc53b20374edd6565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814394Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698519}

Simply removing these tests since this implementation was never
launched.

Bug: 1005295
Change-Id: Ia2799658867ad5a0be45f238f0def5b95800ef32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815883Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698518}