- 22 Aug, 2019 40 commits
-
-
Tiansong Cui authored
Bug: internal b/135576340 Test: Build and run Change-Id: Iae347132d9302488a832902f38b6be8a4168783e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762286Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#689669}
-
John Lee authored
This CL adds the target context to the event's will_dispatch_callback method so that the TabEventRouter can decide what level of scrubbing is needed for the Tab data it dispatches. In a target context of WebUI, no scrubbing is needed. Actual usage of the context param will come in a follow-up CL. Bug: 994337 Change-Id: I55d7ff66b1353cb6df34931f209f3e68a339cace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763090 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689668}
-
Kush Sinha authored
Chrome OS Printing dialog allows users to add additional accounts for finding more printers. When Chrome OS Account Manager is available on Chrome OS, we will need to display native account management UIs, instead of Gaia webpages. Bug: 982641 Change-Id: I42238967d3e0ee2bbee499797b69bcc42b01d6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763413Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#689667}
-
Mike Wittman authored
This reverts commit 1863eb4a. Reason for revert: breaks win32-archive-rel build: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/4104 Original change's description: > Enable building OpenXR by default in Windows. > > Bug: 989254 > Change-Id: I8f2ad0214cc17c324774e08ee34baba87dae7f42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745502 > Commit-Queue: Patrick To <patrto@microsoft.com> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689609} TBR=ddorwin@chromium.org,rafael.cintron@microsoft.com,patrto@microsoft.com,alcooper@chromium.org Change-Id: I897e1e6ada7e3c35fcc0377fc428a717c6db7aae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766453Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689666}
-
Gabriel Charette authored
This is a reland of d7b74986 As usual, if this fails **please** paste the build failure, not just silent revert, logs can be hard to find in retrospect. Reason for reland: - joenotcharles@ fixed the windows build in https://chromium-review.googlesource.com/c/chromium/src/+/1764471 - google chromeos build failure fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1764256 Original change's description: > Reland "Reland [base] Require task posters to specify an explicit destination" > > This is a reland of dd34a877 > > Rebased on a few more fixes including a local full build of: > - Windows + is_chrome_branded > - ChromeOS + is_chrome_branded > (except for the libassistant portion which is giving weird errors...) > > Original change's description: > > Reland [base] Require task posters to specify an explicit destination > > > > This patch makes it a requirement for all task traits to specify their > > thread affinity. Previously task traits that did not name a specific > > thread would implicitly run on the thread pool, which could be > > surprising. To make this more obvious, thread pool tasks must now use > > the base::ThreadPool() trait. > > > > This is the final reland of > > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > > (will attempt to fix errors that caused original revert before > > relanding). > > > > Bug: 968047 > > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#688782} > > Bug: 968047 > Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689097} Bug: 968047 Change-Id: Ie338781aba9b5f5990ffe74e02bb85f08fe683d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764398 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#689665}
-
Robert Ogden authored
Bug: 996870 Change-Id: If8c35b69d94302fbc45db4e0d43a5aed4c2b1329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766351Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689664}
-
Rakib M. Hasan authored
We should raise exceptions for expectations where the tag condition list mixes mobile and desktop tags. Bug: chromium:973936 Change-Id: I52395ead03afb022063bf565f6c1e742cb5f4086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754982 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#689663}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2891cbc02f12..a52177c11e72 git log 2891cbc02f12..a52177c11e72 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 primiano@google.com Merge "Client API: allow to configure SMB size and page size" 2019-08-22 primiano@google.com Merge "Fix chromium roll (INSTANTIATE_TEST_CASE_P/SUITE)" 2019-08-22 treehugger-gerrit@google.com Merge "Temporarily disable ConcurrentProfile test." 2019-08-22 nicomazz@google.com Fix perfetto's extension listener registration 2019-08-22 primiano@google.com Merge "Fix signed-unsigned conversions" 2019-08-22 treehugger-gerrit@google.com Merge "Add support for Dvorak keyboard layout" 2019-08-22 treehugger-gerrit@google.com Merge "client api: Introduce a bare-bones TrackEvent library" 2019-08-22 primiano@google.com Merge "Speculative fix for Windows build failure" 2019-08-22 treehugger-gerrit@google.com Merge "Removing useless permissions to the extension" 2019-08-22 oysteine@google.com Merge "Separate out the parts of HeapProfiling that CPUProfiling will reuse into StackProfiling" 2019-08-22 lalitm@google.com Merge "trace_processor: add Table and Column classes" 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add UI control to record GPU sched trace events" 2019-08-21 lalitm@google.com trace_processor: add SparseVector implementation and tests 2019-08-21 lalitm@google.com trace_processor: add RowMap implementation and tests 2019-08-21 lalitm@google.com trace_processor: add bitvector implementation 2019-08-21 treehugger-gerrit@google.com Merge "[GPU TRACE] Add GPU scheduling trace events" 2019-08-21 primiano@google.com Merge "Remove use of -isystem for googletest" Created with: gclient setdep -r src/third_party/perfetto@a52177c11e72 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:139788095,chromium:135177627,chromium:135177627,chromium:135177627 Change-Id: I0c5963ea1b2a6e433ad3a16eab5b76fa4bc870f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689662}
-
Wei Li authored
Update the case of bubble banner's accept button. Also, use the proper test survey's site id as the default value. BUG=996547 Change-Id: Id5e2c0ba2512eda171f82af4d4b7c159b89ac573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766002 Commit-Queue: Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689661}
-
Sharon Yang authored
Migrate base::fuchsia::ServiceDirectory to sys::OutgoingDirectory and sys::ServiceDirectory because functionality in base::fuchsia is now in the sys_cpp package in the Fuchsia SDK. Both the source code and unit tests are updated. Bug: 974072 Change-Id: I505da402f99f8b1beeec3084b8b1c5502b9ac0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758835Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689660}
-
Robbie McElrath authored
Bug: 934152 Test: gn check out/Default //android_webview/renderer Change-Id: I6d192ae647e048e2222d2405b5a7237052212385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764678 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689659}
-
Raphael Kubo da Costa authored
The two changes are independent, but it is easier to land them together. The idea behind them is to make it easier to then land some changes to sensor/ambient-light-sensor.html that will cause it to round the values made available to users of the Ambient Light Sensor API. sensor-helpers.js now has a small RingBuffer class that is used to wrap the readings passed via MockSensor.setSensorReading() so that we iterate over the array of readings (and wrap around) and every time a reading event is fired a potentially different value is emitted. This is useful for ALS because we will no longer be able to use the same value in succession and expect two reading events to be fired (only one will). In order to make it easier to implement those changes in sensor-helpers.js, runGenericSensorTests()'s signature has been simplified and all raw readings and expected values have a standardized format, an array of arrays, where each item corresponds to one reading. This also allows us to stop using Function.prototype.bind() for the reading verification function and be more explicit in telling which expected value we want in a specific reading callback. Bug: 642731, 606766 Change-Id: Ib9103b86116e99eff2f017806393489a8c1e99f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760954 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#689658}
-
chrome://flags/enterpriseYann Dago authored
Even if the chrome://flags page is not localized, the chrome://flags/enterprise page has to be localized. Also, that page should not have dev and beta channel promo messages. Screenshot: http://screen/NRUmyRFCMkG Bug: 982371 Change-Id: I2939d6f38467d60d3dcd2da79b419c24c5692c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721049 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#689657}
-
Chris Hamilton authored
This lifts the base/task/intrusive_heap container to base/containers, and makes it fully STL-like. Change-Id: I511ca1e675d37b46ec4049663c564ce490706e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739411 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#689656}
-
Peter Wen authored
This reverts commit f9be5898. Reason for revert: Crash on startup for bundle targets, see https://crbug.com/996886 Original change's description: > Android: Use new play core API for activity > > Add myself to OWNERS for //third_party/google_android_play_core. > > Built locally @264816199 and uploaded to CIPD. Updated ModuleInstaller > to use the new SplitCompat API. Add new play core activity to expected > manifest file. > > Bug: 996212 > Change-Id: I0aba37897048cc554330eb933b2687d37e9343e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764804 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689477} TBR=wnwen@chromium.org,tiborg@chromium.org,fredmello@chromium.org Change-Id: I633f9f1b3652fc4a28c6042144a9075166cff228 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766428Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689655}
-
Sean Harrison authored
Bug: 960513 Change-Id: I72288f524a82a74bfb5f23c1489c98ca7bec1dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764125Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#689654}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b179babe2c3e..00bc04d26609 git log b179babe2c3e..00bc04d26609 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 vapier@chromium.org rewrite_git_alternates: switch to our wrapper script 2019-08-22 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@00bc04d26609 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0ad455420b2d789226b827a78c7662c39f966b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689653}
-
Dana Fried authored
This also prevents invalidation of a layout in the middle of processing this kind of change, and moves a lot of the responsibility of maintaining state down into layout_manager_base, shrinking derived classes. Bug: 991492 Change-Id: I94be162ad1abe1377b7b96c14f233bec1abd0c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762878Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#689652}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/58940f67acd5..56db378961af git log 58940f67acd5..56db378961af --date=short --no-merges --format='%ad %ae %s' 2019-08-22 clemendeng@google.com Use flat arrays instead of switches for function lookups 2019-08-22 tobine@google.com Vulkan: Use VK repos' internal BUILD.gn files 2019-08-22 lujc@google.com Use SamplerID in place of GLuint handles 2019-08-22 clemendeng@google.com Change gl_DrawID from level = ESSL1+ESSL3 to COMMON 2019-08-22 svaisanen@nvidia.com Remove skipping of groupMemoryBarrierAndBarrierTest on NVIDIA Created with: gclient setdep -r src/third_party/angle@56db378961af The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I726c49ad25775c57450c298ba9fedfbf583b758d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689651}
-
Reilly Grant authored
Subclasses of DialogDelegate that override GetInitiallyFocusedView() are also susceptible to the same crash fixed for the parent class in r652329. Bug: 995688 Change-Id: I464541871e85cb0d366425f1cd957eb32176904c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764514 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689650}
-
Joe Mason authored
R=proberge Bug: 969139 Change-Id: I14af6d59541cc5ca2e7ad02f5c93ca3a328c2c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762315Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689649}
-
Mei Liang authored
This is a reland of 28b4dfc2 Original change's description: > [Dark] Update style for incognito grid tab switcher > > This CL modifies incognito GTS to use the same color palette as Dark > mode. In addition, this CLs add darker theme support for all tab group > related UIs in incognito, except for TabSelectionEditor. > > Change-Id: Ic1517867cf90ac0550fd1bf15e91cd19c4231eab > Bug: 960891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745619 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689339} Bug: 960891,996720 Change-Id: I12edea2877b44f6061fcc16e02f608758a172ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765829Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689648}
-
Tao Bai authored
From the bug report, RenderFrameHost might not available in some corner cases. Bug: 995121 Change-Id: I1258518ef171a03ee504a68c711f91f5979a5c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762830 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689647}
-
Karolina Soltys authored
Bug: 968047 Change-Id: Idaf9c72f13419ac29804a91e54be86d71ff9b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751251 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689646}
-
Nick Harper authored
This is a reland of 5572b090 with a fix to net_perftests. Bug: 980654 Change-Id: I18a5b339dbe6166ff42c0aec9f27b99d5a2139dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762821 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689645}
-
Daksh Idnani authored
Suppressed Pixel_OffscreenCanvasWebglResizeOnWorker on NVIDIA GPUs on Mac. Bug: 996824 Change-Id: I295c36d7f98b5d5fcc72f3723244ccc0dddc6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764562Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa6228187eab..3336a66fbd9d Created with: gclient setdep -r src-internal@3336a66fbd9d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:996754 Change-Id: Iaec3fd27b1bc71bf97a129990871d90cd6d0de6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764475Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689643}
-
David Black authored
ThreadPool argument should be supplied for creating a sequenced task runner with default traits. Bug: b:139822449 Change-Id: I9f9fd99050521c140a7472bb1be95b5e96f39a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764256 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#689642}
-
Donn Denman authored
Extends the expiration of various flags that would otherwise expire soon, for Contextual Search. Details and justification are in the bug. BUG=996814 Change-Id: I569cc2b368f785c97a896bf6113565d80c1a5427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762766 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689641}
-
Eric Roman authored
Connecting to 0.0.0.0 varies between platforms. Tests that intend to have connections fail should not use it, as it is interpreted as the ANY address on Linux/Mac and connections to it may succeed leading to test flakiness. 0.0.0.1 is a more reliable address for testing. It is in the same reserved IPv4 block, but does not have special meaning like 0.0.0.0. 0.0.0.0 has a consistent meaning when listening, so fine to use for server sockets. Change-Id: If484cb42023b2d85e2517f959fb625accaf87161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764941Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40be6fa4. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." c9bcba93 "Create Web Platform Tests for Scroll to text" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I491f9a4f795c34955bce7342ea5d549177404f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765573Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689639}
-
Alex Cooper authored
This change tailors the content of the WebXR consent flow to convey appropriate privacy concerns based on features that have been requested and information ineherently exposed due to the way the devices work. Bug: 987029,985026 Change-Id: I741c99d7cb39ef3fd1a59dedf0b1e58536d87f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762820 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#689638}
-
Andy Paicu authored
This CL does the following: Adds the ability to display a permission request via a notification on android. Uses this ability to show notification permission requests (gated by feature flag). This will enable experimenting with this particular UI, and represents the reparo "Mobile Experimental Candidate 3": go/reparo-candidates TBR=raymes@chromium.org Bug: 986737 Change-Id: I32f1567814b5938edf7211d7fd1d2522af778c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742168Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689637}
-
Nathan Zabriskie authored
This CL removes the maps storing various FrameTimingDetails timings in favor of a pending FrameTimingDetailsMap. This allows more timestamps to be added to FrameTimingDetails in future CL's without needing to create an additional base::flat_map for each one. Change-Id: I9b67ca9ed22e0fce40747fa942a90285fa290891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764255Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689636}
-
Nico Weber authored
Bug: none Change-Id: I8357608f3d735c1882ed246abf001ec347690f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766248 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689635}
-
Caleb Rouleau authored
R=hypan@google.com, johnw@chromium.org, sadrul@chromium.org Bug: 996830 Change-Id: I0e9e7f33818aa3278166e81b6580c699f45e1b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765997 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#689634}
-
Daniel Rubery authored
When the enterprise policy says to upload a file, attach the DM token so the server can validate the SKU. The DLP protos had also changed on the server side, so add the content source for DLP scans. Bug: 980784 Change-Id: I65fd18a9e91fd4e9a43882ac5b30be648afce74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689633}
-
Alexander Hendrich authored
This CL: * updates IsPermittedToGetDeviceAttributes() to also allow calls from the sign-in profile. So far, only affiliated users were allowed to prevent unaffiliated users from reading sensitive device information. The sign-in profile can never be affiliated since it does not map to a user account, but is bound to the device instead. * whitelists the Imprivata login screen extensions (prod and dev versions) to use the chrome.enterprise.deviceAttributes API. Bug: 996125 Change-Id: I62d1d1d7bf458250301d4b404ba546b9011a26ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762078Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#689632}
-
Alex Newcomer authored
IgnoreUpdateAndLayout does not have a clear purpose, and is causing a bug. So remove this code. I have manually tested this extensively and it appears to have no adverse side effects. Bug: 995877 Change-Id: I8ae1ce8ee680eda3771f045834daaeeded7b23ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764776 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689631}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02d4c0d38ea1..243997ac5d09 git log 02d4c0d38ea1..243997ac5d09 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 capn@google.com Don't access sampler handles for sampled image descriptors 2019-08-22 capn@google.com Fix samplerless image fetch Created with: gclient setdep -r src/third_party/swiftshader@243997ac5d09 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139401791,chromium:b/139401791 Change-Id: I95db1ceb4f2a85e4db040efa6a10695c9168a240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689630}
-