- 23 Nov, 2020 32 commits
-
-
Bao-Duy Tran authored
- Add tranbaoduy@ as primary owner of InputMethod.ID2 histogram. - Add dvallet@ as primary owner of all other CrOS histograms where there are no owners from the current team yet. - Retain ex-team members as secondary owners of all CrOS histograms. - Add team alias as secondary owner for all CrOS histograms. - Keep owners of all non-CrOS histograms intact. Also, drive-by: Fix "units" for InputMethod.CommitLength. Bug: None Change-Id: I27b3338bb46c7c0ea768976530604bba0f5f7df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545861 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#830098}
-
Nicholas Hollingum authored
This is done by AppServiceAppWindowCrostiniTracker::GetShelfAppId before this point always, and the subsequent call will always return the same thing. The claim in the comment is probably legacy, as empty-app-id windows will be filtered out by AppServiceAppWindowLauncherController::OnWindowVisibilityChanged. Bug: b/172979315 Change-Id: I38121c68cb48c9840831b83665fdf7e33285cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552327Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#830097}
-
Shik Chen authored
Bug: None Test: CQ Change-Id: I66602b8876bc43b0ec288d1bc4e8d7420ba3242d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554251 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#830096}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ebf890fcf9f3..a304f111386d 2020-11-23 ynovikov@chromium.org Skip tests failing on Linux AMD RX 5500 XT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1004356 Tbr: cnorthrop@google.com Change-Id: I0e5ddb3ca9f619b7e92aebb6048db12e2bd52153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830095}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a5aa0a295c1..639fb024beb2 2020-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1a14e7e02441 to 546a7c98c897 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I397aa0a083a79449761660154113dfc16691f582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554144Reviewed-by:
-
Jit Yao Yap authored
The CL (https://crrev.com/c/2418989) removed the default values in DeviceReportingProto since the protobuf default values are not respected in the Chrome. However, the server-side team feels that this removing the default values is unsafe as it can introduce unexpected behavior changes. This CL serves as a compromise where the default values are re-introduced to DeviceReportingProto and comments are added to indicate that the default values used in Chrome have to be kept in sync with the default values in the protobuf. Change-Id: Icb0922a4ed6a68897069854049b5302b2f9ef94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549300 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830093}
-
Melissa Zhang authored
This reverts commit a1ce46be. Reason for revert: Need to add new enum to enums.xml. Original change's description: > [Sharesheet] Record ShareAction invocations. > > Bug: 1148694 > Change-Id: I2843e2c39c3ad5229b45b5889a76cb93b1795689 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537505 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Auto-Submit: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827325} TBR=avi@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148694 Change-Id: I02b569aed30b452093cb3dc1e5020ec8f0282e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551899Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830092}
-
Aaron Leventhal authored
Calling AXObjectCacheImpl::Get() can cause objects to be detached, and this can occur when that very object is running code on itself. For example, UpdateCachedAttributeValuesIfNeeded() calls BackgroundColor(), which can call Get(). Once this returns, |this| is detached, and AXObjectCache() will return nullptr for the rest of the function. This patches the issue with temporary wallpaper until the long term fix lands in CL:2485519. Bug: 1138861,1138837 Change-Id: I3fc40954e38eddf852894af2561b9305ca0b2405 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553695 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#830091}
-
Austin Tankiang authored
Bug: 1150731 Change-Id: Ia55338e87250fd28f19c28343b6bf3a65dfacf10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549160 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#830090}
-
My Nguyen authored
Update according to description in http://go/cros-input-methods-naming. Also update Bangali to Bangla and Myanmar to Burmese/Myanmar Bug: 889763 Change-Id: I53bf124a52c8064e3ab11d2b1a3b022559b7ba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551897 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cd19e31f. With Chromium commits locally applied on WPT: 3cb8033c "Reland "webauthn: move create credential tests for residentKey/credProps to WPT"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure mcasas@chromium.org: external/wpt/mediacapture-record mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I2667a777644ad67fe65e2add05851f2d64d72267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553132Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830088}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1bc5c997775..6eed66a65984 2020-11-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I708721b8089e3cc812f7237f956f17f37a5ff054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553512Reviewed-by:
-
Hyunjune Kim authored
the width of nested grid container with margin:auto is zero when their item has 'max-height'. so the grid item's position is incorrect because the value of auto-margin computed with 'width' is wrong. Because intrin- sic width is not updated so they use the old intrinsic width. This patch is checking the dirty of the intrinsic logical width when the grid area is changed in |UpdateGridAreaLogicalSize|. Bug: 1149143 Change-Id: I4d4bf839723f05c60ed91b80148caf7b504d5aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503910Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#830086}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Icfab45bd54a1ae161e36a34a363a99d28c8ad2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554134Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I285eb7824892ee557f7a68ef2d35134c52a38c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553973Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830084}
-
Glen Robertson authored
This was a method call simply passed through to profile so that chrome_content_browser_client.cc could have different behaviour for testing profiles. It introduced a dependency "up" the build hierarchy (in the wrong direction) when profile should be a dependency leaf within //chrome/browser. That made #include cycles which prevent profile from being extracted into a separate target. Unfortunately, need to early-construct ProfileNetworkContextServiceFactory in ChromeBrowserMainExtraPartsProfiles so that ServiceIsNULLWhileTesting works as expected. Bug: 1149277,1150733 Change-Id: I608ec127813086db3aa5550e2fe9af5afb7b7e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539813 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#830083}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1286f58c2996..5abd252a0a26 2020-11-20 apodtele@gmail.com [cff,cid,type1] Demote old engine for lack of CFF2. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I8bbb088c563fcf8f0b4747265f7ec4df2aa80d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552810Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#830082}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606066622-c33e50528b69efee7458239f141a95e52f0eb25d.profdata to chrome-win64-master-1606077424-ec0f84a9c2a3c633b1c20d4d880b1629a0383891.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib05df538777ee76b558ab86456be39da6674c073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554131Reviewed-by:
-
Stephen McGruer authored
TBR=robertma@chromium.org Bug: 1151784 Change-Id: I7d93332e8217aa71867f84874cd06aa5d0ad8037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554290Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#830080}
-
tby authored
This makes three updates to the XML config: 1. All events must now have an associated project. 2. All projects now have an ID field. 3. Events no longer need owners fields, only the project itself. Bug: 1148168 Change-Id: I128d365819f9d54a92b3293b21b9b78a16af059c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550150 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#830079}
-
Shakti Sahu authored
Currently ThinWebView background is set to white from the cc::Layer. This causes a white flash in the video player. This CL adds the ability to set a background color Bug: 1151187 Change-Id: I32bcee040d1662a04477feb6b8ac6dc92f652a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552222Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830078}
-
Mike Reed authored
Bug: skia:7650 Change-Id: I42d71b2f50eae55cfd393b55d10d28d8b3b3b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553013Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830077}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606066622-40aaadfcd842623a7f3214f8df1a1a34a8723d2f.profdata to chrome-linux-master-1606089386-1100858bd739b2cdd53e6f084f74316be20c2045.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If383262af8894b6685b25f284a12aad3372c5f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554138Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606066622-142bf75e33d80f9d7fb95184ad5b40ac5d82b96f.profdata to chrome-mac-master-1606089386-260a0b5b2f863e489966f04b1fedc1aa4f716d07.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38a9bb28946ccf0290e2a8e8190ef2a4e0350ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554136Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b092342ffea..667511e44111 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: Ic917de95de2c04bbab38c76a7287e0ea313290f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830074}
-
Glen Robertson authored
This was only used in one test and is covered by an observer interface method. This cleans up a dependency from profile.cc on //c/b target towards moving profile into its own target. Bug: 268984,1149277 Change-Id: Ic12380f8175214da5ce6920172252178e3268126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550158 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
David Munro authored
Per the note, you probably don't need to use TickClock or DefaultTickClock anymore. Stick that note in both TickClock and DefaultTickClockheaders instead of just DefaultTickClock. Bug: None Test: None Change-Id: I7cdaa5b198ad06b230e2b0406c51f49f769b0794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547749 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#830072}
-
Alan Cutter authored
This copies the JSON config for Google Calendar https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/master/chromeos-base/chromeos-default-apps/files/web_apps/calendar.json to C++ in the Chrome OS binary. The JSON configs will be removed in a follow up CL to avoid data duplication in multiple locations and formats. This CL also addresses issues found in the existing JSON config: https://chrome-internal-review.googlesource.com/c/chromeos/overlays/chromeos-overlay/+/3323009/comment/8f887088_d4b89b50/ This migration is to make use of the app name localization machinery. Bug: 1147410, 1058265 Change-Id: I1a03a1d7d1c5c41cb0027dc8fba2811b5e06083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550151 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#830071}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6f9ec30edd..3b092342ffea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie005588acc152dcf1ff9873f0f0bd9fae22af599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553823Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606002382-d3c2f4299acf04e4a4c0181d7e8f98e136a20d91.profdata to chrome-win32-master-1606066622-6c4da226bf03284a24fb3e251f76a24f1e8c9c69.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1d780d664f9f767e0b0b023c6eefa1921d2ba76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554091Reviewed-by:
-
David authored
This was racey, we don't need this anymore after cl/343193875 lands and ships in our CIPD build. DO_NOT_SUBMIT until after cl/343193875 lands in chromium. Bug: b/172985712 Change-Id: I8b24f132e9bf853a67974bd15bb32716d56ec47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549201Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#830068}
-
David Munro authored
After e.g. a Chrome crash we're in a known unsupported state, we tell the user this but allow them to continue. Restarter errors in this case should go in their own bucket, since we're in a different starting state with its own set of failure modes. Bug: 1142321 Test: Launch Crostini before/after a crash, check chrome://histograms Change-Id: I7927b18f6d98572b6a083426eb3d8a7a05f13f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532135 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#830067}
-
- 22 Nov, 2020 8 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606055752-ea5379f5060a9812e063a3040f32b27130d1601d.profdata to chrome-win64-master-1606066622-c33e50528b69efee7458239f141a95e52f0eb25d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66a6360da29c436451b9ee7aab1757351d70f2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552259Reviewed-by:
-
My Nguyen authored
These were added in 2017 in https://crrev.com/c/720699, but the input methods are not implemented yet. Removing these for now so we only update description and naming for the ones in used. Bug: None Change-Id: I80422cf96ceb22f61158e51f68fa41455d4bbfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550334Reviewed-by:
-
Joel Hockey authored
This reverts commit e5fe4ff5. Reason for revert: deploy_chrome broken in 13612 Original change's description: > Automated Commit: LKGM 13612.0.0 for chromeos. > > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome > TBR=chrome-os-gardeners@google.com > > Change-Id: Ie4b66fcda58e464986edbd0e631c4a11bd75979a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553044 > Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#830005} TBR=tbarzic@chromium.org,3su6n15k.default@developer.gserviceaccount.com,amoylan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9062f24ba8f5754a80ba0a30372cc079bd666022 Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Cq-Include-Trybots: luci.chrome.try:chromeos-kevin-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550337Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830064}
-
Joel Hockey authored
This reverts commit 93f8fa9a. Reason for revert: deploy_chrome broken in 13612 Original change's description: > Automated Commit: LKGM 13613.0.0 for chromeos. > > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome > CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome > TBR=chrome-os-gardeners@google.com > > Change-Id: Icfeb7f83e86eeb99c8fa1e965deb3a63eff21f51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553533 > Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#830034} TBR=tbarzic@chromium.org,3su6n15k.default@developer.gserviceaccount.com,amoylan@chromium.org Change-Id: I9b69b3d551bc9e0b4d74006c28cc90a4e15239e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Cq-Include-Trybots: luci.chrome.try:chromeos-kevin-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550336Reviewed-by:
-
Luciano Pacheco authored
This test function isn't referred anywhere else. Change-Id: I22793003c317c0d4fc44bf59d3eeaaf97cf6213f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547647 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb772086ff9d..1f6f9ec30edd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I037104e2645913b4ed4df1feab334c4d9cdfc3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553818Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibd519f39d19e8e29a9e53d1feee864209f84accb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553692Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830060}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606041132-1840ca94124e1df207150775f6f2cfce49b1fc31.profdata to chrome-win64-master-1606055752-ea5379f5060a9812e063a3040f32b27130d1601d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I35ae5e8316285be1ec4bef2ee8e62c2a15394cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552358Reviewed-by:
-
