- 10 Sep, 2018 40 commits
-
-
Changwan Ryu authored
There is no logic change - this just move the code around for optimization. Android's VM does run-time verification for all the methods in a class if any of the methods fails in AOT compilation time. Therefore, splitting out failing methods into a separate class containing it there help reduce the overall time taken in the run-time verification. Landing all 6 CLs saves up the startup time for WebView (5% when locally tested), at the expense of slightly increasing method count and increasing apk size. See crbug.com/838702 for more information about run-time verification issue. Bug: 868250 Change-Id: Ibcf67a14882414a6fecad254378c9015d30cf6da Reviewed-on: https://chromium-review.googlesource.com/1175444Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590001}
-
Gabriel Charette authored
TBR=rbpotter@chromium.org Bug: 881685 Change-Id: I26cf5783d26d7dfadd53b1db890b09d14fb09a7e Reviewed-on: https://chromium-review.googlesource.com/1216625 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#590000}
-
Lei Zhang authored
Change-Id: I8b811528e1708ac63c5ae66fff9f057e0499adec Reviewed-on: https://chromium-review.googlesource.com/1215048Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589999}
-
bsheedy authored
There's been some more flakiness with VR instrumentation tests that use the VrCore-side emulated controller. Increasing the amount of time that's waited before sending the first input event seems to fix this from some limited testing, so speculatively commit to see if it fixes the issue on the bots. Change-Id: If438358d14f410911831911a3b0880902b57ddda Reviewed-on: https://chromium-review.googlesource.com/1217027Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589998}
-
Reilly Grant authored
This change updates usb_blocklist.cc with the latest devices as of this pull request: https://github.com/WICG/webusb/pull/149 Change-Id: I8669d03dbe2893045e77664d4fa68721d71c01d9 Reviewed-on: https://chromium-review.googlesource.com/1213938Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589997}
-
Theresa authored
The FeedNewTabPage previously added a context menu close listener to the WindowAndroid without removing it, causing a memory leak. Remove the context menu close listener in #destroy(). Also make BasicSnackbarApi static so that if the Feed session cache holds on to it the entire FeedNewTabPage isn't kept in memory. BUG=881954 Change-Id: I55c86e66c785c7ce70157454575a16bd8e5d15c6 Reviewed-on: https://chromium-review.googlesource.com/1217102Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#589996}
-
Manu Cornet authored
Add rather than replace icons since the shelf UI is still protected by a flag and we want to keep supporting both cases for a few more weeks. Bug: 880598 Change-Id: If11bbad338b4113f3e9724a729451e159c4b5964 Reviewed-on: https://chromium-review.googlesource.com/1214695 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#589995}
-
Matt Menke authored
Also remove corresponding header, and add some missing headers for used classes. Bug: None Change-Id: I2439a13b7995569a50a1f7f62aa5836589988c32 Reviewed-on: https://chromium-review.googlesource.com/1216622Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#589994}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5fea8ca820be..a5078b7c17f7 git log 5fea8ca820be..a5078b7c17f7 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 hnakashima@chromium.org Save and reload document in RemoveMarkedObjectsPrime test. Created with: gclient setdep -r src/third_party/pdfium@a5078b7c17f7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I55dfbe41082f22e43f2ae3f440342d088aa6dcd8 Reviewed-on: https://chromium-review.googlesource.com/1216804Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589993}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25c380cf9d2d..a68660d0bb5d git log 25c380cf9d2d..a68660d0bb5d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 cwallez@chromium.org gclient: add use_relative_hooks Created with: gclient setdep -r src/third_party/depot_tools@a68660d0bb5d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875245 TBR=agable@chromium.org Change-Id: I25d022673caafa13a1f410b6c2a8ba5643d7766f Reviewed-on: https://chromium-review.googlesource.com/1217144Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589992}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f62d7978fc50..75c1bf28431e git log f62d7978fc50..75c1bf28431e --date=short --no-merges --format='%ad %ae %s' 2018-09-10 31666470+s-perron@users.noreply.github.com Add option for the max id bound. (#1870) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@75c1bf28431e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2d9b580568dff1ed60469876d0160007cba31c91 Reviewed-on: https://chromium-review.googlesource.com/1216862Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589991}
-
Lei Zhang authored
Change-Id: I3716899d74877992ad3b85a82eda82a17dcf142e Reviewed-on: https://chromium-review.googlesource.com/1215049 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589990}
-
Xiaoqian Dai authored
Auto hide option is enabled in tablet mode. Thus remove this DCHECK. Bug: None Change-Id: I5833ed4f104dd5ba4eae589d4458ec85d774f676 Reviewed-on: https://chromium-review.googlesource.com/1216626Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#589989}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd9d074578e0..10494e34e453 git log cd9d074578e0..10494e34e453 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 brianosman@google.com Restore lazy image cache key logic 2018-09-10 reed@google.com implement onMakeFromData for FontConfigInterface 2018-09-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a735ee2f6df8..480edb8c1d7d (1 commits) 2018-09-10 bsalomon@google.com Relax hairline requirement that all non-quadratic cubics are split once. 2018-09-10 fmalita@chromium.org [skottie] Add support for explicit image asset sizing 2018-09-10 bsalomon@google.com Simplify GrResourceCache/GrDrawingManager flush interaction. 2018-09-10 reed@google.com Revert "remove legacy google3 flag" Created with: gclient setdep -r src/third_party/skia@10494e34e453 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I8eeaa6a7f959a8b66d7d3be958204b844af1e6b8 Reviewed-on: https://chromium-review.googlesource.com/1217142Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589988}
-
David Tseng authored
ChromeVox recently began to "stutter" or duplicate output. This occurs most frequently when navigating by headings. The underlying issue. ChromeVox requests focus whenever it navigates. This, in turn, triggers actions in Blink. This correctly emits a focus event, along with the correct event from action annotation. Once it finally arrives in automation, we dispatch the event in js. In js, we suppress focus events in favor of tracking the focus computation given by AutomationInternalCustomBindings. Unfortunately, if, within the same event bundle, there is an event immediately before the focus event (either generated or not), the event triggers a synthesized focus event, before the actual focus event. In the end, the incorrect event from value is associated with the synthesized focus event. This has enormous impact on users as we unpredictably flood users with duplicate feedback. This seems worse on some devices (depending on the event bundle's contents and ordering). Technical details. What's happening: we receive events (in order) like: 1. layout complete (event from page) 2. blur (event from action) 3. focus (event from action) in the same event bundle. Before any of these get fired, we unserialize all of the tree data, so the focused node is already updated as far as the tree data is concerned. After this, we proceed to fire events. The first one, is the layout complete. This translates into a *focus* event js-side, along with event from page, because that's what the layout complete event had set. If we honored the actual focus event first, then we would pick up on the right event from action value. Bug: 881495 Change-Id: I73b1afc3f1b224ade0cef29a89e00c179438a575 Reviewed-on: https://chromium-review.googlesource.com/1211106Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589987}
-
Eugene But authored
WaitUntilConditionOrTimeout replaces deprecated WaitUntilCondition. Bug: 784735 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7be4ef5e89e72e2bdee8721a6be7fcaba96107a8 Reviewed-on: https://chromium-review.googlesource.com/1214425 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589986}
-
Tommy C. Li authored
1. Revert the change where we decided to ignore eTLDs (https://crrev.com/c/644491). We figured that none of these would allow "www" or "m" as a subdomain but the m.tumblr.com case proves this wrong. 2. Only strip leading trivial subdomains. Bug: 881694 Change-Id: Ia8b7bb02611edc4d6c6c2c634f428dee0bff11e2 Reviewed-on: https://chromium-review.googlesource.com/1215420Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#589985}
-
Leszek Swirski authored
Posted blocking ScriptStreamer tasks can end up in a queue, and have their Resource complete loading before the task even starts. When this happens, these tasks will no longer block on network input, but they will still be posted to the blocking task runner, which does not spin up new threads if the running task is not blocked. When there are a lot of small functions posted for streaming, this results in a slightly paradoxical starvation, where the blocking task runner is processing lots of no-longer-blocking tasks all in one thread, as it has no reason to spin up new threads. To avoid this, if a streaming task isn't started before the resource finishes loading, we can cancel this posted task, and instead post a new non-blocking task to the non-blocking thread pool. This frees up the blocking task runner to process only blocking tasks (and thus allows it to spin up new threads for them). TBR=kouhei@chromium.org Bug: chromium:865098 Bug: chromium:866868 Change-Id: Ia955fb7a5fd7a6dfdac6a21d8d866b1d1699054d Reviewed-on: https://chromium-review.googlesource.com/1216963Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589984}
-
Manoj Gupta authored
Currently there are no widevine cdm libraries for arm64 builds. Disable it to avoid build errors when building ARM64 Chrome in Chrome OS. Bug: 881022 Test: No more missing widevinecdm files errors. Change-Id: I476415cef0c435cb50e113de4e576cb6d3006951 Reviewed-on: https://chromium-review.googlesource.com/1211974Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#589983}
-
Ryan Tseng authored
These builders take a long time to finish. Bug: 868213 Change-Id: I532603b76a6a724bbdf36f5d27e93223d6f5d2de Reviewed-on: https://chromium-review.googlesource.com/1217223Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#589982}
-
Wez authored
This reverts commit e67557cd. Reason for revert: Issue 864351 has been traced to a bug in ThirdPartyModulesBlocking. Original change's description: > Copy some more BlobReader state to the stack and alias it. > > Temporarily add some values to minidumps, to help diagnose BlobReader > crash reports. > > Bug: 864351 > Change-Id: I048600d890496247fc966442d8f533d4b9eb51c8 > Reviewed-on: https://chromium-review.googlesource.com/1196041 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587476} TBR=wez@chromium.org,mek@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864351 Change-Id: Ibb9809ce230a615ec18a36708d45635fc40ca8c1 Reviewed-on: https://chromium-review.googlesource.com/1216711Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589981}
-
Kenneth Russell authored
The test recently and unexpectedly became so flaky (timing out) that it was failing its 3 retries. Bug: 882323 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I79865837adcab6553693cdf3cb37db356a7d3816 No-Try: True Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1216085 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589980}
-
Esmael El-Moslimany authored
Bug: 875461 Change-Id: If447041f60540c338a368a94900632693d1a18d3 Reviewed-on: https://chromium-review.googlesource.com/1217162Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589979}
-
Charlie Harrison authored
The only behavior change here is operator<<, which is pre-defined for mojo enums. This is in preparation to moving subresource_filter to mojo. Bug: 820612 Change-Id: I5ff3f4d55588bdb153f5875885824cd0cc315e13 Reviewed-on: https://chromium-review.googlesource.com/1213533 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589978}
-
Dominic Mazzoni authored
These four events are (1) properly covered by AXEventGenerator, (2) don't have any very specific logic in ChromeVox, they just call onEventIfInRange, and (3) they aren't ever fired by views in a place where AXEventGenerator wouldn't be able to infer the same event. For those reasons, these 4 are safe to switch over. Bug: 699438 Change-Id: I05037a29e63e01b2be1a23c1057750ada24f0172 Reviewed-on: https://chromium-review.googlesource.com/1215058Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589977}
-
Harley Li authored
Blob requests do not make sense when running outside of the page which created them, so generating a cURL command would be misleading. Bug: 791974 Change-Id: Ica9295d4e9f1cced9fd47b78a5338f68f71e5373 Reviewed-on: https://chromium-review.googlesource.com/1213825Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#589976}
-
Mason Freed authored
Previous to this CL, the RenderWidgetHostViewAura::CopyFromSurface function would capture only the main window contents. It would ignore any secondary child popup screens that were generated as a result of many popup operations, for example calendar pickers, selection popups, suggestion pickers, etc. With this CL, those popup screens are detected, captured, and overlaid on top of the main window capture. Note that in the process of implementing this, I fixed a bug in RenderWidgetHostViewAura::GetBoundsInRootWindow(), for the Windows case. Previous to this CL, for Windows, when legacy HWNDs are not in use (UsesNativeWindowFrame() returns false), the function would return locations in units of DIPs divided by scale factor. It should be returning DIPs. I moved the conversion up into the if{} block. It seems that no current test catches this issue, but once --enable-display-compositor-pixel-dumps becomes a default flag, the existing layout tests, under virtual/scalefactorXyz, should serve to monitor this code for regressions. Bug: 875962, 667551 Change-Id: Iefc9bfd7798b3dfabb3a28eb46009fa703c0fca0 Reviewed-on: https://chromium-review.googlesource.com/1192330 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#589975}
-
Leonard Ge authored
In this CL, I've extended the functionality of the `generate_perf_sharding` script to generate the shard_map only for the given benchmark. The user needs to provide the `benchmark_name` and `builder_name`, and the script will generate the shard map. Users can also set the number of shards to use as well as the output file path. I've also fixed some minor style issues. Bug: catapult:# Change-Id: I956ebea0a8d044b1725de4a94eb17f60260a1424 Reviewed-on: https://chromium-review.googlesource.com/1216064Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Leonard Ge <wangge@google.com> Cr-Commit-Position: refs/heads/master@{#589974}
-
Lei Zhang authored
Change-Id: If3b12f9ef36d20c43283fba936bdf4f9be7c1889 Reviewed-on: https://chromium-review.googlesource.com/1214742Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589973}
-
Tatiana Buldina authored
Bug:chromedriver:2574 Change-Id: I4818d3765f02998a3d317476e0b80d37483c5b52 Reviewed-on: https://chromium-review.googlesource.com/1214683Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589972}
-
Xianzhu Wang authored
Previously we adjusted local border box properties out of LayoutBlock::PaintObject(), while adjusted cull rect and paint offset inside of LayoutBlock::PaintObject(), making inconsistent relationship among paint chunk properties, cull rect and paint offset between the two adjustments. We should adjust them altogether to ensure consistence. Now rename PaintInfoWithOffset to ScopedPaintState (which will include more paint property adjustment in the future), and combine ScopedBoxClipper and the original code that adjusts cull rect and paint offset for ScrollTranslation into ScopedBoxContentsPaintState. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70f1ad00f2508d80eaa387259a1a62f301016ee5 Reviewed-on: https://chromium-review.googlesource.com/1213824Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589971}
-
Ryan Harrison authored
I introduced a second definition of ZWW in the PDF plugin code without realizing it in a previoud CL. This CL merges the two definitions together. BUG=chromium:743522 Change-Id: Id5389bffc9aca70458c4aa934eb3163bf6ad503a Reviewed-on: https://chromium-review.googlesource.com/1213543Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589970}
-
liberato@chromium.org authored
When we detect that an underlay is unoccluded, we would previously consider removing its damage rect if it hadn't moved. However, this can cause problems if the underlay was occluded on the previous frame, since we still need to erase whatever disappeared above it from the framebuffer. This CL requires that an underlay is unoccluded for one frame before removing its damage rect. Bug: 875879 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I00394c6d6f61c4381a97a6c753c8840485163845 Reviewed-on: https://chromium-review.googlesource.com/1211202Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589969}
-
Quan Nguyen authored
This CL adds a button to the login-dev-overlay to pop up a fake kiosk error message. We also update the ToastManager to allow showing toasts on the Login screen (which also uses LockSystemModalContainer). This involves consolidating the toast requeueing logic into OnSessionStateChanged. Bug: 879117 Change-Id: I557f0444a2368d1bf460d5db0a41f893ce0e69ea Reviewed-on: https://chromium-review.googlesource.com/1211969Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589968}
-
Nicolas Ouellet-Payeur authored
Bug: 881859 Change-Id: Ic6d6945726d1dfd4fda5b59031c785d321730a09 Reviewed-on: https://chromium-review.googlesource.com/1214243Reviewed-by:
-
Min Qin authored
TBR=bashi@chromium.org Bug: 882477 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id894ba9de59d1936591f78fed39fefe66658ba70 Reviewed-on: https://chromium-review.googlesource.com/1217062 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589966}
-
Zhenyao Mo authored
So we can easily take advantage of devtools integration in tests. For example, the ability to automatically turn into fullscreen video playing mode. BUG=867155 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2ed4d91ea82c3fc1308663c5d70e0f37bd50cd78 Reviewed-on: https://chromium-review.googlesource.com/1159690Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/abd4273e43da..b2d711673390 git log abd4273e43da..b2d711673390 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 peah@webrtc.org AEC3: Correction of the suppressor behavior at delay changes 2018-09-10 danilchap@webrtc.org Allow different header extensions in 1st packet of a video frame Created with: gclient setdep -r src/third_party/webrtc@b2d711673390 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:882396 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I19018fd072ff9c12a936a165fe5e1df5f6d8be64 Reviewed-on: https://chromium-review.googlesource.com/1216803Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589964}
-
tzik authored
The usage of `has_value` in remote_suggestions_fetcher_impl_unittest.cc works for base::Optional, but does not work for std::optional. To keep base::Optional be replaceable with std::optional, this CL updates RemoteSuggestionsFetcherImplTest to avoid using the method pointer to `has_value`. Change-Id: Iac3bfd47680b7678fcabdfaaa3ad8cc440e43408 Reviewed-on: https://chromium-review.googlesource.com/1215433Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#589963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43b882bceda7..cd9d074578e0 git log 43b882bceda7..cd9d074578e0 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 fmalita@chromium.org [skottie] More efficient group sizing 2018-09-10 reed@google.com remove legacy google3 flag Created with: gclient setdep -r src/third_party/skia@cd9d074578e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I9f51452870dfdc39abb5ab4094a596ed0db14cfd Reviewed-on: https://chromium-review.googlesource.com/1216542Reviewed-by:
-
