- 16 Aug, 2020 28 commits
-
-
Peter Kasting authored
This makes it easier to track down and/or change types. Also renames CallbackList -> RepeatingCallbackList. Bug: 1113007 Change-Id: Ib934071a88a991178dee8a99f722770f4e3f3957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354614Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798495}
-
Findit authored
This reverts commit 4de14608. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 798490 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRkZTE0NjA4NGVmNzcyNzI1ZmI2MDRmNGM5MTkyMWM5ZWQ1YzZhY2MM Sample Failed Build: https://ci.chromium.org/b/8871798512306610112 Sample Failed Step: compile Original change's description: > [Files] Add file-type filter buttons in Recents view. > > This adds file-type filter buttons (Audio, Images, Videos) above the > file list only in the Recents view. > Expected behavior: > Users can toggle(enable/disable) file-type filters by clicking it. > Only one filter can be applied at the same time. > Active filter should be cleared when a user leaves Recents view. > > Bug: 1114721 > Test: Manually tested with flag #files-filters-in-recents > Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 > Commit-Queue: Naoki Fukino <fukino@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798490} Change-Id: I78ec51191bd1ce062f1a5cf06a74baf213a915fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359469 Cr-Commit-Position: refs/heads/master@{#798494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1b37b7a9dad..f93d7f924e80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4f8ead0786971feec69ce8e22c22cde45f0f504a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359428Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798493}
-
Hitoshi Yoshida authored
Move definition of use_blink_v8_binding_new_idl_dictionary to t/b/r/config.gni and define a C++ definition. Bug: 839389 Change-Id: I8ebe279ad03af81ceb81a5856119eb3097a379b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358930 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798492}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597556507-5d0b6a058065c766d64fdd0bab871442eca481b8.profdata to chrome-mac-master-1597574780-11032f77f0853e1d71f33728c0242d630bf5af1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4eeb49ee9b3621da9ffd3eb48169a91f82eb6d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798491}
-
Naoki Fukino authored
This adds file-type filter buttons (Audio, Images, Videos) above the file list only in the Recents view. Expected behavior: Users can toggle(enable/disable) file-type filters by clicking it. Only one filter can be applied at the same time. Active filter should be cleared when a user leaves Recents view. Bug: 1114721 Test: Manually tested with flag #files-filters-in-recents Change-Id: I50ecd9c1c2f9a587d63e6ae89f88d6b5fe0cba4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354115 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798490}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c0263ae980bf..e4e6433497c5 2020-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I020aab369be1173dcc39a413406252ea63b07822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359420Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, the Android payment apps installed on Chrome OS would not be available in Web Payment. This patch queries the list of installed Android payment apps and returns all of them to Web Payment, if chrome://flags/#enable-web-payments-experimental-features is enabled. After this patch, the Android payment apps installed on Chrome OS are available in Web Payment. Bug: 1061503 Change-Id: Ifb11741377a0a21166d77c547dbbad21b6daffeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302269 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798488}
-
Matthias Körber authored
This CL grants precedence to the heuristic field type detection if a structured last name type is detected. Change-Id: Ic058b13b641328ed4bc583d786836f71d527dbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353347 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#798487}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I602a5cb1022cc5aaaa2944833c09d2d53f49e289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359355Reviewed-by:
-
Viktor Semeniuk authored
This change adds default selection style to Password Check Details cell on Passwords screen and to Change password button on Passwords details screen. Bug: 1113816 Change-Id: I7ae74f009e62c9700c4a85480ddf416102e71d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353260Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798485}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa79253c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: If86799adfafb1bbd36a3d06b0f4536755fdecac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358575Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798484}
-
Viktor Semeniuk authored
This change fixes bug for iOS 12 (and earlier) when activity indicator is not visible by changing it's color from white to gray. The change has no effect on iOS 13 and later. Bug: 1116406 Change-Id: Ia8852bbfde208c7ff006da607b702ad97f12b8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356384 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
Matthias Körber authored
Adds a test to verify that the correct types are determined for structured address tokens. Change-Id: I303e50e049f8ed8e8418659ae8c750f16ee6ccee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352808Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597514130-fe0a8d516b962baead2578c487739528f5924993.profdata to chrome-mac-master-1597556507-5d0b6a058065c766d64fdd0bab871442eca481b8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ife0fbb180fd5271966156defefdab973cd006ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359350Reviewed-by:
-
Arthur Eubanks authored
Ran `./tools/clang/scripts/upload_revision.py 95fad44e34c3c20263961a715571d798d90921f6`. Bug: 1113154 Change-Id: I2cbd4533fcedea8acfb6d5f5067e56c7d758d25b Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357413 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798480}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d2954f..7dff8b43 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia960dac61c0a4d9c2cfa3553bd83cfee65c76c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798479}
-
Peter Kasting authored
* TimeDelta::InMicrosecondsF() actually returns a double * Shorten code Bug: none Change-Id: I0dc35be9c2298e79d8a8f0cd34492d09c04cf9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359002 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798478}
-
Sven Zheng authored
This cl fixes the interactive_ui_tests(and storage_service_interactive_ui_tests) test failures from ~350 down to ~150. Fix 2 things: 1 ui_control is not installed. 2 Sometimes the SendKey send to a wrong window. python build/lacros/test_runner.py test \ out/LacrosDesktop/interactive_ui_tests \ --gtest_filter=WebViewInteractiveTest.NewWindow_OpenInNewTab python build/lacros/test_runner.py test \ out/LacrosDesktop/interactive_ui_tests \ --gtest_filter=AutofillInteractiveTest.OnInputAfterAutofill TEST: linux-lacros-fyi-rel shows the result. For local testing: Bug: 1111979 Change-Id: I256e6e87299cd8403894823d73804c2765616163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355137Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798477}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4a040e8b22f..c1c3c6d70d32 2020-08-16 johnstiles@google.com Enable ClangTidy flag bugprone-suspicious-string-compare. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I2647ad8a7a3a522cf2208c8e2c57f8125610a405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358447Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibaa2ebd7bc5855b71df822ef8b9289264370fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358446Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9bf882434e99..c0263ae980bf 2020-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46aeab3621eec5dbc09d6f2cab9614ef6b05ef0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358445Reviewed-by:
-
Chris Cunningham authored
- don't clear the error callback prior to calling it - implement encodeQueueSize to signal backpressure - add extra error logging for VpxVideoEncoder - disable vp9 profiles 1 and 3 (not yet implemented) And opportunistically mark a number of inputs in IDL as required - timestamp (its required for creation of VideoFrame internally) - error and output callbacks (duh). Remove ? from duration input dictionary. Its not required, no need to null. Bug: 1094166, 1116617 Change-Id: I9577bc42d1f24c2ec14885401e87337ba0937e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355276 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#798473}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Iaa7a183f8465f7306d20abe4579001bd6ac86850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358891Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798472}
-
Rouslan Solomakhin authored
This patch adds the skeleton code for a payment app factory for Android payment apps. The new factory is disabled by default, but can be enabled via chrome://flags/#enable-web-payments-experimental-features drop-down or --enable-features=CrossPlatformAndroidPaymentAppFactory command line flag. When enabled, the new factory does not return any payment apps in this patch. Bug: 1061503 Change-Id: Iea19c68889be77d5083f86d2b9063db64de38cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299855 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798471}
-
Alexander Surkov authored
Bug: 1115489 Change-Id: I4dfe7402cf80863a33bc36f48817e9b20705436c AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351954Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798470}
-
Christopher Cameron authored
Add plumbing to send the gfx::ColorSpace of the GLImage through to the HDRCopierLayer. Bug: 1101041 Change-Id: Ia41022d068b6daea5f1fd17191468cf89c463e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352618 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798469}
-
Rouslan Solomakhin authored
This patch adds a utility function (and corresponding unit test) for separating a single Android payment app into multiple Android payment apps that have exactly one payment activity per app. This enables treating each PAY intent filter as its own payment app, including when one app declares multiple PAY intent filter targets. Bug: 1061503 Change-Id: Ieecd43607b282295667108f70f94b276997fe25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300276 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798468}
-
- 15 Aug, 2020 12 commits
-
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsNetworkPasswordInputTest* Change-Id: I7201a50e233aba39bd8b086d54c03a3dbb4ca41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357709 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798467}
-
Christopher Cameron authored
There exists code that copies an IOSurface to a CAMetalLayer, because simply setting a CALayer's contents to an IOSurface that has an HDR color space is not sufficient to guarantee that the content will be displayed as HDR (it did in early versions of 10.16, but now does not). Separately, there is now desire to have tonemapping on lower end HDR devices. This is fairly easy to wrangle into the pipeline in the place where we do the copy. In this patch, replace the blit with a shader that does the blit. Also, change the CAMetalLayer from matching the IOSurface to being float16. Patches will follow will include - Change the CAMetalLayer to be in extended-linear-sRGB color space, by adding limited color conversion to the shader. - Add tonemapping in the extended-linear-sRGB color space. - Set the tonemapping parameters based on the NSScreen properties. Bug: 1101041 Change-Id: If1aaa6081730212611cb4cf58d8f90d5957dddf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352027 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
This patch adds a utility function (and corresponding unit test) for filtering the requested payment method data according to the payment method names supported by an app. This prevents a payment app from receiving method-specific information about methods that it does not support. Bug: 1061503 Change-Id: I901a2fd6166ddc031f8910816a0e3f8fdc5a7b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300344 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54c877799ca3..f1b37b7a9dad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I1c0254df5a1be7f6e5a8ee4eeb2bd01a95ffce12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358662Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iaaa949eb334cd8d6d60dbb3c10c764f95ba20f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358663Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/939cc7a63059..d4a040e8b22f 2020-08-15 brianosman@google.com Remove obsolete support for sk_InColor in GrSkSLFP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ie66c3e75479d791988908a4b7a98907cd1458bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358661Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a060dda080b8..54c877799ca3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I8a07d3211f99a0e5ce9e2a941db236771bc25fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358657Reviewed-by:
-
Mason Freed authored
This test worked on Mozilla due to the adoption of orient="vertical" and the native sizing of the range control. It failed on Chromium because min-content was less than 30px. This new version appears to pass on both Chromium and Mozilla. Fixed: 1108796 Change-Id: Ie5cbaaff6c78f7658931e8d63860383e3501f5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355567 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#798460}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597469709-8cf61cc1ffe0a31b31c564af7daefa20dac2379b.profdata to chrome-mac-master-1597514130-fe0a8d516b962baead2578c487739528f5924993.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iba2a14f55182696c3f497ca7fe51284c37e74f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358658Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36652baf8b7e..a060dda080b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1116760 Tbr: Change-Id: Ia8b7f5e067ce3803487a2aba5864dc97b1baa35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358695Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d253278f9865..758b30727efc 2020-08-15 john@johnkgo.com Build: fix a build warning 2020-08-14 johnkslang@users.noreply.github.com Merge pull request #2367 from KhronosGroup/fix-semantic-checking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC ynovikov@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: ynovikov@google.com,radial-bots+chrome-roll@google.com Change-Id: Id55907f2dee16e9bdb5b7f2e1753adbd0b3a9087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358654Reviewed-by:
-
Dirk Pranke authored
It looks like this binary was originally declared as a 'raw' test (meaning that we didn't know how to do anything other than look at the exit code to determine pass/fail), but that was probably a mistake, as it looks like it is a normal chromium gtest-based test. This fixes that. However, it also looks like we're not running this test anywhere, so I can't easily verify this on a bot. This CL makes no attempt to fix that, but I did confirm that the test runs locally under iossim and looks like a gtest-based test. Bug: 816629 Change-Id: Ibf5370d365e0b7e2ba5238bbcc416db0407d8b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354778Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#798456}
-
