- 30 Jan, 2020 40 commits
-
-
rbpotter authored
This is a dependency of settings_shared_css in the settings page. Bug: 1042558 Change-Id: Ibd7ec9f7a098787556bcdb1276732c94410781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028765 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736716}
-
Youkichi Hosoi authored
BUG=b:147917544 TEST=trybot Change-Id: I5e31ef997e7348b388f6a6fce9027b36e1a4fcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026534 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Auto-Submit: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736715}
-
Eric Karl authored
We allowed destruction on main thread for historical reasons. Update DCHECK to represent the real requirement, that we're always destroyed on the bound thread. Bug: 899395 Change-Id: I542ecbd2bbdb449b96bed2b7f747640873847e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029491 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736714}
-
Luciano Pacheco authored
Fix tests broken by the new structure in the directory tree. Enable some of the broken tests with FilesNG flag so they don't regress. Changed 2 let to const as pointed by presubmit. Bug: 1002790 Change-Id: I4b9c6e34d8f89df1b7f7ece002f8c121ca4eb3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029392 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736713}
-
Bo Liu authored
Useful for debugging binding related issues from logs. The message looks like this: bindings:WMS state:3 counts:0,0,0,2, Bug: 1045059 Change-Id: I4523494c08f2dcee94c5ee9ca337284dedfea6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028162Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141427882038..adc8d4cb9876 Created with: gclient setdep -r src-internal@adc8d4cb9876 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1040871,chromium:1046370,chromium:790886 Tbr: jbudorick@google.com Change-Id: I9fb2dde88a7812434fce8c15de50071c986ba32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029275Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736711}
-
Kai Ninomiya authored
And temporarily disable use_dawn for the M81 branch point. This allows dawn's standalone tests to continue to be built for Chrome OS's testing during the branch period. Bug: chromium:985142 Change-Id: I9b2924276b65b628056f811008f3432be4ad5539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028649Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#736710}
-
Demetrios Papadopoulos authored
The violation was uncaught because the corresponding js_type_check() target was not referenced from anywhere. Initially revealed by building the |all| target locally as follows ninja -C out/<out_folder>/ all Bug: None Change-Id: I63b81ba5a4d48854d38166679df60ec8900bddcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029197Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736709}
-
Alan Cutter authored
This CL removes all references to ThemeService::theme_supplier_ when computing colors/images by moving the logic up into separate ThemeServiceBase class. Previously, to return a default theme value, ThemeService::BrowserThemeProvider used a helper class called DefaultScope that would swap ThemeService::theme_supplier_ with nullptr while it was in scope to simulate the user having no theme installed in order to compute default color values. This CL cleans up this hack by making theme_supplier an explicitly passed in parameter to the theme logic which has been pulled out into a separate ThemeHelper utility for the ThemeService such that it does not depend on the active theme_supplier_. This is a pure refactor with no changes to existing behaviour. This is in preparation to allow BrowserFrame Widgets to use their own CustomThemeSuppliers: https://chromium-review.googlesource.com/c/chromium/src/+/2003156 Bug: 1020050 Change-Id: I483a845dcda3fd612b6a5e8608cce1553581e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994026 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#736708}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I63cd0fce1d0ab62be3ddf9d22ed34a940623f60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029313Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736707}
-
Dan Harrington authored
And pref_names. These components can be used without modification in feed v2. Bug: 1044139 Change-Id: I79a11a20c08d9117ceab4eec04743df1d35bc5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013024Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#736706}
-
David Black authored
This CL also restores the proper icon size to Assistant suggestion chips (which was at some point updated to use AppListConfig back when this class was also being used for AppList suggestion chips) and clips suggestion chip icons to a circle. Bug: b:148246719 Change-Id: Idd12f248ff1962153449f7f0f1ceb82aeec87af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021009 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736705}
-
Manu Cornet authored
(Current subclasses are: ShelfNavigationWidget, HotseatWidget, ShelfWidget) Bug: 1044306, 1042491, 1040177, 1042911 Change-Id: I6788ef709be7a5eb97c0554ec9337cd5e6c5f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029331Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#736704}
-
Sinan Sahin authored
With this CL, we calculate an anchored top control offset (used as the status indicator offset for now) during the height change animations and send it from BCOM to the status indicator's compositor layer. Bug: 989148 Change-Id: Ie61c343e43a0ec2c469aa37d14a79fe9abeab731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003869 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736703}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I41b53e841a303c7a27653f879dd86be0c2831da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028527Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736702}
-
Etienne Bergeron authored
The Intersects function had an inconsistent behavior. This CL is fixing the issue and adding tests for these cases. Without the fix: Range(0,0) contains Range(0,0) but they do not Intersects. Also, for these two ranges: r1 = gfx::Range(0, 1); r2 = gfx::Range(1, 2); r1 does not intersects r2 but r2 does intersect 1. R=pkasting@chromium.org Bug: 1025561 Change-Id: Id68da5930d7bfc69c8c97738735acbb22369d2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983563 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736701}
-
Manas Verma authored
Currently when the user cancels the Verifying Pending Dialog immediately after card selection, the Payments Request to fetch unmasking details is not cancelled. This means that when the request is responded to, the CVC dialog is shown. However, cancelling the Verifying Pending Dialog should fallback to a regular CVC auth flow. This CL fixes both these issues. Bug: 949269 Change-Id: If2dc973c5d938cf05d43694342894b572205cbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028116 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#736700}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5c2c334d9f5d507db7ec459ef7c458be07c0cd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736699}
-
Tom Anderson authored
Adds GMB support for Linux/X11. ANGLE support will be added in followup(s). For now, support on EGL/GLX is enabled when --enable-native-gpu-memory-buffers is passed. Main code additions: * GbmSupportX11: ui/gfx/linux/gbm_support_x11.* - Uses DRI3 to get an authenticated DRM fd. Creates a GbmDevice with it. * GLImageGLXNativePixmap: ui/gl/gl_image_glx_native_pixmap.* - Subclasses GlImageGLX. Uses DRI3 to get a GLX pixmap from a dma-buf. * ui/gl/gl_visual_picker_glx.* - Figures out which GLXFBConfigs should be used for corresponding gfx::BufferFormats. Only BGR(A) formats are supported by GLX. GMB support used to be routed through gpu::GpuMemoryBufferSupport, which is basically just a switch statement over the various gfx::BufferFormats and gfx::BufferUsages. With X11, GMB support needs to be determined at runtime, and in the GPU process (since it depends on the singleton GbmDevice and the GL implementation), so GMB support is put into gpu::GPUInfo, similar to how we're already doing with visual IDs. BUG=1031269 Change-Id: Ie254e6c5646073be0cb76d549c115be274e4ef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984712 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#736698}
-
Darin Fisher authored
The only dependency is prerender_dispatcher_unittest.cc, and the only purpose of that file is to test that aliases are updated properly. It can all just be deleted. Change-Id: I6114d85cc53333d5712d0f4baceb18ed143a0055 BUG: 755921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029271 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736697}
-
Kenichi Ishibashi authored
This CL fixes flakiness of ServiceWorkerBasedBackgroundTest.TabEvents by changing the order of registration lookup in FindRegistrationForScope(). Context: crrev.com/c/2003163 introduced the flakiness because it changed timing (not ordering) to look up installing registrations. See the linked bug entry for details. This CL makes FindRegistrationForScope() look up installing registration before checking storage. This changes existing behavior (which looked up stored registration first) but we believe that this wouldn't make any difference from the call site's perspective. Our rationale is that there should be always 1:1 relationship between registration and scope so FindRegistrationForScope() should return the same registration no matter it is installing or not. Bug: 1043481 Change-Id: I0eb1a2b1933229724c52e6a5929a3e25a91c0c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024588Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736696}
-
Koji Ishii authored
Following bot results are included. 1175 1179 1182 1183 1184 1185 1186 1187 1190 1192 1194 1197 1198 1201 1202 1203 1200 119 lines were removed and 16 lines were deflaked by consecutive results since 1179. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I335622850023f752364a6caa587f3b6034f00a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024768Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736695}
-
Scott Violet authored
This is intended for scenarios where the full state is not necessary. The minimal state attempts to save all the tabs and at least the current navigation entries of each tab. This saves as much as will fit in 512k. 512k is roughly half the max size allowed by most android versions for saving application state. If application state is too big, the OS throws an exception. This code path will be used when full persistence is not desirable and the system asks WebLayer to save state. Ideally when the system asks WebLayer to save state and no id was given, we would use the same code path as when an id was given (perhaps by generating one off ids and saving that), but there is no clear way to know when Android no longer needs the data, which means it's nearly impossible to automatically delete the data. Trying to use heuristics will be error prone, for this reason I'm adding the minimal code path. I plan on moving session_service into weblayer/browser/persistence after this. BUG=1033924 TEST=component_unittests CommandStorageBackend* Change-Id: Ie0cce1f4123a54d816d11f51a6ee6546310d3b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027129 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Kent Tamura authored
* Add |parent_style| argument This makes a later patch smaller * Do not check text direction repeatedly * Do not call LayoutTheme::GetTheme() repeatedly This CL has no behavior changes. Bug: 1040828 Change-Id: Id5ece1da90dc5ae9500247c212ad9adc230b00da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029527 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/76a9d840b0f0..707a8742cabd git log 76a9d840b0f0..707a8742cabd --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fancl@chromium.org Switching List Sheriffs from datastore to sheriff-config Created with: gclient setdep -r src/third_party/catapult@707a8742cabd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: skyostil@google.com Change-Id: I31bb5e6e512774c0615878bf308359b046c793df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029222Reviewed-by:
-
Anand K. Mistry authored
This passes the kerberos authentication identity (either account guid or principal name) to smbfs, along with which source to query for credentials. Bug: 939235 Change-Id: I06b2739231b17ff36a75308afc80554b1b80bdb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006906Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#736691}
-
ssid authored
TBR=oysteine@chromium.org Change-Id: Ie970a1309835d250dbd0436d1a26bbc9547c0d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812223 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#736690}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0a0c59c80b0..24ed75db12ba git log d0a0c59c80b0..24ed75db12ba --date=short --first-parent --format='%ad %ae %s' 2020-01-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@24ed75db12ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ic522bb6038d0fa748a3b414a3bb6e7c02b76de18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029272Reviewed-by:
-
Nick Yamane authored
This reverts commit 97332534. Reason for revert: This caused in regression keys decoding in non-qwerty keyboards, as reported in crbug.com/1047005. Original change's description: > x11: Ensure XEvent translation is equivalent to ui::Event ctors > > This is part of the patch series migrating PlatformEvent to ui::Event > (formerly using XEvent) in Aura/X11 in order to eliminate this > fundamental difference/incompatibility between Ozone and non-Ozone X11 > ports. Design doc [1] describes in details such effort. > > This CL, particularly, is meant to ensure XEvent => ui::Event > translation code (x11_event_translation.{h,cc}) is equivalent to > constructing ui::*Event using the PlatformEvent ctors, the mechanism > used so far to do such "translation". > > To achieve it, events_unittests have been modified to use the brand new > X11 event translation code as well as fixing discrepancies found along > the way. Most of them are trivial and this change does not bring any > behavioral change. > > [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc > > Bug: 965991 > Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736213} TBR=sadrul@chromium.org,dcheng@chromium.org,thomasanderson@chromium.org,nickdiego@igalia.com Change-Id: I545d08c193f70cd5a0c7216f1e6783f8478d9e64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030004Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#736688}
-
Daniel Rubery authored
If deep scanning is enabled by policy, it should still occur even when Safe Browsing is enabled. This CL ensures that will happen. It implements the following flow for deep scanning: - If SB is disabled, immediately begin deep scanning - If SB is enabled, begin the consumer SB check - If this identifies malware, skip deep scanning and warn the user - Otherwise, deep scan the file To accomplish this, we restructure the interaction between the ChromeDownloadManagerDelegate and DownloadProtectionService so that the DownloadProtectionService is now responsible for determining whether scanning (either consumer or enterprise) should be performed. Bug: 1041578, 1020215 Change-Id: Ia681b2cfee9cf2adecbba2aa62e83b530faaedeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020408Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736687}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6c3dc3581eaf..430def835f9f git log 6c3dc3581eaf..430def835f9f --date=short --first-parent --format='%ad %ae %s' 2020-01-29 capn@google.com Regres: aways use build output path for ICD json 2020-01-29 capn@google.com Associate bug IDs with unimplemented functionality 2020-01-29 amaiorano@google.com Fix memory leak in rr::Optimizer 2020-01-29 bclayton@google.com Regres: Make it work on windows. 2020-01-29 amaiorano@google.com Subzero: implement coroutines for Win32 2020-01-29 bclayton@google.com SpirvShaderDebugger: Expose builtins in HLSL / GLSL. 2020-01-29 bclayton@google.com Vulkan/Debug: Add VariableContainer::extend() Created with: gclient setdep -r src/third_party/swiftshader@430def835f9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I02f8c532b33dc934d1f4da0da6eb43dd0b7e174b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029219Reviewed-by:
-
David Grogan authored
Flex containers can place the top of their items above the top of the container. This should not show scollbars on overflow:auto containers, but FlexNG currently shows them. See the new test for a simple case. Legacy got around this by passing an adjusted height to ComputeLayoutOverflow: ComputeLayoutOverflow(ClientLogicalBottomAfterRepositioning()); This patch does something similar, but in NG layout objects don't calculate their own overflow, NGBlockNode does it in NGBlockNode::CopyFragmentDataToLayoutBox. So this stores an offset on the LayoutResult that's akin to what legacy flex does. What legacy does: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_flexible_box.cc?type=cs&q=clientlogicalbottomafterrep&sq=package:chromium&g=0&l=387 Change-Id: I3dd31e862c11ac3916e6b914ee34d46afa015aa9 Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018085 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736685}
-
Joon Ahn authored
In order to have quantitative confidence in our crash sending system, we should add a new metric that tracks all the crash collection events at the collection site. This way we can see (# crash report / UMA frequency) to get a % confidence. Bug: chromium:1045219 Change-Id: I5dce6080abde69ce86cf45f32aa0724fdc4e9192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992007 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4dcd39d..e58dfbd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53bafbe7d28941c382b2697b986c3071f560d83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028474Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736683}
-
Yuchen Liu authored
This is to support EME persistent usage record on Cast. Bug: internal b/142677685 Test: Build, test page together with other CLs. Change-Id: I0baccaba979a457990d3ffc584dc25d24191efcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023515 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#736682}
-
Donn Denman authored
This changes the Translation experiment to force the Long-press experiment to also be enabled, that way you only have to flip one flag to get the right semantics (since our Translation effort is gated on the Long-press triggering experiment). Also fixes a typo in ChromeFeatureList.java -- the Feature name is plural. BUG=952401 Change-Id: Ia6f185d8ee0a4bb4c28486f30d98600f048741e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028758 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#736681}
-
Michael Spang authored
This reverts commit 4b7ef458. Reason for revert: Some symbols aren't being stripped out of Cast binaries, and there are developers that prefer we keep the inline symbols for those. We may want to bring this back if developer tooling is able to run asan_symbolize transparently so that we always see the full detail. Original change's description: > Enable print_unsymbolized_stack_traces on Chromecast target builds > > Chromecast cross compiled builds are always stripped before being > deployed to the target, so local symbolizion doesn't work there. > > Enable print_unsymbolized_stack_traces in this config to ensure traces > are in a consistent format, which should be post-processed with > asan_symbolize.py. > > Bug: 1040148 > > Change-Id: Ib133644336beba363faf0efe7792d8bee62531c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991727 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729569} TBR=thakis@chromium.org,spang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1040148 Change-Id: Id24f91b47061313c2361e1d9f97d06ec7b1d505c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029447Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736680}
-
Regan Hsu authored
Move AddPrintingStrings that are OS exclusive from browser settings string provider to OS settings strings provider, copy one string "printingPageTitle". Bug: 967888 Change-Id: Ib54ddfc0f860244d8f49cc0e23edd26745c6b6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028185 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Karthikeyan Ramasubramanian authored
When the system firmware update includes MRC training update, it can cause the system to boot slower after the update is applied. Currently a user notification is generated regarding the slow boot. This CL generates an additional shutdown confirmation dialog to the user highlighting the same. Here is the screenshot capturing the confirmation dialog: https://screenshot.googleplex.com/8przUKEDrRz Pressing "Continue" button in the screenshot will continue with the restart. Pressing "Do it later" button will cancel the restart. Also added a test case to UpdateNotificationControllerTest to verify the same. Ensured that all the tests in that test suite ran successfully. Bug: b/129056373 Change-Id: Iba3b53dffad9216e1e18a94fc80328d2cbdae4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001740 Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736678}
-
Yi Gu authored
compositing/overflow/composited-scroll-with-fractional-translation.html is no longer failing consistently[1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=compositing%2Foverflow%2Fcomposited-scroll-with-fractional-translation.html TBR=bokan@chromium.org Bug: 736052 Change-Id: Ic7e1b4bddb42a1b6cf1859766009274936b5b52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029251Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
-
