- 31 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c2928bb0d5f..241f08018af3 2020-08-31 johnstiles@google.com Add helper function for inlining argument lists. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ie221e170585e0272545d2c9ee89c5e910dfbf4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803218}
-
Olesia Marukhno authored
The first time when match changes its height, pedal button is misplaced and overlaps with another match. This was caused by setting wrong bounds for button row. Bug: 1121934 Change-Id: I297a3551c370f8efd7c4079e14b9c6fcace70e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385378Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#803217}
-
ckitagawa authored
We are seeing some possibly statistically significant memory increases with the show on startup experiment. One avenue to optimize is to only capture when the tab is hidden with the activity (may avoid capturing renderer staying around too long). Pros: - Probable reduction in memory usage - Fewer captures/disk-usage Cons: - Possibly there are scenarios where the user was on the tab switcher or in another state where we won't have hidden the tab with the activity meaning fewer cases where we have a capture to show. - We need to re-add this behavior for the tab-switching experiment where we need to capture on all hides anyway. Bug: 1123523 Change-Id: Icbb5e71b6255d32670dea558e63e4aba00a77506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382224Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803216}
-
Noah Rose Ledesma authored
Crashes have been observed on OSX canary builds that are likely due to an absence of a default device. This change removes the assumption that a default audio device will always exist from the device provider and UI. Bug: 1123043 Change-Id: I6983d2086b704274990e3019277976b9ffffa494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381810Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#803215}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.14-r1 to 86-4183.59-1598262024-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7ec949bac5738863ff614067311b3eee53a1b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385693Reviewed-by:
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I8391d3e66cd5395e8107f43d680b9057446f14ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385302Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803213}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iad9f9a167eda67d20d9e99861804a1f2183fe3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385455Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803212}
-
Anupam Snigdha authored
It is really not necessary to DCHECK whether the TSFBridge instance is null or not as the caller does check for null. Bug: 1115355 Change-Id: I256ec204e35bb3a3b76cedb7adffee7b2e856ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385978Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803211}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.14-r1 to 86-4183.74-1598264968-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id38e8eb7b09dbb8c8f7205a9168211576f898c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386076Reviewed-by:
-
Wenbin Zhang authored
This is the CL to disable reference builds on all testers from perf waterfall. Bug: chrmoium:1108663 Change-Id: I26152451b80094fb301552fefe8f4270d7faa732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378786Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803209}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.14-r1 to 86-4183.74-1598267562-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie7d062da0a550e99b4e31cb9c4500bf9a2a58df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386075Reviewed-by:
-
Xing Liu authored
This CL extendsd the flag expiration date for a few download related features. Bug: NONE Change-Id: I4393f74e095a150ff204a7a1494946a2f434beb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385977Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803207}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I80662cfab027d52340d006c895cb2297de45b2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385415Reviewed-by:
-
evliu authored
This CL adds a command line switch that enables the kLiveCaptionEnabled preference which will make it easier to add Swarming tests. Bug: 1122784 Change-Id: I27f0f4ae4a0b19b97f454336f1ca5f372b1e50cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382961Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#803205}
-
Prashant Nevase authored
The virtual tests for dark mode were scattered in virtual test directory. This patch moves them in web_tests/dark-mode, a single real directory. The dark mode has two main categories of the tests viz. colors and images. The tests are now organized in these categories. The web_tests/dark-mode runs tests in normal mode. The virtual tests run the tests in dark mode with additional arguments. Bug: 1116914 Change-Id: I5c8dfc9b6085e5d70475a82d018c25482f53fb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377037 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#803204}
-
Yue Zhang authored
This CL prevents default undo closure snack bar from showing when a closure happens within TabGridDialog. We use the visibility of TabGridDialog as a proxy to decide whether a closure happens in dialog. This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. Bug: 1119899 Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803203}
-
Andrew Grieve authored
Java code can have per-target lower-than-default min_sdk_versions, but the same is not true for native code. In order to increase min_sdk_version for native code, it must be done globally. Bug: 1116198, 1119402 Change-Id: Id6e55027f57bae26fc13b4338c4b16c462dfacf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367649Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803202}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: Iae5980e46b154f0ec170c92f37d602b91ff5a854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385358Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803201}
-
Brian Sheedy authored
Adds a test for exercising Telemetry's hung renderer detection/crashing code. If Telemetry detects a hung renderer, it should crash the hung renderer process and the GPU process so that we can get minidumps to diagnose the root cause. Bug: 1119564 Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0940e75ccf4aaa92b856ccf13e2d6ec5e52a4e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385439Reviewed-by:
-
Peter Wen authored
Remove test-specific suppressions. If and when we enable lint on test targets again, blanket testonly suppressions should be added to lint.py instead. Fix some WrongConstant issues. These are useful to understand and make sure we are passing the right @IntDef and @StringDef variables to android APIs. Bug: 1116130 Change-Id: I43bea517bca2436f2063829fe74d280b5df6bca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375700Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803198}
-
Sadrul Habib Chowdhury authored
If a CompositorFrame includes new updates from the main-thread, then that frame should be treated as having complete update, rather than partial update, even if the main-thread update is not for that specific begin-frame. BUG=1115376 Change-Id: I9987e77a3357c1c5eeb895514e584e780628fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381731Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#803197}
-
Vladimir Levin authored
This patch renames RenderPass and associated types to CompositorRenderPass to distinguish it from AggregatedRenderPass. R=weiliangc@chromium.org, magchen@chromium.org Bug: 1106418 Change-Id: Ia1ab7199473d960df4ea5ce715476d2c4c290a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380730Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803196}
-
Geoff Lang authored
Bug: chromium:1115621 Change-Id: I00580d92c3b33ac84d3a9509bb94fc76f810cf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378753Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Panos Astithas authored
Bug: 646113 Change-Id: I4e16b3db222dd2a5b4084adfbecb601e1a97e355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368323 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#803194}
-
Kalvin Lee authored
We erased the effective_uri_ member of the Printer class in https://crrev.com/c/1551683; this CL erases its declaration in the header file. Bug: chromium:838677 Test: CQ passes Change-Id: I2a6307cf0a56b32ec30375aeaeeafc1f15fb3f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382684Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803193}
-
Daniel Classon authored
Link "Time Zone" search result in the case the setting appears on the subpage as well as the main section page, making the setting accessible for deep linking. Bug: 1084154 Change-Id: I68ec9fabbce8cf25b25779b2f694efa5965e3db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382885 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803192}
-
Sadrul Habib Chowdhury authored
The test wants to send a begin-main-frame for every frame. However, posting a task on the main-thread to request 'begin main frame' can be too slow in some configs (e.g. in asan/tsan etc. builds). There is a more direct way of forcing a 'begin main frame' to be issued directly from the compositor thread through LayerTreeHostImpl. So use that to have a more deterministic behaviour. BUG=1115376 Change-Id: I9ba0304be6f271f9b8025bcd2d82ce1470e9fd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383313 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2f99b8ecd4118707dc535d15ed3d07c727dce653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382078 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#803190}
-
Maksim Ivanov authored
Fix a typo (wrong variable) found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3a546274cb3efbc9226cccb86dc37fea89771e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385463Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803189}
-
Jae Hoon Kim authored
Preloading times out for large DLC images because the hash takes too long. F20 provisioning can resolve this issue for tests that currently depend on preloadable DLC images. BUG=b:164310699 TEST=unit_tests # --filter=*Dlc* Change-Id: I919004d7081de6e93aa26113f931ac1c0154e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381052 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#803188}
-
arthursonzogni authored
COOP reporting is gated behind: 1) An Origin Trial: https://developers.chrome.com/origintrials/#/view_trial/2780972769901281281 2) Use of the Cross-Origin-Opener-Policy(-Report-Only) HTTP header with the "report-to" attribute. 3) The following features used as "kill-switch": - CrossOriginOpenerPolicyReportingOriginTrial - CrossOriginOpenerPolicyAccessReporting This patch turns the flags from (3) on to match with the future finch config. [specification]: https://github.com/whatwg/html/pull/5518 [explainer]: https://github.com/camillelamy/explainers/blob/master/coop_reporting.md [intent-to-prototype]: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h5s3SMpF8QI [intent-to-prototype-review]: https://docs.google.com/spreadsheets/d/1g8sekkR7J_nYf5WFUSkgllxujrZEYD-R77K4vofDVm8/edit#gid=1681607078&range=H309 [intent-to-experiment]: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/JhRU2d7RQ_k/eu5Jx3jIAwAJ [intent-to-experiment-review]: https://docs.google.com/spreadsheets/d/1g8sekkR7J_nYf5WFUSkgllxujrZEYD-R77K4vofDVm8/edit#gid=1681607078&range=H404 Bug: 1116413 Change-Id: I2ca66ce3a9228602ff2e471b9b7b8f6cde418e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379774Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803187}
-
Tomasz Moniuszko authored
mock_tsf_bridge.cc was compiled as a part of //ui/base:test_support and //ui/base/ime/win:win. This caused link errors in some configurations as MockTSFBridge symbols were duplicated. //ui/base:test_support depends on //ui/base/ime/win:win so mock_tsf_bridge.cc is redundant there. Bug: 968222 Change-Id: Ibc159c336c0feef285e1066d3dc73c57c62b981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379764 Commit-Queue: Yohei Yukawa <yukawa@chromium.org> Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803186}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 096493df. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I48bc26d7a872f235a9d664dfa56856a7b7c9f76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385637Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803185}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0d24fdc82118ff3d62609500d859507742a8cb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383653Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803184}
-
Nohemi Fernandez authored
Fixed: 464306 Change-Id: I561a1465616f16103c285620e8689b761f5a07a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385338Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#803183}
-
Sean Gilhuly authored
Test names can only contain alphanumeric characters, plus underscores. testing::PrintToStringParamName() stringifies tuples using characters that aren't valid for test names. Add a similar function which joins each element using underscores. This will generate valid names for test parameterization, provided each element of the tuple can be written using valid characters. Bug: 1092945, 1117587 Change-Id: I868b1d4040a93bdbf763dbb45b94ff15f181dd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376882Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#803182}
-
Becca Hughes authored
Using the frame on the NTP to load the data is too slow for what we want to do so this removes the frame and does the fetching in C++ instead. The deserialization and business logic is still handled by the JS but on the NTP instead of in a child frame. BUG=1121360 Change-Id: Idad8c9403fd51cccaf4a8edff31d244ac2642432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373384Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Since default apps' installation isn't urgent, it's fine if they take a bit more time to install. This saves precious CPU cycles during fresh profile startup, when Chrome is already busy doing a bunch of other stuff. There are 2 benefits: (1) Other extensions that install at the same time install faster (e.g. force-installed extensions) (2) It reduces jank during the first-run experience (FRE), especially for lower-end/older CPUs, and virtual machines. Since the FRE has fancy CSS animations, the jank is noticeable. Before/after trace comparison: https://imgur.com/a/o9Y0Dqv Bug: 1103447, 904486 Change-Id: I4b9f2eecf71c3414a36769d896296d4f089c81a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377888Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#803180}
-
Wojciech Dzierżanowski authored
`player_id_` identifies MediaSessionControllers in MediaSessionImpl. The possibility to mutate it left the door open to failing to unregister a MediaSessionController from MediaSessionImpl on destruction. That could lead to a use-after-free of MediaSessionController in MediaSessionImpl. Bug: 1115478 Change-Id: Ib309b09345be9c6da2668a40100297942118b578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353250 Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
-
