- 01 Nov, 2019 40 commits
-
-
Joshua Pawlicki authored
Bug: 1020330 Change-Id: Ia6aa7442290c5af37c56e387c17cd609ed6467b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894265 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/385f3caebd48..d2af989b003e git log 385f3caebd48..d2af989b003e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 eseckler@google.com processor: Replace pbzero includes in importer headers with fwd decls Created with: gclient setdep -r src/third_party/perfetto@d2af989b003e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:130786981 Change-Id: I6a8bd3b5ad937c6ad9d221e0a6b2313ebb4bc8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711681}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/736b04307a..0c74f23ba9 TBR=sigurds@chromium.org Change-Id: Ib6f2e121d8936255172f9926690739806e349430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895191Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711680}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec, kMiscPlatformAPI if it's not speced yet or kInternalDefault if it's a non-spec-related task. R=falken@chromium.org Change-Id: Ib693ffc41d9c096f3ed6d4e4ab9797cf8fdd1773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888031Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711679}
-
Elly Fong-Jones authored
This change removes DialogDelegate::CreateExtraView, replacing it with a non-virtual method DialogDelegate::DisownExtraView that simply hands back the view provided via DialogDelegate::SetExtraView. An earlier iteration of this change (CL 1881312) went further in adding DialogClientView::SetExtraView() and having DialogDelegate push the extra view to DialogClientView. This broke a bunch of tests in a subtle way: the obvious place to call DCV::SetExtraView was from DD::OnWidgetInitialized. DCV::SetExtraView would then add the new view to DCV, which would invalidate its layout. However, many tests were doing essentially this: TestDialogDelegate delegate; ShowBubble(&delegate); TryToUseExtraView(); and then trying to use the extra view's bounds, most commonly by synthesizing mouse clicks on it. At this point the extra view's layout is invalid *but* it has not yet been laid out, because View::InvalidateLayout schedules a deferred re-layout later. The design where DCV pulls the extra view from DD doesn't have this issue: during the initial construction of DCV, DCV fetches the extra view and slots it into its layout, and then the initial layout pass in Widget::Init causes the extra view to get laid out. Deferring inserting the extra view until after Widget::Init has finished is what causes the extra view to not be laid out (and hence the tests to fail). It's not obvious how to fix this: 1) The tests could manually force a re-layout here, or 2) The tests could be rewritten to not depend on the extra view's bounds, by not trying to deliver mouse events to it somehow, or 3) DCV::SetupLayout could always force an explicit Layout, ignoring the lazy layout system in View::InvalidateLayout None of these seem palatable, so I'm shelving that specific problem and the general cleanup of the interface between DialogDelegate and DialogClientView until a later date. Bug: 1011446 Change-Id: I9641c6306756fd5702a8e9b60558e3223a02f73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887835 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711678}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ce01db4f59d..f28e9facdd3c git log 1ce01db4f59d..f28e9facdd3c --date=short --no-merges --format='%ad %ae %s' 2019-11-01 perezju@chromium.org [Telemetry] Clean up more story_runner unit tests Created with: gclient setdep -r src/third_party/catapult@f28e9facdd3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1008852 Change-Id: I8a78d1ca68e59dd592a66ba7168b0a08253b2d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895157Reviewed-by:
-
Francois Doray authored
The --disable-best-effort-tasks switch was only read when a task execution fence was created. This CL ensure that it is read even if there is no task execution fence. It also adds a test to verify the behavior and avoid future regressions. The TabCapturePerformanceTest.Performance test used --disable-best-effort-tasks to ensure that the test can pass without BEST_EFFORT tasks. Prior to this CL, this flag only prevented BEST_EFFORT tasks from running in the browser process. With this CL, it also prevents BEST_EFFORT tasks from running in renderers and utility processes. Since the test needs BEST_EFFORT tasks to run in utility processes for tracing, this CL changes --disable-best-effort-tasks to ScopedBestEffortExecutionFence. The ScopedBestEffortExecutionFence only prevents BEST_EFFORT tasks from running in the process where it is used (keeps the test's existing behavior). Bug: 839110 Change-Id: I4ef104ccabb81840cbb48d309e1ed3baaa20feda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872654Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#711676}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec, kMiscPlatformAPI if it's not speced yet or kInternalDefault if it's a non-spec-related task. R=falken@chromium.org,peter@chromium.org Change-Id: Id82556a9da16d0d04acdaf4eed7a9604e8796172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891290Reviewed-by:
-
Juan Antonio Navarro Perez authored
Ensure benchmark names match the regex r'^[\w._-]+$'. Bug: 994187 Change-Id: I2209c2a7c98c638a1e8aa3ad925b1efdc0be6499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886900 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711674}
-
Juan Antonio Navarro Perez authored
To debug testRunPerformanceTestsTelemetrySharded_end2end, add more information and a better formatted output to help figure out the cause of problems when things go wrong. Also re-enable the test on linux to see if previous failures reoccur. Bug: 996003 Change-Id: I86ed6ca3c03943674bc77483688ea24fa5193225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886680Reviewed-by:
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of DOMException, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: Ic11d5b0528ce909faa641ec01047ec2ef4d88775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890404 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711672}
-
Armando Miraglia authored
This reverts commit e4e0b509. Reason for revert: same reason as first revert (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280) which is causing problems on Mac10.10 and Mac10.12. Reland was based on an incorrect analysis. Original change's description: > Reland "Fix about:webrtc-internals "Stats Tables"" > > This reverts commit 2302c7e1. > > Reason for revert: relanding because without win-build-perf is broken (possibly needs manual work). > > Original change's description: > > Revert "Fix about:webrtc-internals "Stats Tables"" > > > > This reverts commit f61878bc. > > > > Reason for revert: [sheriff] it looks very likely that this change caused a crash in WebRTCInternalsIntegrationBrowserTest.IntegrationWithWebRtcEventLogger (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280). > > > > Original change's description: > > > Fix about:webrtc-internals "Stats Tables" > > > > > > This is a fixup CL of [1] spotted and report by hbos@chromium.org > > > on [2]. > > > > > > [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) > > > [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 > > > > > > Basically the original CL was supposed to replace the code > > > that used to bound PeerConnectionTracker to its associated > > > mojom::Receiver instance in [3] by the corresponding code in > > > Blink. > > > However, the replacement code got accidentally missing while rebasing > > > the CL over and over. > > > > > > [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 > > > > > > This CL amends the original CL with the proper code in > > > blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). > > > > > > TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ > > > --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 > > > > > > Manual test= Open Chromium load about:webrtc-internals and [4]. > > > It is expected that WebRTC statistics appear. > > > > > > [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 > > > > > > R=haraken@chromium.org > > > TBR=guidou@chromium.org, hbos@chromium.org > > > > > > BUG=787254 > > > > > > Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293 > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#711647} > > > > TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com > > > > Change-Id: If20ddd5622f30af1bfe1a8ca7d3b041b605bc7b2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 787254 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895195 > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > Commit-Queue: Armando Miraglia <armax@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711665} > > TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,armax@chromium.org > > Change-Id: I4bac5da3cae4161f788ac0d1ef602bccb1419da7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 787254 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893868 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711668} TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,armax@chromium.org Change-Id: Iad30a7ae431a5d5839f49a16c2f644d90a12a1f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895196Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711671}
-
Eric Seckler authored
Enables perfetto service to emit clock snapshots when tracing Chrome. This is required to correctly import traces specifying a clock other than BOOTTIME (Android, Linux, Fuchsia). Since perfetto snapshots all clocks, this requires relaxing the syscall filter of the sandbox to also allow CLOCK_BOOTTIME & CLOCK_MONOTONIC_RAW access. Bug: 1018134 Change-Id: I98e9ffee97bda4381da7170d917c3bd83beecaff TBR: hidehiko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879894 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711670}
-
Armando Miraglia authored
TBR=dpapad@chromium.org Bug: 1020490 Change-Id: I853e6eb07357bdff23435577edc88fb93e5b12c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895331Reviewed-by:
-
Armando Miraglia authored
This reverts commit 2302c7e1. Reason for revert: relanding because without win-build-perf is broken (possibly needs manual work). Original change's description: > Revert "Fix about:webrtc-internals "Stats Tables"" > > This reverts commit f61878bc. > > Reason for revert: [sheriff] it looks very likely that this change caused a crash in WebRTCInternalsIntegrationBrowserTest.IntegrationWithWebRtcEventLogger (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280). > > Original change's description: > > Fix about:webrtc-internals "Stats Tables" > > > > This is a fixup CL of [1] spotted and report by hbos@chromium.org > > on [2]. > > > > [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) > > [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 > > > > Basically the original CL was supposed to replace the code > > that used to bound PeerConnectionTracker to its associated > > mojom::Receiver instance in [3] by the corresponding code in > > Blink. > > However, the replacement code got accidentally missing while rebasing > > the CL over and over. > > > > [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 > > > > This CL amends the original CL with the proper code in > > blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). > > > > TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ > > --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 > > > > Manual test= Open Chromium load about:webrtc-internals and [4]. > > It is expected that WebRTC statistics appear. > > > > [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 > > > > R=haraken@chromium.org > > TBR=guidou@chromium.org, hbos@chromium.org > > > > BUG=787254 > > > > Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711647} > > TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com > > Change-Id: If20ddd5622f30af1bfe1a8ca7d3b041b605bc7b2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 787254 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895195 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711665} TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,armax@chromium.org Change-Id: I4bac5da3cae4161f788ac0d1ef602bccb1419da7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893868Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7f680a638e96..8f062cdaa7fd git log 7f680a638e96..8f062cdaa7fd --date=short --no-merges --format='%ad %ae %s' 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8f062cdaa7fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Idfd09658cf1e078e76fb2ba522701ebb0688a988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895213Reviewed-by:
-
Clemens Arbesser authored
This CL adds support for an additional image with an optional subtitle. The image is rendered on top of full overlays only, and is anchored to the top such that viewport resizes do not affect its position. See the linked bug for example screenshots. Bug: b/143452916 Change-Id: Ic974b2e0f622edd2a917d1f2fe54b4a4ccd33949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886851Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#711666}
-
Armando Miraglia authored
This reverts commit f61878bc. Reason for revert: [sheriff] it looks very likely that this change caused a crash in WebRTCInternalsIntegrationBrowserTest.IntegrationWithWebRtcEventLogger (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280). Original change's description: > Fix about:webrtc-internals "Stats Tables" > > This is a fixup CL of [1] spotted and report by hbos@chromium.org > on [2]. > > [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) > [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 > > Basically the original CL was supposed to replace the code > that used to bound PeerConnectionTracker to its associated > mojom::Receiver instance in [3] by the corresponding code in > Blink. > However, the replacement code got accidentally missing while rebasing > the CL over and over. > > [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 > > This CL amends the original CL with the proper code in > blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). > > TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ > --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 > > Manual test= Open Chromium load about:webrtc-internals and [4]. > It is expected that WebRTC statistics appear. > > [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 > > R=haraken@chromium.org > TBR=guidou@chromium.org, hbos@chromium.org > > BUG=787254 > > Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711647} TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: If20ddd5622f30af1bfe1a8ca7d3b041b605bc7b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895195Reviewed-by:
-
Marina Sakai authored
The name of const variables should be "k{{camel case name}}". This CL follows the style. Bug: 715418 Change-Id: I54c37152cebee1a863fceabb685480cdf08f93f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893603Reviewed-by: -
Armando Miraglia authored
This reverts commit 849315dd. Reason for revert: [sheriff] does not build on Mac per builder (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/125702) Original change's description: > Make AppMenuModel keep most submenus in a vector. > > They are only needed for ownership, so no need to give them names and concrete > types. Removes some forward declarations from the header and serendipitously > happens to remove GOOGLE_CHROME_BUILD from the header as well. > > No intended behavior change. > > Bug: 961769 > Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711431} TBR=thakis@chromium.org,rsesek@chromium.org Change-Id: Id7abf98d32a424fdf3d8d0638c9967931eec30a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893867Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie90acdb50b06f881dbdc80b2818583353d5f1c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895211Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e96039218e9d..076fae010165 git log e96039218e9d..076fae010165 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b131630e7c74..48233ad3d45b (1 commits) Created with: gclient setdep -r src/third_party/angle@076fae010165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I198caaf01234ad353d71b9922b5f98ac07ae9e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895212Reviewed-by:
-
Armando Miraglia authored
In the previous CL I incorrectly disabled TriggersOnEditDistance, since I missed to rename the test. I am ammedning this here. TBR=estark@chromium.org Bug: 1020109 Change-Id: I1ce35929dd2082ee1b27c91e7e29da743e77df26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895192Reviewed-by:
-
Eero Häkkinen authored
This CL renames CreateAlwaysUseUTF8ForText to CreateUTF8Decode and CreateAlwaysUseUTF8WithoutBOMForText to CreateUTF8DecodeWithoutBOM in TextResourceDecoderOptions. This is to make it easier to distinguish these two named constructors, to match with the spec names and to shorten the names. Bug: 796192 Change-Id: Ib3ee204b1e0c81a95ab0ca58f47def892525984e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893260 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#711659}
-
Julie Jeongeun Kim authored
This CL is a part of effort for converting mojom::URLLoaderClient to new Mojo types. It converts URLLoaderClientPtrInfo to new Mojo types using PendingRemote and keeps URLLoaderClientPtr yet. On a follow-up CL, URLLoaderClientPtr will be handled with new Mojo types. Bug: 955171 Change-Id: I659a7e0d409a8fe86e72e0dcb504fe7fa1082592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893112Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Kent Tamura authored
It was deprecated in M79. I2DR: https://t.co/ngv1jxRKwk Bug: 981720 Change-Id: I5c365aaaa65c66a4dccd7224e4ad5d482b6ad2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892971Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#711657}
-
Chih-Yu Huang authored
When we allocate frames with new layout, we always need to know the maximum number of frames. This CL combines SetMaxNumFrames() and NegotiateFrameFormat() to RequestFrames() to simplify the interface. BUG=b:136716638 TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest* TEST=video_decode_accelerator_tests on Kevin and Eve Change-Id: I7c194a9107319f1a91da961140548216d2240e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861437 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711656}
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of NamedConstructor, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: I2e56fbf6354643f7d81e15774bb8774e98048288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895020Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95bb5f86b1c0..05ff793e61e6 Created with: gclient setdep -r src-internal@05ff793e61e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6dd00adbd986e800813f48d21c129fb4a6208e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711654}
-
Tsuyoshi Horo authored
Bug: 1018640 Change-Id: Ifeed5db772abface2d6ed9a6b12c3f6e0a8481e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893127Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711653}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the VideoSourceProvider mojo interface (from video_capture service) using the old APIs to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: I321f8d47bd0efc12bc054ad13e4ac44f02516da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886854 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711652}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the VideoSource mojo interface (from video_capture service) using the old APIs to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: Ib647a30ca7c95683bf9edca0e89d7bba1ce53d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886893 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of Global, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: I12c60681dfa521d30dd4ec88f9cc9887e1770541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895094Reviewed-by:
-
Marina Sakai authored
The function CreateCachedV8Private, which is not recommended to use because of calling ForApi(), is called only in one place. So, this CL writes the contents of the function directly in the place where uses the function, and removes the function. The macro V8_PRIVATE_PROPERTY_SYMBOL_STRING is also called only in one place. So, we replace the macro with a constant string. Bug: 715418 Change-Id: Ie136200f3b87d760aa79556f835c8438e8ad47ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893602Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3940.0-1572257069-benchmark-79.0.3945.20-r1 to 80-3940.0-1572255699-benchmark-80.0.3951.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Iafdc442ccf05d89a137253a452b07de5ab56b52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895152Reviewed-by:
-
Antonio Gomes authored
This is a fixup CL of [1] spotted and report by hbos@chromium.org on [2]. [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 Basically the original CL was supposed to replace the code that used to bound PeerConnectionTracker to its associated mojom::Receiver instance in [3] by the corresponding code in Blink. However, the replacement code got accidentally missing while rebasing the CL over and over. [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 This CL amends the original CL with the proper code in blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 Manual test= Open Chromium load about:webrtc-internals and [4]. It is expected that WebRTC statistics appear. [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 R=haraken@chromium.org TBR=guidou@chromium.org, hbos@chromium.org BUG=787254 Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711647}
-
Daniel Cheng authored
The JSON files that are merged by the helper script generally contain a lot of values. The regex matcher in Python is quite optimized, so it's faster to combine identical cases with '|' rather than adding multiple merge helpers that execute the same thing. Savings when run locally on my dev machine are around 500ms-1000ms. Bug: 1014845 Change-Id: I36af02140b5efa2cbd306f7f1fb6c26f93f37a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894416Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711646}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie4d22e3f2fc9bbdc1396cc26343d036cfd317063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893299Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711645}
-
Maggie Cai authored
This CL adds a method to add a preferred app with specific intent filter to ARC. Currently the existing method uses the previous queried intent info in the ARC code base, however, with the new intent handling implementation, the query happened in Chrome OS and ARC does not have this information anymore, we need to send the corresponding intent filter to ARC to be able to set the preferred app. BUG=853604 Change-Id: I7b3bf11deb920aadd9f6421d9f05d313bbdd8850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882194 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711644}
-
Ken Rockot authored
This switches extensions code to the new DataDecoder API. As a result none of this stuff depends on the Service Manager anymore so a bunch of Connector plumbing and awkward test setup is also deleted here. Bug: 977637 Change-Id: Ib4e995c75673e349c165aeb375bd78d4d7eb43af Tbr: poromov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881807 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711643}
-
