- 09 Oct, 2020 40 commits
-
-
Jimmy Gong authored
- Responsible for sending requests for displaying the notification access setup UI to the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: If00b19664b4dd6240558e48b4bf5bb45c98e2723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453511 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815448}
-
Darwin Huang authored
Refactoring change only. No functional change. Change-Id: If333b87c14cf8c9e06cd3bae544c5e71ce998678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458825 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815447}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602179909-33e9e654a138340f2ff74cc84be2567f323eeba5.profdata to chrome-mac-master-1602201537-11aed398f2fb6b4c095a189eb8886f38c679c48f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I404f00803d14f78b77bd85afaec9e1ba3bedb46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815446}
-
Clark DuVall authored
Review from Patchset 1 to get the right diffs on the changes in ChromeBackupAgentImpl. Bug: 1126301 Change-Id: I441e3dc4cf098212d6170db7f3913ef2edbc2066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461221Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815445}
-
Jing Wang authored
In some edge cases, these function may return nullptr which will crash chrome. TEST=passed unit tests and browser tests BUG=1121330 Change-Id: I4863ac4a43b5dcdae684f948abbf40d627c4ab9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462745Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815444}
-
Tarun Bansal authored
Bug: 1130607 Change-Id: If75e1cd436fc5383f5c786e95a6525f35606f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462625 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#815443}
-
Hajime Hoshi authored
Bug: 1136687 Change-Id: Ic4b355611010a70ce4ae903c948fb67ed2a02ad9 Tbr: danakj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462755Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815442}
-
Brian Geffon authored
Because the pagemap uses the term present instead of in core we will rename those methods. Additionally, we add a little helper called IsFullyPresent. Bug: chromium:1067833 Change-Id: I98099cdd1afa5ed0bc3ded3f22592000719281a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462687Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Auto-Submit: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815441}
-
Kenichi Ishibashi authored
This CL moves tests in ServiceWorkerStorageDiskTest to ServiceWorkerRegistryTest. These tests check that some fields of ServiceWorkerVersion and ServiceWorkerRegistration are appropriately set after simulating shutdown. Such tests should be moved to other place so that service_worker_storage_unittest.cc can be moved to the Storage Service. Bug: 1016064 Change-Id: I5d7deb91abc3a5d017aa2871cde152f6eabc5e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462747Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc36658f1442..557d8bce351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126301 Tbr: hajimehoshi@google.com Change-Id: I3986bffa31ced4c09e28179f68e16b15c92ae997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462603Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815439}
-
Thomas Guilbert authored
Currently, when using AAudio, we treat device changes like any other error, which causes video playback to fail when plugging in headphones. This CL changes this so we intercept device disconnection errors, and report them as kDeviceChange errors to the OutputController, which forces the graceful creation of a new stream. Bug: 1136559 Change-Id: I7969ad3edac2b7bbc9a3e2271f423cf7a029e7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462340 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815438}
-
Moe Ahmadi authored
Adds Fieldtrial params to be used for fine-tuning the frecency score of local repeatable queries. These params allow fine tuning of the age threshold, recency decay, and frequency exponent of the score. The default values match those in http://shortn/_VLAOJTxx6J Bug: 1110077 Change-Id: I6d2cd1452d02c1133c7e2f6232b25168d81408da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422427 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815437}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I2e4e8c883f4b6192ec4ec0aac048835a483c43b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815436}
-
Zentaro Kavanagh authored
- Will later hold a list of routine results with the ability to update the status of the items Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Iaebb25b50b7fc35c8dbf67043e495762e3f2dec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462381 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815435}
-
Andrey Kosyakov authored
TBR: altimin@chromium.org Bug: 1136683 Change-Id: I92fd979c419639a618a05920d1475a2afb6efd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462570Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815434}
-
Yoshifumi Inoue authored
This patch changes |TextOffsetMapping::InlineContents| not to use |LayoutRubyAsBlock| as container to avoid invalid DOM range. In <ruby>abc<rt>XYZ</rt></ruby>, before this patch |InlineContents| use <ruby> as container and having range start with <rt>@0 and "abc"[3] because in layout tree, <rt> comes before "abc". After this patch, we make |LayoutNGRubyRun| and |LayoutNGRubyBase| as container but |LayoutNGRubyAsBlock|. Layout tree: LayoutNGRubyAsBlock {RUBY} at (0,0) size 784x27 LayoutNGRubyRun (anonymous) at (0,7) size 22x20 LayoutNGRubyText {RT} at (0,-10) size 22x12 LayoutText {#text} at (2,0) size 18x12 text run at (2,0) width 18: "XYZ" LayoutNGRubyBase (anonymous) at (0,0) size 22x20 LayoutText {#text} at (0,0) size 22x19 text run at (0,0) width 22: "abc" Bug: 1124584 Change-Id: Id4006630a87127a6af2d1a5044a07e253457f8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460551 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815433}
-
Zentaro Kavanagh authored
- This is will represent a line item in the list of routine results Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I597f8f1d03e13d413978c185fa97a72611fe2072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461720 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815432}
-
Hidehiko Abe authored
This CL introduces new AppType, called LACROS, and annotate it to the Lacros windows. Ran tast run ${DUTIP} lacros* Bug: 1090663 Test: Ran locally, and made sure AppType is annotated. Change-Id: I56c38ed03a655de8870fad298b962656f2b6156f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449830 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815431}
-
Roman Arora authored
Bug: 1128599 Change-Id: Ibbf2b73ab4da67ce5cfc6130bbef860b0ee21132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459126Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#815430}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02a7aa75bb24..628c64d7a14c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c306321de442c3d9b87fb6cc5c2ba96557fd41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815429}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I274a1e66cc2959f5e3655d7e0655293a1a4f6eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462349Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815428}
-
John Lee authored
This CL replaces everything after the '#' if it exists in a URL to avoid chaining multiple refs such as #anchor#:~:text=selected%20text. Bug: 1136468 Change-Id: I22583af358c1169a2b97bfad12d2e75a2d8e172c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460797Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815427}
-
Eric Willigers authored
As DesktopPWAsWithoutExtensions are enabled and shipped, we no longer need to mention the flag in tests. Bug: 1065748 Change-Id: I643757798cbe6ee1972a26d39e9df8f9dc7ef903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454353 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815426}
-
Maggie Chen authored
Syntax: drop-shadow(offset-x offset-y blur-radius color) The maximum pixel movement needs to include offset-x, offset-y, and blur-radius. Although blur-radius is optional, we still need to consider it. This CL adds Blur-radius to the comparison formula. Bug: 1064390 Change-Id: I3b9579335086bfda808c99cc263fdbcc8210fd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453338Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815425}
-
Jeffrey Kardatzke authored
This adds a buildflag that enables handling encrypted content in the HW accelerated video decoders for Chrome OS. Initially this will be for VAAPI only. No builders are enabling this flag yet, it is still in development. BUG=b:153111783 TEST=Built/deployed Chrome with flag enabled/disabled Change-Id: Idcf50f3c302d619f8586306db9cf85164e051dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461993 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815424}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/628c64d7a14c..7c2d888fdffc 2020-10-08 treehugger-gerrit@google.com Merge "trace_to_text: make endian functions portable" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia18bfebbb7450519cf9eb92db07214f75bbdf0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815423}
-
Leonid Baraz authored
Bug: None Change-Id: Ic04c54b9b5db82f9c17d5abd2b4e79b2b9e15dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461748 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#815422}
-
Jeffrey Cohen authored
Downstream CL https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3314008 Bug: 1093386 Change-Id: I03a48bfc29cdb2ccdaae4e854cc08dc39b2ca3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451570Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815421}
-
Sunny Sachanandani authored
Changes since initial patch: 1) Fix hardware overlay support detection in trace_integration_test.py. 2) Add trace test failure suppressions for newly added tests. Original change's description: > gpu: Remove obsolete direct composition feature flags > > Remove the NV12, decode swap chain, and underlay feature flags since > these features have shipped for quite some time. The NV12 feature flag > was also used for using YUY2 over NV12 for tests so introduce a new flag > for choosing the default SDR video overlay swap chain format. Add tests > for NV12, YUY2, and BGRA instead of just YUY2. Also cleanup some of the > testing code to be consistent in other_args, switch names, etc. > > Bug: 869677 > Change-Id: I0831b103506f394d6fe26bf1085401e2e2d50599 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424576 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810453} TBR=zmo@chromium.org,magchen@chromium.org Bug: 869677, 1132381, 1132375 Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-win10-intel-rel-64 Change-Id: I063be532ec93ac148ecaff9403a44cdf05aa33e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442503Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#815420}
-
Roman Arora authored
Bug: 1128599 Change-Id: I821f2adb8b13cdbd8d161a6b7cd75dc667cd7be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450813 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815419}
-
Brian Geffon authored
Change-Id: I101d6093207fafe3ddf85fcccc41d56ca7b9720f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461600 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815418}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82430d69..8a9b91b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ca537d2076cc5fca6e9f2f2e9dc7f317d51a326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461635Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815417}
-
Andrew Xu authored
After selecting a menu item by MenuController::SelectItemAndOpenSubmenu(), the item's child button (if any) should be hot tracked if the selected item does not have a submenu. Bug: 1136261 Change-Id: I37d3616f716155ff9f3bcc1e22faf198d77b5e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458449Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815416}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. We no longer need to use ScopedFeatureList. Bug: 1065748 Change-Id: I68ebbc4307e295c924f198f7f702cf7718db8283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455509 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815415}
-
John Lee authored
Autocomplete seems get activated if the user has submitted a form with the same ID or name on another website. Given that WebUI does not specify names or use cr-inputs within form elements, it seems safe to assume that autocompletion on cr-inputs would in general be not helpful as they will be autocompleting off values submitted on any website that has an input with an ID of 'input'. Bug: 1134578 Change-Id: I066bdd74ac60274346113b03489a98797c2f3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453589Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815414}
-
My Nguyen authored
Screenshot: http://screen/6acSzc7a52VoxFS Fix: b/165460145 Change-Id: I480bb444b6b00f7dd1df41603a1754405c31356e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460068 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815413}
-
Azeem Arshad authored
This CL updates the label for multidevice suite toggle from "Android phone" to "Connected phone features enable". This makes it consistent with other feature toggles in the settings main page. https://screenshot.googleplex.com/6PzrfqVEj2kLUNW Bug: 1009143 Change-Id: I50d0851adc5136b8c593b597fa481571ec44cc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462253 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815412}
-
Xing Liu authored
This CL moves reading list folder to be the first top level folder. Bug: 1128074 Change-Id: I720955a1a14545a7380efd019e349b81cb554e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462235Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815411}
-
Joel Hockey authored
Add feature flag for adding Trash support in My files volume of FilesApp. Bug: 953310 Change-Id: I3d06b39b77a744251a35001eb4c77bffab41383a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461508Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#815410}
-
Sammie Quon authored
This will used for a perf test. Adds an api and a supporting animation observing class which waits until the animation has been scheduled, which means the desk ending screenshot has been taken. The observing class then activates the adjacent desk. This repeats until we have reached the target desk, then we wait for the whole animation to finish and run the given callback. Test: added test Bug: 1111445 Change-Id: I9f859a2ae31da958c0d539f7e00a1a9944c3bb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437151 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#815409}
-