- 30 Jul, 2018 2 commits
-
-
kristipark authored
Bug: 851656 Change-Id: Id9927c2343c6fbdaccdcd385b1b9a50e0176d32c Reviewed-on: https://chromium-review.googlesource.com/1152519 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578957}
-
Kyle Milka authored
If the attribution link is not https or is empty the action_url in theme info should be reset. Otherwise its possible for an old action url to be displayed for a new custom background image. Bug: 868164 Change-Id: I00ca396b665c169410c33730f16c3054ec761c26 Reviewed-on: https://chromium-review.googlesource.com/1152516 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
- 29 Jul, 2018 14 commits
-
-
John Budorick authored
This CL: - groups layout tests by argument sets to reduce the number of driver restarts required when running tests w/ shards that include multiple argument sets. - updates chunking logic to match that used by //base/test/launcher, which should ensure consistent chunking across all swarming shards and ensure stable chunking given consistent chunk parameters. - fixes a small bug in http server execution and teardown. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1120431 Bug: 824539 Change-Id: Ic1a2ab34f38e8d4c15784977de792314d106e484 Reviewed-on: https://chromium-review.googlesource.com/1149418 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578955}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4f9fefc477806fff7cb71fd14d59354fb72cb79f Reviewed-on: https://chromium-review.googlesource.com/1154498Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578954}
-
Reid Kleckner authored
This should give us better Pacific time coverage for update.py and package.py changes. R=thakis@chromium.org,hans@chromium.org Change-Id: I713033f33f755fce6b4c8e5aa4387cf2d4b3a245 Reviewed-on: https://chromium-review.googlesource.com/1154043Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#578953}
-
https://crrev.com/574738Christopher Cameron authored
TBR=lgrey Bug: 863817 Change-Id: I64bb71603eb5fba012d17c953e61481c7ee5182b Reviewed-on: https://chromium-review.googlesource.com/1154357Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#578952}
-
Koji Ishii authored
Following bot results are included. 8394 8396 8403 8406 8409 8417 8427 8441 8442 8444 8447 8448 11 lines were removed and 3 lines were deflaked by consecutive results since 8394. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icbab9e03eedf3d624e84b2c704c8a952fd6e05ce Reviewed-on: https://chromium-review.googlesource.com/1152708 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578951}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd0e9db48d2e..823c88d37b4d git log dd0e9db48d2e..823c88d37b4d --date=short --no-merges --format='%ad %ae %s' 2018-07-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@823c88d37b4d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0362fcd9f4edd1017ea93ba2ec8c9ac911d1b75c Reviewed-on: https://chromium-review.googlesource.com/1154177Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578950}
-
Koji Ishii authored
From a review of build 8447. * css-grid/* are still failures, but turns one of failures into pass, and two failures fail with different values. Rebaseline because wpt wants failures built into expected, and the diff is pure improvements. * fast/parser/entities-in-* are different output of text dump for soft-hyphens. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I35c42c7ec8b7580597f1c3addb8fff95217afb3c Reviewed-on: https://chromium-review.googlesource.com/1154239 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I45de9bb3d758307b16787c6b9d8b35bf9ef62e7d Reviewed-on: https://chromium-review.googlesource.com/1154437 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578948}
-
Peter Boström authored
The current 18dp fixed height results in pushing the total button height on Mac. This doesn't happen by default on Windows as the default font results in equal size_delta values for 18dp and 17dp available height. This probably means that 17dp is the actual available height that doesn't increase the toolbar-button height. Bug: chromium:862514, chromium:868442 Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3 Reviewed-on: https://chromium-review.googlesource.com/1153574Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578947}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ib9e20055672b7c44bef0ba00106dd3b7017c49cd Reviewed-on: https://chromium-review.googlesource.com/1154352Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578946}
-
Victor Costan authored
This CL uses the passkey idiom recommended in https://abseil.io/tips/134 to restrict APIs in sql::Connection to sql::Recovery. Test APIs are exposed via a peer class, following recommendations in the same tip. This CL also exposes sql::Connection::page_size(). Asides from being used in sql::Recovery, this can be useful in unit tests. It is worth noting that set_page_size() is a widely-used part of the sql::Connection API, so page_size() does not introduce a new concept. Last, in order to make page_size() intuitive, this CL removes the possibility of having sql::Connection::page_size_ be zero. Instead, SQLite is configured with an explicit SQLITE_DEFAULT_PAGE_SIZE (matching the current default), and page_size_ is initialized with sql::Connection::kDefaultPageSize, which is guaranteed to match the SQLite configuration. Bug: none Change-Id: I555a0bcf02f12ee006bbfc1a91080d7c0b8845d4 Reviewed-on: https://chromium-review.googlesource.com/1146768 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#578945}
-
Nigel Tao authored
These are the Web App analogs of external extensions, described at https://developer.chrome.com/apps/external_extensions On start up, *.json files (often but not necessarily named external_extensions.json) are scanned in a number of directories. Prior to this CL, such .json files can install regular extensions (.crx files) or, on Chrome OS, Android apps. New in this CL is being able to install Web Apps (sometimes known as Progressive Web Apps or PWAs). For example, the chrome::DIR_USER_EXTERNAL_EXTENSIONS path (defined in chrome/common/chrome_paths.h) can correspond to file system directory like "$HOME/.config/chromium/test-user/.config/chromium/External Extensions". Placing a foo_bar.json file containing: { "web_app_manifest_url": "https://www.chromestatus.com/static/manifest.json", "web_app_start_url": "https://www.chromestatus.com/features" } in that directory will install the Chrome Platform Status web app. Bug: 855281 Change-Id: I716fead81d407076a0dda32f5c0b3e8869351c83 Reviewed-on: https://chromium-review.googlesource.com/1127214 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#578944}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42c75b14f495..d1d8f9815d76 git log 42c75b14f495..d1d8f9815d76 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 buildbot@webrtc.org Roll chromium_revision 743fc877..2d5685c1 (578837:578940) Created with: gclient setdep -r src/third_party/webrtc@d1d8f9815d76 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic21cf9a145c27aa5d81b199978f57770bb56094f Reviewed-on: https://chromium-review.googlesource.com/1154176Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578943}
-
Jinsuk Kim authored
Due to a recent refactoring, we were not creating the internal plumbing needed to show popups anymore. BUG=868238 Change-Id: I9ffcdff49a2c3a5f4de9dbda741986de765ad6a6 Reviewed-on: https://chromium-review.googlesource.com/1154039 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#578942}
-
- 28 Jul, 2018 24 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ca3b449..5279da5c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3c317d75d8bd687d2d402746ae4f8e8b90ea7cdc Reviewed-on: https://chromium-review.googlesource.com/1154324Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578941}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e00185925aa..3b438311bbf3 git log 0e00185925aa..3b438311bbf3 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 vapier@chromium.org lint_autotest: remove hack to make unittests pass Created with: gclient setdep -r src/third_party/chromite@3b438311bbf3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6ad3b5d47d60e04ccddd99390a3f7555a7e4a9f5 Reviewed-on: https://chromium-review.googlesource.com/1154175Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578940}
-
Chase Phillips authored
Now that the renderer-side factory uses a normal Mojo interface, there's no longer a need to jump to the IO thread to make the calls on that interface. This allows us to clean up the code by removing the IO thread helper class. Bug: 717812 Change-Id: Iab04a90677d50ab3a911330ede2333d452b6f829 Reviewed-on: https://chromium-review.googlesource.com/1150724Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578939}
-
Antoine Labour authored
This allows shared ownership with classes that wouldn't have a TextureManager (i.e. no client id). Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I655b3ae6e316c0071604fbe7bd8ac7851c23fac5 Reviewed-on: https://chromium-review.googlesource.com/1148695Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578938}
-
Peter Kasting authored
Bug: 862664 Change-Id: I05e936b9f165278d46f7b9aee4dc1fe8dd20624c Reviewed-on: https://chromium-review.googlesource.com/1139410 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#578937}
-
Ned Nguyen authored
NOTRY=true # this script has no test TBR=eyaich@chromium.org Bug: 863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I33eb97b5403095e2ec208f03589b49db9acef4f4 Reviewed-on: https://chromium-review.googlesource.com/1154322 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#578936}
-
Peter Kasting authored
This means themes which do not set a background tab tint or image will get background tabs that blend into the frame, just like the default theme. Bug: 866672 Change-Id: I9ad1544f6fbc3b6bcc134312fab329d7f4554694 Reviewed-on: https://chromium-review.googlesource.com/1152522 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Joel Einbinder authored
This method emulates sending text into the page that doesn't come from a key press. This can be used to simulate text from an emoji keyboard or an IME. Change-Id: I643a0ac2ba2faa4988975d87641414b6f3896301 Reviewed-on: https://chromium-review.googlesource.com/1128398Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#578934}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d050c7fa..8ca3b449 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib59814ba0612e32b7b24b073c54b9ffb9dc6ef07 Reviewed-on: https://chromium-review.googlesource.com/1154318Reviewed-by:
-
Peter Kasting authored
This is a reland of df84748a Original change's description: > Compute colors for the frame and tabs from provided images. > > If theme authors explicitly provide values here, we'll use them; but if they > don't, but do provide images, set the colors to be the dominant colors of the > images, using an existing K-means algorithm (similar to what we use for > computing representative favicon colors etc.). > > This allows us to rely on those colors later when deciding what color to make > tab text, the new tab button, and similar tabstrip/window frame items. > > This also does a bit of cleanup to the theme pack code, e.g. moving a map used > in only one function into that function to make its provenance clearer. I can > try to split this apart into more CLs if desired. > > Bug: 862664 > Change-Id: I8c3f15893ad491a6fee8aa5f76ae162cecb2c6fd > Reviewed-on: https://chromium-review.googlesource.com/1152517 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578823} Bug: 862664 Change-Id: Ic5d9479a144f07f48de5bf4e2a07d6b6b0ea8f72 TBR: asvitkine, estade Reviewed-on: https://chromium-review.googlesource.com/1154150Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I6034d6753b6a59b4859110c7e63427d579d8f66d Reviewed-on: https://chromium-review.googlesource.com/1154319Reviewed-by:
-
danakj authored
Pass the DisplayMode to the RenderWidget constructor instead of setting it through set_display_mode() in RenderViewImpl::Initialize(). This makes the chosen DisplayMode explicit for all creators of RenderWidget instead of having a default value. Also store the renderer_wide_named_frame_lookup_ in RenderViewImpl directly in the constructor instead of in Initialize() since it does not need to be there (does not make use of the vtable or anything funky. Make the member const as a result. R=ajwong@chromium.org, avi@chromium.org Bug: 419087 Change-Id: I8d4354d770df8abf5273935412a3d28a98017434 Reviewed-on: https://chromium-review.googlesource.com/1153592 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Peter Kasting authored
This is a reland of 3b7859cb Original change's description: > Add background tab text colors for inactive and incognito windows. > > With the default behavior of Chrome being to not show a tab background, we want > to change themes to default to that as well, unless the theme author actually > supplies an image/color for this explicitly. To do this, we need to support > different tab text colors for the cases where the frame colors can vary. This > adds the framework for that support. > > Right now, the default is to use the same text colors in inactive windows as > active ones. > > This also gives themes that want normal and incognito windows to differ greatly > (as the built-in theme's does) the ability to implement that and still have > readable tab titles. > > Bug: 866672 > Change-Id: I032a72bc799d0675c517db10283513a30db23328 > Reviewed-on: https://chromium-review.googlesource.com/1152418 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578807} Bug: 866672 Change-Id: I2d80ccb2db306655b666d16588bfae59f087639b TBR: estade, bsep Reviewed-on: https://chromium-review.googlesource.com/1154149Reviewed-by:
-
Pavel Feldman authored
Change-Id: I5d67d97c3dc4a852ad516ebb58de1d24bae599e1 Reviewed-on: https://chromium-review.googlesource.com/1154200Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578928}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9576eff..d050c7fa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6fde89fd7d3ff81945832165b62a61ec4ef6deeb Reviewed-on: https://chromium-review.googlesource.com/1154202Reviewed-by:
-
Jungshik Shin authored
string-prototype-properties has an errorneous expectation. When a fix for crbug.com/v8/7958 was landed, that led to a test failure. See https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64/25165/layout-test-results/fast/js/string-prototype-properties-pretty-diff.html This CL marks the test for Skip and fix the expectation manually. Once the fix for bug v8:7958 [1] is landed and rolled to Chromium, the Skip line can be dropped. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1154247 TBR=gsathya@chromium.org Bug: v8:7958 Test: fast/js/string-prototype-properties Change-Id: I7402f8a896a073a897d44a16e4ec76ea1fda61fc Reviewed-on: https://chromium-review.googlesource.com/1154289Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578926}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7f1178ce3c1af8eb5676ce47b927d88c2002dfd3 Reviewed-on: https://chromium-review.googlesource.com/1154307Reviewed-by:
-
Mark Pearson authored
Tested interactively using a new install (no sync), a syncing install, and a syncing install with a custom passphrase. Only the non-custom-passphrase install sends the URL to Google's servers. These tests should be re-run with unified consent enabled before starting a unified consent experiment. Bug: 857589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic0fba71302cb04da623890daedf7c852324aae31 Reviewed-on: https://chromium-review.googlesource.com/1137096 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#578924}
-
BUG=762641 TBR=stevenjb@chromium.org Change-Id: Id322aa3ea897a50a42719bf958b55f3b258e2b97 Reviewed-on: https://chromium-review.googlesource.com/1154308 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578923}
-
Ken Buchanan authored
Currently when an OOPIF receives an updated viewport intersection rect from its parent, it schedules a lifecycle update. However if the OOPIF is now throttled it will not calculate new intersection observations based on the new viewport rect, and as a consequence any contained OOPIFs will not be throttled. This forces intersection observations whenever an OOPIF has its viewport intersection changed. Bug: 868558 Change-Id: I18c955b8cc40ec2ebe31d1f0fb35aa5a26f9f447 Reviewed-on: https://chromium-review.googlesource.com/1153838 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578922}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iecc22e3f634a3bfdd84192fec48c4d3d48d053c5 Reviewed-on: https://chromium-review.googlesource.com/1154312Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e61f6096b9a..e05f902a6929 git log 1e61f6096b9a..e05f902a6929 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 nednguyen@google.com Revert "rendering: Add pipeline metrics." Created with: gclient setdep -r src/third_party/catapult@e05f902a6929 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855328 TBR=sullivan@chromium.org Change-Id: I1ff64230a3aeebfa2a8f3749fd47053320dddcef Reviewed-on: https://chromium-review.googlesource.com/1154174Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578920}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6192d6f0f94b..dd0e9db48d2e git log 6192d6f0f94b..dd0e9db48d2e --date=short --no-merges --format='%ad %ae %s' 2018-07-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 306b6c168dc7..5b3b5cc126a7 (1 commits) Created with: gclient setdep -r src/third_party/skia@dd0e9db48d2e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I34b031f5936901182ea40fcd0244edd8fcc3e5eb Reviewed-on: https://chromium-review.googlesource.com/1154173Reviewed-by:
-
Pavel Feldman authored
Change-Id: I34db4fd1972bc42289f1f88031057ec7dfd4e5f8 Reviewed-on: https://chromium-review.googlesource.com/1154204 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
