- 25 Aug, 2020 40 commits
-
-
David Roger authored
Bug: 1076880 Change-Id: Ia9a7663c0089ee891853ef3458e0f1d449695295 Fixed: 1121189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372393Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801350}
-
Luke Zielinski authored
These expectations are overwritten by checked-in metadata ini files introduced in crrev.com/c/2327138 TBR=robertma Bug: 1116091 Change-Id: I0096780c0a07b38d61eff548b7338c140e4f90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372594Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801349}
-
Mohamed Amir Yosef authored
... CompromisedCredentialsManager() Bug: 1108422 Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#801348}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. The preference is still used in the UI and extension APIs and will be removed in followup CLs. Tbr: jianli@chromium.org Bug: 1104836 Change-Id: I44f896c4191af2b49decdc01696f2974b99b9120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366721 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#801347}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I3a96f9d3a422590df5c0b0947e6b803c074ef9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372322 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Justin Cohen authored
TBR=mrefaat Bug: 1121425 Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801345}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cccd55094dbe..59230836579a 2020-08-25 mbonadei@webrtc.org RTC_OBJC_TYPE RTCWrappedNativeVideo{Decoder,Encoder}. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b67048ca040f5d12ca61b73597962f41fa187d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374672Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801344}
-
Benoit Lize authored
Virtual size and size are reported by each segment in detailed memory dumps, and also by the heap implementation. This is not an issue in reported metrics, but can lead to double-counting in about:tracing, as the per-segment sized are summed with the overall ones in the UI. Bug: 1106364 Change-Id: I7099909b50d7902c3b7f0117934d3ca6dba75cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372327Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801343}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..d6482730a5b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia5a0bd618e71afcab887d6e1e3975773363a2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374236Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d6482730a5b0..41db2fb64914 2020-08-25 treehugger-gerrit@google.com Merge "Added Flow Events panel for selected slice" 2020-08-25 lalitm@google.com Merge "ui: mark non-IO uninterruptible sleep in a different colour" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3d0a5f7a1f74ef925ef8e4ac64c5aed66141c6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374671Reviewed-by:
-
Elly Fong-Jones authored
Use WidgetDelegate::SetModalType instead. This allows us to delete some subclasses of WidgetDelegate. Many more now only need the forthcoming WidgetDelegate::SetContentsView before they can be safely deleted. Bug: 1075649 Change-Id: I7c1cafce5a8c61ecfe0f986b40eed9c326995e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373169Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801340}
-
Clemens Arbesser authored
Change-Id: Icfdb23eb07a680d445ac89e853459c3483b62ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374528 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801339}
-
Viviane Yang authored
This change adds a new push_messaging namespace with general utils methods needed in chrome/browser/push_messaging. Change-Id: Iea9b5f54fe01b9a1b3eb027432731b23b4838bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374745Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#801338}
-
Maria Kazinova authored
processed by PasswordManager. This fixes an issue when websites trigger events on fields on a pageload before the base value for unique is received from the PasswordManager, leading to invalid values being set. Bug: 1121523 Change-Id: I58aee1dd065de7a547d016d4a35a0ec30c63e5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374866Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#801337}
-
Mohamed Amir Yosef authored
... when joining stored and compromised credentials. Follow up CLs will support Account Store during other operations in CompromisedCredentialsManager. Bug: 1108422 Change-Id: I023026589c4717e0db002901104d7353a6dbae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370635Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Richard Knoll authored
This times out outgoing connections after 1 minute. This only includes the initial connection accept flow that happens without user intervention. The payload accept / decline step has a separate timeout later on in the send flow. Bug: 1085067 Change-Id: Icb0f091879f2a657875e2ad8442102a6fccd0c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367951Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c8f0a829. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 323cee1a "Rename OverrideBuiltins to LegacyOverrideBuiltins." f503f766 "Correct waiting for negotiationNeeded in test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I56e98ab4a2803bb62d54b1591fc2120de02f2bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374090Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801334}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bccf9d55..47054c84 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I97f6d14bca9dfcc1db0691db6d6996a79042eb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374089Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801333}
-
David Jean authored
Fixed crash on exit with connectedScenes empty while the last scene tries to get interfaceProvider from it. Fixed crash with disconnected states remaining as dangling pointer observers in AppState Bug: 1114586 Change-Id: I4865d261082e81c2684065f97a8a6d94ffd2164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374785Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#801332}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Ib87706aeb8c6e100ba542a31e7374b2fe8c12210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372325 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d37b0ec2bb0c..cccd55094dbe 2020-08-25 nisse@webrtc.org Delete unneeded dependencies on deprecated build target webrtc_common 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c4572c2..ba69b98d (801101:801212) 2020-08-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6cc8efac..0c4572c2 (800536:801101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia13aa4ec9c7eb685c987c45fe3c34a2278f22005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374805Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..d6482730a5b0 2020-08-25 treehugger-gerrit@google.com Merge "Fix typo in sqlite BUILD define" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I177d7209896bf478f3b3847b07e6333812b9efdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374232Reviewed-by:
-
Peter Kasting authored
* Remove string arg to constructor, since SetText() already existed. * Strip trailing whitespace in SetText() as was previously done in the constructor, and comment about why it matters. I doubt this ever triggered outside of unittests. * Default the listener arg to null, which a lot of callers want. * While touching the callers anyway, use std::make_unique<>(), T* AddChildView(), etc. more. Bug: 648382,1108460 Change-Id: I7b3893ce922264581a7696d8fbcbdc70aecefaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360498 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801328}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..cdedf581e53e 2020-08-25 wolfi@chromium.org Revert "Update Mocha and rollup-plugin-terser" 2020-08-25 sigurds@chromium.org Add filter in network panel for resource type 2020-08-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-25 chrche@microsoft.com [Elements]: Fixing issue when searchConfig is unexpectedly undefined 2020-08-24 jegarc@microsoft.com Hide color picker on scroll 2020-08-24 patrick.brosset@microsoft.com Allow horizontal scrolling in the Elements tree 2020-08-24 michael.liao@microsoft.com [Accessibility - XHR Breakpoints]: Set accessible name for text input 2020-08-24 michael.liao@microsoft.com [AriaUtils]: Removing NVDA workaround for alert function 2020-08-24 petermarshall@chromium.org components: Use the new PieChart2 everywhere 2020-08-24 petermarshall@chromium.org css: Remove our implementation of data-keyboard-focus 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116327,chromium:1120103,chromium:1120844,chromium:1121086,chromium:1121141,chromium:880265 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib1d2e1953a818f81decffa8dda47e9f19115a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374229Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25e9f126d8c3..a5c279111d94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: I021bf56752d15d9655a08119718856d56b8183f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801326}
-
Aaron Leventhal authored
This patch removes the now unused method BrowserAccessibilityComWin::IsListBoxOptionOrMenuListOption() AX-RelNotes: n/a Bug: None Change-Id: I21e076c5a5ec8de83b0a7919ebb63de5350e7c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368460Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801325}
-
Hirokazu Honda authored
The bitrate is not specified in MultipleOutstandingEncodes case. So the default bitrate is used. It causes a failure in higher resolutions because of the bad stream quality. This fixed the issue. This also removes the default argument value to the bitrate argument in order to refrain this bug. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: I9c638db22175a7bc0573868fadc2057ec34bbdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371903 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#801324}
-
Alexander Hendrich authored
This CL: * uses ExtensionId as type instead of std::string * adds empty default implementations to ExternalCacheDelegate since most delegates don't care about all On*() methods. Bug: none Change-Id: I37cce73d60708305b8746e20803216da21eefa9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366744 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801323}
-
Dominick Ng authored
The tests fail at tear down when the TestingProfile is pre-emptively destroyed. Remove the pre-emptive destruction to fix the flakes. Additionally, instantiate an in-process data decoder in the test to ensure that data decoding doesn't need another process. BUG=1115763,1115762 Change-Id: I0b12669144093090d7f280057ee5069e314d6bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371767 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801322}
-
Findit authored
This reverts commit 2a107111. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 801312 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJhMTA3MTExMWQzYTY4ZWY3NjQwNjM0YmIxYzk5ODljOGI4MWVlODIM Sample Failed Build: https://ci.chromium.org/b/8871005296611674816 Sample Failed Step: compile Original change's description: > Video Tutorials : Modularized JNI bridge > > This CL moves the VideoTutorialServiceFactory and the JNI bridge into > the internal target. A corresponding public factory class is generated > from the internal factory using android_library_factory function. The > JNI function lives in video_tutorial_service_bridge_factory.cc which is > included in chrome/browser target while still living in > chrome/browser/video_tutorials/internal. > > Bug: 1120097 > Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801312} Change-Id: I9f4a941756cfce48418d07a5477712f992ecfdd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374233 Cr-Commit-Position: refs/heads/master@{#801321}
-
Yuki Shiino authored
Disable an unittest that tests OOM allocation behaviors when USE_PARTITION_ALLOC_AS_MALLOC because operator new (nothrow) do not return nullptr and crash instead. Bug: 998048 Change-Id: I14a2b25152568c912273215a24b9b528ddfa304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366446 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801320}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4dd122392f3a..12df3cafeee0 2020-08-24 greg@lunarg.com Fix SSA-rewrite to remove DebugDeclare for variables without loads (#3719) 2020-08-24 stevenperron@google.com Add undef for inlined void function (#3720) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ic6dbacc23b0f153ea678d8e34c74bc21d7a53daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374228Reviewed-by:
-
arthursonzogni authored
Add a basic WPT test where the reported: body.type is: "access-to-coop-page-from-other" Bug: 1090273 Change-Id: I6961a1a939c707264f215542a2bd99cdc45fb34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367098 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#801318}
-
arthursonzogni authored
This checks the following scenario: 1) Start from cross origin isolated document. 2) It opens a new window with the same policy, but with CSP:sandbox. Currently, this ends with two documents in the same cross-origin isolated process, but from a different origin. Goal of this test is to trigger DCHECK/CHECK we might have, or will have will: https://chromium-review.googlesource.com/c/chromium/src/+/2230632 Bug: 1115426 Change-Id: Id457f8bc30bf737405aed8d1e98f4243aef7135b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351920 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /base This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 1110266 Change-Id: I164e315751f8e43de5e37f639d836bd09129d706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371210Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801316}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ad0c9e91a7d..578215be44d0 2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4f7edbe1f6f0 to 7bce5194d1d6 (7 revisions) 2020-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 65295ec3 to 752313f1 (354 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Test: Test: Test: angle_unittests.exe --gtest_filter=FastInteger* Change-Id: I6f236a6b6128479fc13bb2106484e278c37410ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374227Reviewed-by:
-
Noel Gordon authored
third_party/closure_compiler/externs/file_manager_private.js says that the third argument to getContentMetadata is a boolean includeImages. Fix all parts of this API to agree with that definition, including the test coverage (MediaMetadata apitests). Closure compilation pointed out the type error when using the API from file app frontend JS. Bug: 1114622 Change-Id: Ie5102e14b796cc92931a20abb65c3ddec50adb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368575 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#801314}
-
Hans Wennborg authored
which includes 'printenv' now used by some lit test. The zip was constructed like this: $ gsutil.py cp gs://chromium-browser-clang/tools/gnuwin-13.zip . $ unzip gnuwin-13.zip $ curl -L -O https://downloads.sourceforge.net/project/gnuwin32/coreutils/5.3.0/coreutils-5.3.0-bin.zip $ unzip coreutils-5.3.0-bin.zip bin/printenv.exe $ mv bin/printenv.exe gnuwin/ $ zip -r9 gnuwin-14.zip gnuwin/ $ gsutil.py cp -n -a public-read gnuwin-14.zip gs://chromium-browser-clang/tools/gnuwin-14.zip TBR=thakis Bug: 1121387 Change-Id: I93f49303e104431be50389bbf7202621f6881d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374146Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#801313}
-
Shakti Sahu authored
This CL moves the VideoTutorialServiceFactory and the JNI bridge into the internal target. A corresponding public factory class is generated from the internal factory using android_library_factory function. The JNI function lives in video_tutorial_service_bridge_factory.cc which is included in chrome/browser target while still living in chrome/browser/video_tutorials/internal. Bug: 1120097 Change-Id: I4cbc7e2763012e3780a28f58bf14e3374464e20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368474Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801312}
-
Hidehiko Abe authored
Lacros used to use mojo_base::mojo::Binder to establish the Mojo connection between Lacros and Ash chromes, preferring the plataform independent way. However, it is too late for passing initializing parameters, which needs to be passed before starting the main message loop. This CL directly binds the LacrosChromeService, so that parameters can be available at earlier timing. Bug: 1115092 Test: Ran Lacros locally. Change-Id: I5345fa4bfe57b9a922e2d6c389c579266893d03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353976 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
