- 27 Oct, 2020 40 commits
-
-
Nate Chapin authored
NavigatorXR is fairly trivial, and XRSystem can just hang off of Navigator directly. Change-Id: Ied94d8e303c3d407f14531c85c860c366ee2183e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494822Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#821347}
-
Zhaoyang Li authored
This is useful for developers to locate a shard from a test name, when there are multiple shards for a suite. Bug: 1047704 Change-Id: Ie107d145036e85ca60fe44305fc33ddb17d30ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495792Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821346}
-
Joe Downing authored
All hosts should now (as of several years ago) be set up using a robot account so the codepath to handle host registration for a person account is no longer useful. Removing it to clean up the logic and prevent future confusion. Change-Id: I7cb813dc05e9eb79a76d04ea37a80470edd66d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495981 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#821345}
-
kylechar authored
The GPU workaround wasn't being passed to Skia when running with Vulkan. In general, GPU workarounds aren't implemented for Vulkan so remove the GPU workaround and add a real flag. Set the GrContextOption based on the flag from GetDefaultGrContextOptions() so it's picked up everywhere. Bug: 1138979 Change-Id: I469a7b38517e62f0577673ac1b8c1430fee9f55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502952Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#821344}
-
David Black authored
This CL pulls the holding space tray icon out into a separate class. Moving forward, the new HoldingSpaceTrayIcon will be modified to add support for a content forward UI and accompanying motion spec. Changes will be gated by a new feature flag (or param to the existing flag). No changes should be visible to the user as a result of this CL. Bug: 1142572 Change-Id: I21f85f37eeb595f7aa9ac3c79a171634b22e939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499376Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821343}
-
Liquan (Max) Gu authored
Changes: * Separated PaymentRequestService#Delegate into the common part (will be shared with WebLayer) and the Chrome part (moved into ChromePaymentRequestService#Delegate). After the change, the Chrome part has the TWA and basic-card related logic (skipUiForBasicCard). * skipUiForBasicCard is used by both java tests and browser tests. The java tests depends on its being overridden in PaymentRequestServiceObserverForTest#onPaymentRequestCreated. The browser test depends on its being overridden in PaymentRequestTestBridge#PaymentRequestDelegateForTest #skipUiForBasicCard (which was buggy as it was not set) Bug: 1142636 Change-Id: I4556f025e5a1c646d26bd4768724ac8ddcf9e874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499323 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821342}
-
Stefan Holmer authored
Bug: 1088919 Change-Id: Iabd3bf97ec3abd8ccb5e54ca63e201fdfc2867a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485942Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821341}
-
Robert Ogden authored
This CL adds an optional experiment param that controls what positions of the navigation prediction can be prefetched if they are eligible. In practice, this will hopefully control the number of prefetches that occur on searches where the first eligible link is pretty far down the page. The param is a CSV instead of a min/max to allow fine-grained control. Bug: 1141988 Change-Id: I35d581e10c291f6aaca79370c9f8f23aca76e40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495965Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#821340}
-
Bailey Berro authored
Adds an implementation for the ctor/dtor. Bug: 1128204 Change-Id: Id5f1534333909d88c44c988258df1007adb3f285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503195 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#821339}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=tiborg@chromium.org Bug: 1142671 Change-Id: Ie2aff35d42822e95da7a00b10c1d0e791998e25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500490 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821338}
-
John Chen authored
https://chromium.googlesource.com/catapult.git/+log/4f6c1bb4191b..a01dd2af4292 2020-10-27 bsheedy@chromium.org [typ] Add ResultSink support Manually rolling Catapult as automatic roll failed. The changes in Catapult repo require updates in chromium repo. Bug: chromium:1104252 Change-Id: Ifca77cd77b141e4561091c95acceeeb15530f761 TBR: bsheedy@chromium.org, agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503190Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821337}
-
Renjie Tang authored
Conversion is complete and exception is no longer needed. Bug: 1007794 Change-Id: I53ca46ad6405f9de6792d022c7d4416509cc025d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503808 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821336}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64543505bd67..ea2a4adced5c 2020-10-27 andoli@chromium.org [ts] Typecheck snippets/SnippetsQuickOpen.js with TypeScript 2020-10-27 ciccolella.krishnal@gmail.com [WebAuthn]: Add highlight to focused checkboxes 2020-10-27 tvanderlippe@chromium.org Typecheck formatter/ScriptFormatter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1127286 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie950d080ea63ce46926033591b545dc5a4f0120b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821335}
-
Haiyang Pan authored
Bug: 1141527 Change-Id: Id1df958b7c413adc2b04a401c2723bece05e9c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492661Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#821334}
-
David Schinazi authored
This should help us debug the ongoing issue of old Finch configs being served to users. R=mpearson@chromium.org Bug: b/167728915 Change-Id: I394a0b2d08e6b40476725e3e901149372723b862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500533 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821333}
-
Dominique Fauteux-Chapleau authored
Bug: 1109240 Change-Id: I70af6c0371edffbaf4bf108cb332683de4c77bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498880 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#821332}
-
Steven Bennetts authored
Primary captive portal detection is done in Shill and reflected in NetworkState::portal_state(). Chrome portal detection is also reflected in NetworkState, so observing NetworkPortalDetector is not needed. This enables removal of the per-network tracking of portal state in NetworkPortalDetectorImpl. BUG=1133376 Change-Id: I7d610092ec7412da1e7e727ced29ab80b0b6991f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490141Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
-
Bence Béky authored
Remove two obsolete flags: FLAGS_quic_bbr_rtt_variation_weight and FLAGS_quic_ietf_draft_version. Every remaining flag is a reloadable flag or a restart flag, all Boolean. Remove type argument. Change-Id: I0b9d6db33b82968c05aa8025d86921f1df7a29b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502751Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#821330}
-
Mustaq Ahmed authored
ids. We encountered a device that reserves three-finger touches for a system-defined gesture, so it cancels all touch points at the moment the third finger touches the screen. But the device wrongly sends a pointercancel for the third finger without sending a corresponding pointerdown first. This caused Blink to fire a pointercancel with a new id, which is not a valid event sequence! This CL suppresses such pointercancel events. Bug: 1007164 Change-Id: I0af68ac229e56344ee013a8e65fe18b3cc4e9fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488181 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821329}
-
Angela Yoeurng authored
This CL modifies the context menu behavior to match the new speech submenu behavior on the New Tab Page. Bug: 1141372 Change-Id: Icb79a66290d1c49b132ce0bef123a91facf7d67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500423Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#821328}
-
Alexander Yashkin authored
BUG: 1142196 Change-Id: I5d3ad265e026ba93a3b2d69866b0ef29dda72113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495462Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#821327}
-
Andrew Grieve authored
* Adds a flag for disabling -checkdiscard failures * Contains fix for assertions being removed when code coverage is enabled. * Contains fix needed for vertical class merging Bug: 1040534 Change-Id: I6e5eb6242a6126fd4293920bff5267149fabbe1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489729 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#821326}
-
Xiaocheng Hu authored
StyleRuleKeyframes internally stores its name with an AtomicString but returns it as a String, while there are some other code using StringImpl for a keyframes name, which causes some confusion. So this patch unifies all such code to use AtomicString. Change-Id: Ic7eeff262bcb2ff1c055c9a36ce43ff03ccee1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500954 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821325}
-
Mark Schillaci authored
This CL is the third part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. We have also hidden the entire feature behind a feature flag, so this CL is not visible to an average user. ---------- This CL adds the following: - Adds helper text/hint for unlabeled images - Adds returned image description to node's inner text - Associated strings etc for above ---------- Binary-Size: Size increase is unavoidable, it comes from adding necessary content strings and descriptions for translations. AX-Relnotes: Adds feature to enable generating alt image descriptions, currently behind a feature flag. Bug: 1057169 Change-Id: I6becb973045e127681136a1fe0b7171d5cbddca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317712Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#821324}
-
Mark Schillaci authored
This CL updates the behavior of aria-current nodes on Android. With this change, the value of aria-current (e.g. "date", "page", "location", etc.) will be read as a part of the state description for that node on Android. For example, if aria-current="page", then the node will announce "current page". We append this status as part of the state description in the AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnotes: aria-current nodes now explicitly announce their state. Bug: 1093578 Change-Id: I6028f235e663e7df5ce4e626db16f68acbbc9b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493660Reviewed-by:
-
Dom Schulz authored
We don't want to sync chrome-untrusted: or devtools: schemes to user profiles. They are internal details about system apps. This cl brings the behavior of those schemes in line with how the chrome: scheme works. Bug: 1044864 Change-Id: Ia3549a57840d071826dda02d0f38b242404ed0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493260 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821322}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7e3b823b7b18..15b2c074595f 2020-10-27 ahassani@chromium.org xbuddy: Do not rename update payloads to update.gz anymore 2020-10-27 ahassani@chromium.org xbuddy: Remove unused APIs 2020-10-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-26 jomag@google.com PUpR for DriveFS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I57fa3239b3f84b625dc24954e5fecadb5e9fdc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502390Reviewed-by:
-
Hidehiko Abe authored
Bug: 1133732, 1123705 Test: Ran Lacros locally. Change-Id: Id74573390f287512a4455636e7b636255df4e025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503528Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821320}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4af02fc0ad4a..06d17a5d6ff2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nektar@google.com,droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nektar@google.com,droger@google.com Change-Id: I9d219da9089096dc205d7c3eec3c4a20ee50efac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502835Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821319}
-
Kramer Ge authored
If the surface is a synchronized subsurface, wl_surface.commit on a sub-surface will accumulate the committed state in a cache, but the state will not be applied until a parent surface commit. Reference: https://github.com/wayland-project/wayland/blob/master/protocol/wayland.xml#L2834 Bug: 1123921 Change-Id: I32396bb087db1e06262deca2611615d9f89c930e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382057Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#821318}
-
Jérôme Lebel authored
When kMobileIdentityConsistency flag is disabled, the sync should be confirmed or disabled by GoogleServicesCoordinator. Bug introduced: crrev.com/c/2463306 Fixed: 1141961 Change-Id: I2bd01a0c43458758f0088a17594bf5291900c510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498525 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#821317}
-
Caitlin Fischer authored
Clarity changes: - Improved the wording in the Directly Measure What You Want and Expired histogram notifier sections - Removed "will" since the present tense is preferred - Replaced some unclear expressions with clearer ones Style changes: - Periods are now consistently followed by one (not two) spaces - Hyphens are replaced with em dashes where appropriate and spacing around them is corrected (no spaces) Change-Id: I94e845fcf64e761814f7ae448ab1a50015238698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500141 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821316}
-
Gavin Williams authored
Stop showing the back button in the search box to remove an unnecessary tab stop. Keep the placeholder text left justified and a consistent color with or without focus. Video: https://bugs.chromium.org/p/chromium/issues/detail?id=1005166#c27 Fixed: 1005166 Change-Id: Ie6daa2fd659122ca88bda39c2ab2dd36de2acf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499803 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821315}
-
Jan Scheffler authored
This patch enables a test that blocked landing the following cl: https://crrev.com/c/2466187 Bug: chromium:1093791 Change-Id: I195d71618548766a0de4e9128d03a032284909b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498508Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#821314}
-
Dominic Farolino authored
Putting `loading=lazy` on an out-of-view iframe creates an internal LazyLoadFrameObserver owned by the HTMLFrameOwnerElement associated with the iframe element. Before this CL, `src` mutations reset the HTMLFrameOwnerElement's LazyLoadFrameObserver member, however old observers may hang around until they are garbage collected. Until this happens, they are technically active observers and still reference the HTMLFrameOwnerElement. This means if you queue multiple lazy loaded navigations via `src` attribute mutations, there may be multiple LazyLoadFrameObservers that are "active" and referencing the element. When the iframe is scrolled into view, the old still-alive LazyLoadFrameObserver's LoadImmediately() method may is called before the observer is GC'd. In that case, we start to navigate the iframe. This calls Frame::Navigate, which is expected to call LazyLoadFrameObserver::CancelPendingLazyLoad(), which is ensured by this CHECK [1]. However, the "old" LazyLoadFrameObserver::LoadImmediately() method invokes Frame::Navigate(), which invokes the "new" LazyLoadFrameObserver::CancelPendingLazyLoad() method. Therefore the CHECK mentioned above actually fails, because the "old" LazyLoadFrameObserver was not cancelled correctly during the navigation flow. After this CL, upon creating a new LazyLoadFrameObserver for the HTMLFrameOwnerElement we reset old LazyLoadFrameObservers by calling CancelPendingLazyLoad() on them. Then they are effectively disabled until they are GC'd. This CL also includes a test which crashes Chrome's renderer before the fix. [1]: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/lazy_load_frame_observer.cc;l=197;drc=6e8b6ca4b8f8f7ff0b41ba613edd47453bb3aafe R=dcheng@chromium.org, sclittle@chromium.org Bug: 1137708, 1126127 Change-Id: I0a7eef854bed3e192a5ef68b9cec18c95353298a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497424 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
The first event(s) that used GetProfileUsername() would get an empty username since identity_manager_ is still null when events are reported. The fix is to make the that variable in the ctor. This also adds a check for the profile user name in EventReportValidator to ensure correct reporting for that field. Bug: 1140993 Change-Id: I1f96bc68e5196fbfc29b5bf287e5894b578a2f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493042Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010270700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MHfyzcW1xhCWhSgftO6_x002FdOnWyLr6xw7ohbtv7oC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/167996158,b/170172114 Tbr: media-app@grotations.appspotmail.com Change-Id: Id49d4eeae3eedeef0e04f2ed16c20f6c54f009fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502389 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Clark DuVall authored
GPU process sometimes accesses this class through JNI, and it was not present in the base module. Bug: 1142536, 1126301 Change-Id: I16a9f1fec7c970991f0335c9e6030ff4510965e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502410 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
David Grogan authored
This is the 'width' version of https://chromium-review.googlesource.com/c/chromium/src/+/2462574 min-width:auto had been using the image's intrinsic widths as the content size suggestion, as returned by image_node.ComputeMinMaxSizes(). But that function honors specified min/main/max widths and the content size suggestion is supposed to ignore those. Now content size suggestion ignores specified width properties and also honors the transferred size -- if the specified height is definite, we pass it through the aspect ratio to determine the content size suggested width. Change-Id: I74ed9d96e584605ad8154cc9cb5a94ef84f78544 Bug: 1132627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500448Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821309}
-
David Roger authored
[sheriff] Disable ChromePrivateNetworkRequestBrowserTest.RecordsAddressSpaceFeatureForFetchInNonSecureContext TBR=titouan, arthursonzogni Bug: 1142865, 1124358 Change-Id: I6f89ad282539ea4150f9fa069f8a61576327ceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502931Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821308}
-
