- 02 Oct, 2020 40 commits
-
-
Siyu An authored
Bug: 1112095 Change-Id: I614ec70d4ba183850cd19412c963bd344b7c318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444800 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#813422}
-
Orin Jaworski authored
This CL includes data fixes for several languages to improve Pedal triggering. Issues resolved include: Stray capitalization, duplicate synonyms, synonyms consisting entirely of a single dash, separators consisting only of a single dash, empty cell gaps, and synonyms consisting entirely of ignore group synonyms. Bug: 11347706 Change-Id: Iabc8099db437e518ef2deea34fd41329985e5b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446823Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813421}
-
Jimmy Gong authored
Fully implements the DoNotDisturbController. This class is responsible sending and receiving states in regards to the DoNotDisturb feature of the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I6a4fa96de5920711a7534ae7eff8bb33b9bb35b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439777 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813420}
-
Yi Gu authored
Currently when an SmsService has unhandled request upon destruction, e.g navigating away, we record "Timeout" as an outcome. This is misleading because "Timeout" should refer to the user consent prompt being timeout. This patch renames Timeout to UnhandledRequest and the follow up patch crrev.com/c/2427560 records the right Outcome.Timeout. Bug: 1127397 Change-Id: I151d5f087c416136bc042d12086df3185dbf2b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424894Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813419}
-
Hung Vu authored
This CL handles unit test for shouldSuggestDownloadLocation in DownloadDialogUtils. Change-Id: I39442ffe032550631c8f47f6ecc49529b489903c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446518 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813418}
-
Ben Pastene authored
Adds a `mb.py train` command that will dump json files for every builder (one file for each master) to a specified dir. And hook up `mb.py validate` to also validate the expectations. This won't actually generate the expectations. For now it's silently skipped if the expectations dir doesn't exist. Will create it in a follow-up. To see what the expectations would look like, see patchset 5: https://chromium-review.googlesource.com/c/chromium/src/+/2378273/5 Bug: 1117577 Change-Id: Iaa7be9201d26fe331620f0d666a03a6adbaa2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378273 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#813417}
-
Elly Fong-Jones authored
These methods express that the caller is passing in ownership of the delegate, and assert that the delegate believes it is owned by the widget. This change also corrects a flaw in ownership handling in an ash unittest: some of the created delegates were passed around as raw pointers, and one was sort of leaked (not actually leaked, but destroyed in an extremely non-obvious way). Bug: 1075649 Change-Id: I655dfe3e2466032b85247341f43b1b2d75c0b561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446015Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813416}
-
Peter Kasting authored
Also addresses c/b/ui/views/{read_later,web_apps}/. Bug: 772945 Change-Id: I71a0bb167c8eefb19624240536ca1d98dd2bfb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446022 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#813415}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d696086211d..a6ca9757d3a6 2020-10-02 brianosman@google.com Let skslc use more of Skia's core 2020-10-02 johnstiles@google.com Factor out Inliner candidate list assembly into its own function. 2020-10-02 brianosman@google.com Detect non-2D textures in MetalCodeGenerator and fail cleanly 2020-10-02 brianosman@google.com Fixes to array handling and interface blocks 2020-10-02 bsalomon@google.com Remove unused SkImage YUVA factories. 2020-10-02 fmalita@chromium.org [skottie] Auto-resize and VAlign support for point text 2020-10-02 egdaniel@google.com Remove some unneed read access from vk srcAccessMasks. 2020-10-02 ethannicholas@google.com Revert "Revert "moved SkSL FloatLiteral data into IRNode"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I2d8fe59a3c7347c5d1b8b6956f901edfc771c330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b9855ccf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic0381cd6dce3b49b5a10d911030b0c7effdbf94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446819Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813413}
-
Zentaro Kavanagh authored
- One test file was missed from CL [1] that split up tests [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2442502 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I5d52dbcc4b6e90fa8b22a059471167f6d10ef0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446389 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813412}
-
Andre Le authored
- Change the status order in the controller. - Use setter function for find my device status. BUG=1106937 Change-Id: I628512f3b13362acc69982a8df48c0e2ada23658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446969Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ida267e2a5dfa7b70d0ea25e5a91a4a6cceafe555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446833Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813410}
-
David Bertoni authored
Bug: 1133034 Change-Id: Iec185526bfa222e601252d9a0e1e7cedde2988cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437307Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813409}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4036e35e8d8d8737a327d6133a193c810eb8e929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382595 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#813408}
-
Sinan Sahin authored
When ContextMenuHelper#setPopulatorFactory is called, the current ContextMenuPopulator is destroyed. If a context menu was showing when dismissed after the populator is destroyed. This is because the populator is accessed when the context menu is dismissed. This CL holds a reference to the current context menu and dismisses it in #setPopulatorFactory. Bug: 1133172 Change-Id: I879a4278c045c3a4c9028b9b4825b5cd497a5e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446775Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#813407}
-
Ionel Popescu authored
The eye dropper test run close to (and sometimes exceed) the 60s timeout limit on MSAN builds. This is similar with other tests that are using the color picker[1]. This change marks the test as slow to avoid timeouts on the MSAN trybots. [1]: http://crrev.com/c/2330086 Bug: 1134580 Change-Id: Ica5b48dd7690a91c507e5c2517e985599333741b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446194Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813406}
-
Sadrul Habib Chowdhury authored
If shared-memory allocation for smoothness-ukm data fails, then handle that error gracefully, rather than crashing out. BUG=1134659 Change-Id: I309e478ce112d9e0303d7aea6619260abac0cfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446929Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#813405}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b494582b95e5..d82d30da43cd 2020-10-02 chonggu@google.com [Fuchsia] Remove fuchsia-ssh-config-dir flag. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133039 Tbr: oysteine@google.com Change-Id: Ia2a835b441e55fe925e94c3413de7806ce7384c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446910Reviewed-by:
-
Ben Wagner authored
Skia is removing the old display globals. Chromium is the remaining heavy user of these globals; defining this macro will preserve the existing behavior until Chromium can be updated to no longer use them. Change-Id: I509b6333ea39c60e0b0aab1817513f4f895121a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446776Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d81cd72..f38f24c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib76db6cefac6a5ab0369236fbfc9f02ee6b33ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813402}
-
Jonah Ryan-Davis authored
These tests began failing on Sep 21: conformance/textures/misc/copy-tex-image-2d-formats.html conformance/misc/uninitialized-test.html conformance/textures/misc/copy-tex-image-and-sub-image-2d.html Bug: chromium:1134756 Change-Id: I788ab772a1ee8c5159366404e37abc30a412744d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446654 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813401}
-
Jeffrey Young authored
BUG=none Change-Id: I31c164b88d0724d333b2861ab83cbc1f8b76a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445631Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813400}
-
Yuly Novikov authored
Makes them consistent with other GPU builders. Bug: 1123215 Change-Id: Iff4b08b496bf41df37c9d2fb78dc633a98b633ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446558Reviewed-by:
-
Xiaoqian Dai authored
In window capture mode, the user should be able to interactively select a window to capture. when the to-be-captured window's bounds or state is changed, we should update the capture region to reflect the change as well. Other changes that is worth mentioning in this CL: - Window stacking order or activation order will not be changed by the capture window selection change - If current selected is closed/minimized or becomes invisible, we automatically select another window under mouse/touch event location. and if there is no such window, do nothing. - If another window is activated when a window is selected, if the activated window is under mouse/touch event location, it will be focused instead. - When a mouse moved over a selectable window, change its cursor to either capture icon or recording icon Bug: 1127526 Change-Id: I6cf2abce18e1c38f06dfc3b7def3280b9fd8de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#812976} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446590 Cr-Commit-Position: refs/heads/master@{#813398}
-
Zhenyao Mo authored
BUG=1109268 TEST=gpu_unittests R=kbr@chromium.org,bbudge@chromium.org Change-Id: Ib30e393d223834bea48eebadb8f465fb74a92925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446532Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813397}
-
Tim Song authored
BUG=1106937,1126208 Change-Id: Ic8178b1c481db1b74a9abd775f8e98b30d81e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444126 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813396}
-
Ben Kelly authored
This CL enables a feature to move cache_storage operations off the IO thread and onto a sequence instead. This feature has previously launched on all other platforms. It has been held back until now on ChromeOS due to some measured performance regressions. After a couple months of experimentation we have not been able to shift the regressions. It appears there is just measurable delay from the additional task that is run when mojo messages are targeted off the IO thread. There is not a lot we can do about this unfortunately. The regression show up in cache match time and body reading at P95. Top level UMA such as FCP, however, are neutral. Architecturally we are motivated to launch this in spite of the regressions. We do not want to support multiple threading models into the future. In addition, cache_storage can interfere with other parts of the browser that also need to use the IO thread via mojo message passing. Therefore this CL proceeds with enabling the feature. Bug: 960012 Change-Id: Ie9d5931ce9530dafe101d209a13f65ff22dffddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441125Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#813395}
-
Antonio Gomes authored
chromeos::TabletState is the singleton that actually holds the information about the current TabletMode state. The state getter method is public, but its setter is not. The idea is that only a handful of classes can actually set the state, eg ash::TabletModeController. In the future, Lacros will also be able to create a chromeos::TabletState instance and set the tablet mode state via the (upcoming) use of `zcr_remote_shell` Exo protocol extension. BUG=1113900 R=jamescook@chromium.org Change-Id: I2ec77e7f038095b7e4f9c776683993f6b30c409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443219 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813394}
-
Bruce Dawson authored
thread_watcher_report_hang.cc has various unique functions which are designed to be on the call stack when hangs are reported. Guaranteeing this requires making all of the functions unique and inhibiting tail calls. The tail call inhibiting was only applied to two of the functions so this change applies it to the other two (commented out in one of them) and adds the NOT_TAIL_CALLED attribute to the function they all call. This attribute makes the ordering in the functions irrelevant but there is no cost to having belt and suspenders, so why not? This completes the work of crrev.com/c/1373878. Bug: 905288, 1032679 Change-Id: I383cc3453ab2f506017de1143bc8f3666ed38a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443891Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#813393}
-
James Cook authored
Crosapi mojoms have to be backwards compatible. Most interfaces and structs use explicit ordinal values (@0, @1, ...) to emphasize this, but I missed a couple of them. Add annotations to the missing ones, so we're consistent throughout //chromeos/crosapi/mojom. Bug: none Change-Id: I9c7e7729cbdab903154d8d9c3d10b2e44fbb0b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442645Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813392}
-
Chris Sharp authored
Deprecate ProxyBypassList, ProxyMode, ProxyPacUrl & ProxyServer since ProxySettings can do everything they can and is the first policy checked. Bug: 1018157 Change-Id: If312cc1419a1c6761d1580609be0582ca95fbb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441265Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813391}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Icc8256e084705d78b460641a873a05cdc0d7ef06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446766Reviewed-by:
-
Chris Harrelson authored
This was a mistake in the previous patch. When walking up the DOM tree, we don't encounter the document object directly (this is different than the layout tree). Bug: 1129979 Change-Id: Ib6b7040e2a54658948d0830230d7a8ebeba44b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446517Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813389}
-
Raymond Toy authored
AudioBufferSourceHandler::RenderFromBuffer wasn't handling the case where the source buffer had buffers that were transferred away. Check to see if the buffer was transferred and then just fill the destination with zero. Bug: 1132574 Change-Id: I92abd74f20918cb53810abf9ad00c9c4f4582baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439361Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#813388}
-
Kelvin Jiang authored
This reverts commit 991f4851. Reason for revert: This causes generate_buildfiles to fail, as seen here: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome-easwa This is the only CL within the revert range that includes barhopper Original change's description: > [ShapeDetection] Add barhopper impl for BarcodeDetection. > > This CL adds BarcodeDetection and BarcodeDetectionProvider > implementations based on the barhopper barcode detection > library. > > NOPRESUBMIT=true > > Bug: 1093185 > Change-Id: I29b233418108482ebc80bce7c34888fa2081068f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419911 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813335} TBR=jam@chromium.org,dpranke@google.com,reillyg@chromium.org,azeemarshad@chromium.org Change-Id: Ia604a3ad2999116a453384261cd6f1873c73454d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446027Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813387}
-
Matt Jones authored
This patch replaces the TopToolbarOverlay's dependency on the ControlContainer with a callback for the progress bar's draw info. This will make chainging the ownership of TopToolbarOverlay from the LayoutManager to the TopToolbarCoordinator easier. Bug: 1100332 Change-Id: Id6cd9ae9f2ffe8b4dd70436c360147fb9877dcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357955Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813386}
-
Taylor Brandstetter authored
Fixes some windows compile warnings that were preventing fuzzers from being added; only minor functional changes since last update. https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2caaff2b0a1d $ git log 995c0b844..2caaff2b0 --date=short --no-merges --format='%ad %ae %s' 2020-10-02 tuexen Minor cleanup. 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) 2020-10-01 tuexen I guess Bitrig support arc4random(). 2020-10-01 tuexen Whitespace change. 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. 2020-09-30 deadbeef Add missing return type to init_random. (#531) 2020-09-30 tuexen Try to fix the Windows build. 2020-09-30 tuexen Add Android specific code for the random number generator. 2020-09-30 tuexen Add platform specifc includes to the corresponding code. 2020-09-30 tuexen Add a cleanup routine for the random number generator. 2020-09-29 tuexen Improve the input validation and processing of cookies. 2020-09-28 tuexen Whitespace cleanup 2020-09-28 tuexen Improve random number generation on __Fuchsia__. 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 2020-09-24 tuexen Whitespace changes 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) 2020-09-19 tuexen Improve consistency. 2020-09-19 tuexen Cleanup. 2020-09-19 tuexen Improve Windows build. 2020-09-19 tuexen Fix syntax error on windows. 2020-09-19 tuexen Add include for getrandom() on Linux. 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. 2020-09-19 tuexen Improve Windows build. 2020-09-19 tuexen Improve consistency. 2020-09-19 tuexen Improve random number generation on Linux and Windows. 2020-09-19 tuexen Cleanup read_random(). No functional change. 2020-09-19 tuexen Fix NetBSD related #ifdef. 2020-09-19 tuexen Whitespace changes 2020-09-18 tuexen Add license. 2020-09-18 tuexen Add license statement. 2020-09-18 tuexen Fox more typos. 2020-09-18 tuexen Fix typo. 2020-09-18 tuexen Remove trailing whitspaces. 2020-09-18 tuexen Improve consistency, no functional change intended. 2020-09-18 tuexen Check for too short packets when using the receive threads. 2020-09-18 tuexen Fix mask for ECN bits. Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: chromium:1025302 Change-Id: I3faeb75f9f12d71b7b6ef3d326ad2e8d8becf3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430446 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#813385}
-
Sammie Quon authored
Test: manual Change-Id: Ic3cfb8d62a72a07b9ced7d8de778b25134e16dca Fixed: 1134451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446531 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Michael Checo authored
- Unnecessary because the "title" slot can be placed directly on the div that contains the title text content for the card. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4f5620c6c07d5afc28288fd04dd902ca5f92dc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443499 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813383}
-
