- 15 Apr, 2020 40 commits
-
-
Charlie Hu authored
Because feature_policy_helper now contains document_policy related helper functions as well, rename the file to a more general name: policy_helper. Change-Id: I8a6c7d2343ff8ff780e64bef52c8b41d38414022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144040 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#759408}
-
Dale Curtis authored
This reverts commit d888e096. Reason for revert: Issue may be fixed now, lets see! Original change's description: > Disable audio output for media browser_tests on Linux > > Due to problems on some bots failing to start PulseAudio and causing > Chrome startup to hang, disabling audio output for media browser tests > on Linux to avoid the hang. > > Bug: 986021,1023029,1026849,1035472,1049467 > Test: modified browser_tests pass locally > Change-Id: I29a996ee627bc4a5b93e5b8d6227dd7801998d11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056760 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741613} TBR=dalecurtis@chromium.org,jrummell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986021, 1023029, 1026849, 1035472, 1049467, 1054560 Change-Id: Iffb9f8299c86d9a1eccb59f3db0e5f16d09b207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151049Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759407}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: Id950858f00c584a99af69faab6f70ed4c984db9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150009 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759406}
-
Sigurdur Asgeirsson authored
The serialization ID is slated for removal, and local ID assignment is sufficient for this metrics provider. Bug: 1071090 Change-Id: I73165ae30636a834fc9d1294d3dbf40ed308d48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150234Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#759405}
-
Erik Staab authored
Bug: 1058963 Change-Id: If7d10216e236282357f88e3cc49a5a2c5b3200a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150395Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759404}
-
Carlos Knippschild authored
- Rename PERMISSION_DENIED to STORAGE_PERMISSION_DENIED for clarity. - Favor using OfflinePageModel::CanSaveURL when deciding about saving an OP. - Properly reporting metrics for pages that failed being published (new call to OfflinePageModelTaskified::InformSavePageDone). - Removed OfflinePages.SavePageCount which was recording unsuccessful saves too. The same information can be obtained from OfflinePages.SavePageResult. - Adds a new error type to OfflinePages.SavePageResult: incorrect URL. - Consolidates OfflinePages.PublishPageResult as a special case into OfflinePages.SavePageResult. - Renames OfflinePages.SavePageResult to *2 due to the reporting changes described above. - A few more minor changes. This is not a full review of all metrics reporting but covers some bugs I found. There might be more issues to be addressed. Change-Id: I941effe555050b841c90735f6ff66f1641b7255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138775 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#759403}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9ac89e3e1842..b9ebe017027a git log 9ac89e3e1842..b9ebe017027a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 ilkos@google.com Merge "Incorporate oom victims in the lmk metric" Created with: gclient setdep -r src/third_party/perfetto@b9ebe017027a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3ec84fd84b44e4ace1f4f01e41a0abd0d92216e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151072Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759402}
-
Clark DuVall authored
This implements basic client hints functionality. Still TODO after this patch to make sure ContentSettingsAgentImpl is working as expected: - Sync content settings to renderer - Add ContentSettingsManager implementation for WebLayer Bug: 1065537 Change-Id: I3a281c2a6a472ba9e1d79ff860d5bb94367cf888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145156 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#759401}
-
David Van Cleve authored
There's some global state that the key commitment fuzzer needs initialized, or else it (evidently) crashes. So far, this seems to include ICU and the command line. This change adds a dependency on //net:net_fuzzer_test_support in order to initialize net-relevant global state, including those two. R=svaldez Fixed: 1071130, 1071084, 1071157 Change-Id: If92e8a9e3a7905e0966950cc45576fd9549adca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151105Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759400}
-
David Black authored
This CL: - Creates public interface for AssistantController - Renames existing AssistantController to AssistantControllerImpl - Updates references This new interface (which exposes a singleton accessor) will be used moving forward to get a handle to the AssistantController from outside of Ash. The most pressing need for this is the new Assistant search provider. Note that this CL doesn't yet add public APIs onto the interface, as I attempted to only make the smallest possible change in this CL. Follow up CLs will migrate public APIs onto the interface as well as remove the existing accessor to AssistantController that is currently exposed through Shell so that we can enforce consistent access to AssistantController through this new public API moving forward. Bug: b:146074655 Change-Id: Id9f414f66fbfc60c90eb5d0c8a9b86681c641da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148098 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#759399}
-
Clark DuVall authored
PathClassLoader may call stat on the library paths, which causes a strict mode violation. We may want to try to move this to a background thread eventually. Bug: 1071119 Change-Id: I51df3ee7bcd3a4bb94d4c0a56a21d97dc9406548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150886Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ff53c7..b774f178 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9aaf0c2c019480b2416035899a64dd1bcd05e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759397}
-
danakj authored
Rather than passing a BlinkTestRunner unrelated to the current frame to GCController, we drop its dependency on BlinkTestRunner, as it can get the task runner from its own WebLocalFrame directly. Renames BindTo() methods to Install() as they are all there to install JS bindings, and forward through to other Install() methods. Moves the GCController binding installation out to the frame, as it is done per-frame, instead of going through the "global" TestInterfaces. R=nasko@chromium.org Bug: 866140, 1069111 Change-Id: I75325ee908d31dca7d9dcd8a5b7673d999dd891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150396Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#759396}
-
danakj authored
Instead of using the BlinkTestRunner from the main frame's RenderView, have the TestPlugin use the BlinkTestRunner for its own frame tree fragment. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I1a5a2b67ec864665f3fa98d7b19511e36ac23ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150162Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#759395}
-
Vladimir Levin authored
This patch ensures that nested locks are forced when they are discovered during an update which itself was forced by a descendant node. R=chrishtr@chromium.org Change-Id: I675b9e5e4f7c60f96afd2fb62eefbb1ad020bb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138120Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759394}
-
Lei Zhang authored
In order to do so, add a new AddResourcePathsBulk() variant that takes a span of GritResourceMap entries. Change-Id: Ie3907bf811b654904ad9c650c53b30db7d9fdff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150072Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759393}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01d5f76e. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 231c063a "[css-grid] Migrate whitespace-in-grid-item.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If6bc9723c4cd2507d97ae4a3792e66dacdd64bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150675Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759392}
-
Matt Menke authored
In particular, make GetNormalizedHeader() and RemoveHeader() and take StringPieces. Both are already calling StringPiece-friendly methods internally, so this should reduce copies slightly. Also make a number of methods take a "base::StringPiece" instead of a "const base::StringPiece&". Bug: 1068194 Change-Id: I7a27d505a8f5c20ddb5c1313b9de4f2cb1069dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149690 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759391}
-
dpapad authored
These files are purposefully not compressed, since unpack_pack.py does not support decompressing files. This is part of a series of CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I2467173ec95bd5086fbbde262dc5206d9112b032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149638Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759390}
-
Elly Fong-Jones authored
The Views subclass is now the only subclass of the original base class, so fold the base class into the Views implementation. This reveals a few unused methods on the delegate interface itself and some other simplifications that will come in a followup CL. Bug: 1070331 Change-Id: I223f32b784c85c406b1dd82116bf19cf5360ee86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148020 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Devlin Cronin authored
ExtensionInstalledBubbleView tests didn't pass with the ExtensionsMenu enabled. Fix them (by waiting for the bubble to show - it doens't happen immediately because the extension slides out of the menu), and parameterize them so they run automatically on both the old and new UI. Bug: 943702 Change-Id: I1ed98e80b7ce8c312c82e2d01cc2ba05bcee5f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150058Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759388}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fill, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: If837131b95e0583a965ae1468f6072537b589ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147402Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#759387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1a9c8db7e7c..fc5e10322119 git log e1a9c8db7e7c..fc5e10322119 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 agrieve@chromium.org Fix "git freeze" failing on broken symlinks Created with: gclient setdep -r src/third_party/depot_tools@fc5e10322119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071066 Tbr: agable@chromium.org Change-Id: Idd255d88f409419be113f17df3a4832ecfb1952f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148495Reviewed-by:
-
David Van Cleve authored
This CL adds a new switch, --additional-trust-token-key-commitments, and updates TrustTokenKeyCommitments to read its default commitments from the switch's value (via the key commitment parser). This is useful for automated testing; it's also useful for playing around manually with Trust Tokens functionality in environments without access to the component updater, or against Trust Tokens issuers whose keys aren't being shipped through the updater. R=csharrison Bug: 1068651 Change-Id: If6483d4210856d91665784e730a4af31ee3558af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144412Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759385}
-
Sebastien Lalancette authored
- Created helper file with function to create the UIImage. - Added unit tests to validate the generated image. - Added the generated QR code image to the QRGeneratorViewController. - Added portrait/landscape constraints. Bug: 1064990 Change-Id: I79038e3119be5ea9be1f1af5143dc3d1f4c8821a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136042 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759384}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ff1d841f6cc..0f1f87d7bd4b git log 9ff1d841f6cc..0f1f87d7bd4b --date=short --first-parent --format='%ad %ae %s' 2020-04-15 reed@google.com transition matrix44 to opt-in only 2020-04-15 mtklein@google.com report all test errors in fm 2020-04-15 herb@google.com Schedule using tree order traversal the DAG. Created with: gclient setdep -r src/third_party/skia@0f1f87d7bd4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: If377335460731b234bef1b0a6f1056c127c92f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151068Reviewed-by:
-
David Bertoni authored
The LaunchWebAuthFlowFunctionTest.InteractiveSecondNavigationSuccess test was disabled in 2014 when it was only flaky on MacOS. The flake seems suspicious and was never investigated. I will monitor this test to make sure it's OK on MacOS and disable it only on that platform if necessary. Bug: 377624 Change-Id: I925aaa4a04d01b1a4ce30160feeb17ee1aa83bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149912 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759382}
-
Sean Harrison authored
update the banner images on the security, cookies, and permissions settings subpages Bug: 1032584 Change-Id: Ibb0c6d7f7b8eb1a31487746baf6f774ff6c2e3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150427Reviewed-by:
-
Neha Gupta authored
This CL adds ability to tab across links and highlights (along with already supported widgets) behind a newly added feature flag kTabAcrossPDFAnnotations. This is done by calling the newly added PDFium API FPDFAnnot_SetFocusableSubtypes(). A unit test has also been added to validate the added support. Here is the related CL: https://pdfium-review.googlesource.com/c/pdfium/+/60011/ Bug: 994500 Change-Id: I00312c00f3e6373949a4723cc65778fdb32ab963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783695Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Neha Gupta <negupta@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759380}
-
Eugene But authored
-[AppState applicationWillTerminate:applicationNavigation:] crashes on dereferencing null or invalid pointer returned from ios::GetChromeBrowserProvider(). GetChromeBrowserProvider returns pointer to an object created in application:didFinishLaunchingWithOptions:, so there are 2 possible explanations for this crash: 1. application:didFinishLaunchingWithOptions: was not called 2. there is a memory corruption (which is inlikely given the high volume of crashes with this particular stack) This CL should workaround the problem if root case is #1 and logs histogram to understand how often GetChromeBrowserProvider() can return null. Bug: 983504 Change-Id: Idfd5b22d0319cba5e1a38f78020d6fca1e01529c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145968 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: -
Kai Ninomiya authored
Change-Id: Ic7e2fa7612652cbb86b2be07ce10d9bea3ce194d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151330 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759378}
-
bttk authored
RecordHistogram can now be used without native. Bug: 1069507 Change-Id: If4a6dd84b510f021f6e690df7e6e8d112e031caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148042Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759377}
-
Siyu An authored
Add an experiment flag and change the navigation logic for upstream bubble and card migration bubble. New sets of metrics will be added in the following CL. Bug: 1070799 Change-Id: I7c81b1b568ea10c179c402aeb9be9a3002496370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149696 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759376}
-
Kurt Horimoto authored
TabHelperDelegateInstaller is a utility class template that sets up delegates for tab helpers for all the WebStates in a Browser. Now that OverlayPresenter can be used to implement tab-specific UI functionality, tab helpers can show UI without delegating this functionality to coordinators. This coupled with the increasing usage of BrowserAgents in preparation for multi-window support means that more tab helpers will be using Browser-scoped C++ delegates implemented in BrowserAgents. Bug: none Change-Id: Ieed54409bcfb228685baa417ad4fdc7d3e3f45b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Revert "Tab strip ideal bounds are calculated from the available width instead of the current width." This reverts commit d091784a. Reason for revert: caused crash regression https://bugs.chromium.org/p/chromium/issues/detail?id=1070980#c1 Original change's description: > Tab strip ideal bounds are calculated from the available width instead of the current width. > > This obviates the need for the work described in > go/chrome-nonpredictive-tabstrip-animations. > > One known issue: with stacked tabs enabled, resize a window to trigger > a transition into the stacked layout. The tabs will animate into the > new layout, and while this is taking place, they will ignore any > further changes to the tabstrip's bounds. > > Further work: Continue removing now-dead code from the new animation > system. > > Bug: 958173 > Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759054} TBR=sky@chromium.org,pbos@chromium.org,tbergquist@chromium.org,connily@chromium.org Change-Id: I4b995aeb6515aa675442e4cf69a4a4d0be48e840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151425Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#759374}
-
Antonio Gomes authored
BUG=767015, 1063749 R=svillar@igalia.com Change-Id: I727fd772a631c03e038da4687881d3f9ec707ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144250 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Aaron Leventhal authored
It's a performance bottleneck. It was originally added here: https://codereview.chromium.org/1195353002 - but the test added then still passes without this code. I tried reverting some other recent patches but I can't pinpoint what made it start working. We re-landed this a year ago and it caused crashes on the index.html page for the built-in PDF viewer extension, specifically on Mac. We should try relanding and determine the actual cause of that crash if it occurs again, since we know what page causes it. Bug: 489590, 579199, 916936 Change-Id: Ic142d7ac2711698513069bdda5376920a8e00bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148035Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759372}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2a94f532d738c88f24b6dc7fa4fa2f8d990a421e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150400Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#759371}
-
Harald Alvestrand authored
This simplifies the class hierarchy; the class is no longer used outside of modules/peerconnection. Bug: chromium:787254 Change-Id: Iff526b1ef1d6d324c67b72ff3e1420ccd1f0ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144025Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Bryan Clark authored
We don't have support for alsa on borg, so this is needed to prevent an endless stream of alsa related errors. Bug: b/151360165 Change-Id: I765b98d637ed1741c16069024160c5748ec6cde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150032 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Bryan Clark <bryanclark@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#759369}
-
