- 28 Sep, 2020 40 commits
-
-
Moe Ahmadi authored
Modules do not need names in addition to titles. Bug: 1130799 Change-Id: I6475d1b1b72b5e94e7417dbf533b7684c051fd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436374Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811439}
-
Yulun Wu authored
chromium/src/ash/app_list/views/app_list_folder_view.cc:260: Add #include <utility> for move [build/include_what_you_use] [4] chromium/src/ash/app_list/views/folder_header_view.cc:46: Add #include <memory> for make_unique<> [build/include_what_you_use] [4] Bug: 1130129 Change-Id: I0f9351349ae983d45e12591f74b97c3d5c5ceff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419756Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811438}
-
Reilly Grant authored
Based on a stable 1% experimental launch in M-85 new backend appears to be stable. Enabling it by default so that it rolls out to all users as part of M-87. Bug: 637404 Change-Id: I57d996c1cef5c5c097561c9c23b9ae713825e4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436292 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811437}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08ae7cea30d2..e39b378d4a92 2020-09-28 mbonadei@webrtc.org Remove tests associated to WebRTC-LibvpxVp{8,9}TrustedRateController. 2020-09-28 danilchap@webrtc.org Delete RtpRtcp::BitrateSent as no longer used 2020-09-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0957d98f..3274067a (810507:811217) 2020-09-28 guidou@webrtc.org Add API to allow legacy TLS protocols. 2020-09-28 hta@webrtc.org Refactor webrtc::PeerConnection to split out offer/answer 2020-09-28 tommi@webrtc.org Delete dead signal code in pc/channel.* 2020-09-28 mbonadei@webrtc.org Compile screen capturer mac test only when is_mac=true. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131805 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id129c3c36831d735d142996385e07a96c931bfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1fbf9326. With Chromium commits locally applied on WPT: 6bdcd688 "[COOP] access reporting: split property.https.html test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I3be97c0bbe568962b2b62fcb2a2b30cef9f6b32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436651Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811435}
-
Siyu An authored
We don't need this field in the MVP scope, and we are not 100% sure what format of the text will be. So remove it for now. Will add it back when we really use this. Bug: 1112095 Change-Id: I919c5520cf14da24d9474fff0b3f95716fd31935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432322Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#811434}
-
Matt Swartwout authored
A basic true/false does not encapsulate the full error reasons. Some clients may want to behave different on a ConnectionPending error vs a real connection failure. Bug: None Test: None Change-Id: Ic38eaad6dd0d27046e9c9d8d6fe45847756046e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431408 Commit-Queue: Matt Swartwout <mwswartwout@google.com> Auto-Submit: Matt Swartwout <mwswartwout@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811433}
-
Emily Stark authored
We are not planning to run the stable experiment with this enabled. Bug: 1090393 Change-Id: I2763b67032564580806f0053b1507e5d7a4334c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431460Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811432}
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ice5e4cf1583502d47cf4350274c9b58fc5ebc142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434737Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#811431}
-
Sophey Dong authored
AndroidX's DialogFragment does not have the issue where onAttach(Context) is not called for API < 23. Bug: 1131851 Change-Id: I116785d34f59dde51ed3204c12867aad486237e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430325Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#811430}
-
Andrew Grieve authored
This reverts commit 0ce26a3b. Reason for reland: Leaving in a suppression that broke tests. Original change's description: > Revert "Android: Remove StrictMode usage from //chrome" > > This reverts commit 1de470a5. > > Reason for revert: Likely caused a lot of test failure due to StrictMode. > An example build is https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27067 > > Original change's description: > > Android: Remove StrictMode usage from //chrome > > > > Removes direct usage (StrictModeContext left for follow-up) > > > > These suppressions are safe to remove now that StrictMode handling in > > chrome has been switched to a filter-based approach. > > > > Bug: 1038384 > > Change-Id: I59ee33bd1e34249c6be7973e5d759007ec0b2533 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410537 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#809402} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org > > Change-Id: I6277029a7154c53d2ea1bc0f4d7cc6b9aacb0e62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1038384 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424989 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#809584} Bug: 1038384 Change-Id: Ibb41fc756f9e1aa76d738cdc08436d1013562cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426465 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811429}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7930477fba50..19e9df68a7bb 2020-09-28 jmadill@chromium.org Re-land "Add a small unit test that dumps system info." 2020-09-28 jmadill@chromium.org D3D11: Enable renderable mipmap generation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1130678 Tbr: jonahr@google.com Change-Id: Ia345f8a6812e2b493820da438bd51f1fa82e9688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436438Reviewed-by:
-
Dave Tapuska authored
Accessiblity can use gfx::RectF directly instead of using the deprecated WebFloatRect. Change-Id: I9ae67e219900bb4df7857a6d935280cc41966a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431794 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811427}
-
David Black authored
Pinned files container should show a prompt to the user when empty, otherwise the pinned files. This CL also: - Updates a few styles. - Fixes a bug in which downloads were not restored due to the time of first enabling holding space not being stored to prefs. Bug: 1131253 Change-Id: Ife26c626e633c4263fea80610b4948c7971ba09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434465 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811426}
-
Nektarios Paisios authored
This patch prepares the groundwork for three related changes: 1. The merging of AXNodePosition and BrowserAccessibilityPosition by moving hypertext computation to AXNode. This work will be completed in the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2327552 2. Computing the value of rich text fields on the browser which will improve performance considerably in online document editors such as Google Docs, once Blink stops computing and sending their value with every selection or text change event. This work will be done in the following patches: A) Improves performance by generating value and text changed events on the browser instead of in Blink. https://chromium-review.googlesource.com/c/chromium/src/+/2322487 B) Stops generating the value attribute for non-native text controls. https://chromium-review.googlesource.com/c/chromium/src/+/2250070 3. Consolidates all the methods for retrieving the value of any control, e.g. text field, color well, <select> element and ARIA combo box, in AXNode::GetValueForControl. This will enable Views to use an AXTree and deduplicate logic between BrowserAccessibility and AXPlatformNodeDelegateBase. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Change-Id: Iadd42e69d47394db95401a9822dd5a5eb55fb520 Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312642 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Dominic Farolino authored
This CL adds a helper to RenderFrameProxyHost that retrieves a reference to the relevant AgentSchedulingGroupHost via SiteInstanceImpl. Via the helper above, this CL migrates the last non-AgentSchedulingGroupHost call-site of RenderProcessHostImpl::GetRemoteRouteProvider() to go through AgentSchedulingGroupHost. Furthermore, by usage of util::PassKey, this CL restricts the usage of RenderProcessHostImpl::GetRemoteRouteProvider() to AgentSchedulingGroupHost only, until we actually move the underlying route provider implementation to AgentSchedulingGroupHost. Bug: 1111231, 1132901 Change-Id: I18d73b5e8d9e30b871cbb373f276f58476a1785d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433057Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#811424}
-
Jeffrey Kardatzke authored
This adds the mojo OutputProtection interface and implementation that is used to provide the OutputProtection service to the Chrome OS cdm-oemcrypto daemon. BUG=b:168230642,b:153111783,b:132039686,b:169530695 TEST=Unit tests pass, HDCP enabling/verify works with daemon Change-Id: Ia40a8631894f937e79ab4504a7121d31b3713ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432804Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#811423}
-
Jack Lynch authored
This CL pushes out the expiration of two histograms by a year: DevTools.KeyboardShortcutFired and DevTools.KeybindSetSettingChanged Bug: 1130657, 174309 Change-Id: Id6af73627f34477ed4b87e2b42df547cd42fb28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432136Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811422}
-
Hirokazu Honda authored
A frame context is necessary to parse vp9 compressed data and the context is updated every frame by default. In other words, it is necessary to see all previous frames. In temporal layer encoding, frames in temporal layers, e.g. TL0 only stream and TL0+TL1 stream, must be able to be decoded even though there is no frames in TL2. To resolve the frame context problem, we enable error resilient mode in temporal layer encoding. It let the frame context not be updated and thus the syntax of a frame can be decoded independently of the previous frames. Bug: b:169219904, b:169538499 Test: https://appr.tc/?vsc=vp9&vrc=vp9 Change-Id: I976dc2d2f0f91d69b87b081da22f1c153ecb634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435030Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811421}
-
David Grogan authored
This is very similar to https://chromium-review.googlesource.com/c/chromium/src/+/2399082 , which dealt with items whose inline axis was the flexbox's main axis. This patch deals with items whose block axis is the flexbox's main axis. Old behavior: Use post-layout height of image items, obeying min/main/max height. New behavior: use the intrinsic height after applying the aspect ratio and min/main/max width. Ignore computed min/main/max height. Fixed: 987000 Change-Id: If64eeca9cc541bec863b1132aea4fd89305f5d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433629 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#811420}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3cd3b4e18cd1..21e6e530cf90 2020-09-28 sebmarchand@chromium.org Make the CHROME_SHUTDOWN_TIMEOUT var work on !win platforms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1071664 Tbr: rmhasan@google.com Change-Id: If7c8e3dc43c7b6fce2b2d6b38fa401df74d91011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435905Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/spellcheck This CL was uploaded by git cl split. R=timvolodine@chromium.org Change-Id: I8e56e103edc746726326ebef61563614b82fd6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435961 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811418}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/defd223d4023..3d921f1b2c56 2020-09-28 johnstiles@google.com Add unit test to demonstrate lack of SkSL swizzle optimization. 2020-09-28 johnstiles@google.com Add 'tricky' OutParams golden output. 2020-09-28 mtklein@google.com impl q14 in JIT using even lanes 2020-09-28 herb@google.com air gap SkStrikeClient API from implementation 2020-09-28 bungeman@google.com Respect kGenA8FromLCD when creating mask from path. 2020-09-28 herb@google.com introduce SkGlyphRect specialized for union & intersect 2020-09-28 johnstiles@google.com Fix call counts for intrinsic functions. 2020-09-28 johnstiles@google.com Reland "Support out parameters that use a swizzle." 2020-09-28 michaelludwig@google.com Check SkRRect::transform result, don't assume S+T matrix is safe 2020-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6a3c229f to 8563523f (1024 revisions) 2020-09-28 bungeman@google.com Fix gms placing text in bounds. 2020-09-28 bsalomon@google.com Log more info for Chrome bug 1132617 2020-09-28 egdaniel@google.com Use sk_sp for GrVkImageViews. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1132617,chromium:1132739 Tbr: brianosman@google.com Change-Id: Icb6397aa0b3e78e24b85a64d3eea0ad53bd1eee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436096Reviewed-by:
-
Dan Harrington authored
We were loading xsurface at startup when FeedV2 was enabled. Now it's only loaded when the feed surface is created. This change shouldn't even affect normal startup when the NTP is loading, because the startup() function is typically called after creation of the feed surface in that case. Bug: 1130677 Change-Id: If5edaa35fc387e92530b01e2421e1eef4b6ced82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422690Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#811416}
-
Kevin McNee authored
The GetRenderWidgetHostViewMac(NSObject*) test function was using whether a WebContents was a guest to determine whether a cast to RenderWidgetHostViewMac was safe. This would not be correct with other nested WebContents, so we update the logic to check for a root RWHV before casting. Bug: 533069 Change-Id: I7af9fae9a862e2731e5770a1f628f9d6c39f8dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436950Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/chromeos/crostini This CL was uploaded by git cl split. R=hollingum@google.com Change-Id: I5fa53d165710036fd346b5d864251502ce57cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435979 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#811414}
-
Ahmed Fakhry authored
This reverts commit 3df38ad3. Reason for revert: OverflowScrollInterruptedByInstantScroll fails on linux-chromeos-dbg BUG=1133037 Original change's description: > Rewrite scroll interruption tests into browser tests > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. We rewrite below tests > fast/scroll-behavior/main-frame-interrupted-scroll.html, > fast/scroll-behavior/overflow-interrupted-scroll.html and > fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests > because we cannot guarantee that the scroll arrives before the animation > completes. > > Bug: 1047176 > Change-Id: I79275eb7f2a78fd52e0c1ac93c4ee7d95d27b22f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250663 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811361} TBR=ajuma@chromium.org,bokan@chromium.org,lanwei@chromium.org Change-Id: I124efbb27cbba87f09c96e4813ad66532487b95e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436781Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811413}
-
Alan Cutter authored
This CL is a mechanical change that renames GetAppLaunchURL() to GetAppStartUrl(). This makes the getter more consistent with the web app manifest field it represents: https://www.w3.org/TR/appmanifest/#start_url-member This is in preparation to reintroduce GetAppLaunchUrl() with a slightly different behaviour. Instead of just returning start_url it will append any query parameters specified at install time to be used as the launch URL. Bug: 1045537 Change-Id: I99d1b16f83caaa5b53a0c392268dc9b389b0aa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435135Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#811412}
-
Curt Clemens authored
BluetoothMediumClassic::GetRemoteDevice should now return a new device with the given mac address if one hasn't been added yet. Bug: 1131981 Test: unit_tests Change-Id: I5a8f19469799074e667bfa05f3ae667d789d8572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435821 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#811411}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idacff67c0f62dc93adbc5e22551b0c5c6e335132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436436Reviewed-by:
-
Haiyang Pan authored
This reverts commit 4f50dcad. Reason for revert: Revert to release resource for Android M CQ builder as the bot usage is high now: http://shortn/_6Egeg4knUp Original change's description: > luci: increase the experimental percentage to 20 from 5 for MM-x86-rel > > The builder runs a smaller test suite since crrev.com/c/2422710. > The GCE capacity should be able to hold more traffic. > > Bug: 997376, 1127110 > Change-Id: I23c9bb5b55aa5f335dea3bdc1817c4793fcf9eb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429249 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811299} TBR=liaoyuke@chromium.org,hypan@google.com Change-Id: Iddef5694a45ec74fcfd4bb478008963bde2fcf5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997376 Bug: 1127110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436854Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3860f7c6..a9c65f64 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0692fe45254dcddf5f9bbbefd39d38a6cf3e1ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436059Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811408}
-
Jesse Schettler authored
Add a new Polymer element, source-select, to display scan sources (e.g. flatbed, document feeder, etc.) in a dropdown. Styling will be added in subsequent CLs. Bug: 1059779 Change-Id: I88603298c3c749905527b5d74216f6285d984d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424988Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#811407}
-
Daniel Hosseinian authored
Adds a setter for the thumbnail element to accept an ImageData object with which to paint the canvas of its thumbnail. The canvas is sized according to the dimensions of the image and the screen resolution. Bug: 652400 Change-Id: I885a1524cadd55731d90bfd0a8d2c4788beb1370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430728Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#811406}
-
Michael Hansen authored
This is a follow-up from the Nearby Connections uprev to add the |enable_bluetooth_listening| advertising option which allows listening on incoming Bluetooth Classic connections. Bug: 1131986 Change-Id: I76c5ee5583264e0e65afdc6f48db4455922f5c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432197 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Alan Cutter authored
AccountManagerUIHandlerTest tests were disabled in https://bugs.chromium.org/p/chromium/issues/detail?id=1131834 due to flakiness with ExternalWebAppManager. This is due to https://chromium-review.googlesource.com/c/chromium/src/+/2423823 altering the behaviour of when chromeos::ProfileHelper::IsPrimaryProfile() gets called uncovering an incompatiblity between the profile created by these tests and IsPrimaryProfile(). This CL disables ExternalWebAppManager's start up flow to avoid triggering the IsPrimaryProfile() incompatibility so we can re-enable these tests. Bug: 1131834 Change-Id: Ia4d15785a64b45689f742d3604c10e1b8502cafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#811404}
-
Xiaohui Chen authored
Bug: b:169578241 Test: manually Change-Id: Ia9ae5b9a71838c160ca81c73842c59b71db16270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436583Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#811403}
-
Austin Eng authored
Adds Dawn's tests to Linux FYI Experimental Release (NVIDIA) Bug: chromium:1016948, dawn:200 Change-Id: I69f3c9d7c4eb4e54e7ae2c5d8738547b4784d17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424036 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811402}
-
Sebastien Marchand authored
There's 2 issues with histogram_paths.py on Windows: - Some path have different casing on Win vs Linux, see crbug.com/1132974 . This is not the right way to fix this but this allows running histogram_paths.py on Windows. - Normalizing the path separators after sorting them causes some sorting differences (this causes "tools/metrics/histograms/histograms_xml/renderer4/histograms.xml" to appear before "tools/metrics/histograms/histograms_xml/renderer/histograms.xml" on Windows. Bug: 1132974 Change-Id: Id6953f29f2073551df9a13cc2c72d2e6eef33cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436293Reviewed-by:Weilun Shi <sweilun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811401}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/views/extensions This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I5300e111b30d94c6571f090128a32ad638f0f2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435980 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811400}
-
