- 13 Sep, 2017 40 commits
-
-
David Tseng authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I403f6a8d408a068860f1baa06a7e2b6a78300399 Reviewed-on: https://chromium-review.googlesource.com/654140 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#501610}
-
Rohit Rao authored
This test is failing flakily on the bots. BUG=764691 Change-Id: Ief33f7d5613a12610d6734db0ce798ac7564644c Reviewed-on: https://chromium-review.googlesource.com/664957Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501609}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/49fbcfa16b5d..596aa47eec50 $ git log 49fbcfa16..596aa47ee --date=short --no-merges --format='%ad %ae %s' 2017-09-13 perezju [experimental/qbot] Python module to interact with Buildbot Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie1ccfa618f24fd437c95ea119e918fdc09b545fe Reviewed-on: https://chromium-review.googlesource.com/664597 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501608}
-
Gabriel Charette authored
R=rdevlin.cronin@chromium.org Bug: 667892 Change-Id: I21df3c5a2eac7d6a5d2b1a3bc0322d752baca286 Reviewed-on: https://chromium-review.googlesource.com/663767 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501607}
-
Gabriel Charette authored
ios/ equivalent to https://codereview.chromium.org/2841593003 R=sdefresne@chromium.org Bug: 689520 Change-Id: I6aa6a0042f26177f9db38053f9c05bb1402aaf75 Reviewed-on: https://chromium-review.googlesource.com/664064Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#501606}
-
Chris Pickel authored
I renamed the class, but forgot to change the manifest, and the class became incapable of receiving intents. Bug: 764646 Change-Id: Ie6128bd2ea07c0b0d0eb8eefc1d17b1354911c30 Reviewed-on: https://chromium-review.googlesource.com/663730Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#501605}
-
Rohit Rao authored
This test was already disabled on iOS 11 iPad, but it has started failing on iPhone as well in the iOS 11 GM build. BUG=753098 Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83 Reviewed-on: https://chromium-review.googlesource.com/664837 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501604}
-
Yuki Shiino authored
Creates a new header TraceWrapperBase.h and makes ScriptWrappable.h and TraceWrapperMember.h include TraceWrapperBase.h that defines TraceWrapperBase class. Bug: Change-Id: I9135b9394ef4a116322d6f9fc1ac97969e4735f3 Reviewed-on: https://chromium-review.googlesource.com/664503Reviewed-by:
-
Walter Korman authored
Change-Id: Iba7b4793e70ab7cda182b0fba47beef117119e20 Reviewed-on: https://chromium-review.googlesource.com/664385Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#501602}
-
Marti Wong authored
Demo: https://drive.google.com/open?id=0B1O0Z7eoZMuGbjM3TnJ3eVRoYmM Bug: 695749 Change-Id: Id1cf2cb9877ccedf12a2f76dffa671bc3ae88439 Reviewed-on: https://chromium-review.googlesource.com/658164 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#501601}
-
Ondrej Skopek authored
Fixes the issue of showing an error message for a short time before restarting Voice Search after click on the Try Again link (the microphone icon retrying worked correctly). As a result, removed the |speech.restart| function and associated test. Now, the display of the "Try Again" message is tested in text module tests, and the actual click handling is tested in the view module. Renamed the |text.cancelListeningTimeout| function to |text.clearListeningTimeout| for consistency. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5815f9857b90264340ebb37b9ef603bbae404ea Reviewed-on: https://chromium-review.googlesource.com/663547Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ondrej Škopek <oskopek@google.com> Cr-Commit-Position: refs/heads/master@{#501600}
-
ericwilligers authored
The :focus-within pseudo-class shipped in Chrome 60. The runtime flag is no longer needed. BUG=617371 Change-Id: I12db298d40df458c24987e7928d85aea179e6046 Reviewed-on: https://chromium-review.googlesource.com/662984Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501599}
-
Max Morin authored
AudioInputController unconditionally calls UserInputMonitor::DisableKeyPressMonitoring when closing, but only calls EnableKeyPressMonitoring when Record is called. This leads to a messed-up reference count in UserInputMonitor if we close a stream without first starting it. Bug: 764656 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id85c5c2d26d2745588d8c6cc7c4555adddb9c2f2 Reviewed-on: https://chromium-review.googlesource.com/664577Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501598}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6442dfd5..fd1dd40d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifde3bf1e13d4116896defa1d8447bd7a88ba0b60 Reviewed-on: https://chromium-review.googlesource.com/663680Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501597}
-
Gyuyoung Kim authored
Bug: None Change-Id: I4f7fb1e3a682cfddd951a08266d8239efc4f1970 Reviewed-on: https://chromium-review.googlesource.com/663536Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#501596}
-
Takashi Toyoshima authored
Provide TimestampToTimeDeltaDelay as a static helper method of MidiService, and use it to calculate a delay time for a timestamp to post a delayed task. Bug: 672793 Change-Id: I7307bb816c262073ceae557ad9345c451051d414 Reviewed-on: https://chromium-review.googlesource.com/656924 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#501595}
-
galinap authored
This CL adds an offline icon when the user downloads a suggestion from the context menu. This is done by registering an OfflineModelObserver in the SuggestionsCarouselAdapter. Bug: 763390 Change-Id: I8cf9adf54706927b5f11628c7e330b42eb4f2e94 Reviewed-on: https://chromium-review.googlesource.com/660538Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Galia Peycheva <galinap@google.com> Cr-Commit-Position: refs/heads/master@{#501594}
-
John Mellor authored
This reverts commit 793d799b. Reason for revert - made TabsTest very flaky on the following bots: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/15045 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/45549 Original change's description: > Convert TabsTests and IncognitoNotificationServiceTest to JUnit4 > > For more on JUnit4 migration, please check src/testing/android/docs/junit4.md > > Bug: 640116 > Change-Id: I508ee1b6512a4a96175d1747a0f8ebe1764f11e6 > Reviewed-on: https://chromium-review.googlesource.com/662241 > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501446} TBR=tedchoc@chromium.org,yolandyan@chromium.org Change-Id: I86ba1b7776b734a9150a09a3b6994c46732ac1e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 640116 Reviewed-on: https://chromium-review.googlesource.com/664717Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#501593}
-
Ramin Halavati authored
Traffic annotation auditor would need to accept its clang tool from arbitrary (non-default) path and is updated to accept a switch for this. Bug: 656607 Bug: 690323 Change-Id: I071718f0410ecc636d71cbfc4fa9f18f9fcf1d19 Reviewed-on: https://chromium-review.googlesource.com/634908 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501592}
-
Raphael Kubo da Costa authored
Follow-up to https://chromium-review.googlesource.com/576183 ("bindings: Return the right property descriptors for legacy platform objects"), which introduced the indexed descriptor callbacks for bindings. Even if a given IDL (such as Storage.idl) only supports named properties, our bindings layer installs a handler for indexed properties that, in this case, mostly just ends up falling back to the named property handlers. However, we were not defining a descriptor callback for indexed properties when the IDL only supports named properties. Consequently, we were not setting the right property descriptor values for a given numeric property, leading to bizarre cases where, e.g. if Storage only had numeric keys, Object.values() and Object.keys() would return arrays of diffferent lengths (the latter would be an empty one, actually). This change is a bit complicated because we install our indexed and named property handlers differently: the former is created with descriptor and definer callbacks, whereas the latter uses the query callback signature instead. This means the indexed property descriptor callback for named properties needs to call the query callback and translate its return value into a format suitable for descriptor callbacks, which is not very efficient. Ideally, both named and indexed properties should converge in terms of how their handlers are declared. Despite the fact that this is a follow-up commit, the original CL did not introduce a regression; interfaces that only support named properties were just behaving like they did in the past, with an indexed descriptor callback not being set. Bug: 719703, 764633 Change-Id: I1ebaabe61f5f8b6cadb0cfa8b41664a64e49e51b Reviewed-on: https://chromium-review.googlesource.com/660497 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I88f2d778c7f0351daf6165fefc0c8654f209dca7 Reviewed-on: https://chromium-review.googlesource.com/663426Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#501590}
-
Jinho Bang authored
The current PaymentInstrumentIconFetcher class is too complicated and can not ensure thread-safety due to misuse some APIs. So, this patch refactors the class to use ManifestIconDownloader internally. After this patch, we can remove much duplicated codes and resolve some crashes in debug mode as well. Bug: 752836 Change-Id: I04c01d433d093ae138148e6aa2849bc1713c1c85 Reviewed-on: https://chromium-review.googlesource.com/658201 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501589}
-
Morten Stenshorne authored
Such breaks used to go unnoticed and cause misery and assorted unpleasantries. Upgraded test expectations. Added a unit test. As long as we haven't both got an in-flow child that broke AND exceeded available fragmentainer space, we need to continue and lay out its siblings. A block of zero height at a fragmentainer boundary actually belongs in the former fragmentainer, not the latter. A consequence of this change is that even non-zero height blocks that start at a fragmentainer boundary gets a zero-height fragment in the former fragmentainer, before it continues in the next fragmentainer. We may want to avoid this, but I'm not sure what's more correct yet (or if it matters at all). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I50e862d8c0dc787a47b799e2e639e5ca7ba57158 Reviewed-on: https://chromium-review.googlesource.com/663141 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
-
Mounir Lamouri authored
YouTube has deprecated Flash embeds so it will provide a better experience for our users to have them inlined with possible breakage instead of having to use Flash and navigate to YouTube. Bug: 763322 Change-Id: I3243e3048f499ec51e3220ebd18201a94e3eca46 Reviewed-on: https://chromium-review.googlesource.com/657277Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#501587}
-
ericwilligers authored
Support for font-display shipped to stable in Chrome 60. The runtime flag is no longer needed. BUG=669455 Change-Id: I8d7e5eb46797dc78f9f4330dcba28ab68212f2e5 Reviewed-on: https://chromium-review.googlesource.com/659719Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#501586}
-
Takashi Toyoshima authored
Mechanical changes to use BindOnce and OnceCallback explicitly at everywhere in media/midi. Bug: 672793 Change-Id: Ibef3543d3b91f6617f5116a845b03e0ccb823629 Reviewed-on: https://chromium-review.googlesource.com/657357 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#501585}
-
Ramin Halavati authored
The following changes were done: 1- Auditor adds a list of OSes that actively use each annotation to annotations.xml, so that removing annotation from one OS and keeping it in another would not result in marking it deprecated. 2- A script is added to tools/traffic_anntotation/scripts, to call all scripts that update a give file when annotations.xml is modified, or to run unittests that ensure these files are up to date. 3- 'test-only' switch added to Auditor. When this switch is present, auditor only checks if annotations.xml is up to date and issues an error it if is not. When switch is not specified, annotations.xml may get updated and if so, the above mentioned script is called to update downstream files. 4- Auditor will prevent use of deprecated unique ids. 5- Unittest checks that annotations.xml is loadable and its content are valid. 6- Unittest calls the script mentioned in (2) to test if downstream files are correctly updated. Bug: 656607 Bug: 690323 Change-Id: I00acbddbe14eeee23317bb9990069e00558a5bb4 Reviewed-on: https://chromium-review.googlesource.com/645088 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: -
Alexander Timin authored
Instead of exposing individual task runners (timer/loading/unthrottled) to content/, expose a method which returns an appropriate task runner for the given type. R=haraken@chromium.org,kinuko@chromium.org CC=hajimehoshi@chromium.org Change-Id: I16b6b04dd4ce2715dd2d7580c4cdc2fa45236de6 Reviewed-on: https://chromium-review.googlesource.com/657418 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501583}
-
Han Leon authored
This CL replaces native struct content::ServiceWorkerRegistrationObjectInfo with mojom struct blink.mojom.ServiceWorkerRegistrationObjectInfo. BUG=758151 Change-Id: I8e79e1d7ed46ca12c247d83448be0531e3818e50 Reviewed-on: https://chromium-review.googlesource.com/662369Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#501582}
-
Yeol authored
It's modified in core/frame and /platform. Bug: 751425 Change-Id: Ibe09bbd6debbcfcbef5624f98ec486770d97698c Reviewed-on: https://chromium-review.googlesource.com/611742Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#501581}
-
Yuta Kitamura authored
ContainerTypeOperations is a class template representing type traits for various generic container operations, such as storage initialization or bulk copy. This can be used, for instance, to use memcpy for efficient copying for specific types. This will be used in HashTable v2 (see bug). The set of operations are mostly inspired by Vector's traits. This traits is intended to become the unified traits that can be applied to any WTF containers (currently, Vector and HashTable have separate sets of traits). This patch only provides a basic implementation that should work for any types. Specializations for other types will be added later. Bug: 715430 Change-Id: Ie1fb852942e4f6210eef26cad7606833c5d1949f Reviewed-on: https://chromium-review.googlesource.com/641290Reviewed-by:
-
Jaebaek Seo authored
This is a subtask to enable use-zoom-for-DSF in Android. This CL correctly applies the DSF to Android scrollbars when using the 'use-zoom-for-DSF' flag. Bug: 737777 Change-Id: I207cdaf26b1501e99f80019acfe56240d704ce5a Reviewed-on: https://chromium-review.googlesource.com/620328 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501579}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17f4706e..6442dfd5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I11eff13dc65184a17c5af28a2a6b0d44ccd0a0c8 Reviewed-on: https://chromium-review.googlesource.com/663244Reviewed-by:
-
Klemen Kozjek authored
This CL adds an implementation for setting and reading last modified date of a file/folder in a zip file. As a result, last modified date of a file will not be default value anymore. BUG=607078 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idfcb3249360aa7c6d8ca8004a39ce38813bf4932 Reviewed-on: https://chromium-review.googlesource.com/664499 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#501577}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: Ic2f7c192a9899e21816de675fa19ac33fa5eb5e5 Reviewed-on: https://chromium-review.googlesource.com/642639Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Cr-Commit-Position: refs/heads/master@{#501576}
-
Matt Falkenhagen authored
There were two issues: * The contentWindow access was throwing an exception because Chrome's error pages are considered cross-origin. * The test uses a setTimeout of 10 sec since Mozilla had flaky failures at 5 sec. This issue is still unresolved, see github.com/w3c/ServiceWorker/issues/1194 However, somehow the test seems to pass on local Release despite taking over 6 seconds, so I'm leaving it out of SlowTests for now. Bug: 758892 Change-Id: I4ff501bcc679db6e7d6ddd7d70adfd33e79bd718 Reviewed-on: https://chromium-review.googlesource.com/664460 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#501575}
-
Christian Dullweber authored
To simplify the Clear Browsing Data ui on desktop, we introduce a basic section with the most frequently used options and an advanced section showing the existing options as well as an additional "Site settings" checkbox. The footers are removed and their information is integrated into the checkbox descriptions in the basic tab. This change requires a few additions to cr_dialog to inject a tab bar and restrict the dialog to a fixed height. SettingsCheckbox requires an additional attribute to add html with links to the summary. https://screenshot.googleplex.com/TvDGxE77XUC.png https://screenshot.googleplex.com/CvF0kx7UwSY.png Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2a84d468d9e4fd74c225d8a3668d8d1663f8da6 Reviewed-on: https://chromium-review.googlesource.com/580987 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501574}
-
Hiroshige Hayashizaki authored
In successful revalidation, - The SRI check result before the revalidation can be reused - Resource::Data() can be already null and thus we shouldn't check SRI again. This CL - Skips SRI checks if |integrity_disposition_| is already set (i.e. set before revalidation) to avoid crashing, and - Clears |integrity_disposition_| on failed revalidation to ensure correctness. Bug: 752830 Change-Id: I482cad4e6e0daa0c078f8fc5fe9f6c30526105dc Reviewed-on: https://chromium-review.googlesource.com/656297Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#501573}
-
Bugs Nash authored
Now that the legacy parsing code has been removed from the base API the CSSPropertyID argument is not required. This patch deletes the argument from the following base class methods as well as all overrides. - CSSPropertyAPI::ParseSingleValue - CSSPropertyAPI::ParseShorthand Bug: 668012 Change-Id: Iad91612b5917d7349cf4f6f3a1beb1286c7256fc Reviewed-on: https://chromium-review.googlesource.com/662927Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#501572}
-
Kári Tristan Helgason authored
Bug: None Change-Id: I5729ca7f84b19d09aa1bae586e5c921ad997bb43 Reviewed-on: https://chromium-review.googlesource.com/640380 Commit-Queue: Kári Tristan Helgason <kthelgason@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501571}
-
