GitLab

Chrome OS AccountManager has not been fully turned on yet and error
logging missing tokens file is creating noise in error logs.

This error log will be re-introduced once AccountManager is the default
Identity provider on Chrome OS and failure to read tokens file is an
actual error for all users.

Bug: 841524
Change-Id: I608306317f1aa6edc6f44ec3338df8a63b1bba5c
Reviewed-on: https://chromium-review.googlesource.com/1054673Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557872}

This CL fixes the case where network::TCPServerSocket::Listen() fails to catch
the error from net::ServerSocket::GetLocalAddress().

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I16916e1ddfd717715ab08ad56c06d1b38e220471
Reviewed-on: https://chromium-review.googlesource.com/1054588Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557871}

IsBlacklistMatch method can be simplified and removed by replacing it
with lambda function.

Bug: 831123
Change-Id: I80c838629c65270f022683d1d18b64fbba3c9f67
Reviewed-on: https://chromium-review.googlesource.com/1054874Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557870}

This reverts commit e6ae8f4c.

Reason for revert: Perf regression

Bug: chromium:841807

Original change's description:
> Switch to using skcms for ICC profile parsing
> 
> Change-Id: I8bafe64117d7247b7806e1d64d6e7e793078877c
> Reviewed-on: https://chromium-review.googlesource.com/1028452
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556861}

TBR=ccameron@chromium.org,bcwhite@chromium.org,mtklein@google.com,brianosman@google.com,mtklein@chromium.org,bcwhite@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I2cc981f9fcce42e94a0cc74240d51fc7dbb0f1db
Reviewed-on: https://chromium-review.googlesource.com/1054509
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557869}

Without specifying "fetch" in Info.plist, runtime generates spurious
warning messages.

Bug: 795802
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie9e73e52d626a170645a98db8e7ae90b61755ce1
Reviewed-on: https://chromium-review.googlesource.com/1050687Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557868}

Remove use of ToString(), and replace that with explicit width and
height checks instead. ToString() shows up in sampling profiles as
being rather expensive.

BUG=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I928962767f8078a9c50aef485000e31d52c2869b
Reviewed-on: https://chromium-review.googlesource.com/1054158Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557867}

This conditionally replaces "Autofill settings" with "Manage cards" or
"Manage addresses" when using the new Autofill UI.

Bug: 768881
Change-Id: I9257385a0af87d8208e54db5f56daf78f54b770f
Reviewed-on: https://chromium-review.googlesource.com/1054102Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557866}

Enabled in RELEASE/MSAN, now re-enable this test in DEBUG/ASAN because
crrev.com/557831 improved our browser test speed.

Tbr: fukino
Bug: 836254,837106
Change-Id: I8f0e803901926f37438125174c16b173bbb83f89
Reviewed-on: https://chromium-review.googlesource.com/1055527
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557865}

This uses the actual size of the native views dropdown to decide
if it will be drawn upwards or downwards, to the left or to the
right.

Screenshots can be found at: https://drive.google.com/open?id=1F43ccvwErhPS7hEmdKWl90i0yHmd3-7J

Bug: 768881
Change-Id: Iedc166b7c7edbdfe324c7657f7f319dc4032487f
Reviewed-on: https://chromium-review.googlesource.com/1036286
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557864}

Followup for the image of the activity service.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71a5c8679d2734fbc0ca942105d7478eef1dbc8d
Reviewed-on: https://chromium-review.googlesource.com/1055492Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557863}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I50de51120163cf0244b22c6e7cfca45327618cb3
Reviewed-on: https://chromium-review.googlesource.com/1045614
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557862}

Before this CL, TryStart and TryStartImmediately returned a bool.
However, nobody actually consumed it, and IMO its meaning was unclear
and more confusing than helpful. This CL removes the return values.

Bug: none
Change-Id: Ib9ff4786bd888d0fbefad7d89fc26be1e681238f
Reviewed-on: https://chromium-review.googlesource.com/1054876Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557861}

thread_time was previously overriding the wall time, but should actually
be reported in a separate UKM field.

Bug: 842112
Change-Id: If772b5276c0629a4184006bb5382939d9281d3d7
Reviewed-on: https://chromium-review.googlesource.com/1054011Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557860}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/98ce1809..e5661887

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I41375018f5acb805ae540ffed10ad1dc44e94c6d
Reviewed-on: https://chromium-review.googlesource.com/1054512Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557859}

1) Exclude deprecated model types (e.g. DEPRECATED_SUPERVISED_USERS and DEPRECATED_SUPERVISED_USER_SHARED_SETTINGS) from kModelTypeInfoMap presubmit check.

2) Improve a couple of comments in model_type.cc.

Change-Id: I68fd166396804c69ca567686b671ee9d19c624ac
Reviewed-on: https://chromium-review.googlesource.com/1054875Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557858}

This reverts commit e3d54350.

Reason for revert: Broke detached bookmark bar

Original change's description:
> Implement |GetChildrenInZOrder| in browser and top container views
> 
> Currently, we ensure that the bookmark bar view is always the first
> child view of its parent to ensure that toolbar inkdrops are drawn on
> top of it. Unfortunately, this breaks keyboard traversal order.
> 
> This change implements |GetChildrenInZOrder| on the two views that
> host the bookmark bar: browser view and top container view. This
> ensures that the bookmark bar is painted first, removing the need
> to manipulate child view order.
> 
> Bug: 712347
> Change-Id: If8f2aabe816a86b7ec29ff41779783c0f05a6393
> Reviewed-on: https://chromium-review.googlesource.com/1052854
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557537}

TBR=ellyjones@chromium.org,lgrey@chromium.org

Change-Id: I43286f3f1a771a8835f72d28c2333f67c9ef6b7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 712347
Reviewed-on: https://chromium-review.googlesource.com/1054594Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557857}

https://webrtc.googlesource.com/src.git/+log/73b36b582fcf..e72ea24d884b

$ git log 73b36b582..e72ea24d8 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8aa19aef3d7aede779021c77968de738a57ee254
Reviewed-on: https://chromium-review.googlesource.com/1055467Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557856}

This allows telemetry to have access to an indexed ruleset, without
having to specify one in the source tree (which would need to be
updated every time the format version changes).

Follow-ups will copy this into telemetry's user-data-dir.

Bug: 823982
Change-Id: Iba551b1cd6137d73bed8dfbb0bc69d00f32be7ab
Reviewed-on: https://chromium-review.googlesource.com/1052860Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557855}

This CL changes the style of the PopupMenu associated with the tab grid
button. If the action is destructive (closing the/all tabs), the action
is tinted in red.
Also it adds the same icon for closing all incognito tabs as the one for
opening a new incognito tab.

Bug: 831152
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84617985d0811d431e38ee58391dd22df1cfb8f0
Reviewed-on: https://chromium-review.googlesource.com/1051709Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557854}

|optional| in Web IDL must only accept |undefined| in ECMAScript,
and must not accept |null| unless the argument type is nullable.

    void foo(optional CallbackType foo_arg);
    void bar(optional CallbackType? bar_arg);

In this case, |null| should cause a TypeError for |foo_arg|.
(|bar_arg| is okay with |null| because the type is nullable.)

Blink supports this rule for non-callback argument types, but not
for callback function and callback interface.  This patch applies
this strict rule to callback function/interface, too.

Since historically Blink implementation has accepted |null| for
callback types, this patch also changes all existing argument
types to nullable types in order to keep the backward
compatibility.

Change-Id: I3212ddb1388f8a4facb6b846de1347263556632e
Reviewed-on: https://chromium-review.googlesource.com/1018320
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557853}

NOTRY=true  # Test covered by PRESUBMIT
TBR=eyaich@chromium.org

Bug: 841492
Change-Id: Id93784c4f9e91e665c8f251349cacd846560ef75
Reviewed-on: https://chromium-review.googlesource.com/1055469Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#557852}

Bare NONE is not great: scope resolve it SharedOption::NONE to make it
somewhat more obvious.

Tbr: fukino
Bug: 836254
Change-Id: If7b2ed65129ab8c6d0ce729037fac90fee3a3999
Reviewed-on: https://chromium-review.googlesource.com/1055352
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557851}

1, Added a progress bar to indicate page loading progress.
   The progress bar is hidden when progress is 1.0.
2, Moved payment handler icon from left to right.
3, Replaced the info icon with the gear icon.

Bug: 840803
Change-Id: I0386d268b54585c54836229ca7fece76fea5a4fd
Reviewed-on: https://chromium-review.googlesource.com/1053791Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557850}

https://skia.googlesource.com/skia.git/+log/0cc01b753ac6..244f754cdd6b

$ git log 0cc01b753..244f754cd --date=short --no-merges --format='%ad %ae %s'
2018-05-11 angle-skia-autoroll Roll third_party/externals/angle2/ 2fc0806f5..8073a9511 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Idd3964c1b57aa90fc664ceaa170dae5bdfba90f0
Reviewed-on: https://chromium-review.googlesource.com/1055206
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557849}

This CL re-enable the EG tests for the promo when UI Refresh flag is
enabled.

Bug: 832661
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4102d6c61cd774387817d5dc30d4794d02f42ac2
Reviewed-on: https://chromium-review.googlesource.com/1052112
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557848}

Using wpt-import in Chromium 98d8ce92.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17287

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
meade@chromium.org:
  external/wpt/web-animations

TBR=markdittmer

No-Export: true
Change-Id: Iac177b40f401cbc07dbd34989d2d3b1ed23d17b1
Reviewed-on: https://chromium-review.googlesource.com/1054510
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557847}

BUG=762641
TBR=sammiequon@google.com

Change-Id: I6c42039958ab12ff7a2c3633bfdbf6fc0053bfe2
Reviewed-on: https://chromium-review.googlesource.com/1054513Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557846}

This CL disables the QR code tests that are failing consistently.

Bug: 842072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I29acaf666d0f21a6dcbea1780fe56eb0f3ac4d5e
Reviewed-on: https://chromium-review.googlesource.com/1054231Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557845}

This isn't C++98 :)

Bug: none
Change-Id: I71a616498a7233ad932fa3f273ab87677eb346e8
Reviewed-on: https://chromium-review.googlesource.com/1052467
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557844}

This is [1/2] of the patch: https://chromium-review.googlesource.com/c/chromium/src/+/925987 to add Memory_Experimental UKM 1, 5, 10 and 15 minutes after page loaded.
ProcessMemoryMetricsEmitter is used to record Memory_Experimental UKM and emits the all processes' memory metrics.
Since we would like to use the same code to record the UKM, we modify ProcessMemoryMetricsEmitter to record the specified page's Memory_Experimental UKM, i.e. the specified renderer's Memory_Experimental UKM.

Change-Id: I99242123529a53c97e91153545a40e0f7aa21f26

Bug: 837498
Change-Id: I99242123529a53c97e91153545a40e0f7aa21f26
Reviewed-on: https://chromium-review.googlesource.com/1032150
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557843}

Add a note about the need to reply to a chrome.test.sendMessage: it is
imprecise to say that we "just ignore it", we must reply. And an empty
std::string() is a sufficient reply.

Tbr: fukino
Bug: 836254
Change-Id: I969cf4659e415fcd004f0619d9de04a2b2f10c7e
Reviewed-on: https://chromium-review.googlesource.com/1055034
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557842}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a8050d3d8618..ec4bbb378159

$ git log a8050d3d8..ec4bbb378 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 yunlian binhost: stop filter CFLAGS -clang-syntax

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I579ebca1089747a89e45fc6d9a5705a4ab44b542
Reviewed-on: https://chromium-review.googlesource.com/1055205
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557841}

This patch tests re-using NGInlineItems for all tests in
NGInlineItemsBuilderTest that use |TestAppend| function.

Also converts two tests to use |TestAppend| to increase the
coverage.

TBR=eae@chromium.org

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iab588f9aa5a2c6137c50f3444e2372b182f74b3c
Reviewed-on: https://chromium-review.googlesource.com/1055033Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557840}

Tbr: slangley
Bug: 841659
Change-Id: Ie9c79c80a3105ced7d97636ad8cb519e66d99244
Reviewed-on: https://chromium-review.googlesource.com/1055409Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557839}

This reverts commit 539d243b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 557832 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTM5ZDI0M2IwODdlNmUzMTI4MWMzMjI5OTI5ZjVhMWZjOTdjZDgyZgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Linux/None

Sample Failed Step: content_unittests

Sample Failed test: RenderFrameAudioInputStreamFactoryTest.CreateOpenedStream_ForwardsCall

Original change's description:
> Add a new RenderFrameAudioInputStreamFactory
> 
> It checks that the stream is allowed and forwards the request to the
> relevant ForwardingAudioStreamFactory if so. This will cause
> the stream to be served by the audio service.
> The old RenderFrameAudioInputStreamFactory which creates streams
> living in content/ is renamed to
> OldRenderFrameAudioInputStreamFactory. Since the class was renamed,
> the files were moved (by adding "old_" to the beginning). No need to
> review those files. Also note that replacement is diffed against
> the previous implementation. It's probably best to just ignore the diff
> and review render_frame_audio_input_stream_factory{.cc,.h,_unittest.cc}
> as new files.
> 
> The same flag as for output is used to switch between the old factory
> and the new one.
> 
> Approximate diagram of stuff:
> https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit
> 
> Bug: 830493, 836226
> Change-Id: Ib0f58a52d849a48ba79405f0d499444c66029b58
> Reviewed-on: https://chromium-review.googlesource.com/1050245
> Commit-Queue: Max Morin <maxmorin@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557832}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 830493, 836226, 842115
Flaky step name: content_unittests
Flaky test name: RenderFrameAudioInputStreamFactoryTest.CreateOpenedStream_ForwardsCall

Change-Id: If1683461af7fcbe0a9be633db62087dafe66235b
Reviewed-on: https://chromium-review.googlesource.com/1054162
Cr-Commit-Position: refs/heads/master@{#557838}

It's flaky on all platforms.

Tbr: smcgruer@chromium.org
No-Try: true
Bug: 829740
Change-Id: Ibcbf34bf2a999c0814cf2d5546109561093030be
Reviewed-on: https://chromium-review.googlesource.com/1054012
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557837}

This follows the best practice outlined in the whitepaper at
https://youtu.be/lrHJhKEtQEI.

Bug: 839648
Change-Id: Ic578859515ae2e1fdd13bf7966c544fe2490ffcf
Reviewed-on: https://chromium-review.googlesource.com/1051244
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557836}

Now it loads owner key to identify the owner. This does not work for
Active Directory devices which does not contain the key.

BUG=chromium:709416
TEST=manual

Change-Id: I44469a2f0b68910490ffa45cef14be6e53ff1cae
Reviewed-on: https://chromium-review.googlesource.com/1046602Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557835}

This reverts commit 05267e5e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Cancel parallel download request if server doesn't send partial response"
> 
> This reverts commit 13077433.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Cancel parallel download request if server doesn't send partial response"
> > 
> > This reverts commit 189d1033.
> > 
> > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666.
> > 
> > Original change's description:
> > > Cancel parallel download request if server doesn't send partial response
> > > 
> > > If the server doesn't support partial responses, Chrome should cancel
> > > parallel download requests.
> > > These requests result in the wrong write offset and makes the file larger
> > > than the original
> > > 
> > > BUG=838627
> > > 
> > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba
> > > Reviewed-on: https://chromium-review.googlesource.com/1048130
> > > Commit-Queue: Min Qin <qinmin@chromium.org>
> > > Reviewed-by: Xing Liu <xingliu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#557252}
> > 
> > TBR=qinmin@chromium.org,xingliu@chromium.org
> > 
> > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 838627, 841666
> > Reviewed-on: https://chromium-review.googlesource.com/1053470
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557489}
> 
> TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org
> 
> Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 838627, 841666
> Reviewed-on: https://chromium-review.googlesource.com/1054887
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557734}

TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org

Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49
No-Try: true
Bug: 838627, 841666
Reviewed-on: https://chromium-review.googlesource.com/1053729Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557834}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/394f1c63d58a..a8050d3d8618

$ git log 394f1c63d..a8050d3d8 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 bpastene cros_run_vm_test: Pass board and cache dir args down to deploy_chrome.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:823996


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1fb09689cbf824cf46c5332a473261f6c6ca55b8
Reviewed-on: https://chromium-review.googlesource.com/1055193Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557833}