GitLab

Per discussion on chromium-dev
(https://groups.google.com/u/1/a/chromium.org/g/chromium-dev/c/F2xhH0h36rU),
set up stack tracing and enable error reporting when
ReadyToCommitNavigation is called instead of when RenderFrameCreated is
called.

Bug: chromium:1121816
Change-Id: Ie0aaf56ced830180284f153bc43322701c95e504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585659
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838262}

This CL ensures paper-tooltips is not a hop on keyboard arrows key
navigations.

Bug: 1158411
Change-Id: I6067312772859ef62bbb98d4d368edd93e3e9a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592789
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838261}

At smaller window sizes, parts of the settings section become hidden
from view. Allow users to scroll through the settings section when this
occurs.

Screenshot: http://shortn/_kQ7nVMKigV

Bug: 1059779
Change-Id: I1e118760c8dfa6a191163416028681b3644d6869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596170Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838260}

In CL:2577757, we enabled fragmentation for absolutely positioned nodes
with `height: auto` and positioned with the bottom property. That
uncovered a bug with nested abspos in a fragmentation context - the
innermost abspos was never laid out.

This CL fixes it. We now query the OOF descendants generated during the
layout pass of the outermost abspos right after the layout is completed
to lay them out - if there are any.

For the moment, the offset of the innermost abspos is still wrong, but
the crash is fixed.

Bug: 1157086
Change-Id: I1031f4837f493032feb5de047e2366afc6d69599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587553Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#838259}

When doing sentence navigation, we will first search for next sentence
start within the current node group. If that fails, we will look for the
rest of the content within this paragraph. If we still cannot find a
sentence start, we will look for the next paragraph.

Once we find a sentence start, we will get the nodes from the sentence
start until the end of that paragraph. Then, we will send the new
content to TTS.

AX-Relnotes: N/A.
Bug: 1143823
Change-Id: I051c572d4a9f866aeb37fba32137ed81b9cac744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587799
Commit-Queue: Lei Shi <leileilei@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838258}

If an entire iframe is display locked by an element in the parent
document, it throttles rendering in the iframe's content frame and
also forces all IntersectionObserver's to report "not intersecting".
This is already the case for same-process iframes; this CL extends it
to OOPIF's by informing the OOPIF when it is display locked by the
parent.

Change-Id: I4cb89c515c74b6a39a0d5cf8a4fd721eb9b95b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587657
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838257}

https://dawn.googlesource.com/dawn.git/+log/155241b665f8..ee977a0df8e3

2020-12-17 enga@chromium.org Update MultisampledSamplingTests to use WGSL
2020-12-17 enga@chromium.org Update DepthStencilCopyTests to use WGSL - FragDepth
2020-12-17 enga@chromium.org Autogenerate all of the wire callback mocks
2020-12-17 cwallez@chromium.org Introduce SubresourceStorage (3/N): Inline data

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: Ie4775c298e9a1806b2b3c47d74c3060a80edcd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838256}

When reading user-selected content (e.g., from mouse selection), STS pauses at the end of the selected content. This CL enables the user to use resume to continue reading from the pause location till the end of the paragraph.

When resuming from the content processed by the navigation feature (e.g., the user hits pause), STS will continue reading from the start of the current sentence (implemented in 2572905).

In both cases, if there is no content left in the paragraph, STS will continue reading content from the next paragraph.

AX-Relnotes: N/A
Bug: 1143817
Change-Id: Idb48219fd805c8b5167f1b30850fea904a06259e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582524
Commit-Queue: Lei Shi <leileilei@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Josiah Krutz <josiahk@google.com>
Cr-Commit-Position: refs/heads/master@{#838255}

Screenshot of change has been uploaded to the bug.

Bug: 1156245
Change-Id: I80ed29bb9486c75b1ce6bd4217401cb4f25758d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594448Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838254}

This reverts commit 6a6c700a.

Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8860631130980203728/+/steps/compile__with_patch_/0/stdout

Original change's description:
> GMSCore API availability function for specific versions
>
> Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Reviewed-by: David Van Cleve <davidvc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#838236}

TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org

Change-Id: Iac1a894b3d3adaa58c0fcfefd407cd8db82b3e56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597817Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838253}

Fixes a recent regression where mb.py started incorrectly classifying
tests due to a change in how GN args were parsed from the build
directory. This re-adds quotes around string args, which brings the
previous behavior back.

Bug: 1159618
Change-Id: Ide52674e258d2a2698d0011928bd0d452a92cb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596640
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838252}

Bug: 1158635, 1112471
Change-Id: I51e6bfff20cabc4d79ae49af66b8e1cfd095c593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597797Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#838251}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc9b7694ce3d..0d23e521cc40

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I28a0e39a19247117b0601d1a84acc448b53e8650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596872Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838250}

The overall project aims to expose CNAME aliases to the
SubresourceFilter to aid in ad tagging and blocking.

A previous CL added a base::Optional parameter to
net::ConnectJob::SetSocket and a getter and setter to net::Socket.

This change continues the plumbing by adding an accessor to
net::HttpBasicState as well as one to net::HttpStream.

All of HttpStream's derived classes receive trivial implementations
except for HttpBasicStream and WebSocketBasicHandshakeStream. SPDY and
QUIC support will come in later CLs.

Relevant tests:
net:net_unittests
out/Default/net_unittests --gtest_filter=*Dns*Alias*

Bug: 1151047
Change-Id: I8b38591e4b186ded8cb41f89571385eee9fe0aa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563450
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838249}

Screenshot: https://screenshot.googleplex.com/3iiZMSnumBBEyB6.png

Bug: 1093185
Change-Id: If5c3b664f3affc958cad4a0042a0d6552ed56180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597766Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#838248}

This avoids destroying and recreating a border every animation tick as
well.  Hopefully this will reduce CPU usage a tiny bit.

Bug: 1114976
Change-Id: I3b2b29a2c8bd04fd7d38aaf69bb9988070826a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596438
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838247}

This is a reland of 42509254

Original change's description:
> Fix ScrollNestedLocalNonFastScrollableDiv under ScrollUnification
>
> With Scroll Unification, in LayerTreeImpl::DidUpdateScrollOffset there
> are cases where a ScrollUpdate may be mutating a ScrollNode that:
> - has a MainThreadScrollingReason - the main thread needs to repaint it
> each time we scroll.
> - it isn't composited
>
> In this case, when ScrollNode is mutated we don't want to make a
> corresponding change in the associated TransformNode. Instead, we want
> to SetNeedsCommit so that the changed offset in the ScrollNode is
> committed to the main thread, then blink regenerates its side of the
> property trees and cc::Layers.
>
> In this test, we hit the first case. In order for the test to pass we
> need to wait for the main thread to sync.
>
> Bug: 1086625
> Change-Id: Icdc3eb5cc786ebdecd516f3cb0fd58d47077d6ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585765
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836593}

Bug: 1086625
Change-Id: I053f4eabd5bc62e0959274236919cd53293315ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591088Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838246}

Bug: 1152279
Change-Id: Ib3ba70a5b7ebb25bed2faada69c48f300b0ff18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595462Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838245}

TBR=kinuko@chromium.org

Bug: 1156939
Change-Id: I23443fc4461dc61223fef249bac109a8b7e8183e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586233Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838244}

This cl add strings which will be used by grid tabs when
IncognitoModeAvailability policy is set to disabled/force.
Mock: https://docs.google.com/presentation/d/19BYpNAMopjUnxVdI3Gc4WcpJ6IVAZ_kw_4CCNs3tP3A/edit#slide=id.g5412b41971_0_147

Submit this cl first because it contains string changes.

The follow up cls are:
1. Create empty tab grid with enterprise message for normal tab grid,
incognito tab grid and the recent tabs grid.
2. Prevent the access to certain tab grid and using empty tab grid when
incognito mode is disabled/forced.
3. Add click action on the "learn more" in-text link.
4. Disable new tab button in certain mode.

Bug: 1148888

Change-Id: I8ba847935ed0228b45c0125f7f2d590e276daa3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595591
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838243}

This is part of the effort to remove usages of cr.js and eliminate
dependencies to JS Compiler's --chrome_pass flag.

Bug: 1028829
Change-Id: Ic963a5dbfe0c18f0428e4432b2e6db3fb930a081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938074
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838242}

This is a purely refactoring change to set up ChromeVox to use all
possible intents. IntentHandler, the newly introduced class, will
cleanly process all intents, along with whatever computed metadata is
needed (e.g. EditableLine).

R=akihiroota@chromium.org, nektar@chromium.org

AX-Relnotes: n/a
Test: existing browser_tests --gtest_filter=ChromeVoxEditing*.*
Change-Id: I74d9454794fc6a40075bbf56fb0037b607c2b974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594240
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838241}

* This patch creates empty targets in the payments component which will
  contain the minimal dependencies needed by downstream GPay code.
* This allows downstream to depend on these targets before things are
  moved into it.

Bug: 1144488
Change-Id: Ib0d6a1e0ea9aae2988322e6632e890d5185e4b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597559
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838240}

This CL is a prefactoring to other in-progress work on
TemplateURLService.

We discovered that TemplateURLService has both CanReplace() and
safe_for_autoreplace() with slightly different logic.

This CL goes all-in with safe_for_autoreplace():
 - It marks Play API engines as NOT safe for autoreplace. It adds an
   UMA to be recorded so we know when the migration is complete.
 - It adds an additional constraint on auto-generated engines that they
   also leave prepopulated engines alone. (Debatable, may change).
 - It also explicitly forbids deleting the DSE during de-duplication,
   but it DOES allow deleting other pre-populated engines in favor of
   policy, extension, or Play API engines, which fixes 953711.

The full design is in:
go/chrome-search-engines-2020-improvements

See Heading: 6. Ranking, and simplifying CanReplace() vs.
safe_for_autoreplace() - (pkasting@'s idea)

Bug: 1022775, 953711
Change-Id: I217bbfc9010fae1c3546e1ffd061ff415e9674dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589638Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838239}

A Trust Tokens issuance request is a request created by
  fetch(..., {trustToken: {type: 'token-request'}})

With the new "platform-provided trust tokens" expansion of the Trust
Tokens feature, the request's destination origin can provide
configuration indicating that the browser should divert the origin's
Trust Tokens issuance requests to system-local providers, on platforms
that support this behavior (currently Android). [1]

In this case, there's no need to send an HTTP request directly to the
destination URL provided in the fetch() call, so we return early via
URLLoader::OnComplete(URLLoaderCompletionStatus). We provide a
non-net::OK error code to this URLLoader::OnComplete call since we won't
receive an HTTP response from the request's destination.

Since this case is semantically a success, we want the caller to be able
to distinguish it from errors encountered during the Trust Tokens
operation. This CL updates trust_token_to_mojom.cc to throw a
NoModificationAllowedError, instead of OperationError, when operations
are successfully diverted locally.

It might make more sense from an API design perspective to resolve the
promise, instead of rejecting it, in this case. This would require some
refactoring in the loader (or the willingness to resolve a promise from
FetchManager::Loader::DidFail!). For now, returning a distinct exception
at least allows callers to distinguish this success case from the
feature's failure cases.

I've updated the user guide to mention this behavior. [2]

[1]: https://bit.ly/platform-provided-trust-tokens
[2]: https://bit.ly/trust-token-prototype-user-guide

R=yhirano
CC=zhengwe@google.com

Test: The child CL adds browser tests covering this path
Bug: 1154847
Change-Id: Ie56ddd0aaf544289184f7d0b47f525fcb654877b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585792
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838238}

The majority of the tests no longer need to use |extraLibraries|,
so it makes little sense to keep adding them by default. Instead
defaulting to an empty extraLibraries list, and only adding them in
the few places that still use them.

Specifically:
 - Move all default |extraLibraries| from PolymerTest to a new
   Polymer2DeprecatedTest base class (and similarly for
   PolymerInteractiveUITest)
 - Make all Polymer2 tests subclass Polymer2DeprecatedTest.
 - Remove |extraLibraries| overrides from all Polymer3 test
   subclasses.

Bug: 1158471
Change-Id: Ibfb3c75dc2f5ccd6fee40bdc6b1ceb6b87fee27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594111
Commit-Queue: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838237}

Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838236}

Rolling back the bump to 25% and increasing sharding
Capacity looks good: http://shortn/_0ICs5GbtYR
However, build times have gotten much slower.

Bug: 1042757
Change-Id: Ifd058c01da1641aeea0adb04e3f5a6dff031aa81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596793Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Auto-Submit: Gary Tong <gatong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838235}

https://android.googlesource.com/platform/external/perfetto.git/+log/0da7da798b33..cc9b7694ce3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I73a9a5ed4b417f67b35d6065374df8373c216a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597737Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838234}

Makes BlankCTATabInitialStateRule more robust:
  * Handles the activity being restarted as part of the test.
  * Handles the case where all tabs are closed.

Performance metrics: 117777 -> 77156

BUG=989569

Change-Id: Ib1281d1160a76595c6ef5ead3cde2a7fcd370293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596034
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838233}

This verifies intersection observer properly reflects
overflow-clip-margin on an ancestor.

BUG=1157843
TEST=test only change

Change-Id: I9c9839294df8ffb88b42947aa87c7cc5222f5a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593812Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838232}

This is a code health CL, no behaviour change is expected.

Bug: 1152278
Change-Id: Ic4a28f6b32b30427c8a5da2f72e1c3a55c85595a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597639Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838231}

Set the dir attribute based on the language to enable RTL based styling.

http://screen/3NMj5SV79ka7cFW

Bug: 1059779
Change-Id: I7dc492fde9724d5cac9529b8866db2eb4d87a632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597757Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838230}

Bug: 1159836
Change-Id: Iddc347d1ea2c79f4ab330345fe2c2782d21e1849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596865
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838229}

After allocate a large buffer in memory and creating canvas, it will
trigger the garbage collection from v8, which will trigger
HtmlCanvasElement::Dispose to be called. This call will cause the
canvas element detached from the |host|. However the |host| is saved
as a valid callback in the observer list of the canvas resource
provider. Calling this |host| without canvas element causes this access
to poison address.

In my fix, after garbage collection is triggered and dispose is called,
DiscardResourceProvider() is called as well, so it removes itself from
the observer list.

Bug: 1158266

Change-Id: I40bfc24ff5dcdb7a248114220100b6dd54ac06f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595734
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838228}

This reverts commit fbeb26e5.

Reason for revert: Suspected cause of https://crbug.com/1159974

Original change's description:
> Re-land #2 "Use new vulkan-deps repo for all Vulkan dependencies."
>
> Re-land #2 includes update to licenses.py and removes stale files.
>
> Re-land includes missing headers directory.
>
> This replaces several grouped dependencies with one meta-repo.
> The meta-repo will allow us to group multiple inter-dependent
> deps rolls into one single roll. This solves the problem of
> separate rollers breaking because of the inter-dependencies.
> It also allows ANGLE and Chrome to share common bits like the
> README and .gitignore files.
>
> Bug: angleproject:5390
> Bug: 1153258
> Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#838196}

TBR=thakis@chromium.org,dpranke@google.com,jmadill@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I60ab236419d36f55cf84c294f5a4e69f23c4c9c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5390
Bug: 1153258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595256Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838227}

This CL is the fist in a series to convert DataItem from the deprecated
base::Callback (and Bind) to [Once|Repeating]Callback. See the relation
chain of CLs for the complete change.

This CL starts by converting a set of injectable callbacks used for unit
tests to observe this class. These callbacks may be called repeatedly
after being registered so they are RepeatingCallbacks. However,
ItemFactoryCallback and ItemStoreDeleter both take a callback as a
parameter. The unit test implementations only invoke these parameters
once so we convert them to the "Once" variant.

The RegisteredValuesCallback is a type defined in DataItem and used
elsewhere. For now, we add a "Once" typedef to prevent changing too
much. This will be removed in a downstream patch once all uses of the
ambiguous form are removed.

Bug: 1152268
Change-Id: I694df544b97ede7b1e5aa8af388ca4ed186d8156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595932Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838226}

This is a necessary step into getting per-profile Connectors to work, as
some configurations could use different tokens per Connector when some
are set at the machine scope while others are set at the profile scope.

This also updates |authorization_callbacks_| and
|pending_validate_data_upload_request_| to use the same mapping pattern
as |can_upload_enterprise_data_|, this is actually a bug in how that
was updated to map to Connectors in crrev.com/c/2499082

Bug: 1148789
Change-Id: Ib216dbfba5ade900c035513b70f2d07176bb87bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593761Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838225}

Change-Id: Ic19e456fa6e0c345dcaacebabd9b3f96aad33573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595616Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838224}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fdd70108b562..692a30f556f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC kmilka@google.com,gayane@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1106990
Tbr: kmilka@google.com,gayane@google.com
Change-Id: Icb1f248ceb8d00a99e62d4e0b5f64ada5276411a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597736Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#838223}