- 13 Aug, 2019 40 commits
-
-
Martin Kreichgauer authored
TBR=dbeam@chromium.org Change-Id: I348816d4cbc717b3aae9ca18612fa2a1f67ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752558Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#686591}
-
Min Qin authored
When download is paused, watching the mojo data pipe for data ready callback is not needed. As the callback will trigger an early return and do nothing. We can register the callback later when download is resumed. BUG=927530 Change-Id: Ifc225241978cb34991846ffb4a6a40166e5fc953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748122Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686590}
-
Sean Gilhuly authored
Add new baseline images for the flag --enable-gpu-rasterization that are used by these SkiaRenderer variants: GL, GL Swiftshader, Vulkan, and Vulkan Swiftshader. Add a new FlagExpectations file for skia_renderer_gl_blink_web_tests for the tests that are failing on Skia GL. Bug: 954328 Change-Id: I289cccb773513ab3199b624cb0af63f06556c2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747983Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#686589}
-
Pavol Marko authored
Support generating policy sources from policy_templates.json without version restrictions. This is useful for testing where we may want to set policies that are not yet supported or are not supported anymore. python components/policy/tools/generate_policy_source.py \ --policy-templates-file=components/policy/resources/policy_templates.json \ --target-platform=chromeos --chrome-version-file=chrome/VERSION \ --policy-constants-source=test.cc and python components/policy/tools/generate_policy_source.py \ --policy-templates-file=components/policy/resources/policy_templates.json \ --target-platform=chromeos --all-chrome-versions \ --policy-constants-source=test2.cc then diff test.cc test2.cc Bug: 976424 Test: Run Change-Id: I3d0b7a0676ba771aec06ff7df0465e3b9539fd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686668 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#686588}
-
Francois Doray authored
Currently, LocalFrame::DidFreeze performs these steps: 1. Obtain the DocumentResourceCoordinator. 2. Dispatch the beforeunload event. 3. Invoke SetHasNonEmptyBeforeUnload on the DocumentResourceCoordinator. However, it is believed* that dispatching the beforeunload event can invalidate the DocumentResourceCoordinator (by shutting down the document), which causes an invalid access at step 3. With this CL, the latest DocumentResourceCoordinator is obtained just before calling SetHasNonEmptyBeforeUnload. *Ideally, a Blink expert could confirm if that's a reasonable assumption. Bug: 991380 Change-Id: Ie542b34a67900d427fbdc720f0d362522eba5da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749531Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#686587}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/83ed3059..4b08436c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8816e6f616029743bc7c2bb5a677bb404fdd4e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752630Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686586}
-
Sebastien Marchand authored
Bug: 966059 Change-Id: I9afc2ed7c722166f6dbcd96c412387fab97d32ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752743 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#686585}
-
Gabriel Marin authored
MetricCollector is split into MetricProvider and MetricCollector. MetricProvider runs on the UI thread and owns a MetricCollector instance. External classes interact only with the MetricProvider. MetricProvider creates a dedicated sequence for running the collector. It forwards callbacks received on the main thread to the collector via PostTask. MetricCollector runs on the dedicated sequence. It posts a callback that is provided at creation time, on the main thread each time a profile is generated. PerfCollector required minimal updating, but there was some churn in the unit tests. HeapCollector was updated to execute the heap profile parsing asynchronously on the thread pool, since it is a potentially blocking operation. Its behavior was also modified to not collect a profile if an incognito window is open, as opposed to disabling and then enabling heap sampling while an incognito window is open. This is in line with how the PerfCollector and memlog work. BUG=b:134761848 TEST=Unit tests pass under tsan. Change-Id: Iaa9550bd7ff4fc03651737023cffe1893b322d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654270Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686584}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e73aa7573279..5e2c489a335c git log e73aa7573279..5e2c489a335c --date=short --no-merges --format='%ad %ae %s' 2019-08-13 mtklein@google.com remove redundant CPU bots Created with: gclient setdep -r src/third_party/skia@5e2c489a335c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I082d2e53a7615bac6608439ee7d8cfa51c8519ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686583}
-
Leon Scroggins III authored
Bug: 993266 When checking to ensure that the frame rect fits inside the canvas, check for overflow. Change-Id: I70c7c6a2b0f2700c0446c23ba6c9fb44a22577d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752126 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#686582}
-
Tommy Li authored
We had this enabled by default in 77, since we were presuming we would launch this feature. We're not so sure now, so turning it off by default. Bug: 958655 Change-Id: I77be67f4cb883413ac225c569d3df7a3017d5ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752297Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686581}
-
James Cook authored
It was added for mustash. The value is written, but never read. Also remove obsolete mustash-related comment. Bug: 679056 Test: compiles Change-Id: I6e35c57a606f0e6e781c3edf36522490468f5f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752548 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#686580}
-
Kelvin Jiang authored
This CL implements the logic to store the number of actions matched for an extension's ruleset and surface this count as a extension's badge text if the extension has called setActionCountAsBadgeText(true). Bug: 973211 Change-Id: Icc438d7be5f4e33bd8e0e77c4034bd2f69391a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656970Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686579}
-
Oksana Zhuravlova authored
This change adds BrowserInterfaceBroker plumbing for service workers, as well as support of task runners for binding interface handlers. It also converts BackgroundFetchService clients in blink to use BrowserInterfaceBroker as a use case. Bug: 985110, 985112, 976962 Change-Id: I5c431f3f862cb3ac10d389f8c7afea3734d5bfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742779 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#686578}
-
Axel Antoine authored
The OneEuroFilter filter is available in the filter factory, flags are updated to change filter through Chrome's flags. The OneEuroFilter also takes 2 variable parameters: mincutoff and beta. * mincutoff is used to reduce the input noise * beta is used to reduce the introduced lag when filtering Regarding Prediction and filtering in general, we want to be able to load filter parameters through fieldtrials and to have different parameters for each couple (predictor, filter, feature). For that purpose, the filter factory has been modified to dynamically load filter params from fieldtrials or use default ones when fields are empty. The factory keeps a copy of the loaded params locally in a map to avoid multiple calls for a same trio (predictor, filter, feature). Thus, the factory is now an instantiable object. Bug: 985993 Change-Id: I8f1381889128a7e500bab4df1f064580e3a99f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711202 Commit-Queue: Axel Antoine <axantoine@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#686577}
-
Chris Davis authored
These changes reduce chrome.exe by 11k, chrome.dll by 80k and chrome_child.dll by 51k. Total of 143k in disk savings. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=985505 Change-Id: If03a5306aa6b8f114f911150d0781226fbbc6273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708767Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686576}
-
Jun Cai authored
This CL implements timeout UI for SMS. I uploaded a screenshot of the SMS dialog on the issue page. Bug: 983325 Change-Id: I0299981a1efbc29cb78532cafb090425138c65cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727730 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/956770025c8c..225110211231 git log 956770025c8c..225110211231 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 jmadill@chromium.org Vulkan: Remove unused GetDepthStencilAspectFlagsForCopy. 2019-08-13 jmadill@chromium.org Use TextureID in place of GLuint handles. Created with: gclient setdep -r src/third_party/angle@225110211231 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:992863 Change-Id: I564cf8a4be8fd7df819592350dc222979c359fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752042Reviewed-by:
-
sczs authored
Bug: 979201 Change-Id: Iee3f28ab517b0f59ea043dde7ba15248d8083201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727430Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686573}
-
Sunny Sachanandani authored
Bug: None Change-Id: I5ed40fa82eac128a05772b8c0c2adf09392dd92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752802 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686572}
-
Xiaoqian Dai authored
Bug: 991406 Change-Id: I71c9d0a4ec11838cfc9d90b8cfdc78608c06426b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749647Reviewed-by:
Avery Musbach <amusbach@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686571}
-
James Cook authored
The test was only relevant to SingleProcessMash, which was cancelled. The teardown flow it tests shouldn't happen any more. Bug: 922293 Test: ash_unittests Change-Id: Iabd150315ae4f0618462924a379108832530bd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752540 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#686570}
-
Vladimir Levin authored
This reverts commit 7bc6e04a. R=eae@chromium.org, pdr@chromium.org Bug: 993476 Change-Id: Icd741e1a4d1383ccb486dcb2f27b432b3635a997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752527 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686569}
-
Peter Boström authored
This increases contrast as GG700 changes to GG900, alongside similar contrast gains for dark mode. Bug: chromium:987260 Change-Id: I2db14c3c8bc7bfc441ae60a8f5571c570f9a86ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752552 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686568}
-
Ian Kilpatrick authored
This changes the flex intrinsic block-size algorithm to be based off the FlexLayoutAlgorithm::IntrinsicContentBlockSize and removes the additional code within NGFlexLayoutAlgorithm::Layout which was separately tracking this. Bug: 845235 Change-Id: Ic5bc4ec7268488e4e9e8aff7b4510e660a0220f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752545Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686567}
-
jonross authored
If a GPU Pixel Test crashes during init, it will attempt to close the non existent browser, crashing the run. Once a test ends, it restarts the browser, with the current command line. This leads to command lines propagating between tests. Normally a test will then restart the browser an additional time, with new command line args, if desired. However if init is failing, this then persists for all subsequent tests. This change updates the restart behaviour to detect failed init. Then to use default args for the restart. To allow subsequent tests the change to succeed at init. Furthermore, ChromeBrowserBackend._GetDevToolsClient can timeout while we are attempting to handle exceptions in _RunGpuTest. Leading to the test suite left without an open browser. This error then cascades, leading to the next test to also fail. (crbug.com/993379) This change also updates _EnsureTabIsAvailable to create a browser with the default options if we are ever in such a case. To prevent one failure from affecting subsequent runs. Bug: 985530 Change-Id: I7256fa01e9b1e5d84a65a7073b3fb625a716f13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715778 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686566}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/34aee67c1145..01525f9e0338 git log 34aee67c1145..01525f9e0338 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 nisse@webrtc.org Delete method StreamStatistician::GetDataCounters Created with: gclient setdep -r src/third_party/webrtc@01525f9e0338 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I5b5b43a9e4a0286db4fa5afb0b2602f7c9ca6d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751750Reviewed-by:
-
Jonathan Ross authored
This reverts commit 0f4c96b1. Reason for revert: The CHECK added in crostini_export_import has been failing with a high rate of flakes. On unrelated infra change. crbug.com/993521 Original change's description: > crostini: log .tini export statistics > > BUG=992293 > > Change-Id: Id54f0b0f26e06b1ce5c2c7c4e725889867e88334 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750516 > Commit-Queue: Julian Watson <juwa@google.com> > Auto-Submit: Julian Watson <juwa@google.com> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686355} TBR=joelhockey@chromium.org,juwa@google.com Change-Id: Id2ff483d833df1770abdd40a1440a544f4514e9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752929Reviewed-by:
-
Avery Musbach authored
OverviewSession::OnDisplayRemoved is unreachable and contains a TODO that describes behavior contrary to the current design decisions. Also, when a display is added, overview ends (as expected) only because of OverviewSession::OnShelfAlignmentChanged; the present CL adds OverviewSession::OnDisplayAdded to improve code maintainability. Test: ash_unittests OverviewSessionTest.Shutdown Test: ash_unittests OverviewSessionTest.AddDisplay Test: ash_unittests OverviewSessionTest.RemoveDisplay Test: ash_unittests OverviewSessionTest.RemoveDisplayWithAnimation Change-Id: If2a282364b72f5fcedac5bdbb7a9f0c1ab8ebd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743114Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#686563}
-
Justin Cohen authored
Sometimes clear browsing data times out on the bots. This happens currently with iOS12, but is happening much more regularly with iOS13. Bug: 979728 Change-Id: I8e5105925b0365681fe5d6e9e5e4735e546100b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750863 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
RJ Ascani authored
The fuchsia.media.StreamProcessor protocol is soft-transitioning the OnStreamFailed event to include an error code for the failure reason. This CL is the first stage of that soft-transition by updating the FuchsiaVideoDecoder to use a temporary OnStreamFailed2 event that includes the new error code. Change-Id: Ie7901d306e851751be4de98680ba89e980bb6b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752351Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#686561}
-
Mia Bergeron authored
This CL invalidates the action buttons if their visibility changes. Previously, if a button's visibility changed, the space would remain there. Now, if a button's visibility changes, the space is removed. This way, there is always equal spacing between the visible buttons. Change-Id: Ie73d1072ef61da2c65b7a89414b689a04d7cf858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752555Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#686560}
-
May Lippert authored
BUG=950007 TEST=Ran browser tests with and without flag Change-Id: I0946762b7445ce5799043b50fdff3efd57a670f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749004 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#686559}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7588713317d6..811aead064fb git log 7588713317d6..811aead064fb --date=short --no-merges --format='%ad %ae %s' 2019-08-13 andrewlamb@chromium.org chromite: Implement BundleChromeOSConfig BuildAPI endpoint. Created with: gclient setdep -r src/third_party/chromite@811aead064fb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9bd0c1ee726db28f269d9c92d2f745c698887cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751764Reviewed-by:
-
Gayane Petrosyan authored
No need to update color picker value while its open. As theme updates have latency, it only creates unsmooth behavior as theme updates try to update the color picker color while sliding over the color spectrum. Bug: 990379 Change-Id: I6feaabee66ecbbc15b70b26037224a8655c69f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749424Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#686557}
-
David Benjamin authored
This CL comes with a behavior change: set_allow_credentials(false) additionally sets LOAD_DO_NOT_SEND_AUTH_DATA. However, this would only matter if the origin server actually used HTTP auth. Bug: 799935 Change-Id: I764586d72b69c1a24d4981a4a5ba1127bf4e91aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752622 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686556}
-
Dan Sanders authored
Bug: 993311, 985144 Change-Id: I36104029d3fdfafcfee5be53b79a250017e9f86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751910 Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#686555}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 R=jbroman@chromium.org Change-Id: I3d783e09b91aa4b0fa4274d83600d401873fb45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752075 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686554}
-
Etienne Pierre-doray authored
This CL refactor TaskSource tear down so that Clear() can be called in production by the task tracker and clear sequence in one go. -Uses WillPostTaskNow to drop delayed tasks early. This replaces effective_shutdown_behavior so that a task doesn't need to be popped first before deciding whether it is run. -Fix a logic bug in WorkerThreadDelegate::PostTaskNow. -TaskSource::Clear() now eats a RunIntent and returns a task to run. -The extra parameter to DidProcessTask is replaced by a call to TaskSource::Clear(). Bug: 839091 Change-Id: I331336a84c62a282c5efef1fb8ac84b4fe33e259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719104 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#686553}
-
Tommy Li authored
This reverts commit 0297659d. Reason for revert: Build failures here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI Original change's description: > Stablizing Mac autofill accessibility when popup show/hides > > This is a follow up change of CL:1667787, which introduced > AutofillPopupControllerImpl::FireControlsChangedEvent for autofill > popup accessibility. > > On Mac and potentially other platforms, when accessibility is > enabled, upon invoking autofill popup and FireControlsChangedEvent > we end up dereferencing a nullptr of AxPlatformNode due to > Mac does not have a complete implementation of AxPlatformNode yet. > > This CL fixes the above by adding a check for AxPlatformNode in > FireControlsChangedEvent. > > Changes: > 1. Introduced a check for invalid AxPlatformNode in > AutofillPopupControllerImpl::FireControlsChangedEvent to return > early from firing event. > 2. Added associated unit tests for FireControlsChangedEvent. > 3. Exposed GetWebContentsPopupControllerAxId virtual to > AutofillPopupDelegate.. > > Bug: 986587 > Change-Id: I9a6ed49330a9ea9d7d4e5483c3ee06d5675919ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714297 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686461} TBR=sky@chromium.org,estade@chromium.org,nektar@chromium.org,ftirelo@chromium.org,akihiroota@chromium.org,iapres@microsoft.com,vicfei@microsoft.com Change-Id: I67ef1a599f54569e9cd9a964bc3b1b27f7c27c4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752863Reviewed-by:
-
