GitLab

Fixed: 1134810
Change-Id: Id46b76dc22328b826a3359344e8d33366661459d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476685
Commit-Queue: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817623}

base/win/registry.h includes more than it uses. These files were
inadvertently relying on that fact. This CL adds missing includes so
that registry.h can be cleaned up.

BUG=None
This CL was uploaded by git cl split.

R=eroman@chromium.org

Change-Id: I204ca677225511983881927d46f7344442ea4ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475074
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817622}

See screenshot in bug.

TEST=deploy on chromebook, open feedback window.

Fixed: chromium:1138774
Change-Id: I91249d08dbb2bde7ba65b15adf5fed5c43cc1855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476565Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817621}

Using wpt-import in Chromium 678eb60a.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org:
  external/wpt/css/css-conditional

NOAUTOREVERT=true
TBR=smcgruer@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I18c17d92d7c393844c6f7743469de183fe1dc4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476140Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817620}

This change replaces "Found n security issues" with "Found n weak
passwords" in the case where the user is signed out and has no
compromised credentials.

Translation Screenshot:
https://storage.cloud.google.com/chromium-translation-screenshots/8f393f395ae0dda9238b4f170c9d9940cd2a60a9

Bug: 1138468
Change-Id: I0cb563ee35f60f63bfd4dd503efe955c8876b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475913
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817619}

This CL 'zaps' (`memset`s) the allocated region on free. This may
help detect some instances of UAF, causing them to crash (with
nullptr deref).

Rather than doing so on every free, we zap probabilistically to
reduce the performance impact.

If the perf bots show an unacceptable regression, we'll revert this.
But, it might be acceptable.

This is a re-land of
https://chromium-review.googlesource.com/c/chromium/src/+/2469840.

Bug: 1005070, 1013329, 1013326, 1013324
Change-Id: I7ae007767b31cab139c6b27c5e4667309d4d707d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473041Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817618}

Update to libavif v0.8.2.

https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/e67f9369d50e..33ece0a9f897

$ git log e67f9369d..33ece0a9f --date=short --no-merges --format='%ad %ae %s'
2020-10-14 jdrago v0.8.2
2020-10-14 jdrago Stop being lazy about CHANGELOG (catch up!)
2020-10-14 jdrago Re-contribute my oss-fuzz decoder implementation under the same license as libavif itself
2020-10-12 wtc Detect file read error by calling ferror()
2020-10-13 wtc AVIF_RESULT_NO_IO renamed AVIF_RESULT_IO_NOT_SET
2020-10-13 jdrago Add oss-fuzz implementation to tests/
2020-10-12 wtc Miscellaneous cleanup changes to apps/ and tests/
2020-10-12 wtc avifIO read() should require readFlags == 0

Created with:
  roll-dep src/third_party/libavif/src
R=dalecurtis@chromium.org

Bug: 1136922
Change-Id: I6ac03fa84b87a9699cbf24fda498a4262d4bb4ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476613Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#817617}

Bug: 1130078
Change-Id: I1f1941981229996029488c2d0b001d720f84f259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463769Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Elaine Chien <elainec@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817616}

This reverts commit 08c8cfe5.

Reason for revert: Dawn now matches the value of Chromium's use_x11 so it should not longer be necessary to set manually.

Original change's description:
> set dawn_use_x11 = false for headless builds
>
> headless_shell build with build/args/headless.gn should not
> depend on x11, and https://crrev.com/c/2368534
> brought x11 via dawn to all linux builds.
>
> Bug: 976495
> Change-Id: I65c0371f97e2c7eeda5381f890d52c8b06c60b34
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473444
> Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817311}

TBR=caseq@chromium.org,kvitekp@chromium.org,enga@chromium.org

Change-Id: Iae829a6e8ae612cbe82c632d7897018e1f1a8b40
Cq-Include-Trybots: luci.chromium.try:linux-lacros-rel
Bug: 976495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476953Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817615}

When the user performs a safety check that finds no issues, clear
the timestamp, it is odd to have no issue states on the screen and
see issues last found x time ago.

Bug: 1078782
Change-Id: Ieb9dee1c9428643df05c5c541e6b4de472a623df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474914Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817614}

It is opened FILE_READ here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc;drc=0e22286ee95d2bd711f81d73f1178343fbacc890;l=63

Bug: 1130762
Change-Id: I2b245847ac1b1a67d07d52eeb99e495044d53803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463812Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817613}

This patch adds a new "wayland_client_compatibility_test" test target,
which runs the Chrome OS server sources with a custom, generated-code
client test.

The purpose of the test is to ensure the server never sends an event to
the client that is not supported, given the interface version the client
is using. On a typical client using the core Wayland client code from
freedesktop.org, sending an unsupported event can cause an array access
out of bounds, or potentially other undefined behavior.

(Note that this compatibility test client is built from the same
protocol sources, and supports all the versions the server could
potentially support, so there can be no undefined behavior here.)

The intent is to eventually run this test as part of the Chrome CQ or
similar, to catch protocol version violations as early as possible.

Not all interfaces will be the subject of a generated test. Only
interfaces that have events added with a "since" version after the
initial version of the interface will be tested. Also the test only
tests the versions of each interface that make sense to test.

The bulk of the source code for this patch is in the Python 3 code
generator and the related Jinga2 templates which expand into the client
test. The code generator will generate a fixture for each interface,
with the fixture containing the code to obtain the target interface as
well as all other interfaces needed.

Also generated are some additional helpers that allow the client to use
std::unique_ptr with the various Wayland interfaces, as well as to
obtain global interface pointers using compile time type information.

The special header file wayland_client_event_receiver_version_fixtures.h
contains any optional manual override fixtures needed to get the various
interfaces, to "nudge" the server to ensure it sends certain key events
so that that each test passes. Or if needed, the fixture can be
configured so that the test is skipped.

Currently the code generates sixty-three test cases covering various
versions of fifteen interfaces. The test runs in about a minute under
Linux with xvfb-run.

This patch sets up the framework, but does not include all the changes
needed to get all the tests to pass. The framework works as is to
properly test FIVE of the fifteen interfaces. The other ten interfaces
are configured to have their tests skipped for now. Subsequent patches
will be needed to ensure these ten interfaces are actually tested.

As this patch is all about automatically generating new tests when the
protocol files are changed, thought went into:

1) Limiting work. Again, only interfaces where versions need to be
   checked for events will have a test generated. A brand new interface
   with its initial events will not have any tests generated, and
   therefore not need any customization.

2) Not breaking the build. The build will not be broken if by any
   (valid) protocol addition. The default generated code is expected to
   always compile.

3) Server interface support. Only the interfaces and their versions
   actually exposed by the server will be tested. Interfaces and
   versions not exposed by the server will be automatically skipped.

4) Messaging part 1. If a test fails for any reason, and no custom/override
   fixture has yet been defined, the test will output minimal details
   for defining one that causes the test to be skipped. This is in
   particular intended to help any sheriffs that encounter a failure.

5) Messaging part 2. If a test fails because expected events were not
   received, again it will be clear about the possible need to define
   overrides of certain helper functions in the manually maintained
   fixture overrides, to ensure that the server sends the expected
   events.

Other notes:

If desired, the test generation conditions can be relaxed to cover all
events, though that would almost certainly require more significant
manual help to get the tests for existing interfaces to work, and it
would certainly increase the burden of work for adding new interfaces.

BUG=b:157254342
TEST=wayland_client_compatibility_tests

Change-Id: I756e52408951b7d63653d7e65e138a41859d494f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402148Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Lloyd Pique <lpique@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817612}

It is also timing out on Mac 10.12:
  https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/38444

Bug: 626703
Tbr: pkasting@chromium.org
Change-Id: Ib62dbe51a54f888fd9bd2164fd754d553f13dfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476955Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817611}

Adds the ability to bind the SystemDataProvider interface.

Bug: 1128204
Change-Id: I523618794ecfd8454e7195aabb7bf1e7df25f470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446192
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817610}

Testing:
- check that dark and light mode look as expected in the spec (https://www.figma.com/file/rQFGy3iAMfNdDnydTGkvHr/Style-%7C-Semantic-color-system-surface-theming?node-id=0%3A1).
- check that if DarkLightMode feature flag is disabled, the UI looks the same.
Videos and spec can be found here: https://drive.google.com/drive/folders/1e1P8gJdj3TtJR--3xG3YoK3zc5c-xmSj?usp=sharing

Bug: 1128761
Change-Id: I5e358b2d9d2b0593b301f4ac299227666aea6ada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464124
Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817609}

For window management, since platform app version uses Chrome App Window
API to manage windows while SWA version uses our own implementation in
WebUI controller on C++ side, we should abstract it first and implement
the logic for SWA version in a latter CL.

Bug: 980846
Test: Test with the latter CLs and CCA works normally
Change-Id: Id9deadc129db3a123a7ff0e7c078ea732b3ae18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345897
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817608}

Currently the device-id changes from test run to test run,
which will start causing issues after the next Libassistan uprev,
as that contains http://libassistant-internal/c/147561 which starts
rejecting server responses with mismatching device-id's.

Bug: b/170170824
Change-Id: I1e55239947f5b5d083c01bf85e6f891fa8de69c1
Tests: browser_tests --gtest_filter="AssistantBrowserTest.*"
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472469
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817607}

https://webrtc.googlesource.com/src.git/+log/a39689cc986e..4c54f8638cc4

2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37c343f0..9b1cb285 (817356:817475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I09dd88095ec200412b6b4c46a6e68f341d44cd49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476559Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817606}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010150700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/92sajF7l5YU_FHOF0S5XbbEL1anK6DQMIxOzfUm2nZQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: I800c2f19f7aec37794194ff10795a9ea2dcfb10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475008Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817605}

Remove bad Win7 baseline for virtual/dark-color-scheme/fast/forms/color-scheme/scrollbar/horizontal-scrollbar-basic.html.

It looks like this was intended to match other Windows versions, like
the other pixel baselines, but slipped through the trybots because of a
lack of a Win7 trybot running this test.

Removing the baseline causes it to share the /win/ expectation, which
appears to match the actual result on Win7 bots.

See, for example:
  https://test-results.appspot.com/data/layout_results/Win7_Tests__1_/108950/blink_web_tests/layout-test-results/results.html

Bug: 1096729
Cq-Include-Trybots: luci.chromium.try:win7-rel,win7-blink-rel
Change-Id: If2e3e8b10a479e3e81bf61c4c0cc3f3d302669b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475953
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817604}

https://chromium.googlesource.com/angle/angle.git/+log/b0248ea45f6e..c9206a08c352

2020-10-15 jmadill@chromium.org GLES/GL/Win: Suppress all constancy samples tests.
2020-10-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e72c6099f946 to 52c1a859d9eb (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: I41020c73f6bd2e999a85ba61accd912622cfb2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476553Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817603}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08ffb75d06d1..9dfc25eb5de2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC pkasting@google.com,jbroman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: pkasting@google.com,jbroman@google.com
Change-Id: Ic59d0a75770d1a6734c98d75e1bf0acc6e51d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476561Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817602}

Bug: 878979
Change-Id: I5c24970070e6e6bba0e129efa9bcc3e5e317efd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472447
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817601}

See https://github.com/whatwg/html/pull/5574

Currently applies to JPEG only.

Use the EXIF resolution/size information we read from the
JPEG image to determine a density-corrected preferred size,
which overrides the intrinsic size of the image.

We only apply this intrinsic size when an image has both
resolution and size information in its exif.

When asking an Image for display size, the preferred size
is returned, and the source rect for reading from the image
is scaled when applicable.

Added many WPT reference tests.

Bug: 1069755
Change-Id: I01a38c72bb46974a0c112175934cd3c2c48607a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292219
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817600}

Reference: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2472980

Bug: 1024915
Change-Id: Ie5338dec1421a2cef04d940b63380bf345508923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476873
Commit-Queue: Prakhar Asthana <pasthana@google.com>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817599}

The following metrics will now expired in M95
Enterprise.PolicyUpdatePeriod.MachineLevelUser
Signin.AuthenticatedLaunchUserEvent

Bug: 1138274, 1138327
Change-Id: I60f548c3bb0d16df3e06761469b1a7ae23050003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476954Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817598}

Bug: 1138917
Change-Id: I406730e0d673ac7f58cc9309f8b95141c9623f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476156
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817597}

ProfileSyncService has logic to delete the legacy Directory files on
shutdown if the sync engine doesn't exist (normally the engine would do
the deletion). One consequence of crrev.com/c/2461325 is that the engine
implementation and this deletion no longer have ordering guarantees. If
sync is immediately restarted, it's possible that a new engine will be
created before the deletion finishes, which is a race condition.

This CL fixes the issue by exposing a deletion method in
SyncApiComponentFactory (the class responsible by creating engines)
which is guaranteed to run sequentially with the implementation of any
engine it creates. As a bonus, this removes some assumptions made by
ProfileSyncService that the underlying SyncEngine is actually a
SyncEngineImpl.

Fixed: 1123881
Change-Id: I55528019863eeca9f90c09172c410a87f74e0bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476434
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817596}

Point the tests:

 external/wpt/css/css-masking/clip-path/clip-path-polygon-006.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-007.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-008.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-009.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-010.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-011.html
 external/wpt/css/css-masking/clip-path/clip-path-polygon-012.html

to crbug.com/694218 because that is their primary (known) reason for
failing.

Sort this section of the expectations because that made finding the
tests easier.

Bug: 694218, 843084
Change-Id: Ib55a1a4fd721e1b86782b1f943e009edccdde5f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475114
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817595}

Bug: 1138044
Test: tast run -buildbundle pita <DUT> printer.*
Change-Id: I9f7beed9bc761869fc16e9b565d5e351f5231bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470304Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817594}

This name is passed on to the VMOs and makes it simpler to determine how
much memory is being used by output surfaces. Also add debug client
names to help determine which client failed to set constraints if that
ever happens.

Change-Id: Iff1512c33ca10aa8a57a65e27f3227237a2841dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476135Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: John Bauman <jbauman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817593}

Bug: 1137970
Change-Id: I59fb04e786101f3b60aab41d1ab84a103fb14d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473445Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817592}

We still want to track features like unique local matching timing and
other font performance indicators.

Fixed: 1138243, 1138247, 1138248
Change-Id: Ie1f6acffc1abb5f8398bebcbcb2b31510320ad23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475876
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817591}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b842a763db41..c166b7033fc3

2020-10-15 tvanderlippe@chromium.org Typecheck node_main/NodeMain.js with TypeScript
2020-10-15 jacktfranklin@chromium.org Migrate emulation/InspectedPagePlaceholder to TS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I322a911a6ce22d9ad02beca09a5aed5a442888d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476554Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817590}

The Events tab of net-internals used overly complicated logic to detect
file drop events. Simplify the logic, maintaining identical behavior.

Change-Id: I9959eeb3815b13eb790763eb1c5a518baf655914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473580Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#817589}

ContentBrowserClient::GetSandboxedStorageServiceDataDir returns a
FilePath in which to isolate sandboxed Storage Service instances.
This path must be absolute or the service will reject it and fail to
function properly.

This CL merely updates the documentation on ContentBrowserClient to
clarify the absolute path requirement, and adds a browser process DCHECK
at service launch time to make such errors more obvious.

This requirement exists in lieu of the browser manually resolving a
relative path if needed, because that may be a blocking operation.
We don't want it janking the UI thread or delaying service startup.

Chrome always provides an absolute path here, so this is more about
clarifying requirements for other embedders.

Bug: 1090988
Change-Id: I3c407f92ca52104773c784876f074398531aa35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476453
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#817588}

This change converts the OnLoadScriptInjectorHost template to use
explicit instantiation for std::string and uint64_t.  This will improve
compile times and also makes the types for ScriptId explicit.  The
change also fixes the public deps of the build target.

Bug: None
Change-Id: I0b52f7486589071150a6f5747daef0a0c6fceaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468182
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817587}

This reverts commit f93556a5.

Reason for revert:
The CFI failure was due to multiple template class definitions for same
template parameter. Move the class definitions to different cc file to
avoid multiple definitions.
Also fix base unittests to use the new helper.

Original change's description:
> Revert "Reland "[tracing] Remove special handling of task execution and log events""
>
> This reverts commit 3b99bb24.
>
> Reason for revert: Suspected of causing TraceEventDataSourceTest.StartupTracingTimeout failure in services_unittests on Builder Linux CFI.
>
> Original change's description:
> > Reland "[tracing] Remove special handling of task execution and log events"
> >
> > This reverts commit 989724c3.
> >
> > Reason for revert:
> > Fixing test failures. The msan failures were due to hash operator trying
> > to hash uninitialized padded bytes of the struct. Fix the struct to not
> > have any padding.
> >
> > Original change's description:
> > > Revert "[tracing] Remove special handling of task execution and log events"
> > >
> > > This reverts commit f79b1513.
> > >
> > > Reason for revert: Breaks WebKit Linux MSAN
> > >
> > > The following tests started failing since this landed:
> > >
> > > * http/tests/devtools/tracing.js
> > > * http/tests/devtools/tracing/decode-resize.js
> > > * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js
> > > * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js
> > > * http/tests/devtools/tracing/tracing-record-input-events.js
> > > * http/tests/devtools/tracing/user-timing.js
> > > * http/tests/devtools/tracing/worker-events.js
> > > * http/tests/devtools/tracing/worker-js-frames.js
> > > * inspector-protocol/sessions/tracing-start.js
> > > * inspector-protocol/timeline/tracing-proto-format.js
> > >
> > > First run that failed, also the run where the CL landed:
> > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830
> > >
> > > Original change's description:
> > > > [tracing] Remove special handling of task execution and log events
> > > >
> > > > The task execution and log events are handled specially for writing
> > > > proto arguments because we did not have the support for typed events in
> > > > base and interning support for the event macros. Now these events can
> > > > use the new client library API.
> > > > The events have to be migrated together because the source location
> > > > interning index is common for all events in the API and does not
> > > > account for the special handling in event sink.
> > > >
> > > > BUG=1136635
> > > > TBR=chirantan@chromium.org
> > > >
> > > > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636
> > > > Reviewed-by: ssid <ssid@chromium.org>
> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > > > Reviewed-by: danakj <danakj@chromium.org>
> > > > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > > > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > > > Commit-Queue: ssid <ssid@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#815911}
> > >
> > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: 1136635
> > > Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#816069}
> >
> > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org
> >
> > # Not skipping CQ checks because this is a reland.
> >
> > Bug: 1136635
> > Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: ssid <ssid@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Commit-Queue: ssid <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#816620}
>
> TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org
>
> Change-Id: Ib19224f57b12b423dfbf40f51ebfcc946be061ad
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1136635
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468503
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816764}

TBR=danakj@chromium.org,huangs@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1136635
Change-Id: Ia7c30a7a9929f1d68cf2ed879f8d8e0370f9314c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473343Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817586}

Bug: 1105096
Change-Id: Ic50a54612c0eee975acaa906ce9a3db3964bb7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476715
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817585}

This CL partially reverts [1], [2], and [3] to re-enable Web Components
V0 APIs. This is a very temporary change, through Oct 31, to allow a
bit more time for crbug.com/1136052 to be fixed.

Note: there is no testing of Web Components v0 being re-added here,
so these features are relatively un-tested.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2195005
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2458126
[3] https://chromium-review.googlesource.com/c/chromium/src/+/2451299

Bug: 1136052
Change-Id: Ib8f0fa44406e675aadf13868ce9a085730302347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476673
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817584}