- 28 Feb, 2020 40 commits
-
-
Fredrik Söderquist authored
Missing negation in the "d presentation attribute not supported on other elements" subtest in ...-special-cases.html test. Set 'irrelevantElement' to null for 'd', 'height', 'r', 'rx', 'ry', 'transform', 'width', 'x' and 'y' since they are all mentioned in the table in the spec[1] as being special. They are also covered by the ...-special-cases.html test. The definition of 'Applies to' for the 'transform' attribute varies slightly between the SVG specification and CSS transforms specifications, so this applies essentially the intersection of those two. [1] https://svgwg.org/svg2-draft/styling.html#PresentationAttributes Bug: 1056055 Change-Id: Id7a6e604d4f48abbd601bdc09ec9f7ff795b86ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078581Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#745452}
-
Alexander Timin authored
At the moment we are accidentally marking kBackForwardCache feature and associated trial as active even when it is disabled by low-memory config. Add a test to ensure that it does not regress in the future. R=arthursonzogni@chromium.org,sreejakshetty@chromium.org BUG=1057081 Change-Id: I057ca3a942704eab139c1846dfa87b86e2daedec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080416Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745451}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/141da028168e..216e077600a5 git log 141da028168e..216e077600a5 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 bungeman@google.com [truetype] Add better checks for loading `gvar' table (#57905). Created with: gclient setdep -r src/third_party/freetype/src@216e077600a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 1055577 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4f5556f97d3914f5682fc89258e27f217a57763b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080043 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745450}
-
Stepan Khapugin authored
Adds a check before dereferencing self.webState. Bug: 1055334 Change-Id: Iaa046b5975d72cb7632783289ed9fdb9088a15f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080418 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#745449}
-
Bruce Long authored
WindowsSpellChecker::GetSupportedWindowsPreferredLanguages is only used in a unit test. The plan to support toggling on spellchecking for languages such as Arabic that have Windows spellcheck dictionaries but not Hunspell dictionaries has changed. We will now use the ISpellCheckerFactory::get_SupportedLanguages spellchecker API to get a list of installed Windows dictionaries, which will supplement the hardcoded list of Hunspell languages (future CL). See following for discussion: Windows Spellcheck: Should only be performed for the preferred languages listed in Windows settings https://bugs.chromium.org/p/chromium/issues/detail?id=1000443#c20 Bug: 1000443 Change-Id: I49c220ca76ff2991ee79b6184bc0616724a97267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079651Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a3900fb33dc..bde9fcce155f git log 0a3900fb33dc..bde9fcce155f --date=short --first-parent --format='%ad %ae %s' 2020-02-28 kjlubick@google.com [canvaskit] Precise font measuring Created with: gclient setdep -r src/third_party/skia@bde9fcce155f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4a8c19492e25c3bd50a6de7dd74f98dc59f85ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745447}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I8aed766371f6422df1ac671e8a6a0d12fdea8a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079729Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#745446}
-
Sam Sebree authored
This change uses the -internal-light-dark-color css property to set correct dark mode styling on text input and text area native controls. It also modifies the dark-color-scheme virtual test suite to run with the updated flag "CSSColorSchemeUARendering" Bug: 929098 Change-Id: Id3a632ac19b3705a74b7c098b64773fb98436e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071488Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745445}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29c52f9cafce..4eca785b40e3 git log 29c52f9cafce..4eca785b40e3 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 aerotwist@chromium.org [e2e] Ensures console messages are populated 2020-02-28 tvanderlippe@chromium.org Fix copy-paste error on dir check 2020-02-28 aerotwist@chromium.org Updates boot perf timing to be 2 decimal places 2020-02-28 aerotwist@chromium.org [e2e] Migrate http/tests/devtools/search/sources-search-scope.js to e2e 2020-02-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-28 tvanderlippe@chromium.org Fix clicking on labels for checkboxes 2020-02-28 jacktfranklin@chromium.org Ensure we import `errno` in ts_library.py 2020-02-28 jacktfranklin@chromium.org Remove `String.prototype.computeLineEndings` 2020-02-28 jacktfranklin@chromium.org Typecheck EventTarget.js 2020-02-28 jacktfranklin@chromium.org TypeScript CharacterIdMap_test into Ninja 2020-02-28 aerotwist@chromium.org [perf] Updates boot perf test 2020-02-28 jacktfranklin@chromium.org Typecheck Common.UIString 2020-02-28 tvanderlippe@chromium.org Reland "Typescriptify FormattedContentBuilder + move tests" 2020-02-28 szuend@chromium.org Prepare BreakpointManager.js for asynchronous source mapping 2020-02-28 mathias@chromium.org Revert "Typescriptify FormattedContentBuilder + move tests" 2020-02-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-27 tmathmeyer@chromium.org Switch the Media tab to ES Modules 2020-02-27 joselea@microsoft.com Fix Grid accessibility name. 2020-02-27 jacktfranklin@chromium.org Move Trie test to being built with Ninja 2020-02-27 jacktfranklin@chromium.org Typescriptify FormattedContentBuilder + move tests 2020-02-27 kahinds@microsoft.com Remove transparent border-top from Elements tree rows 2020-02-27 tvanderlippe@chromium.org Run TypeScript without building mode 2020-02-27 jacktfranklin@chromium.org Update screenshot testing to enable element screenshots Created with: gclient setdep -r src/third_party/devtools-frontend/src@4eca785b40e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811,chromium:1032016,chromium:1032561,chromium:1046784,chromium:1048378,chromium:1050549,chromium:1051458,chromium:1054925,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03cdc3a9812b25c683bf9ddb415064f5a260ef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745444}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f999a777d92..0fb07f8c90ae git log 5f999a777d92..0fb07f8c90ae --date=short --first-parent --format='%ad %ae %s' 2020-02-28 hta@webrtc.org Deprecate use of cricket::MediaContentDescription::Copy Created with: gclient setdep -r src/third_party/webrtc@0fb07f8c90ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ce2eb3b58bfc238a4044f7deb26c673469ce3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745443}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a165d9d1. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 98c33104 "[webauthn] WPT: Clean up virtual authenticators" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8b546e412689c0d5a2de39cfde19bdb878855774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079633Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745442}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*"[A-Za-z_]*") *(, *.)/assert_throws_dom(\1\2/gs' Then manually correcting some whitespace errors and one expectation file. Bug: 1051932 Change-Id: Ie6beffd8e61d2dfeaa480eb6024d6dea33fefb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079046 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745441}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/70ba66cdbc23..82da15f4f07e git log 70ba66cdbc23..82da15f4f07e --date=short --first-parent --format='%ad %ae %s' 2020-02-28 cepheus@frii.com Fix #2091, remove incorrect assert for division by 0.0. Created with: gclient setdep -r src/third_party/glslang/src@82da15f4f07e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I6212b870287e1399e303322eef4b3be09d496f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745440}
-
Pavel Yatsuk authored
Currently InfoBarIdentifier class generated from enum in infobar_delegate.h is only available as a source file to be included through srcjar_deps. This makes it impossible to refer to it from both chrome/android and chrome/browser. This CL adds an android_library target for the generated file, allowing it to be referred from multiple targets through deps. BUG=1056346 R=pkasting@chromium.org,twellington@chromium.org Change-Id: I054fb864c7503006e6aa8bf3fc0aedc22d3c8d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079833Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#745439}
-
Nazerke authored
This CL modernizes the IdentityChooserCoordinator to use |browser| in the initializer. Bug: 1029346, 1048410 Change-Id: I6b5440e2124c9d62060bc6eba70446c7fcb1ae5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078476Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#745438}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d33ca0263565..c1503990b2d3 Created with: gclient setdep -r src-internal@c1503990b2d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I42be4d943b1eaf9ccaa3d0d04ea6bf3939a5d151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080296Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745437}
-
Simon Zünd authored
String#trimURL is moved into a utility function upstream. The web test is already replaced by an existing Karma unit test, so it's safe to remove this web test. Frontend change: https://crrev.com/c/2078930 R=mathias@chromium.org Bug: chromium:1050549 Change-Id: Idfcd14c200cfa74ef9240041700d127b614cc2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080263Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#745436}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I672a6329f45383f078780f345ee93c59996c52d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079460Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745435}
-
Oriol Brufau authored
LayoutListMarker used to have a list_item_ member that was a pointer to the LayoutListItem that originated the marker. Now that markers are tree-abiding psedudo-elements, we can just get the pseudo-element node of the LayoutListMarker, retrieve its parent node, and obtain is associated LayoutObject. So this patch removes the no longer needed list_item_. This should have no effect in practice. BUG=457718 Change-Id: Ic4c4b1262feae32474fb279f2da7017ab081eeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079112 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#745434}
-
Rushan Suleymanov authored
This patch fixes the case when the sync service is restarted while device info bridge is loading. Check that the device info provider was actually initialized, IsTrackingMetadata does not guarantee that because the code right after calling ModelReadyToSync might not run yet. Bug: 1055584 Change-Id: Id0c8252bde40ba8814a48a3c06f8e628612b0f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072377Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#745433}
-
Jose Lopes authored
This callback is used to report that the DecodeFrame operation is complete, therefore it's a once callback. Documentation: * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.h?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=21 The callback is executed via PostTask: * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.cc?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=67 * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.cc?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=81 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Id6822683089aa7547171d97a33aa14c0842f97d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074480 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745432}
-
David Roger authored
TBR=ganesh Bug: 1055470 Change-Id: Iece9e9d0f62739ead1c32b529b0bf2f80761e7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080356Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#745431}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c6e40d2264e..1e1d74467e0d git log 8c6e40d2264e..1e1d74467e0d --date=short --first-parent --format='%ad %ae %s' 2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 07e1a0a67aee..f13d38f3cd3c (1 commits) 2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 38f68cce445b..8c312ef4c7a9 (5 commits) Created with: gclient setdep -r src/third_party/angle@1e1d74467e0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I33e4f4f5ff225857687f552ae9c5070b1043d6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745430}
-
Tim van der Lippe authored
These tests were ported in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074760 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077665 and run on the DevTools CQ. Bug: 1044632 Change-Id: Ie68e4ffc2d1a1145d08e564e9d6e0aad79d4509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077737 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#745429}
-
David Roger authored
This reverts commit 3d6d790e. Reason for revert: broke the android-builder-perf compilation See https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/160473? Original change's description: > Reland "[xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec" > > This is a reland of 21245a70 > > TBR=twellington@chromium.org > > Original change's description: > > [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec > > > > Change-Id: Ib77234174ece4facb35596808fd964a18db04311 > > Bug: 1054944 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 > > Commit-Queue: Cathy Li <chili@chromium.org> > > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744352} > > Bug: 1054944 > Change-Id: I5f6c81e1740e418307c3365bd13969769d99472a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078794 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Cathy Li <chili@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745237} TBR=dewittj@chromium.org,twellington@chromium.org,skym@chromium.org,chili@chromium.org Change-Id: I091dc99f611872409caa2ec11521ea696cb290f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080358Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#745428}
-
Anders Hartvoll Ruud authored
Unfortunately, some animation tests are now failing, because the tests use CSS.supports to query for ::marker support, and change their behavior to include ::marker animations. Animating ::marker is currently not allowed by the spec, and therefore not supported by Blink. I2S: https://groups.google.com/a/chromium.org/d/topic/blink-dev/MVXTnyC_4bQ/discussion Bug: 979041, 1054509 Change-Id: Ib97bec4b4ef9e83598543b6d77bc48e434c6180a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064930 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#745427}
-
Thomas Tellier authored
Previously reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033356 Reverted on: https://chromium-review.googlesource.com/c/chromium/src/+/2060491 Bug: 993653 Change-Id: I453f4dad1209033159ba60b1f24a48e39eea86b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066899 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e77912ba8c0f..5f999a777d92 git log e77912ba8c0f..5f999a777d92 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 danilchap@webrtc.org Allow to negotiate dependency descriptor rtp header extension 2020-02-28 kwiberg@webrtc.org Fix + test copying of fixed-sized ArrayView rvalues 2020-02-28 hbos@webrtc.org [Overuse] Separate getting adaptation target from applying it. Created with: gclient setdep -r src/third_party/webrtc@5f999a777d92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3df6a9dc368ba41fca09b2f2771f6d3204caa4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745425}
-
Alex Clarke authored
Based on the foundation from https://crrev.com/c/1967245 this patch adds support for variations headers to WebLayer along with a simple browser test. Bug: 1025612 Change-Id: Ic1dda5ccd2581c15a5d51094ece277e3035a866e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041663 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#745424}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/66759fd96232..e43a2a568976 git log 66759fd96232..e43a2a568976 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 fmayer@google.com Merge "Revert "Disable HeapprofdEndToEnd and HeapprofdCtsTest."" Created with: gclient setdep -r src/third_party/perfetto@e43a2a568976 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9698e76141b081c953d3ef88f0f1605eb989ca08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745423}
-
Dominique Fauteux-Chapleau authored
Makes drag/drop events obey the "ignore events" flag on WebContents. Also add extra early returns in "update" and "exit" since those can be called if the user drags/drops right after a scan completed. This CL is the Mac version of the changes submitted in crrev.com/c/2078654 for Aura. Bug: 1045015 Change-Id: I4dfa3b2675b344ce7befa6be37f24d89957bf16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078782Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745422}
-
Jose Lopes authored
This is a repeating callback because it is run by an event handler: * https://cs.chromium.org/chromium/src/components/mirroring/service/udp_socket_client.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=164 and it is also called repeatedly from a while loop: * https://cs.chromium.org/chromium/src/media/cast/net/udp_transport_impl.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=208 * https://cs.chromium.org/chromium/src/media/cast/net/udp_transport_impl.cc?rcl=9de1b156267c48a11dcd12948c1ab7bfe81fd008&l=217 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I265bfe00a5063e85a3461533019bfbc4f598f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073763 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745421}
-
Oriol Brufau authored
Instead of using GetPseudoElement to obtain the ::marker pseudo-element and then call GetLayoutObject on it, PseudoElementLayoutObject can directly be used. This patch should have no effect in practice. BUG=457718 Change-Id: Iff30a916834b2e57e67be9ce145c2e992b224fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078472Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#745420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4135db4c51d3..d33ca0263565 Created with: gclient setdep -r src-internal@d33ca0263565 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ica58aa1f463155d3d04ef50090f2640162037796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080049Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745419}
-
Adam Rice authored
It would greatly complicate the callers of StreamThenPromise() to handle failure, so instead it attempts to return a "dummy" Promise (that will never resolve) if the call to Then() fails. However, sometimes even a dummy Promise cannot be created. The two known causes of this are OOM and worker thread termination. We cannot recover from OOM anyway, so crashing is fine. However, crashing on worker thread termination is bad. This change falls back to returning the original promise that was passed to StreamThenPromise if all else fails. This is potentially an issue if user JavaScript is able to manipulate that promise, so we only do it if execution is terminating. If not, we fall back to crashing as before. This CL is expected to change the stack traces for OOM crashes inside StreamThenPromise. BUG=1027304 Change-Id: I815803b23af1457e7a96c6afb554066804c5c54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955001Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745418}
-
Ehimare Okoyomon authored
Put incognito ntp cookie controls logic in a class and replaced java-side logic with bridge to connect to c++ backend. Same class is used for incognito for start surface. Bug: 1040091 Change-Id: I18d679731aabda57c6b3852d4f0e4a68c268bb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044273 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#745417}
-
Viktor Semeniuk authored
Fixed spinner bug caused by removing associated-control attribute. This change includes also minor fixes to code based on post-review comments from previous CL. Bug: 1056525 Change-Id: I7492936329192108870a50c1ed10ae306af659f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078546 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745416}
-
Mathias Carlen authored
This patch introduces a test config for the AutofillAssistantDirectActions approved for the M81 Beta channel. The corresponding finch config cl is in review and prompted this change. Bug: b/148647596 Change-Id: Ia85e56c96afaea805c8e65b10a50b1549c93cbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077740Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745415}
-
Peter E Conn authored
While moving Chrome over to androidx.browser, Strings representing package names were replaced with Tokens that represent package names and their signature. Strings have hashCode overridden to provide value equality whereas Tokens don't, so checking for the existence of an equivalent Token in a Set of Tokens doesn't work. This change manually looks through the set of Tokens and calls Token#matches on each one. Bug: 1052288 Change-Id: Ia2ad8bf3272853acbd07ae36aad33e9c78fb9e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078548 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#745414}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/63288e382aeb..e77912ba8c0f git log 63288e382aeb..e77912ba8c0f --date=short --first-parent --format='%ad %ae %s' 2020-02-28 marinaciocea@webrtc.org Insert frame transformer between Encoded and Packetizer. 2020-02-28 kwiberg@webrtc.org Test copying of variable-sized ArrayView rvalues Created with: gclient setdep -r src/third_party/webrtc@e77912ba8c0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a073c2928926df421e1aa35147c8cd7eb619f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745413}
-