- 07 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84323449dfaf..461f9ab12106 git log 84323449dfaf..461f9ab12106 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 cnorthrop@google.com Capture/Replay: Implement more GLES entry points Created with: gclient setdep -r src/third_party/angle@461f9ab12106 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Id7064414d9044a3d282f396ed2e596c5ed3cb768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756944}
-
Gyuyoung Kim authored
The original WPT migration of flexitem-stretch-image.html has caused a test failure on Firefox. The test will be updated to work on Firefox. So, the migrated WPT test needs to be kept in order to make Firefox have the test. Instead, the original test is restored in the css3/flexbox to avoid regressions from the existing behavior. Additionally, this CL adds the test as flex-item-stretch-image.html to avoid the same naming confusion with the WPT test. Bug: 1063749 Change-Id: I2633293f05c3a584e73b6594d12a7c85abe39103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135659Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756943}
-
Hajime Hoshi authored
When we are restoring the page from bfcache, preserving its state, corresponding PageLoadTracker should be preserved too. BUG=1001087 BUG=1014174 Change-Id: Ic207ebfeb09d867e531a94d411efc520e30b5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007095Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#756942}
-
Melissa Zhang authored
This reverts commit 50fbc87a. Reason for revert: Breaking https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 and https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 Original change's description: > Parameterize existing accessibility hit-testing tests > > https://crrev.com/c/2117330 added tests for cross-platform > accessibility hit testing code using parameterized combinations of > simulated device scale factor and use-zoom-for-dsf on or off. This CL > expands the parameterization to other existing hit-testing tests. > > To fix issues running these tests on cast_shell_linux I also made two > changes to the tests themselves: > - Reduce the scale factor from 2 to 1.25 > - Relocate one test point to be within the screen size > > Bug: 1007488 > Change-Id: I715270064365458ac9ec69f3c3ac81a674d2718c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135017 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756884} TBR=dmazzoni@chromium.org,kbabbitt@microsoft.com Change-Id: I5082d843dcdef6454933fc3cb6008b24744af606 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139051Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756941}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dfe9760a8e2d..c048306eaf01 git log dfe9760a8e2d..c048306eaf01 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 dberris@chromium.org Dashboard: Update maximum processing rate 2020-04-07 dberris@chromium.org Pinpoint: Fix TBR parsing to be more forgiving Created with: gclient setdep -r src/third_party/catapult@c048306eaf01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054073,chromium:1067531 Tbr: nuskos@google.com Change-Id: I398991f661f61383b5a1ccf59222568fbd300fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756940}
-
Lingqi Chi authored
FailingHttpNetworkTransaction was test-only code but called by NetworkContext::SetFailingHttpTransactionForTesting, so it was linked in the production code. Since it was only called by a test to force a network error, this patch removed SetFailingHttpTransactionForTesting method and used an alternative way to do that. Bug: 1012116 Change-Id: I918e04a3c143b80292f66d3c0e47651b84d6580e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129791Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756939}
-
John Z Wu authored
Also explicitly whitelist DEVICE_INFO for clarity. Bug: 1056421 Change-Id: I724e5bae984c2b70f28d3f31861c18c0acbfdb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137590 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#756938}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f44ca7b..50b248c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I456c584e3c76c22fb6abff1ffc285c4c77a3827a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138222Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756937}
-
Hitoshi Yoshida authored
The current IDL compiler generates two sets of files foo/bar.{cc,h} and bindings/{components}/v8/v8_bar.{cc,h} for foo/bar.idl that defines a dictionary, and makes v8_bar.h include bar.h. On the other hand, our new code generator which is enabled behind a flag will generate only v8_bar.{cc,h} and foo/bar.{cc,h} won't be necessary. This CL replaces inclusions of foo/bar.h to v8/v8_bar.h to make them work with both code generators, and has no behavior changes. Bug: 839389 Change-Id: I3b9915bd7861170871d671b02330e6643b2cd932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138852Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#756936}
-
Hiroki Sato authored
NOTIFICATION_STATE_CHANGED event is dispatched not only when the toast is displayed but also when the notification state is changed. In the first case, we can dispatch accessibility announcement, and in the second case, we shouldn't. This distinguishment was done in ARC Android side. This CL migrates the logic to Chrome side. See also http://ag/10917984. Bug: b/152374820 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Change-Id: Id59902e980ff9b24d6207a4ac001ba2162937b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132023 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#756935}
-
Mike Reed authored
Change-Id: Ibfccaaa9030b8698bfe5c2652e500b6375abcf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137821Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#756934}
-
Alex Danilo authored
Removes the 'Cancel selection' text from the selection bar cancel button. Changes the icon for selection bar to match the file list selection icon. Positions the icon and number of files selected message to align with the icons and file names in the file list. Removes the resize listener on the toolbar controller which was used in the old layout to size the 'Cancel selection' button to match the position of the splitter bar between the tree and file list views. The listener function itself remains, with a comment added so that it can be removed after files-ng work is complete. Bug: 1068079, 1065837 Change-Id: I857f037995a5bc0ba631fa41f62af8d72ff99dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137185 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#756933}
-
My Nguyen authored
Screenshot view when there is confirmed_text: https://screenshot.googleplex.com/Q0sjaEKi2Qa. There is still a need to take care of cursor position of the window, it should always be at the start of the confirmed_text. Bug: 1068044 Change-Id: I12ca6553f6cf57eac82127433340046aaff804f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137181 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756932}
-
Noel Gordon authored
Update the file manager unittest harness: add SVG files to the list of allowable file types that it can serve. Bug: 1061388 Change-Id: I6ee69e26946a368da77373c2cd8c643cc856c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138931Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756931}
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@chromium.org Change-Id: I577d88c5cee4f7716e07db8b335b83cc35d8e93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134866Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#756930}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib41d35e993e312a61b9d5b3c91f845291a9530a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138772Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756929}
-
Johann authored
BUG=webm:1679 Change-Id: Ia2d3c1a81af2542dbe6c790405cc6d0492391005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136987Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756928}
-
My Nguyen authored
This is the first change in Personal Info Suggestion Window. When "show_tab" is true, the suggestion window created remains the same with the screenshot view: http://screen/MO1QeHfRwi4 When "show_tab" is set to false, the suggestion window created is in this screenshot view: https://screen/moLGCKOrvwr Bug: 1068044 Change-Id: I5397d6a1175fcfca86cb7dc3321d231560b10e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136008 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756927}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia1031c5480e0b3aaf02371befc796db1166a6d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136012 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756926}
-
Michael Sun authored
Some Bluetooth audio peripheral devices negotiate with the Chrome OS Bluetooth stack (BlueZ) for a larger Advanced Audio Distribution Profile (A2DP) stream packet size, a.k.a. AVDTP MTU. In a noisy RF environment, the Bluetooth device may fail to consume such large packet and result in packet fragmentation, which caused audio to stutter. BluetoothFixA2dpPacketSize feature flag tells Chrome OS audio server (CRAS) to override the packet size with a prefixed smaller value. Bug=b:142499564 Test=Manual enable BluetoothFixA2dpPacketSize in chrome://flags and verified audio packet BlueZ send to the reconnected Bluetooth headset, using btmon, became smaller. Change-Id: Id68a05be87c858cce416af284f1321770028402f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134500 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756925}
-
Matt Falkenhagen authored
* ServiceWorker.FetchEvent.Subresource.Status * ServiceWorker.FetchEvent.MainResource.Status Bug: 1059800, 1059801 Change-Id: Ibd6ade3eae1b8cc7b3c1a1c07e5b72f210fdb21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137163Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756924}
-
Sinan Sahin authored
Bug: 1066257 Change-Id: I6212cc2c8364307a17aa0e53e3276eae7143d494 Binary-Size: Re-added material lib component. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134769 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756923}
-
dpapad authored
When the flag is on, chrome://settings serves the Polymer3 version. Bug: 1026426 Change-Id: I376abc974caa2772cd70ff4ce6f4d4b28b5b1796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137912 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756922}
-
Abigail Klein authored
This reflects the change in plan to launch on all platforms. While doing this change, also move the captions settings on non-Mac and non-ChromeOS up above the More Features link. They should be at the same place in the settings as the non-ChromeOS settings. The More Features link should be the last option listed. Bug: 1055150 Change-Id: Ib0d65756b0c23f7523e91a4e9508cf8d4ffa03e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138155Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#756921}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afbf2aa737c8..76f4fff613b5 git log afbf2aa737c8..76f4fff613b5 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 westont@google.com Begin using Debian10 for tryjobs. Created with: gclient setdep -r src/third_party/skia@76f4fff613b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Iaf57948ef5f7aa4dba98029bf788db47ee9c882f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756920}
-
Wan-Teh Chang authored
Change kUndefinedFormat to kWebPAnimationFormat in a comment in ImageDecoder: :GetCompressionFormat(). Change-Id: I369054831fa6913930c7a8e50f1d70abd0f4f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135902Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#756919}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eda150cb2208..dfe9760a8e2d git log eda150cb2208..dfe9760a8e2d --date=short --first-parent --format='%ad %ae %s' 2020-04-06 dberris@chromium.org Fix import order to unblock push-on-green 2020-04-06 jbudorick@chromium.org pinpoint: revert inadvertent copyright change. Created with: gclient setdep -r src/third_party/catapult@dfe9760a8e2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068133 Tbr: nuskos@google.com Change-Id: Ia78de2b386c2542cc82e0ecdd850b9e36c4bac5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756918}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a645d693e951060bfc10cb7b895a8b7564b7c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756917}
-
Zain Afzal authored
The media app now has a bucket for feedback (see b/139318556 for more detail). This CL adds this bucket id to our invocation of the feedback dialog so our reports end up in the right place. Bug: 996088, b/139318556 Change-Id: I30c9cd828c5f71e36f5d45b0603ea8e46b6fcabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137170Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#756916}
-
Azeem Arshad authored
This CL adds additional logging to help understand what is triggering pairing state change in https://crbug.com/1060823 Bug: 1060823 Change-Id: I774167ae0e420bae11c0c58a9caf8937f0c93961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138562 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756915}
-
Xinghui Lu authored
Fix: Initialize the resource_type field with a default value kMainFrame. We'd like to know for each safe browsing blocking page created, what is the resource type that triggers the page. This information can help us decide the priority of resource types that should be checked in real time. Metrics added in this CL: SafeBrowsing.BlockingPage.ResourceType Bug: 1065137 Change-Id: I38f2b0b4787fb1c04ee515e08856d4ab8b00aa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133115Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756914}
-
Wan-Teh Chang authored
This is suggested by a Tricium Robot Comment from ClangTidy/modernize-loop-convert. Change-Id: I352bc58595382cb5d419c0df52941455e4745d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136883Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#756913}
-
Yusuke Sato authored
The job creates /home/root/<hash>/android-data which crosvm will export to the guest via virtio-fs in the near future. This CL depends on platform2's chromium:2134800. BUG=b:151683475 TEST=try, arc.Boot.vm Change-Id: I1c337740ee726e3acc689fb4a1c112ee9a1e7bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135055 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756912}
-
Tsuyoshi Horo authored
This member variable was added by crrev.com/c/659318, to show warning for legacy Symantec roots from content::SSLManager. But crrev.com/c/693315 stopped using it. So this member variable is not used anymore. Bug: 763984 Change-Id: Iffeb27972171bb0d231be6efd07c31cfcf2d951c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137199Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756911}
-
Kevin Babbitt authored
https://crrev.com/c/2135054 resolved a threading issue by moving print operations to the browser UI thread on Windows. Prior to that CL, the work being done was marked as blocking at the task level, rather than at the individual API level. The blocking annotations were removed in order to not have a ScopedBlockingCall immediately preceded by a ScopedAllowBlocking. This CL reintroduces the ScopedBlockingCall marks at the point where potentially blocking APIs are actually called. Existing callers also gain ScopedAllowBlocking as needed. Bug: 1067666 Change-Id: Ifb96feb96f0e6ba38ac06f09f0aa9640c547dba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128690 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#756910}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2e5dab7c2630..9c6bf7207bfe $ git log 2e5dab7c2..9c6bf7207 --date=short --no-merges --format='%ad %ae %s' 2020-04-02 michaelfsun system_api: Add CRAS dbus API SetFixA2dpPacketSize Created with: roll-dep src/third_party/cros_system_api BUG=b:142499564 Change-Id: I68616471a128382564eda7534f9d0da738629521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138113Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#756909}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f985973. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 7e979350 "Handle k-rate AudioParam inputs for PannerNode" b32714e6 "Reland: [shapedetection] Upstream TextDetection tests to WPT" c64eec2c "Implement MediaCapabilities: HDR decoding query" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7c30c4535d633c728eb2348319c001b7f329c9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138571Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756908}
-
Xinghui Lu authored
It is possible that users are not signed in but enabled enhanced protection. In this case, the access token is not available. Add a signin status check in this CL. Bug: 1041912 Change-Id: I1095a3d26784c6ba4bcf8a768bbed064ae39088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138164 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756907}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/be73a51136ac..f526d777e0b3 git log be73a51136ac..f526d777e0b3 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 kainino@chromium.org Fix is_asan build (at least on Mac) 2020-04-06 bryan.bernhart@intel.com Reland "D3D12: Stage BindGroups on CPU descriptor heaps." 2020-04-06 rafael.cintron@microsoft.com Make RefCounted derived objects have private destructors 2020-04-06 cwallez@chromium.org Make Toggles overriden automatically and device creation Created with: gclient setdep -r src/third_party/dawn@f526d777e0b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8a9fb528f5531e377f9997bbb2142f0be8b67afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756906}
-
Orin Jaworski authored
This CL adds three new focus states to the popup model line state enum for use when suggestion button row is enabled. The forward and back step logic is updated with care to respect the experimental flag, and to prepare for new keyword logic handling. Bug: 1046523 Change-Id: I336f74f3d1ed971ee23c245df196192ef29d0940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135381Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756905}
-