- 03 Oct, 2019 40 commits
-
-
Tibor Goldschwendt authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/2ecd66c696c4..93a34f0ec19e $ git log 2ecd66c69..93a34f0ec --date=short --no-merges --format='%ad %ae %s' 2019-10-01 tiborg Add assets and copy target for extra ICU data file Created with: roll-dep src/third_party/icu TBR=jshin@chromium.org Bug: 1006794 Change-Id: Ia47475f5a11e9ffc9cb51ae61f6ea0e7c934869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838356Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702561}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I773ca832b861fe8e87548798c0f0ae8b65abda1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838672Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702560}
-
Andrew Xu authored
It is a regression issue introduced by the CL on Hotseat. When the flag is disabled, the init of DelegateView returns early then it fails to set the layout manager. Bug: 1009609 Change-Id: Id53ee51556e10d60985abcabbbcba186d5afcc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838472Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702559}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0f4ac587a4ae..e5c62b37f645 git log 0f4ac587a4ae..e5c62b37f645 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 thestig@chromium.org Remove use of deprecated v8::V8::SetNativesDataBlob() in PDFium. 2019-10-03 thestig@chromium.org Roll third_party/googletest/src/ 3a4503986..f2fb48c3b (6 commits) 2019-10-03 thestig@chromium.org Roll third_party/icu/ 53f6b233a..2ecd66c69 (4 commits) 2019-10-03 thestig@chromium.org Roll third_party/depot_tools/ e5641be5f..e90e5fe20 (89 commits; 25 trivial rolls) 2019-10-03 thestig@chromium.org Roll third_party/catapult/ 884c81e17..830565958 (80 commits) 2019-10-03 thestig@chromium.org Roll third_party/jinja2/ 45571de47..b41863e42 (1 commit) 2019-10-03 thestig@chromium.org Roll tools/code_coverage/ b53d904eb..4a898be73 (7 commits) 2019-10-03 thestig@chromium.org Roll third_party/libjpeg_turbo/ baa5dc242..38c693569 (2 commits) 2019-10-03 thestig@chromium.org Roll third_party/zlib/ 8c79b6c8d..ddebad26c (2 commits) 2019-09-30 thestig@chromium.org Roll third_party/freetype/src/ 432efa25b..839a02361 (6 commits) Created with: gclient setdep -r src/third_party/pdfium@e5c62b37f645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia2f3437d8c66884a1d7bb2a3418aa5df83635176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702558}
-
Dana Fried authored
Bug: 1004871 Change-Id: I5f656464715fafd5e29a86594418b8e5433bd143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836218 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#702557}
-
Gaoping Huang authored
- What is dagre? - Dagre is a graph layouting library used by the graph visualizer of web_audio. It implements several research papers about layouting graph. License: MIT license. Size: The size of dagre.js 323 KB. The core of dagre.js is 83 KB. Github repo: https://github.com/dagrejs/dagre - Why should we add Dagre as a module, instead of a folder under web_audio? - Dagre is used by both web_audio and web_audio_worker. Therefore, it seems better to be a module that can be used as a dependency. web_audio_worker is a Web Worker that runs `dagre.layout()`. For more information about web_audio and web_audio_worker, here is a link to the POC CL: https://chromium-review.googlesource.com/c/chromium/src/+/1744801 Bug: 974343 Change-Id: Id81de6c171f64781baefac92abb79b691eee57a7 Tricium: disable Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749643Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702556}
-
Francois Doray authored
Documenting the opt-out in preparation for sending the Intent to Ship which will link to this page. Bug: 980533 Change-Id: I3979d5a910ba75447b8b6dca0cf1ed0c63877c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837086 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702555}
-
Koji Ishii authored
|InlineBoxPainterBase::::GetBorderPaintType| uses |NGPaintFragment| only to check if the fragment has a parent. |InlineFlowBoxPainter| has the same check, but painters should be created only if it is in the tree, so this check should pass. I could not figure out when and for what this check was added to |InlineFlowBoxPainter|, but if we can add the same check back if this turned out to be really needed. Also changed the function to: * Use early-return style. * Set |adjusted_clip_rect| only when it is needed. Bug: 982194, 988015 Change-Id: I9d2731acb0fb648ebf53f4cbf72475f4724aa7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832856Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702554}
-
Sven Zheng authored
This filter will be applied to the internal bot. TEST: With this filter all tests can pass. Bug: 1010568 Change-Id: I046d3f58663c5fde47ac8fb3d099099253dd108f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836139 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702553}
-
ziyangch authored
Bug: internal b/137872139 Test: Cast from Google Play Music, YouTube to Android TV. Change-Id: I5027e742bbe74187c6590ac6d478df92cdf9d8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829548Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#702552}
-
Peter Wen authored
For //src/components/module_installer/OWNERS. Bug: None Change-Id: I514d999285073fca97683f70eb03bb8d31d089d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838296 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Manu Cornet authored
Deprecate the |IsVisible| method, which is very ambiguous. Change-Id: I57185f589f338b23573142723ae81ebb75c571c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837251Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#702550}
-
Sergey Ulanov authored
This reverts commit ef78a44e. Reason for revert: input node is still needed. It worked correctly without due to a bug in Scenic. Original change's description: > [Fuchsia] remove input node from ScenicWindow > > Input node doesn't do anything. Scenic directs input events to > the Browser's session, since this is the session that owns the View. > > Change-Id: I34337c8dc98668fd432fb0ac413e19dbc9338b92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704940 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678057} Bug: fuchsia:37760 Change-Id: Ife02bdda703c00ed982b53230994ef1f90f7e867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838379Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702549}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 to 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I9bbea46e2184c4af73ee48ad02188eb5c0ac96e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838294Reviewed-by:
-
Brian Sheedy authored
Makes maps_pixel_test upload to Skia Gold instead of to a cloud storage bucket. This will make it easier to debug failures, as the images get uploaded to the same place as the regular GPU pixel tests. Bug: 1009137 Change-Id: Ia2f19f43efa216f551c0ea47c2018e9c67981b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834825Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#702547}
-
Rahul Arakeri authored
Mac doesn't |use-zoom-for-dsf|. Hence, the ScreenSpaceTransform needs to be scaled down by the device_scale_factor for hit testing to work as intended. Bug: 1003576 Change-Id: I049e5d06d4ed6859e3e5a88b7fb61b46e8175801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588948Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702546}
-
Joshua Peraza authored
eb0c4726f13d linux: make GetHandlerSocket() params optional Change-Id: Iafdf02b6cd814c02aa1892a8fee1bafc20b0e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838033Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#702545}
-
David Black authored
Previously only workspace occluded bounds were checked. This handled the default virtual keyboard case but not the floating virtual keyboard case. To handle both cases, we need to check visual bounds. Bug: b:140987575 Change-Id: I6d2012c28f1202181d5db27ab5dbea6b2f51952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836665 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702544}
-
Mark Pearson authored
Bug: 832926 Change-Id: I2be0237188ebfd7cf15e60f9187bff7deb8ef8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831465 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702543}
-
Daniel Nicoara authored
This causes the Webview channel to be terminated. Don't force the Webview to not function just because some functionality isn't present. Bug: b/142069294 Test: On device Change-Id: I5b7f44a179c6b916f6fba015c5949f743aa28c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838673 Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#702542}
-
Ahmed Mehfooz authored
Change-Id: I8938d8c8db0a3275f4cc272d980c2a09576eba7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836658 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702541}
-
Dale Curtis authored
There's some sort of process spawn failure on the bots that we haven't been able to debug yet. Instead of slowly disabling every test for flakiness, just disable the audio process on linux for these tests. This also enables a couple tests which were either never really disabled (MAC_OSX vs OS_MACOS) or are fixed by the ScopedFeatureList. BUG=832800,847881,979259,986021,1001364 R=xhwang Change-Id: Ie9519e9a5671e9143521e9da893e208d58a520a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835687 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702540}
-
Moe Ahmadi authored
Enables NTP realbox if omnibox::kOnFocusSuggestions is enabled and configured to show zero-prefix suggestions of some type in the NTP Realbox. Bug: 996516 Change-Id: Idcaf394feda35b2903df267baa87764755f79211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837073 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702539}
-
Robert Ogden authored
Keeps the 2G default. Bug: 1010979 Change-Id: I00cff02cfaab075017905a3f64372e36ba97fdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837529 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#702538}
-
James Forshaw authored
This CL adds a new security level to the sandbox to create a non-admin token which also has restricted SIDs. This shouldn't change the security properties of the token but it will ensure that it passes the AppLocker check and allow a child process with non-admin token to start. Bug: 1007260 Change-Id: I9d8b79f46407764cb7c539c0ecddf6a6c555220c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838553Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#702537}
-
Wez authored
Bindings generators now accept both the ordinal and generated-ordinal values, so we can start sending ordinal to servers, to get automatically moved to 64-bit when ordinal migrates. Bug: 991300 Change-Id: I37b3ef48596fd9bd62344a8614bcdcac0b48bd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834566 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#702536}
-
Chris Harrelson authored
This field is never used in cc now that Blink uses cc in layer list mode. Bug: 1008483 Change-Id: Ib70850e91c76cd0613bdf4b24ab14d3b7d21d172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829950 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Owen Min authored
Once we uploaded at least one profile successfully, we begins to track profiles that are opened after that. Record metrics if these profiles are not uploaded before Chrome close. Bug: 1008174 Change-Id: I3f067c594fe5d295828f6a70f494d90f6f8fb7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825301Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702534}
-
Yulun Wu authored
Bug: 976954 Change-Id: Ida65c0bd5a186d82a9947a2a6006206c37f43571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828343 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702533}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 452a3be9. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2d1942a69b2bf0d8f1983aa1959da3ff17ada180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836314Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702532}
-
Jamie Madill authored
conformance/glsl/samplers/glsl-function-texture2dproj.html Bug: 1010942 Change-Id: I3abfc1d0abbf948842836f3921413f153907e991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837374Reviewed-by:
-
behdad authored
Instead of terminating reporter on DidNotProduceFrame, reporter should stay alive until later. It will be terminated if a frame is submitted, or will be overwritten if another activation happens before a frame is submitted. Bug: chromium:1010639 Change-Id: I44c36db0341de1126d2734718e48fcc904c61b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837652Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702530}
-
Samuel Huang authored
This reverts commit 3f9553e2. Reason for revert: Consistent timeout in browser_tests: EditDictionaryA11yTest.EDIT_DICTIONARY_hidden_content on Linux CFI. Original change's description: > A11y: Label "delete word" button in setting's custom dictionary. > > Bug: 1008556 > Change-Id: Ib07aacbba4c611620e64228ae538e02d58aecd75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827384 > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Auto-Submit: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702285} TBR=dpapad@chromium.org,hcarmona@chromium.org Change-Id: I3a7ea9fc5e045da47624652c9f4518f8f9ecd989 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838378Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702529}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab5d4d490562..f585476f768e Created with: gclient setdep -r src-internal@f585476f768e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I04b653b2bb5cf9780f4c28751370e183ad8141d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702528}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/880a3f812b03..a5afaefee543 git log 880a3f812b03..a5afaefee543 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 lamontjones@chromium.org Revert "PRESUBMIT.cfg: verify that we work with signer." Created with: gclient setdep -r src/third_party/chromite@a5afaefee543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0e7d51b8120d1d330f9ddac42dfb4cb1aa3385bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838291Reviewed-by:
-
Koji Ishii authored
This patch fixes bidi reordering sometimes confused by empty inline boxes. These items do not have resolved bidi levels. Before this patch, |NGInlineLayoutAlgorithm| reordered ignoring such items. This patch changes it to assign bidi levels to such items by copying from adjacent items and let reordering to handle them. Bug: 1010662, 1010641, 998872 Change-Id: I5d074143970b83b64bddbb83cd03b17551e3f521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837435Reviewed-by:
-
Aleks Totic authored
Using empty Optional<MinMax> to indicate that MinMax value should not matter caused trouble with ng_length_utils ResolveInlineLengthInternal, when max-width was fit-content. Use MinMax(0, LayoutUnitMax) to indicate intrinsic size does not matter instead. It accomplishes the same goal, computed size does not get clamped by intrinsic. I've also tested running it with width:max-content out of fear that we might end up with too wide OOF, but that did not happen. Bug: 1010798 Change-Id: Ife11b3d9637be91cc0648b7f8485af51f07108bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837118 Commit-Queue: Aleks Totic <atotic@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#702525}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b7cc20e..563be8e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e4801a787f9cf852dfaa3aee65d1266060d0030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835815Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702524}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLOptionElement> and DynamicTo<HTMLOptionElement> as new downcast helper 2. Use IsA<HTMLOptionElement>(element) in place of IsHTMLOptionElement(element) Bug: 891908 Change-Id: I7a825d4ad59b9d8f5c148539b95581a964ac4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803020 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702523}
-
Luum Habtemariam authored
This adds correct handling of this service's failures by tacking on an http_status_code to the returned response. Any requests that fail parsing or validation generate a HTTP_STATUS_BAD_REQUEST. This involves a mojom interface uprev to MinVersion=1, first applied here and once this lands in ChromeOS will be followed by its counterpart crrev.com/c/1834650. Bug: chromium:945409 Test: tba Change-Id: Idacef1633fe6ea6d4c421f04c9dd54b4ce2fad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834742Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
