- 19 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4bcf107ea529..b026043a43f9 git log 4bcf107ea529..b026043a43f9 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 taylori@google.com Import perfetto json traces Created with: gclient setdep -r src/third_party/catapult@b026043a43f9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8d9bd206ca5f251e31eb447b8a4e70d38d1ceb18 Reviewed-on: https://chromium-review.googlesource.com/c/1291164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601207}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I906702293b16456ca8a6d7d7dc513590132233bc Reviewed-on: https://chromium-review.googlesource.com/c/1291789Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/67ebe3f7aebe..c5a6d259c2fb git log 67ebe3f7aebe..c5a6d259c2fb --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Increase the template nesting depth for clang. (#1995) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c5a6d259c2fb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I943fb1eb4d69342d712ce27f9de78a67f6625c5f Reviewed-on: https://chromium-review.googlesource.com/c/1291163Reviewed-by:
-
Shawn Gallea authored
Removed ash dependencies within EXO BUILD.gn file to allow non-ChromeOS compilation. Bug: 896710 Test: Compiled client on ChromeOS and verified it still builds. Change-Id: I57b36c10ad55a609b7969f00b225abecd2f55fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1288894Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#601204}
-
Kyle Milka authored
Remove the use-ddljson-api flag for forcing test doodles on the NTP. Allow forcing of doodles via the url param '?force-doodle=x', for x from 0 to 4. They can also (still) be forced via the command line flag. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibf9836baf2dd43114d85b3daf892c2745a30cb89 Reviewed-on: https://chromium-review.googlesource.com/c/1278952Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#601203}
-
Joe Downing authored
This reverts commit ba9595ea. Reason for revert: Suspected of causing persistent BrowsingDataRemoverBrowserTest failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932222237758099792/+/steps/browser_tests_on_Windows-10-15063/0/logs/BrowsingDataRemoverBrowserTest.SessionOnlyStorageRemoved/0 This failure started after this CL was checked in and appears to be in the same area of code. The failure is being seen on the Win10 Tests x64 builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/28682 Original change's description: > Cache Storage: Clear session-only origins on shutdown > > Bug: 824533,750452 > Change-Id: I103d6b6a3bd106a6a38de03f9ff14d2766c7b269 > Reviewed-on: https://chromium-review.googlesource.com/c/1288890 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601141} TBR=jsbell@chromium.org,jam@chromium.org,pwnall@chromium.org,wanderview@chromium.org Change-Id: Ia41455e70e5e89598fb1296cc539f143bda8295e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824533, 750452 Reviewed-on: https://chromium-review.googlesource.com/c/1291781Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601202}
-
Scott Violet authored
It's flaky on ChromeOS as well. BUG=897058 TEST=test only change TBR=lukasza@chromium.org Change-Id: I11cc721b303a738d1c1b799170887b9b5aa67db6 Reviewed-on: https://chromium-review.googlesource.com/c/1291412Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601201}
-
Wei Li authored
Other than regular fullscreen state changes, there is one more change on Mac -- turning toolbar always on/off during browser fullscreen mode. In such case, we need to make sure 'Always Show Bookmarks Bar' should be enabled/disabled accordingly. This CL triggers browser command update during such transition. BUG=894004 Change-Id: Ia0a5fb358ca5238492cb8ffca957d10a849ded3c Reviewed-on: https://chromium-review.googlesource.com/c/1279410Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#601200}
-
Robert Ogden authored
With the new UI in the Omnibox, showing the UI after a sometimes significant delay whenever a lofi image is loadedis not a good user experience. This moves the decision to show the UI to commit time. Bug: 896476 Change-Id: I26b2ccaf9278435c3ccdfab508937d38fa64660c Reviewed-on: https://chromium-review.googlesource.com/c/1289086 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#601199}
-
Colin Blundell authored
A straightforward port of //chrome's Profile adaptor that will be used by //ios/chrome unittests that tied to the BrowserStateKeyedServiceFactory infrastructure. Bug: 895772 Change-Id: I61cd90a0fdcb494e661711ccfb8c2bdeb411193d Reviewed-on: https://chromium-review.googlesource.com/c/1290941 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b8db890c4ee..ab631ca2c962 Created with: gclient setdep -r src-internal@ab631ca2c962 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6675ce867ca79e55ec1137c45fd07c4e4b715426 Reviewed-on: https://chromium-review.googlesource.com/c/1291161Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601197}
-
jdoerrie authored
This change implements base::flat_tree::contains(). This mirrors C++20, which introduces contains() to the associative containers in the STL. See P0458R2 [1] for further details. [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0458r2.html Bug: 682254 Change-Id: I4af8ce4fadd4647f7021d374bee4316c110c277d Reviewed-on: https://chromium-review.googlesource.com/c/1288434Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601196}
-
Robert Ma authored
This CL changes the behavior of the git_cl.py module to only specify the bucket if it's explicitly given to it. git cl will figure out the appropriate bucket to schedule tryjobs in. TBR=robertma@chromium.org Bug: 891729 Change-Id: Id1ed02d1a3cc3aca53710bf67a69e9da1c7a8a85 Reviewed-on: https://chromium-review.googlesource.com/c/1289694 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601195}
-
Ehsan Karamad authored
RemoteFrameOwner does not implement the logic for fallback content. This means if a cross-origin navigation fails with some error, the owner element (in this context, <object>) in the parent process does not get notified and will not use its fallback content (instead the frame might show an error page). When the <object> has fallback content, it should always use that over the frame's error message. To support this matter, this CL implements fallback methods in RemoteFrameOwner. Essentially, * When <object> creates a local frame, the corresponding frame tree node will be marked as the type that "can" render fallback content. This will propagte everywhere using FrameReplicationState. * When the provisional loading of a frame fails, RemoteFrameOwner will notify the browser through the current proxy for navigation. The browser then uses the parent frame to notify the renderer process that the owner element should render its own fallback content. * If the <object> does not specify fallback, the navigation to error page commits and the error page is shown. * When the <object> renders its own content, the remote frame stays alive. This is a bug but not a new one; It will be fixed in future CLs. Bug: 853140 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb Reviewed-on: https://chromium-review.googlesource.com/c/1105635 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601194}
-
Antoine Labour authored
For any given BufferFormat, there is a single internal format that it is compatible with (note, the converse isn't true), as defined by gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat. Rather than leaving guess-work to the client, instead expose it via a gpu::InternalFormatForGpuMemoryBufferFormat. This in turns simplifies quite a few things, and in particular we don't need to send redundant information in IPC (BufferFormat vs internalformat) that we then need to validate. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I34a12c71c252ba2a5199f47ce983a02307df351b Reviewed-on: https://chromium-review.googlesource.com/c/1290192Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601193}
-
Ella Ge authored
Previous CL crrev.com/c/1279204 changed the touch adjustment bound to CSS pixel; however, kMaxAdjustmentSize is a bound on the finger size in case noisy drivers or errant touches causing degenerate hit-tests that hit too many elements. The bound should be in dip so it's corresponding to a physical size. Therefore, kMaxAdjustmentSize should be in unscaled dip, and we need to convert it to scaled physical pixel to compare with touch_area, which is in root frame coordinates (scaled physical pixel). Bug: 894961 Change-Id: Ib515e55fd027ba7c17db7488d872be82b91f954a Reviewed-on: https://chromium-review.googlesource.com/c/1287201 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601192}
-
Mike Wasserman authored
Changing behavior as requested, and updating tests: 1) The mute button should toggle mute (rename mojo function). 2) Volume up/down buttons should adjust up/down normally when muted. 3) Volume up/down buttons should also un-mute (if above default mute level). 4) Volume down will still mute if the level is below the default mute level. Bug: 895550, 895552 Change-Id: I353ab3124bb0375f109b96841cce6df3c9839388 Reviewed-on: https://chromium-review.googlesource.com/c/1289990 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Xida Chen authored
It looks like a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/985100 which removes a un-used histogram, forgot to indent this part of code. This CL doesn't introduce any behavior change. TBR=enne@chromium.org Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6897c1116f8119c0e14c436e17d2c873d3228ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1291357 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601190}
-
Scott Violet authored
It's no longer used. BUG=895619 TEST=none Change-Id: I9f5c713988f8c5838bc99769cd418778c9e3aa5c Reviewed-on: https://chromium-review.googlesource.com/c/1285121Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
dpapad authored
Bug: 896585 Change-Id: Ifdb8e98e2f58e943dbf2e3ace265a5000757077d Reviewed-on: https://chromium-review.googlesource.com/c/1289155Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601188}
-
Aldo Culquicondor authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7d2dbc7816dca5ada17ca444c8c61093a86f6fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1280605Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601187}
-
Scott Violet authored
on single-process mash (interactive ui tests). It's flaky. BUG=897058 TEST=test only change TBR=mukai@chromium.org Change-Id: I1eaea1ca641f01d4d8e2fb749e497d11c7ec6b1e Reviewed-on: https://chromium-review.googlesource.com/c/1291690Reviewed-by:
-
Bo Liu authored
Change-Id: I67bf19c8225d76d2f1b383597af14627cce2f669 Reviewed-on: https://chromium-review.googlesource.com/c/1291529Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601185}
-
Evan Stade authored
Adds a single-item context menu for Hosted app windows (teleport window). This is currently only supported in single process Mash because multi user window manager doesn't work in multi process Mash. Bug: 887051 Change-Id: Ifd1c7a08acf46615ff5fec2f0e7a614c9c99775c Reviewed-on: https://chromium-review.googlesource.com/c/1287202Reviewed-by:
-
Camille Lamy authored
This CL makes sure we do not attempt to rewrite a subframe navigation URL in should only be performed on main frame navigations. NavigationControllerImpl: :CreateNavigationRequestFromLoadParams. Rewrites Bug: 895065, 803859, 896028 Change-Id: I2a2326d802b55655d59f0c6d3d73e3060c58152b Reviewed-on: https://chromium-review.googlesource.com/c/1282992 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601183}
-
Scott Violet authored
Currently clients of window-service forward KeyEvents to IME. Ash was doing the same, resulting in KeyEvents destined for remote clients going to IME twice. BUG=891489 TEST=none Change-Id: I315c84399cfb9d8adf39ae9f3eb6c50d222f22c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290194Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601182}
-
Fady Samuel authored
Now that we don't do temporary reference ownership, SurfaceObserver::OnSurfaceCreated doesn't do anything useful. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6e9cf4557c10f50f097cd02c78fb3bd688cfc9d6 Reviewed-on: https://chromium-review.googlesource.com/c/1291216Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601181}
-
danakj authored
Child local roots (ie OOPIF) widgets will CloseWebWidget() synchronously in the IPC handler for OnClose(). Then they post-task the Close() action. The Close() action will also CloseWebWidget() but it does other work first. To keep the order consistent, move code above CloseWebWidget() into the method so both paths close things in the same order. R=ajwong@chromium.org, avi@chromium.org Change-Id: I0a5ac711b8ee17879483a1c37fab3d6d5176f798 Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1290129Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601180}
-
Sorin Jianu authored
This is a mechanical change. Its purpose is allowing different wire protocol parsers and serializers to be injected in the UpdateChecker and PingManager instances in the UpdateClient using the Configuration instance. The current code hardcodes an instance of ProtocolHandlerXm. There is work in progress to support JSON. Bug: 881076 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40cb1605f134a5d3f168a511094b2b265bc50f25 Reviewed-on: https://chromium-review.googlesource.com/c/1289510Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601179}
-
David 'Digit' Turner authored
Normally, compiling Android resources requires unpacking and processing resource dependencies into a temporary directory before sending the result to 'aapt2 compile', then getting rid of these intermediate files. To help debug issues related to Android resource compilation, this CL introduces a new GN variable that can be set in your args.gn, to force the build to put all such build directories under a top-level directory, and not removing intermediate files in it. This should allow inspecting the intermediate files to better understand what's going on. This is needed to debug issues that appeared in my attempt to change the resources stored in APKs versus bundles, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/1270947 BUG=879228,882860,897056 R=agrieve@chromium.org, estevenson@chromium.org,yfriedman@chromium.org Change-Id: I76c79a893b0bbdb56ba685f4304da929d11c7e05 Reviewed-on: https://chromium-review.googlesource.com/c/1288436Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#601178}
-
Daniel Bratell authored
Some headers appeared twice in some sources list. This confused some other tools so it seems like a good idea to only have them there once. Change-Id: Ifa0c7b2e0fbb8b7ec401bad2737384cffa3d940a Reviewed-on: https://chromium-review.googlesource.com/c/1290949Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL removes the handling of the com.android.browser.headers intent extra in WebappActivity. The handling was added in https://chromium-review.googlesource.com/c/chromium/src/+/1116219 at the time that TWAs used WebappActivity. They no longer do so. BUG=871266, 801487 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ife40f882f45900f33ff356c435ee1a9283a4419e Reviewed-on: https://chromium-review.googlesource.com/c/1288012Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601176}
-
Scott Violet authored
This adds the ability to register a callback on a KeyEvent that is called when async processing completes. This is important for content as key events may be handed to the renderer, which means the event is asynchronously processed. BUG=891489 TEST=none TBR=sadrul@chromium.org Change-Id: I1dc0ae3768c61eac7bd5edadf0be8562dae8b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1290069Reviewed-by:
-
Lukasz Anforowicz authored
This CL: 1. Transitions core CORB test coverage away from the fetch API (where blocking by OOR-CORS can interfere with test results) to triggering fetches via <img> tags (where CORB stays applicable even after OOR-CORS ships). Tests covering CORS/CORB intersection continue to be done via fetch API (in CrossSiteDocumentBlockingTest.BlockFetches test). Verification of response body no longer depends on disabled web security (and inspecting fetch API results), but is instead done via RequestInterceptor helper that lives next to the tests. The CL also uncovered and fixes a threading issue in the implementation of RequestInterceptor. 2. Stops testing range requests in content_browsertests and starts to rely on existing and new test coverage in content_unittests (fetch API seems to be the only directly-test-controllable way of making range requests). I've tested this CL by manually running CrossSiteDocumentBlockingTest from content_browsertests 1) in default mode, 2) with NetworkService enabled and 3) with NetworkService and OutOfBlinkCORS enabled. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iec5c9f0e7ddad0ff02627b88dcfab276795e7be9 Reviewed-on: https://chromium-review.googlesource.com/c/1279351Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Sky Malice authored
Specifics: +737,771 bytes normalized apk size +5 zip entries file count +62,432 bytes main lib size +454,572 bytes main dex size InstallSize: +285,833 bytes APK size +817,682 bytes Estimated installed size (Android Go) +2,122,304 bytes Estimated installed size InstallBreakdown (+2,119,225 bytes): +2,634 bytes unwind_cfi (dev and canary only) size +1,930 bytes Non-compiled Android resources size +62,432 bytes Native code size +364 bytes Package metadata size +2,036,261 bytes Java code size +15,604 bytes Compiled Android resources size Dex: +2,312 entries fields +3,224 entries methods +758 entries types +1,608 entries strings Change-Id: I11d8256a8a571169e0a39892e6c99ab6f8282629 Reviewed-on: https://chromium-review.googlesource.com/c/1290201Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601173}
-
Ben Wagner authored
Specifies the cross product of '@font-face font-feature-settings', 'font-variant-ligatures', 'letter-spacing', and 'font-feature-settings' with various values to test feature precedence with respect to ligatures. Bug: chromium:894954, chromium:896033, chromium:450619, chromium:443467 Change-Id: I182ce477fd0ec5dd5070c540460b1ee4e1148b8a Reviewed-on: https://chromium-review.googlesource.com/c/1289729 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#601172}
-
chrome://creditsPeter K. Lee authored
Bug: 884663 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0075911b60df18873c8c64db17d3455d567e9ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1236661Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#601171}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0e68bb36327c..67ebe3f7aebe git log 0e68bb36327c..67ebe3f7aebe --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Add custom target to wrap around custom commands. (#1986) 2018-10-19 greg@lunarg.com Fix ADCE to treat OpUnreachable correctly during liveness analysis (#1984) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@67ebe3f7aebe The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2efc4ff24e4f8f11ee84cca38316fd534c2e3466 Reviewed-on: https://chromium-review.googlesource.com/c/1291156Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4c3ebaca5a9..4bcf107ea529 git log a4c3ebaca5a9..4bcf107ea529 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 titovartem@chromium.org Add units for Ampers, Volts, Hertz, bytes per second Created with: gclient setdep -r src/third_party/catapult@4bcf107ea529 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I219847965f9753d4ad032a9d41ea23baf483fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/1291157Reviewed-by:
-
Xida Chen authored
No behavior change. Bug: None Change-Id: Ifc1874c520d7d6f03f674f5fb228cdeec3bc9b7d Reviewed-on: https://chromium-review.googlesource.com/c/1291214Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601168}
-
