GitLab

This CL was created automatically with tools/perf/update_wpr script

R=crouleau@chromium.org

Bug: 878390
Change-Id: I7b2f914297110f7c7daa0da4e58f5339f7b9d18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971915
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726131}

Update the function name from OnWindowVisibilityChanging to
OnWindowVisibilityChanged.

Update the Chrome app checking, because when the app is an extension,
it could be opened in browser, so we should check the browser context
in AppService instance to decide whether that is a Chrome app, which
is opened in AppWindow. Otherwise, it could crash the browser should
manage those apps.

Fix the bug found by the new browser test:
1. The AppServiceInstanceRegistryHelper should be shared by
browser_status_monitor and AppServiceAppWindowLauncherController, and
owned by AppServiceAppWindowLauncherController, because
browser_status_monitor updates the record in
AppServiceInstanceRegistryHelper, if they use separate one, then
AppServiceAppWindowLauncherController can't know which apps are managed
by the browser.
2. When switch between the window, the AppServiceInstanceRegistryHelper
should update the apps opened in the browser.

BUG=1011235

Change-Id: I98080bca6ed6dc80a2c20ab1e9096e455d47187d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973971Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726130}

TBR=govind@chromium.org

Change-Id: I0d2560e3b7ef3263b854dc0b43106f320286130c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974491Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726129}

<This change is hidden behind a flag>

As part of migrating PK IMEs to native code, this CL migrates key
handling to native code path.

We port Background#maybeHandleKeyEvent [1] and
RuleBasedController#handleEvent [2].

[1] chos/background.js
[2] chos/pk/rulebasedcontroller.js

Note that the JS code has already been guarded by the runtime flag.

Bug: 1009903
Change-Id: I801505f11af95dbc066b12d7bb70f6a9765fea65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921589Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726128}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b65f3282baa9..d94b7f19dbf6


Created with:
  gclient setdep -r src-internal@d94b7f19dbf6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic63c2cb085bc2f2cfeec35a8e31576b2701d532a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974642Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726127}

Change-Id: I651e642bce83df4f8e4679353e002ccfde3da808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971845
Auto-Submit: Matthias Körber <koerber@google.com>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726126}

Windows only as rule evaluation uses Windows functions.
|maxParams| is only 2 as that's what the rules use and I'm
trying to exercise code that the rules activate.

Change-Id: I41767336858fef82abcd8ddb9d19fb0e620ce41c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872560Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726125}

Causing WindowServer crashes w/ the reduced filter file.

Bug: 899286
Tbr: ellyjones@chromium.org
Change-Id: I110e7450681b83548c8e6fc6f35fdf6a33dd73e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974492Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726124}

Most added suites were failing to compile due to compiler issues.
We can add them after compiler issues are fixed. (2 fixed upstream
but need to roll in chromium, the one I'm working on is under review).

Bug: 985574
Change-Id: I612a3197a5b142d8049effb73c45a2fb5c0c1e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973240
Auto-Submit: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726123}

Bug: None
Change-Id: I7a48a3a9664d8ce5220284c77d9f0535248f26db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974892Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726122}

Introduce WebContentsObserver::OnDidAddMessageToConsole() to (partially)
replace WebContentsDelegate::DidAddMessageToConsole(). This is useful
for consumers that are interested in monitoring the console messages
added, but not changing the behavior of adding the message. It will also
be used in the future to enable easier testing, since it won't require
modifying the WebContents' existing delegate.

Update WebViewGuest<> to use the new method, instead of overriding the
WebContentsDelegate version.

Bug: 1034150
Change-Id: Ia0d3e9aaf72a57c55244d508b4c49d02644970f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968152Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726121}

Paths in `--files-to-instrument` are expected to be normalized OS-native
paths, so the input source file has to be converted to match.

This is most relevant on Windows, where GN creates build commands that
use `/` for filesystem paths, but the canonical form should use `\`.

Bug: 990480
Change-Id: If7b5da729f0a98ec7945092b0f228cebd50be3a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973360
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726120}

This allows us to provide better runtime estimates for
the cycletime spreadsheet that we are autogenerating.

Bug: 1030840
Change-Id: I02d50f65f916196f9277ba24a356d5380e07c14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974697
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726119}

The internal linux-code-coverage builder doesn't run fuzzers anymore,
so it can be moved to external. This CL revives the external version
of linux-code-coverage, and once it accumulates enough reports, will
turn down the internal version.

Currently there are 4 32-cores ssd bots that are used by code coverage
builders, and there are 3 builders: linux-chromeos-code-coverage,
android-code-coverage and android-code-coverage-native, and the
android-code-coverage usually finishes fast (1h every 6h), therefore,
there is room for one more builder: linux-code-coverage.

Bug: 1016929
Change-Id: Ifeeb78fba69af0567857e905ced9a29196469528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974576Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726118}

This reverts commit 269e59a8.

Reason for revert: Failures on Debug build try jobs:
https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg

Original change's description:
> Android: Add Monochrome32 and Trichrome32 build targets
>
> This change adds a pure 32-bit version of Monochrome and Trichrome to
> the 64-bit build configuration. Building these targets generates a
> product equivalent to building the targets on a 32-bit config. However,
> by adding these, we have the option of building all Monochrome and
> Trichrome products on a single 64-bit builder, and, we share the
> compilation work (as opposed to the obsolete process of "APK merging"
> parts from a 32-bit build into 64-bit products).
>
> The targets added here are the public versions.
>
> Bug: 1027573
> Change-Id: Id5ffd698721077e8fffb1f8206adc0b7b1fce212
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960575
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723897}

TBR=torne@chromium.org,cjgrant@chromium.org,estevenson@chromium.org

Bug: 1027573
Change-Id: I192ff6511e17c745ecadcf4a8ecfdddf40967bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974000Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726117}

Change-Id: Ia1f87b0479a92d9f57d4261379044baa13f574b6
Bug: 1035171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974530Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Amy Huang <akhuang@google.com>
Cr-Commit-Position: refs/heads/master@{#726116}

https://skia.googlesource.com/skia.git/+log/0d7e2f158e9b..f64e958e897a

git log 0d7e2f158e9b..f64e958e897a --date=short --first-parent --format='%ad %ae %s'
2019-12-18 kjlubick@google.com Properly free bytes in SkDescriptor fuzzer
2019-12-18 bsalomon@google.com Make sure random unit test processors use an alpha type compatible with
2019-12-18 mtklein@google.com disable warnings in ANGLE
2019-12-18 mtklein@google.com Revert "roll clang_win"

Created with:
  gclient setdep -r src/third_party/skia@f64e958e897a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: Ia47b6ac174befcef3ac9bfb5038ade27fcc7b58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726115}

A follow-up cl will pipe this information through to NavigationHandle.

Bug: 1016325
Change-Id: Ie82abc6ca072a0354f06dddb5dbf04715599cf21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953511Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#726114}

We accidentally broke altgr for rule-based inputs in [1] because we
looked at the "altgr" attribute of the keypress info, which is only
filled by the VK and not the PK.

For the PK, AltRight is always treated as AltGr, so we add that logic
back in.

We add a test to prevent this from happening again.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1837312

Bug: 1035145
Change-Id: I64d3d56b08c8cd2a82c4617f63a3c6f34444f36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971638Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726113}

This allows us to remove some redeclared classes like TabGroupMetadata. It also gives greater flexibility and readability when creating more Tab Group types (such as TabGroupColor in the followup change).

Change-Id: I5767f6868c202c37550fa2a9e62e565a87ea5686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967128Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726112}

BUG=787254
R=guidou@chromium.org

Change-Id: I642e78ab921ab119b9cb6f4643b03aea00ee975f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969691Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726111}

Apply an app:tint to the icons in the sharing hub, so they correctly
change color when the system is in dark mode.

screenshot: http://screen/zsopm5J1Tg1.png

Bug: 1009124
Change-Id: I4fbf93959829ca570aa5c0b33837ab017e5744a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974694Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726110}

The modification timestamp ensures files can't be read after they are
modified, so make sure it is actually passed along and used when uploading
a file. On its own this change doesn't actually fix anything, since the
timestamp that is passed around isn't always set yet, so for nearly most
cases this CL will have no immediate effect. Separate
CLs will make sure the timestamp is set properly in the first place.

Note that even then, we still trust the renderer process to decide if it
should be allowed to upload a file after the file was modified; ideally we'd
further refactor the network side code to instead check the snapshot state
in the browser process, but that is a much more involved change.

Bug: 844874, 818327
Change-Id: I838d0b6996857ee691fee5b9162c75f8b2ca99c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968113Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726109}

|verified_sync_tokens_required| was set false as a performance
optimization when the display compositor and browser UI shared a command
buffer. This never happens anymore outside of tests so it can be
removed.

TBR=liberato@chromium.org

Bug: 869250
Change-Id: I0d9ae641d3d201061d6326982af04f4fb5262a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972780
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726108}

This covers removal of deprecated base::Bind, base::Callback,
base::Closure, base::Passed across the following components/
subdirectories:

- components/sync_sessions/
- components/translate/
- components/update_client/

Fixed: 1007743,1007746,1007748
Change-Id: Ie8d5c8267ac125b903ba04443d031e8134122dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970293Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#726107}

This CL also updates a number of existing tests to re-enable FTP via
explicitly enabling the kFtpProtocol feature. Unrelated tests will
continue to be run with FTP disabled.

Affected tests are exercising FTP specific functionality which will also
go away when FTP is deprecated.

Bug: 333943
Change-Id: I8dea73bc825011bff1d3fef46194b8ca43e2fc27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966279
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726106}

This reverts commit 630672d6.

Reason for revert: attempts to extract linux build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/20794

Original change's description:
> Make Mac10.X Tests builders into thin testers
> 
> This will free up a small amount of Mac hardware which can be
> used elsewhere. It also creates a template for other OSes with
> builder/tester splits to follow.
> 
> We know that this works because the mac-osxbeta-rel CI builder
> already does this (as can be seen by the smaller diff in its
> generated config).
> 
> Bug: 1003062
> Change-Id: Iecdb68404dd3ae16eabfc657981f0e82478a040a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974510
> Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726077}

TBR=agable@chromium.org,martiniss@chromium.org,gbeaty@chromium.org

Change-Id: Ide3b7335f67e1b48cbaf0cb1a9c69ce4211c0f33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974614Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726105}

No logic changes.

Change-Id: I3f35d7e149f6ffef9cc561c57250eeeacdf603f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973193
Commit-Queue: Stefan Zager <szager@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726104}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99420bb95152..bd51b1d1e98f

git log 99420bb95152..bd51b1d1e98f --date=short --first-parent --format='%ad %ae %s'
2019-12-18 brgoddar@microsoft.com Coverage: Update URL cell in datagrid screen reader label to full url

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@bd51b1d1e98f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:963183
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I26fddc6979b83be637e560f5b3627388f2c8fb41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726103}

BUG=963574
R=guidou@chromium.org

Change-Id: Ie7e76a2fc0e65ddeb53b6af5b12883a4f2994aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969690
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726102}

Test is flaky on Mac and Windows. Disable it on those platforms.

Bug: 1035062
Tbr: dbertoni@chromium.org
Notry: True
Change-Id: Id556b0cde7e9ca26a3b4b3e0fac244f794427010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974577Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726101}

Bug: 1026455
Change-Id: I2475481ecc6d0b93c614cb53413534ea38dc1267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974536
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726100}

The new test expectations format only allows one space between
the specifier list and the test name. It also allows only one space
between the test name and the expectations list.

Bug: 986447
Change-Id: Iced71e58de9d8ad8df2d4b29466a03516c93443d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974752Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726099}

Nothing in production should rely on InProcessCommandBuffer creating its
own SharedContextState. If one is required, it must be obtained from the
task executor and thus shared with other contexts.

Just remove the code and fail init if SharedContextState is null when it
is required.

Change-Id: I7de905182c8127d17907caff4bfd005182037b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970135Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726098}

Using a shared, per-StoragePartition URLLoaderFactory is incompatible
with the desire to have per-factory control of CORB and CORS exceptions
(tracked by https://crbug.com/936310).  In particular, without the
current CL, the WorkerTest.WorkerInBackgroundPage from browser_tests
would fail after a follow-up https://crrev.com/c/1925354.

The problem is that content::WorkerScriptFetchInitiator::Start sets
mode = network::mojom::RequestMode::kSameOrigin and expects that
extension permissions will relax CORS/same-origin requirements.
To ensure that extension permissions are still taken into account after
removing global OriginAccessList, we need to make sure that
WorkerScriptFetchInitiator uses an origin-specific URLLoaderFactory
(rather than a shared, per-StoragePartition factory).  This is exactly
what this CL does.

Bug: 936310
Change-Id: I79c8d0d54404cb8b572b4c1a1195fa88333f0590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962599
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726097}

Bug: 1032236
Change-Id: I5f80fb7c33158e39b17ff0947f1fa239929815b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958808
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726096}

Bug: 1009124
Change-Id: I083464bcae4f431bcb094aed4d9e4edc0d670eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959398Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726095}

https://android.googlesource.com/platform/external/perfetto.git/+log/5bddc336299d..61e3d1746f00

git log 5bddc336299d..61e3d1746f00 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 treehugger-gerrit@google.com Merge "perfetto-ui: Open HTML traces with legacy viewer"

Created with:
  gclient setdep -r src/third_party/perfetto@61e3d1746f00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I804fbbcb5d1526aad02b5566a19d137cfe4fd15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726094}

Using wpt-import in Chromium 25abdbcd.
With Chromium commits locally applied on WPT:
c15c1083 "Add test that datachannels close when connection does."
fadf6027 "[css-pseudo] Recalculate viewport units in ::marker"
044ad8ad "[OT-PW] Make it work with OOP-R"
2ad15546 "Make interpolation-testcommon.js support composition"
9899425d "[css-layout-api] IntrinsicSizes Implementation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ie31543516d0c08fe3915334961382cc967447615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973996Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726093}

Conflicting CLs landed around the same time causing the
ChromeOS build breakage.

Notry: True
Bug: None
Change-Id: If5b733792bdce60fca7de10e150dee7d1aa29ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974702
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726092}