- 03 Jan, 2018 40 commits
-
-
Juan Antonio Navarro Perez authored
(for real this time) TBR=nednguyen@google.com NOTRY=true Bug: 797261 Change-Id: I68bf8771f4b3eb0b8e0cd662b87067b805b8a259 Reviewed-on: https://chromium-review.googlesource.com/848933Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526670}
-
Boris Sazonov authored
This CL changes AccountManagerFacadeTest to use LocalRobolectricTestRunner instead of BaseJUnit4ClassRunner. Bug: 779568 Change-Id: I2ed4af8c6ee239fbbb8c888cc41259f5ad643cfc Reviewed-on: https://chromium-review.googlesource.com/846744Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526669}
-
jdoerrie authored
Chromium allowed std::initializer_list soon after base::Optional was added to the codebase [1,2], rendering the top level comment incorrect. This change introduces appropriate overloads for the construcor, emplace() and make_optional(). [1] https://crrev.com/53f6b258355ce36752ea7a8dcf8953560b5be818 [2] https://crrev.com/0fcb776029fb1380c8e8c9d4cbdcaf7a217ddb5c Bug: 521269 Change-Id: Iba10136c8ff84d4aa1f77148f8dc238db5c1be4c Reviewed-on: https://chromium-review.googlesource.com/840008 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#526668}
-
arthursonzogni authored
content::NavigationData is a copyable interface for embedders to pass opaque data to content/. To make the NetworkService or the NavigationMojoResponse features work, we need to pass this object with mojo. This isn't possible since content/ doesn't know how to serialize it. This CL removes content::NavigationData. To mitigate its removal, a base::Value can be used instead. This CL implements the ChromeNavigationData <=> base::Value conversion. Bug: 705744 Change-Id: I49e2bf617322200b0dfe1462da94880fc6651b8f Reviewed-on: https://chromium-review.googlesource.com/817556 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526667}
-
Michael Lippautz authored
The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows 64bit and thus extended with 0 for uintptr_t. This results in bogus return of StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled due to stack pressure. Bug: chromium:798479 Change-Id: I13710b3dca4d3785e35aedd8ba5f7ece167b20e4 Reviewed-on: https://chromium-review.googlesource.com/847580 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#526666}
-
Colin Blundell authored
In order to move the behavior of PrimaryAccountAccessTokenFetcher closer to what it will be once it is interacting with the Identity Service, I will shortly be changing this class to fetch access tokens strictly asynchronously (by posting a task to the current message loop to call into ProfileOAuth2TokenService). In particular, this change is necessary to preserve the expected ordering with other soon-to-be-introduced IdentityManager APIs that will interact asynchronously with ProfileOAuth2TokenService (e.g., to invalidate access tokens). The RemoteSuggestionsFetcher unittests currently assume that AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes these assumptions so that the tests will continue to work as-is when the above change is made. Bug: 654990 Change-Id: Ic61fd2bf9ef4ffdbba82c7eeff5f54e3766f310b Reviewed-on: https://chromium-review.googlesource.com/844675 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526665}
-
Colin Blundell authored
In order to move the behavior of PrimaryAccountAccessTokenFetcher closer to what it will be once it is interacting with the Identity Service, I will shortly be changing this class to fetch access tokens strictly asynchronously (by posting a task to the current message loop to call into ProfileOAuth2TokenService). In particular, this change is necessary to preserve the expected ordering with other soon-to-be-introduced IdentityManager APIs that will interact asynchronously with ProfileOAuth2TokenService (e.g., to invalidate access tokens). The SubscriptionManager unittests currently assume that AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes these assumptions so that the tests will continue to work as-is when the above change is made. Bug: 654990 Change-Id: Ib0a863c0b00133379819319129e1a49a46647d88 Reviewed-on: https://chromium-review.googlesource.com/844575 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Colin Blundell authored
In order to move the behavior of PrimaryAccountAccessTokenFetcher closer to what it will be once it is interacting with the Identity Service, I will shortly be changing this class to fetch access tokens strictly asynchronously (by posting a task to the current message loop to call into ProfileOAuth2TokenService). In particular, this change is necessary to preserve the expected ordering with other soon-to-be-introduced IdentityManager APIs that will interact asynchronously with ProfileOAuth2TokenService (e.g., to invalidate access tokens). The PrimaryAccountAccessTokenFetcher unittests currently assume that AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes these assumptions so that the tests will continue to work as-is when the above change is made. Bug: 654990 Change-Id: I9f3c8bef926ece573480123136b82df42e71abbc Reviewed-on: https://chromium-review.googlesource.com/844595 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#526663}
-
Colin Blundell authored
In order to move the behavior of PrimaryAccountAccessTokenFetcher closer to what it will be once it is interacting with the Identity Service, I will shortly be changing this class to fetch access tokens strictly asynchronously (by posting a task to the current message loop to call into ProfileOAuth2TokenService). In particular, this change is necessary to preserve the expected ordering with other soon-to-be-introduced IdentityManager APIs that will interact asynchronously with ProfileOAuth2TokenService (e.g., to invalidate access tokens). The ContextualSuggestionsFetcher unittests currently assume that AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes these assumptions so that the tests will continue to work as-is when the above change is made. Bug: 654990 Change-Id: Ia1ee647c3c97af9482e21c2605e1dcd5a4af7894 Reviewed-on: https://chromium-review.googlesource.com/844596 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/fa2260d08dcf..9cc67dc56e08 $ git log fa2260d08..9cc67dc56 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8e7bd203f2a6220d8df060c2673cf85de402ca89 Reviewed-on: https://chromium-review.googlesource.com/848493Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526661}
-
Dominic Battre authored
TBR=wangxianzhu@chromium.org Bug: 798116 Change-Id: I39eb1eb0ad4cb300066c278e4150670bc69cdfdc Reviewed-on: https://chromium-review.googlesource.com/848773Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526660}
-
Mark Cogan authored
This CL removes kTabModelTabDidFinishLoadingNotification, the last TabModel notification. The sole consumer of it was ChromeOverlayWindow, which used it to (on iPad-idiom devices) record the size class at each page load. Because the method used to record this metric was state-independent, it can be changed to a class method. This CL removes the call site in ChromeOverlayWindow (and all associated notification code) and moves it to the appropriate TabModelObserver method in the BVC. Bug: 320877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d42755ffdbd7480d500b1f89c30be9e347dd2b2 Reviewed-on: https://chromium-review.googlesource.com/847005Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526659}
-
Sasha Bermeister authored
Removed WebStorageQuotaDispatcherCallback and replace usages with WebStorageQuotaCallbacks directly. Later, WebStorageQuotaCallbacks will be removed as well and replaced with a mojo callback type. Bug: 781643 Change-Id: Ie233b20ad3d676ba0df220caefe05ac3ecd59ebf Reviewed-on: https://chromium-review.googlesource.com/833438 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
-
Ke He authored
As a part of Onion Soup, the screen_orientation_dispatcher will be moved into blink where the base::IDMap is not allowed to use. So we remove the base::IDMap first in this CL, which makes the next moving step easier. BUG=678545 Change-Id: Id46a80d07c4da90ce8807b1e97a9bee947b1944f Reviewed-on: https://chromium-review.googlesource.com/846699 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526657}
-
Mark Cogan authored
This CL removes kTabModelAllTabsDidCloseNotification, one of the two remaining TabModel notifications. StackViewController was its only observer. This CL moves the notification into a TabModelObserver method. Since StackViewController isn't a TabModelObserver itself, a method is added to CardSetObserver (since the card sets are the objects that observe the tab models in the stack view). Prior to this CL, the flow of events when closing all tabs in the stack view was: [1] The card set whose cards are being deleted (in removeAllCardsFromSet:) calls [cardSet setIgnoresTabModelChanges:YES]. [2] The cards are animated out [3] A completion handler is called when the animation completes; it calls -closeAllTabs on the cardSet's TabModel. [4] The tab model deletes the tabs and sends the kTabModelAllTabsDidCloseNotification [5] StackViewController catches the notification and calls -allModelTabsHaveClosed:, which in turn sets [cardSet setIgnoresTabModelChanges:NO] It's important to note that [cardSet setIgnoresTabModelChanges:NO] removes |cardSet| as a TabModelObserver. Functionally in this flow, tab model observation is disabled, then the notification is used to bypass the disabled observation and to signal that observation should be reenabled. After this CL some of the steps in the above flow are changed: [3] A completion handler is called when the animation completes; it calls [cardSet setIgnoresTabModelChanges:NO] and then -closeAllTabs on the cardSet's TabModel. [4] The tab model deletes the tabs and tells its observers. [5] CardSet (a TabModelObserver) gets the -tabModelClosedAllTabs call and sends its observer a cardSetDidCloseAllTabs: method. [6] StackViewController gets the cardSetDidCloseAllTabs: call and handles the cleanup. Bug: 320877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I98ac82d272d696f2182aa54c5b603cf6c737e073 Reviewed-on: https://chromium-review.googlesource.com/847004 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: -
Hugo Holgersson authored
When a page is opened, unless the page auto-focuses an element, the document <body> is the activeElement (aka focused element). In this case, spatnav uses heuristics in its search for the next focusable element to navigate to: the search starts at the visual viewport. This fixes the regression (caused by an adaption to root layer scrolling) described in the bug as well as adding 3 automated tests that check that spatnav correctly uses the visual viewport. Bug: 796493 Change-Id: Ie6cd71deaf1d7d7b100792feeaef57ab3fbff903 Reviewed-on: https://chromium-review.googlesource.com/847513Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#526655}
-
Wenzhao Zang authored
Previously, UpdateWallpaper() is needed in the WallpaperDelegate interface because it relies on Chrome to set the correct image. After everything is migrated, it no longer needs to call into Chrome. (Eventually WallpaperDelegate will be deleted as well.) All the tests in |wallpaper_manager_browsertest.cc| have been migrated (some of them are deleted because they have been disabled for a long time). But there is some untested code path in wallpaper_manager and we'll add more tests in follow-up CLs. TBR=oshima@chromium.org Bug: 779221, 794725 Change-Id: I81b0a0b6b2a96423a1191054e154761b10304382 Reviewed-on: https://chromium-review.googlesource.com/826325Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526654}
-
Siddhartha authored
gin/per_isolate_data expects task runner to be provided when initializing isolate. Implementing GetWebTaskRunner seems unnecessary. So, make WebThread::GetSingleThreadTaskRunner() virtual and implement it in utility thread. BUG=762723 Change-Id: Ib8aefb5ceca077166d361cc5be9396de170d9453 Reviewed-on: https://chromium-review.googlesource.com/819110 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526653}
-
Morten Stenshorne authored
Bug: 798338 Test: http://w3c-test.org/css/css-multicol/multicol-gap-animation-003.html Change-Id: I352b6a7de8893b27711c178abf7e1ac291429dc3 Reviewed-on: https://chromium-review.googlesource.com/847476 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#526652}
-
Dominic Battré authored
This reverts commit 5c4d3d4a. Reason for revert: Suspected culprit for four failing tests, see bug for details. Original change's description: > Reduce fragmentation of gpu memory by rounding RenderPass textures. > > The IOSurface textures for RenderPasses do this, citing bug > 146070. We can do the same for the RenderPass textures. This affects > any pixel tests that have anti-aliasing, as the float value of > texcoords is changed. So we have to add anti-aliased versions of a few > pixel tests, and rebase a number. > > R=ccameron@chromium.org > > Bug: 146070 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I41628534048b526afb2ac02378d71c329cc02344 > Reviewed-on: https://chromium-review.googlesource.com/841284 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526617} TBR=danakj@chromium.org,ccameron@chromium.org,piman@chromium.org Change-Id: Ief832ac9c4e0803bb1fe0d87f5ea92351f89cdce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 146070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/848852Reviewed-by:
-
Gauthier Ambard authored
This CL adds a DCHECK to the omnibox presenter view controller to check that the incognito style is set before the view is loaded. Bug: 797239 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1bf56e1f4f16c8b4cc0dbbc35267dbb37f80ebb2 Reviewed-on: https://chromium-review.googlesource.com/846989Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526650}
-
Dominic Battré authored
This reverts commit 14b27fbb. Reason for revert: Breaks several unittests, see bug for details. Original change's description: > Surface sync: Late arriving CF should not activate if dependent CF dropped > > A late arriving CompositorFrame should not activate if the dependent CF has > been dropped. This can happen if a CompositorFrame is marked for destruction > and then pulled out of the destruction queue ("surface resurrection"). > > This CL ensures that when a surface is reset, a SurfaceDiscarded notification > is sent to the SurfaceDependencyTracker followed by SurfaceCreated to mimic > creating a new surface. > > Bug: 796602 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I226b23bedbb1855c0da8fada8341c09a2f4fd318 > Reviewed-on: https://chromium-review.googlesource.com/847427 > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526561} TBR=fsamuel@chromium.org,samans@chromium.org Change-Id: Ie14cb8b08b6189941f650a6a4dc5540396498913 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796602 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/848792Reviewed-by:
-
Dominic Battré authored
This reverts commit 6a471e06. Reason for revert: Breaks Google Chrome Win builder, see bug for details. Original change's description: > Improve h264 encode efficiency for MediaRecorder > > This CL enables multithread and NEON in openh264 for ChromeOS devices > by changing openh264 configurations and adding required definitions. > > The effort is needed because currently MediaRecorder with openh264 encode > can only produce 4 FPS on minnie. Enabling multithread and NEON will > improve FPS to 21. > > BUG=797648 > TEST=Verified on minnie that recording FPS becomes 21, which is > comparable to FPS of the camera inside android container (22). > > Change-Id: Ifb54c2fdc07595d1887a36ee791357ef8d503948 > Reviewed-on: https://chromium-review.googlesource.com/831775 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Sheng-hao Tsao <shenghao@google.com> > Cr-Commit-Position: refs/heads/master@{#526647} TBR=mcasas@chromium.org,hbos@chromium.org,shenghao@google.com Change-Id: If8c7c9591406f409986e65166904faa769d7537e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797648 Reviewed-on: https://chromium-review.googlesource.com/848772Reviewed-by:
-
Sheng-Hao Tsao authored
This CL enables multithread and NEON in openh264 for ChromeOS devices by changing openh264 configurations and adding required definitions. The effort is needed because currently MediaRecorder with openh264 encode can only produce 4 FPS on minnie. Enabling multithread and NEON will improve FPS to 21. BUG=797648 TEST=Verified on minnie that recording FPS becomes 21, which is comparable to FPS of the camera inside android container (22). Change-Id: Ifb54c2fdc07595d1887a36ee791357ef8d503948 Reviewed-on: https://chromium-review.googlesource.com/831775Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#526647}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c8c9a24a117a..910a3dafda47 $ git log c8c9a24a1..910a3dafd --date=short --no-merges --format='%ad %ae %s' 2017-11-15 jie.a.chen ES31 program query: support TRANSFORM_FEEDBACK_VARYING Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I63bbd2a003e240b2c54dc1b398bc4a4a3b5331cf Reviewed-on: https://chromium-review.googlesource.com/848328Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526646}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9293af8..73cec2c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6ec3c9349e5321c78c23f6912eaad3ecd014085a Reviewed-on: https://chromium-review.googlesource.com/848353Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526645}
-
Shubhie Panicker authored
This extends stopping to other task queues, beyond timers and loading. This will be used to test various breaking scenarios and edge cases. Clean up flag structuring as part of this. Bug: Change-Id: I98c2a863ffb1aa5af711a026b764ba7dff928441 Reviewed-on: https://chromium-review.googlesource.com/803910 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526644}
-
Darren Shen authored
Adds tests for normalizing <url> and <gradient>s. One test is failing because we can't normalize gradients yet. Spec: https://drafts.css-houdini.org/css-typed-om-1/#resourcevalue-normalization Bug: 788570 Change-Id: I40d567a1e94c3ab4f9a3d7c8ca626da7661ac78e Reviewed-on: https://chromium-review.googlesource.com/845244Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526643}
-
Peter Boström authored
On titlecase systems the "www.example.com Says" heading is awkward, so to end with the URL these are being replaced by "From www.example.com" and corresponding "From an Example Page at www.example.com". Bug: chromium:683346 Change-Id: Ie520328276259f787541a02e39ed725687c1dff6 Reviewed-on: https://chromium-review.googlesource.com/846249Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#526642}
-
chrome://flagsThanh Le authored
Added the link to the flag on chrome://interventions-internals. The value is overridden by the the "Ignore Blacklist" button on chrome://interventions-internals. When all observer removed, the ignore status is reset to the flag value. Doc: https://docs.google.com/document/d/1cyJ-TxBBDdX6GyQzTMNUUzs3Rdis28HhIGsA--YsNxQ Screenshot: https://drive.google.com/a/chromium.org/file/d/1UjyYyJV3JTBg_qJTKT98u-8eruuBmdZR Bug: 793883 Change-Id: I224b6f9b7a3f52d36481e15afeee994f0b68df02 Reviewed-on: https://chromium-review.googlesource.com/841428Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Matt Giuca authored
JS library load_time_data now properly depends upon parse_html_subset. Bug: 798657 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70724a633dcf4e3088162693c9bae16fbf8d3468 Reviewed-on: https://chromium-review.googlesource.com/848592 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#526640}
-
Eric Karl authored
When we upload an image and color convert it with Skia, Skia may decide to re-use the original image's texture memory, keeping it in its cache. This change causes the GPU Image Decode Cache to take ownership of and delete this original image, preventing additional caching. Bug: 787182 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If1522276ba165b3c268a0631d9b7bd2c897489e7 Reviewed-on: https://chromium-review.googlesource.com/830978 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526639}
-
Tom Anderson authored
When using scale factors > 1, it is necessary to set the scale factor on all GtkStyleContext's so that GTK will fetch higher resolution assets. This was only seen on the Breeze theme, because it's the only one that uses bitmap backgrounds. BUG=794358 R=erg@chromium.org Change-Id: Ib2c42e4869156caba94f377b583cbac96f44ad98 Reviewed-on: https://chromium-review.googlesource.com/847683Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526638}
-
Xu Xing authored
Goal is to create resource in LayerTreeResourceProvider and use mapped id in DisplayResourceProvider. Reference document: https://docs.google.com/document/d/1MDrKY4ebi4kQMKOsSbVtDPQnMckja8PjVWut0tC3ynk BUG=793212 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0b23f3e473eff1c6da45b6ed0ed9ab04f9e16eea Reviewed-on: https://chromium-review.googlesource.com/816555Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#526637}
-
Derek Cheng authored
Create the following subdirectories: -- "presentation": to hold classes related to presentation -- "test" to hold mock/test objects -- "providers" to hold in-browser MRP implementations with a subdirectory for each MRP. (providers/wired_display, providers/cast) Attempted to simplify build rules a bit by merging the !is_android rule with enable_extensions rule. Converted some usage of base::Bind / base::Callback into Once/Repeating equivalents. Change-Id: Id71626d2168a3322073d56e6410136d1e7955290 Reviewed-on: https://chromium-review.googlesource.com/840607 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526636}
-
Sasha Bermeister authored
Remove WebStorageQuotaError and replace users with QuotaStatusCode in WebKit/common. This is pre-work to change all users of QuotaStatusCode to use the mojo enum instead. Bug: 781643 Change-Id: Id2d29fe42cf4217c17a5af1d9d832505b7e9edc7 Reviewed-on: https://chromium-review.googlesource.com/828224 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#526635}
-
Darren Shen authored
Currently we need a secure context mode to call toCSSValue. toCSSValue is used for converting CSSStyleValues to CSSValues. However, there's no reason why we need a secure context mode, since we don't do any parsing. This patch removes secure context mode from toCSSValue. We had to make two changes: - CSSUnsupportedValue takes a CSSValue instead of string. Previously, we would parse a string into a CSSValue, then convert it back into a string to give to CSSUnsupportedValue, which would then parse it again when needed. We can just store the CSSValue instead and parse once. - CSSUnparsedValue::toCSSValue creates a CSSVariableReferenceValue, which requires a CSSParserContext. This makes sense if we need to parse the tokens (e.g. for variable resolution). However, CSSUnparsedValue doesn't parse the tokens (hence its name), so it doesn't make sense to create a CSSParserContext. We added a new constructor to CSSVariableReferenceValue that doesn't take a CSSParserContext. Bug: 545318 Change-Id: I03bf66ab3061e00169ddff99b2a128ae3191f793 Reviewed-on: https://chromium-review.googlesource.com/845253 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Will Chen authored
My previous CL changed devtools PRESUBMIT to use eslint from devtools-node-modules: https://chromium-review.googlesource.com/c/chromium/src/+/837651 I inadvertently broke the PRESUBMIT workflow for non-Linux developers because devtools-node-modules was only sync'ed for Linux. Bug: 773287 Change-Id: Ib4bd8ca5a3b61b3289057870996f41a52e8f1784 Reviewed-on: https://chromium-review.googlesource.com/848322Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526633}
-
Wei Li authored
Since the SKP file format support can be changed, so does support of MSKP files, we avoid storing MSKP files directly, rather just generate on the fly as we need them. This change is needed as it blocks skia roll on new SKP support https://skia-review.googlesource.com/c/skia/+/90020. BUG= TBR=thestig@chromium.org Change-Id: I45e43dfd39ee157900687b014daa5f0fed56e3b0 Reviewed-on: https://chromium-review.googlesource.com/846472 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=794358 Change-Id: I48f8e5a6f129734a76fad5622bd1680c4946dffe Reviewed-on: https://chromium-review.googlesource.com/847680Reviewed-by:
-
