GitLab

1. the ruler lines in the "not claire" view on mac is not full width.
2. the title cards on windows has extra padding at the top.

BUG=406618

Review URL: https://codereview.chromium.org/516163003

Cr-Commit-Position: refs/heads/master@{#292967}

BUG=407375
TEST=manual

Review URL: https://codereview.chromium.org/527353002

Cr-Commit-Position: refs/heads/master@{#292966}

This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.

The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.

This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.

To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.

The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.

BUG=377891

Review URL: https://codereview.chromium.org/511283003

Cr-Commit-Position: refs/heads/master@{#292965}

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#292964}

Now that the DMServer has been fixed to accept 'agent' strings longer than
64 characters (http://crbug.com/406948), we can re-lengthen the string
produced by lastchange.py to include both the full git hash and the
Cr-Commit-Position.

R=joaodasilva@chromium.org, scottmg@chromium.org
BUG=406783

Review URL: https://codereview.chromium.org/527103004

Cr-Commit-Position: refs/heads/master@{#292963}

The DataTypeManager now maintains its own status table, which it posts a copy
of on each configuration completion. This makes testing configuration results
easier as we can now just check the type status table, and makes the DTM
more self contained.

To make this work a HistoryDeleteDirectives datatype controller was added to
encapsulate the encryption dependency the type has. Additionally, the PSS
is now able to tell the DTM to reset type errors (e.g. when the user is attempting
to re-configure with or without certain types).

BUG=368834

Review URL: https://codereview.chromium.org/523043005

Cr-Commit-Position: refs/heads/master@{#292962}

Update python API to use mixed case identifier for method to conform to
the chromium python style guide.

R=pkl@chromium.org

Review URL: https://codereview.chromium.org/522483006

Cr-Commit-Position: refs/heads/master@{#292961}

POD members of RequestContentScript::ScriptData weren't being initialized,
which a) is really bad because who knows what they might have been, and b)
is bad because it makes Dr. Memory unhappy.  Fix it (and pull ScriptData into
the .cc while we're at it).

BUG=409865

Review URL: https://codereview.chromium.org/531823002

Cr-Commit-Position: refs/heads/master@{#292960}

-Stop all media playback on an undoable tab close

BUG=388600

Review URL: https://codereview.chromium.org/493253002

Cr-Commit-Position: refs/heads/master@{#292959}

BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/416393003

Cr-Commit-Position: refs/heads/master@{#292958}

Page actions in the location bar have been somewhat loosely tested as a side-
effect of the page actions api testing, but (near as I can tell), we never
explicity test the ui for page actions.

This is a problem because the extensions tests shouldn't care about the UI, and
soon won't, since where the page actions are in the UI may change (i.e.,
location bar vs toolbar).

Fix this by adding a few basic UI tests for page actions in the location bar.

BUG=408261

Review URL: https://codereview.chromium.org/512693003

Cr-Commit-Position: refs/heads/master@{#292957}

Apparently this code was being hit on Android. This CL implements the scroll
offset the same way it's implemented on other platforms.

BUG=409792
NOTRY=true
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/533483004

Cr-Commit-Position: refs/heads/master@{#292956}

https://skia.googlesource.com/skia/+log/ed82c4e822dff3405b0a6ba9c9d054825cb03b13..871dca8ea99f49b8bbf118d0ccbd9da0c59467c3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/530993004

Cr-Commit-Position: refs/heads/master@{#292955}

Maps folks have confirmed that it is public data, the same you'd get by
visiting the site.

BUG=

Review URL: https://codereview.chromium.org/526833003

Cr-Commit-Position: refs/heads/master@{#292954}

It shouldn't matter much but the onMeasure method should be overridden
without calling super.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/531583002

Cr-Commit-Position: refs/heads/master@{#292953}

The initializer for the Copresence permission is malformed. It specifies the
message id instead of the flag.

R=kalman@chromium.org
BUG=408843

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8

Review URL: https://codereview.chromium.org/523433002

Cr-Commit-Position: refs/heads/master@{#292952}

The TestWebKitPlatformSupport will initialize it for us anyway, so use
it.

BUG=none
R=andrewhayden@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/526973003

Cr-Commit-Position: refs/heads/master@{#292951}

Revert of Revert of  Add support for codepen to form_based_credentials_background (patchset #9 of https://codereview.chromium.org/485743002/)

Reason for revert:
I believe the flakiness may have been fixed by https://codereview.chromium.org/520683002

BUG=

Review URL: https://codereview.chromium.org/531733004

Cr-Commit-Position: refs/heads/master@{#292950}

Fix the issue that GetFrameWindow() may change between AddObserver and RemoveObserver in KeyboardController.

BUG=408995
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/527153002

Cr-Commit-Position: refs/heads/master@{#292949}

https://chromium.googlesource.com/chromium/blink/+log/3337740376fe24b813a4ce1dd9f3817edcd9bfa3..07cfde2700209d53893a4f7be2b52a3a25355740
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/531073002

Cr-Commit-Position: refs/heads/master@{#292948}

TBR=markdittmer@chromium.org, kenrb@chromium.org, rdevlin.cronin@chromium.org
BUG=409865, 377978
NOTRY=true

Review URL: https://codereview.chromium.org/526373003

Cr-Commit-Position: refs/heads/master@{#292947}

1. you can now click in the space between the text and checkbox
2. clicking on the text now works consistently (due to removing selectability)

BUG=408344

Review URL: https://codereview.chromium.org/517433002

Cr-Commit-Position: refs/heads/master@{#292946}

Other changes:
* Introduced a ReadHeaders helper function which reads headers from a cache entry into a protobuf.  This is used by Match() and Keys().

BUG=392621

Review URL: https://codereview.chromium.org/477973002

Cr-Commit-Position: refs/heads/master@{#292945}

This patch introduces the mock cast API which provide a dummy cast list and the cast icon is shown on the window. So we can check if the icon is shown correctly.

BUG=405415
TEST=manually tested

Review URL: https://codereview.chromium.org/505043002

Cr-Commit-Position: refs/heads/master@{#292944}

This change makes the test more resilient to unexpected state on the
machine.

- RegistryVerifier can now verify that registry values are not present
  (and, as a result, optional registry keys). A key's "exists" property
  can be one of "required", "forbidden", or "optional". The first two
  behave identically to the true and false boolean values of the
  previous implementation. For an "optional" key, values within it may
  have an empty dict (i.e., with no "type" or "data" members) to
  indicate that the value must not be present in the key if the key is
  present.

- Each test now begins with the "no_pv" state rather than the "clean"
  state. This is more permissive, and simply ensures that Chrome is not
  registered with Google Update.

- After attempting to force-uninstall Chrome (either before executing a
  test or after a test failure), the harness will unconditionally delete
  the Google Update registration of that Chrome if it is present. This
  will clean the machine sufficiently for a subsequent test run.

BUG=375739,401148,402081
R=robertshield@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/520633005

Cr-Commit-Position: refs/heads/master@{#292943}

Removed unnecessary includes, reorder the methods, moved private classes to .cc.

Review URL: https://codereview.chromium.org/534543002

Cr-Commit-Position: refs/heads/master@{#292942}

https://skia.googlesource.com/skia/+log/1cbc68f9659f15206d920dacd434ddf4b658ad1f..ed82c4e822dff3405b0a6ba9c9d054825cb03b13

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/531793002

Cr-Commit-Position: refs/heads/master@{#292941}

BUG=406586

Review URL: https://codereview.chromium.org/518973002

Cr-Commit-Position: refs/heads/master@{#292940}

BUG=

Review URL: https://codereview.chromium.org/515953003

Cr-Commit-Position: refs/heads/master@{#292939}

Maps folks have confirmed that it is public data, the same you'd get by
visiting the site.

BUG=

Review URL: https://codereview.chromium.org/526833002

Cr-Commit-Position: refs/heads/master@{#292938}

The images in google.html seem to be triggering an occasional image
decoding bug. Since the SSLUITests don't rely on the images being
present, remove them.

BUG=368280
R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/522903004

Cr-Commit-Position: refs/heads/master@{#292937}

- Treats ')' as a param delimeter for the macros.
  This makes SCOPED_UMA_HISTOGRAM_TIMER("Foo") not trigger
  the non-literal name warning.
- Removes check for FieldTrial::MakeName() which no longer exists.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/504943002

Cr-Commit-Position: refs/heads/master@{#292936}

BUG=408030
R=estade@chromium.org
TEST=In ChromeOS: Open a guest. Go to settings. Verify search box there.
On desktop: Open a guest. Go to settings. Verify search box not there.

Review URL: https://codereview.chromium.org/517633002

Cr-Commit-Position: refs/heads/master@{#292935}

https://chromium.googlesource.com/chromium/blink/+log/d61a485818c6e67e43934ccd3c6cd453994bebf9..3337740376fe24b813a4ce1dd9f3817edcd9bfa3
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/518803008

Cr-Commit-Position: refs/heads/master@{#292934}

EventGenerator creates touch events in two different manners. Those that use TestTouchEvent set touch radii without exposing this to unit test classes. Chrome's gesture recognizer uses these radii when determining touch rects. This can lead to different views being targetting within unittests.

Remove the setting of these radii. Tests that wish to use larger can still create TouchEvents and call EventGenerator::Dispatch.

Review URL: https://codereview.chromium.org/522453002

Cr-Commit-Position: refs/heads/master@{#292933}

password_manager::CredentialManagerClient was a RenderProcessObserver,
and sent messages via RenderThread. This couldn't possibly have ever
worked; the messages it sent were simply dropped on the floor.

After this patch, it's a RenderViewObserver and its messages
successfully land in the ChromePasswordManagerClient, just as they
ought to.

BUG=400674

Review URL: https://codereview.chromium.org/533493004

Cr-Commit-Position: refs/heads/master@{#292932}

The popup blocker will block them anyways, and if it's disabled, we
shouldn't change the disposition chosen by the web page

BUG=158274

Review URL: https://codereview.chromium.org/527913002

Cr-Commit-Position: refs/heads/master@{#292931}

Review URL: https://codereview.chromium.org/474933005

Cr-Commit-Position: refs/heads/master@{#292930}

. ICU may be initialized twice: once by the test suite, secondly by
  the app.
. window_mamanger_app_.host_ may be deleted by the time we get to the
  destructor to try and remove something. Add check for this.

BUG=none
TEST=none
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/516523004

Cr-Commit-Position: refs/heads/master@{#292929}

on Dr.Memory bot

TBR=juberti@chromium.org
BUG=389132
NOTRY=true

Review URL: https://codereview.chromium.org/534603003

Cr-Commit-Position: refs/heads/master@{#292928}