- 24 Oct, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
NOTRY=true TBR=crouleau@chromium.org Bug: 1017661 Change-Id: I57a3b39daa224618ad87d242fe5521ad655be921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878192 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708972}
-
Rune Lillesveen authored
It is possible to create a shadow root on a Shadow DOM V0 insertion point. However, if it's an active insertion point, we render the distributed children and not the shadow subtree. Make sure we traverse the distributed children in that case, and not the shadow tree, when FlatTreeStyleRecalc is enabled. TEST=fast/dom/shadow/shadowroot-of-insertionpoint.html Bug: 972752 Change-Id: I9158a5d669764a049acb9780dccc4ae1b0ff87b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875735 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#708971}
-
Abhijeet Kandalkar authored
This primary goal of this CL is to use DynamicTo<HTMLSlotElement> as new downcast helper Bug: 891908 Change-Id: Iad3033d44acf245e16c50f0a18cd196cf5791566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874415 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708970}
-
Jan Scheffler authored
This patch makes the pageSize and skipCount parameters for the requestEntries protocol method optional. The call will return all available entries if pageSize is not set and default to 0 for skipCount. Bug: chromium:988038 Change-Id: I6257f1beb07be1a87652334df9cd169d5f65724b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875751Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#708969}
-
Sigurd Schneider authored
This reverts commit 5551563f. Reason for revert: Not needed anymore. Original change's description: > [devtools] Temporarily disable tests related to crbug.com/1003497. > > These will be rebaselined manually once the fix rolls into > devtools-frontend repository. > > Bug: chromium:1003497 > Change-Id: I98b2178dd67be86188e4c212e509330d29f04c94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872098 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708133} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1003497 Change-Id: I49a2907301b59b747c1cc2b497c040b9306c4e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878247Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0b2029c2d7c..3d8b9b834731 git log d0b2029c2d7c..3d8b9b834731 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@3d8b9b834731 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I3c6ed166d646baee8218dc65c856eccac3796b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708967}
-
Richard Knoll authored
This will show the origin of the site requesting the external protocol dialog below the list of apps and devices. See screenshot: https://imgur.com/phoAsfI Test: New automated tests added for views w/ and w/o origin. unit_tests --gtest_filter=IntentPickerBubbleViewTest.InitiatingOriginView Bug: 1010920,754304 TBR=satorux@chromium.org Change-Id: I6637b43b7c8e847663d15d233f958430a51f4b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850151 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c88a741..ca0cdfbf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3e7003b9610a36bf41f3762a86c21e34a989ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877373Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708965}
-
Tony Mak authored
1. Removed reflection and instead use SelectionEvent introduced in P That means we won't have logging from O device anymore. However, P-R logs should be enough for us to conduct A/B experiments. 2. By calling onSelectionEvent, events would now be routed to a TextClassifierService if exists. Previously, TCS won't get the event. 3. This will help migrate to the new android metrics logger. Bug: b/120032995 Change-Id: I4d39600cb0d029f2b311d66fb97ec6bb7a1c7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868882Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tony Mak <tonymak@google.com> Auto-Submit: Tony Mak <tonymak@google.com> Cr-Commit-Position: refs/heads/master@{#708964}
-
Armando Miraglia authored
The Zombie detector identified an issue in how the AV objects for video capture were been used. This change speculatively fixes the crash associated to it by adjusting the objects ownership. The fix is speculative in the sense that a local repro steps are not available for testing the effectiveness of the fix. BUG=1014942 Change-Id: Iaa0a8318b5a71a4b1964a6fa2a2e7459dd09074f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876087Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#708963}
-
Fergal Daly authored
https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-debug They are all in the spreadsheet. Change-Id: I87a6a63b5aa4aa385c0d461167aa2ff2813f2e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877503 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#708962}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/615918c91d1d..4517c7b883c5 git log 615918c91d1d..4517c7b883c5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 stevenperron@google.com Update DEPS (#2986) 2019-10-22 afdx@google.com spirv-fuzz: fuzzer pass to adjust memory access operands (#2968) 2019-10-22 greg@lunarg.com Instrument: Add missing def-use analysis. (#2985) 2019-10-22 afdx@google.com spirv-fuzz: add missing functionality for matrix composites (#2974) Also rolling transitive DEPS: src/third_party/spirv-headers/src 842ec9067462..af64a9e826bf Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4517c7b883c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I1c253ed78593e4e7ba3e8977f8e01a5d5d15fe25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877856Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b2885bc4a40f..806747e03674 git log b2885bc4a40f..806747e03674 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 5e634c8999e6..7662586844f4 (3 commits) Created with: gclient setdep -r src/third_party/angle@806747e03674 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I8b5848c9637df3435993b409498c3cef2122ad43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877858Reviewed-by:
-
Mihai Sardarescu authored
The Unified Consent feature is now enabled on all platforms. This CL removes the Unified Consent feature flag and the pre-UnifiedConsent code. Bug: 1015805 Change-Id: I9f9a43865d7144d8dcce082f0a5d402599973c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866513 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708959}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the FrameSinkVideoCaptureOverlay interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ib835dfbe4a84a8ac5abfef5bbaf3945ad5f3fa61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863291Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#708958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76c2e50d3bb9..ad557c41da7c git log 76c2e50d3bb9..ad557c41da7c --date=short --no-merges --format='%ad %ae %s' 2019-10-24 tikuta@chromium.org presubmit: deprecate vpython_spec_path Created with: gclient setdep -r src/third_party/depot_tools@ad557c41da7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I274a2127848ca8b4077851e1e4f76f4b68e64197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877857Reviewed-by:
-
Corentin Wallez authored
webgpu.h is a new header that's meant to be an interface to both Dawn, and wgpu-native which is Mozilla's implementation of WebGPU. It is being developed jointly with Mozilla at https://github.com/webgpu-native/webgpu-headers We want to transition to only using webgpu.h instead of dawn.h and this CL removes both deprecated headers. (dawn.h and dawncpp.h). This CL does the many renames of types and enum values that are required. BUG=dawn:27 Change-Id: I6deeb1e6b93bc1c4061bbdce85f66af5ef9d2fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873756Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#708956}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0cc2fbd4ba42..177c5c4fe392 git log 0cc2fbd4ba42..177c5c4fe392 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org perf_uploader: get tests passing under Python 3 2019-10-24 vapier@chromium.org tests: add more sanity checks on overall runtime Created with: gclient setdep -r src/third_party/chromite@177c5c4fe392 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7cc73cd6fb3d4be9e68ba8207156f07e5cf50ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877854Reviewed-by:
-
Hiroki Nakagawa authored
This adds Worker.onerror handler in net/data/websocket/connect_check.html. This is useful for debugging https://crbug.com/1000117. Without this change, SSLUITest.TestWSSInvalidCert waits for timeout long time. Bug: 1000117 Change-Id: Ibe0e73fcf30423bb0a1c0cf5b38384355605905c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877496 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#708954}
-
Nazerke authored
This CL adds all handoff manager tests to EG2 target and updates headers and adds eg2_test source_set in build file. Moreover, new app interface for handoff tests is being introduced. Bug: 987646 Change-Id: I3410f778e9f9daece1767a4f0a73c168f6e9aef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872209Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#708953}
-
Javier Ernesto Flores Robles authored
Create an app interface for the app code in fallback_coordinator_egtest related to the keyboard. Move the code from the test to this interface so it can be used later to migrate the test to EG2. Bug: 1017175 Change-Id: I08a85c003a1797d2ef5fa0cd8e4ec444dd05fb3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876392 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Nazerke authored
This CL adds a file to EG2 target and updates headers and adds eg2_test source_set in build file. Bug: 987646 Change-Id: Ia7e5b80e523d48d37b2552623529dc1e93fb0160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871693Reviewed-by:
-
Yuki Shiino authored
It turned out that we'd better sort SymbolDefinitionNodes in order of their first appearance rather than the alphabetical order of their names. In code reading, alphabetic order doesn't make any sense nor doesn't help read code. The order of first use makes more sense. For example, given |f(B, A, C)|, A B C f(B, A, C) will be changed to B A C f(B, A, C) Bug: 839389 Change-Id: Id6bc57ed4ea0afa6e630ab33a55c5472377927e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876293 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#708950}
-
Fergal Daly authored
- SystemNetworkContextManagerMaxConnectionsPerProxyBrowsertest.MaxConnectionsPerProxy was renamed in https://crrev.com/c/1767094 - BookmarksCommandManagerTest.All can be seen passing 100 times here https://chromium-swarm.appspot.com/task?id=48104c14d9892f10 - all other removed tests can be seen passing (also remaining tests can be seen failing) here Change-Id: I6aba8db97ad3e24ae84a5d0afe539878784636ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875353Reviewed-by:
-
DongJun Kim authored
In the past, "content/*/file_system" was renamed to "fileapi" to contain both the code for the filesystem API and the blob system. But the blob system moved out to separate directories, we have the confusing situation that we have directories named after one API that contain the implementation of a different API. This patch rename "storage/common/fileapi" to "file_system" to actually match for reducing confusion. Bug: 921260 Change-Id: I5071d6e268aa6824c165678def35d4dfe88a6f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871711 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#708948}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ac668ca6cd5..d0b2029c2d7c git log 3ac668ca6cd5..d0b2029c2d7c --date=short --no-merges --format='%ad %ae %s' 2019-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d4affcdd2ac9..b2885bc4a40f (8 commits) 2019-10-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@d0b2029c2d7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: Ibf04537509124743d5e8cf3456bbd4b9167182e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877853Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ic6935632890a2696427dd43a0f96d42468939f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873806 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Thomas Tangl authored
+ Add separator margins. + Only show separator when there is a profile management part. (Not the case in incognito.) Bug: 1017241 Change-Id: I67f17905596915bb85b136cb262523560d15cb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876807Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#708945}
-
Yuki Shiino authored
Make SymbolDefinitionNode insertion happen only when the SymbolNode is already registered. Bug: 839389 Change-Id: I5ce1e21511866a511659d1d6e7b3658ccddc5650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873807Reviewed-by:
-
Hajime Hoshi authored
This sometimes times out on a Linux bot. TBR=kinuko@chromium.org No-Try: true Bug: 1017626 Change-Id: I53be2feafa8de6a2f6d1768f59e7c9eea4e7e457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875901Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708943}
-
Antonio Gomes authored
... by its PeerConnectionDependencyFactory counterpart. This is now possible after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. The CL also removes blink::Platform::CreateWebRtcPortAllocator() and its overrides altogether. They are not called anymore. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Iff2967c958165e21e092bbeb617475c31239f060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806847 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#708942}
-
Robbie McElrath authored
We eventually want all standalone webview code (i.e. code not run in an embedder's app) to live in //aw/apk. TBR=isherman@chromium.org Test: ninja -C out/aw monochrome_apk, start CrashesListActivity Bug: 934152 Change-Id: Ibfbdd63d40c1efc24e6bbe9fed08dab61269f482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815157 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708941}
-
Jakob Gruber authored
Plumb through new V8 use counters. V8 CL: https://crrev.com/c/1873698 Bug: v8:5577 Change-Id: I6e57be213c50d27c3c5fabe873532f3e43be95ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875250 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
As UnifiedConsent is now enabled on UI, it does not make much sense to have the EGTest for the sign-in flow spread across 2 files. This CL moves the tests from signin_interaction_controller_unity_egtest.mm to signin_interaction_controller_egtest.mm Bug: 1015805 Change-Id: Ia483f6abf58370d169b056ea83e7ce4cc373aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868955 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708939}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I92a8908433d11ce23009ccce29e4d584a4d3911d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878049Reviewed-by:
-
Jinsuk Kim authored
- Introduces |setNativePage| and remove |freezeNativePage| - Factors common logic hiding the current native page into |Tab.hideNativePage|. - Replaces |NativePage instanceof FrozenNativePage| with a new method |isFrozen| in NativePage interface. Bug: 925242, 995903 Change-Id: I531003e7c880cabdf2ff05489145135d1206eb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861442 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#708937}
-
Javier Ernesto Flores Robles authored
Move profile matchers so they can be used from the app interface. Bug: 1016809 Change-Id: I6179a151c5c82d5f94edb144e2d1241fc11745d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873888 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Add Autofill App Interface with the app code so EG2 can interact with the app. Move matchers to chrome matchers. Create new EG2 tests and needed targets. Bug: 1016368 Change-Id: If2256944612b3c7a6523dd3e1f9e36b79fc1d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872058 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
When TabSwitcherOnReturn is set to "Immediate", the tab switcher should show up immediately regardless of whether the last background timestamp is available or not. "Immediate" is a setting for dev testing only. Bug: 1016952 Change-Id: I3ac40d6695089ea9b14e3841b8834ae3a6b44b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877812Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708934}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c86820c2510..0cc2fbd4ba42 git log 1c86820c2510..0cc2fbd4ba42 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org commands/filelib: fix encoding with base64 calls 2019-10-24 vapier@chromium.org service: artifacts: fix bytes/string mixing Created with: gclient setdep -r src/third_party/chromite@0cc2fbd4ba42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9b548590ad669d7ac0ab5a131acdd671198501fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878048Reviewed-by:
-
