GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/32eff228855c..804ad6f18ad8

git log 32eff228855c..804ad6f18ad8 --date=short --first-parent --format='%ad %ae %s'
2020-01-06 bookatz@google.com CtsPerfettoTestCases secondary_user

Created with:
  gclient setdep -r src/third_party/perfetto@804ad6f18ad8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:141773058
Tbr: perfetto-bugs@google.com
Change-Id: Ib6a39bea17d1a8df1c2816518c79507e60b2a7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988517Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728645}

Previously, placeholders for the saved password
protection warning are reordered based off of
commonly spoofed domains. This means that the
placeholders may not be in the same order as the
|saved_password_matching_domains|. This is the
unit test for cr/1983352.

Bug: 1038132
Change-Id: I5a2d7ee57508c72097631414fc12b4aa0fcc612e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986187
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728644}

https://skia.googlesource.com/skia.git/+log/ce09fb43963c..6dbd7ff34a49

git log ce09fb43963c..6dbd7ff34a49 --date=short --first-parent --format='%ad %ae %s'
2020-01-06 mtklein@google.com first foray into SkVM image shaders
2020-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-06 bsalomon@google.com Remove unused varying type param from GrGLSLShaderBuilder texture methods.
2020-01-06 brianosman@google.com Remove SkRuntimeShaderFactory
2020-01-06 robertphillips@google.com Add GrCompressedDimensions helper function
2020-01-06 csmartdalton@google.com Move "set_path_pt" from SampleAAGeometry into ToolUtils
2020-01-06 kjlubick@google.com [canvaskit] Remove support for T1 fonts and reduce code size
2020-01-06 kjlubick@google.com Make tracing data a compile-time option

Created with:
  gclient setdep -r src/third_party/skia@6dbd7ff34a49

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: I0e407dc41a6f98f7b2f12f0670e17fe23e68967d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988748Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728643}

This patch creates the IndexedDBControl mojo interface that is the
eventual replacement for IndexedDBContext. It can be accessed on the
StoragePartition, which handles binding it on the correct thread.

This change also remove the IOTaskRunner() from the IndexedDBContext
interface.

Planning Doc:
https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.k6qp3j6uiwi0

Bug: 1015214
Change-Id: If56fe06a7349d09325d1e2360b0ceb53e9c6e5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959385Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728642}

This test was previously disabled under some circumstances, but is also
failing on the Win7 Tests (dbg)(1) bot (see
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29)

Failing builds:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81051
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81064
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81067
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81069

Bug: 1039406
Change-Id: I1eb6e1733bc88d21acf377db50c679f6e3306194
TBR: jrummell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988229Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728641}

The histogram will be used once the third party QUIC code is merged into chromium.

Change-Id: Iaf2fd34ca1b60935506d000e6699024bb640ca71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981638Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728640}

Change-Id: I1d6fb45ac8755c39cfebb7a00c3ad04f1d08c3ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986620
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728639}

Motivation: It is odd to define a Gr- prefixed function outside of
third_party/skia.  GrGLCreateNativeInterface exists in third_party/skia, and is
deprecated.

Change-Id: Icb20c390926c063c57d3cd84a9f1a4bfda2e171b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982620
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Auto-Submit: Hal Canary <halcanary@google.com>
Cr-Commit-Position: refs/heads/master@{#728638}

Bug: none
Change-Id: I6035f72ae4a4eccf815a9263f75fdfcd3ff342f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983513
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728637}

After https://crrev.com/c/1592230 the relative path to the framework
changed but this rpath was not updated.

Bug: None
Change-Id: I69b044c96a7eefb09534b62245545e20714b92ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986834Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728636}

Ensure that <histogram> should be added in <hisotgrams> and
<histogram_suffixes> should be added in <histogram_suffixes_list> so
that they will be sorted separately.

Bug: 1034123
Change-Id: Iaf009dacf20a549f6e5865a4a699bb3919e96082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978539
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728635}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25b001799ea6..77e01616ea7b

git log 25b001799ea6..77e01616ea7b --date=short --first-parent --format='%ad %ae %s'
2020-01-06 aerotwist@chromium.org Migrates refs to Common inside ui/ to ESM

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@77e01616ea7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I89cf290b390a818d7439caff98e3337f7eb59fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988254Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728634}

Bug: 1033922
Change-Id: I8c8efc7cae25c2308d8f5289f3f124b0fa4782d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983539Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728633}

Component: the toolbar of the Bottom-sheet based Payment Handler UI.

Description: the toolbar instantiates a URI with a shortened
(ripped off the scheme and keep only the origin) URL. However, the URI
instantiation should take a URL that has a scheme, otherwise, throws
URISyntaxException. This is an insidious bug because a domain url like
"www.google.com:1234" wouldn't cause exception because it would be
accepted as a scheme.

Before change: when the toolbar takes a URL that is "IP + port"
(no scheme), the Payment Handler UI would fail with a
URISyntaxException. An example of url is "192.168.1.1:1234".

After change: a URL "IP + port" (no scheme) wouldn't cause
URISyntaxException any more.

Change: after shortening a URI string, no longer instantiate a URI from
the shortened string.

Bug: 999196

Change-Id: If7cb8e0eff6bc24d973785f9d60b0e02666836e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988513Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728632}

This is the chromium side of the effort to consolidate
TestMediaResourceTracker definitions. Currently there are two
definitions: one in chromium, and one in the internal cast codebase.
After this CL and an internal CL, there will be only one version (the
chromium version).

Test: Ran cast_media_unittests locally.

Bug: b/143154455
Change-Id: I16d6a27679a395a0d4ae512cf29a7fe98e08af84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975071Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Antonio Rivera <antoniori@google.com>
Cr-Commit-Position: refs/heads/master@{#728631}

Thouch menu_button_wrapper is big enough to meet the requirement of
smallest touch size, it does not handle the click or touch events.
The image button, which is handling the click event, inside the
menu_button_wrapper is too small.

Bug: 1038691
Change-Id: If1f6bd4e0dabdc238f9f1a37604b843cb60c360e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986251Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#728630}

On Mac there is a race between the Browser resizing and a Renderer
reconnecting to a frame sink.

Due to this the Browser can end up sending a merge LocalSurfaceId to the
Renderer, which it already used for a previous size.

This is in part because on Mac we are currently accepting all resize
requests from child Renderers. Which is not what we do on other
platforms. This change updates BrowserCompositorViewMac to only merge
LocalSurfaceIds, and to not change the sizes, when requested. Unless
auto_resize is enabled on the RenderWidgetHostImpl. This is also inline
with RenderWidgetHostViewMac::UpdateNSViewAndDisplayProperties

TEST= ContextLost_WebGLContextLostFromGPUProcessExit
      ContextLost_WebGLUnblockedAfterUserInitiatedReload
      GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash

Bug: 1031095

Change-Id: Ie8ef6283ec36169f422af10831001b7c0ee757f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975014Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728629}

Scenic functions with C-style array arguments will be removed from SDK
in favor of std::arrays. This change replaces all the C-style arrays used
in Scenic SDK functions with std::array.

Change in Fuchsia-review: https://fuchsia-review.googlesource.com/c/fuchsia/+/351051

TEST=Build on Fuchsia target; run_base_unittests

Bug: fxb/SCN-1442
Change-Id: I2f828e7217258a71267295f4b26b735d29a9b103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986979
Commit-Queue: Yilong Li <liyl@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728628}

Using wpt-import in Chromium 7b0b7215.
With Chromium commits locally applied on WPT:
400050e6 "Fix toJSON in WindowPerformance and PerformanceResourceTiming"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ic4739759f628638dffd27478a507d56365ee6620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988297Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#728627}

This CL bumps the shard number for a few test targets because they're
consistently timing out.

Bug: 1036394
Change-Id: I6d5e1837dd45e942e3f3d14bee15b155917d7253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979105Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728626}

SetCopyAudioCallback accepts an CopyAudioCB which is a RepeatingCallback
so switching to using WTF::BindRepeating.

Bug: 1007835
Change-Id: If2291c8217a4b2528e686f6f1350e53fc9224461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988505Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#728625}

This mediator uses the information exposed in the request config to set
up a banner consumer.  All other functionality is implemented via the
OverlayRequestMediator superclass.

In addition, this CL removes InfobarBannerOverlayRequestConfig, which
was previously added as auxiliary data for the save passwords config.
However, this was implementing UI logic in the model layer, whereas
this should actually live in a mediator.  Now, the banner coordinator
class is shared, but the banner UI can be configured by specialized
mediator subclasses that perform the UI setup logic.

Bug: 1030357
Change-Id: I2ff9aae6f8618ca65774a045631e78402dbcecec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978558
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728624}

This change makes the check for a permission increase during an extension
update or reload to look against the union of granted permissions and
runtime granted permissions.

Bug: 984069
Change-Id: Ibae549d19d51371070bad4cc10a14d3869b6cced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977385
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728623}

This CL is follow-up cleanup work to crrev.com/c/1729631.

Bug: 1035618
Change-Id: I54cde36e2ace1cd364bcda0dfadd1d75370f9f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984707Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728622}

Bug: 992573
Change-Id: I5a27682828538c72fbe8fc71c78cbadc8fdef23e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872643
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728621}

This change also removes unused delegate method implementations.

Fixed: 1035814
Change-Id: I2eff464a042b5a6917cad9da4e61daf8969672d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986035Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728620}

Use static_assert() to remove the need for a NOTREACHED() and
base/logging.h. Then do IWYU for any files that fail to build as a
result of the header removal.

Change-Id: I2bebcdfce84f9c814a8c38099e0e566812d57d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977782
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728619}

The FileProxyTest.CreateTemporary has been flaky and the most likely
explanation is that something on Windows (anti-virus?) is temporarily
holding a lock on the file. If so then retrying a few times with a brief
delay in-between should avoid the flakiness.

Bug: 1035440
Change-Id: If6d5cf770ebd42e29581c73d2e3e57d4641a3e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986962Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728618}

This CL changes the PageInfoCoordinator, making it a short lived
coordinator, started and stopped at the same time as its UI.
Previously it was living forever and responding to the commands related
to the UI. Now the BrowserCoordinator is responding to them.

The presented state cleanup for the Page info is now done in the
BrowserCoordinator instead of the BVC.

The PageInfoReloading protocol can be removed as the handler is now
conforming to the BrowserCommands protocol, which contains the same
-reload method.

Bug: 1038919
Change-Id: Icbeba08e04481a65388ef2dc9cd82613ef79c826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988356
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728617}

Replace usages of java_files with sources and automatically format:
chrome/browser/ui/messages/android/BUILD.gn

R=pavely

Bug: 1035074
Change-Id: I0d8fbc05a1c19fbf6b2892d8119697691e790f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988725Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728616}

Replacing uses of PipelineStatusCB with PipelineStatusCallback in
various places including: Start(), Seek(), Suspend(), Resume().  With
these changes pipeline.h and friends are now using
PipelineStatusCallback instead of PipelineStatusCB.

Bug: 1007799
Change-Id: Icceaa62afb2ccf60b57bd483754efa56ced22b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978976Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728615}

The class was created when there was multiple implementation of the
TabSwitcher. Now it can be cleaned up.

Bug: 1038034
Change-Id: I86e6fa967c953a892f3fb69f19791427d73f8897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982558
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728614}

This CL also filters out all failing and flaky tests.

Bug: 765833, 1021665
Change-Id: Id9723495864ae2b9b2761649815242fa6da856c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979353Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728613}

This reverts commit 83388678.

Reason for revert: crbug.com/1038660

Original change's description:
> Fire live region events when a node is removed.
> 
> Adds an AXLiveRegionTracker class to keep track of live regions
> in an AXTree. Uses it to fix a bug where we weren't firing the
> LIVE_REGION_CHANGED event on the live root when a node was removed,
> only when a node was added or changed.
> 
> I'm going to follow this up with code that optionally computes
> the text of a live region change, that we can use on Android,
> Chrome OS, and some older versions of macOS. So AXLiveRegionTracker
> is simple now, but it will be a convenient place to put that
> logic.
> 
> Bug: 560599, 930763
> Change-Id: Iaff11e5adbdde533b8868226ed563567edc5589e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464325
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#727589}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aleventhal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 560599, 930763, 1038660
Change-Id: I9b1da430c631d367841a7df820649c4e89b645e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987191Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728612}

Code style/health updates only. No behavior should change from this CL.

Change-Id: I083bc61ff9ffed103f0b70d9ffc30d6481e874b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975035
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728611}

Currently, URLs that are covered by a hosted app's web extent get a
SiteInstance with a special "effective" site URL, formed by
translating the regular URL into a chrome-extension:// URL.  The
translation is done via Extension::GetResourceURL() against the target
URL's path.

This is problematic because GetResourceURL() internally uses
GURL::Resolve(), which may fail for certain paths (such as a double
slash, as in "http://docs.google.com//") and return an empty GURL, as
described in issue 1034197.  This in turn means that the effective URL
used for some navigations may end up *empty*, which is incorrect, as
the resulting navigation won't end up in a hosted app process. It is
also dangerous: cross-site navigations with such paths could try to
share the same SiteInstance since the destination site URL is the same
(i.e., empty), which is a potential site isolation bypass.
Fortunately, we have logic that catches this, but this results in a
browser crash.  See analysis in https://crbug.com/1016954.

This CL fixes this by ensuring that effective URLs returned for hosted
apps are never empty.  The process model never uses an effective URL's
path, just the origin, so there's no reason to keep the path around,
and this CL simply changes the effective URL of a hosted app to be of
form chrome-extension://hosted_app_id/, with no path.

We should additionally ensure that when we set a site URL on a
SiteInstance, the site URL is never actually empty.  Unfortunately,
this currently results in several test failures (see PS1) and thus
will be attempted in a separate CL.

Bug: 1016954
Change-Id: Id4c71a4993de76f5cf8b56bbc333da5e08237c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952033Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728610}

Previously, a hard-coded number of frames was omitted. Such a hard-coded
constant is dependent on both the build toolchain and the optimization
level, which makes it flaky. This change instead omits frames based on
the addresses themselves, which should be much more resilient.

Failures should now mostly show the relevant frames and no less. For
example, a test with an assertion failure in its main test function will
show:

  base::`anonymous namespace'::BindDeathTest_NullCallback_Test::TestBody [0x00F6BC7C+122] (C:\src\chromium\src\base\bind_unittest.cc:1572)

The exception to this is in debug builds, where there may be additional
frames, for example:

  base::`anonymous namespace'::BindDeathTest_NullCallback_Test::TestBody [0x00B11375+245] (C:\src\chromium\src\base\bind_unittest.cc:1572)
  testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0207725B+107] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2493)

BUG=1038787

Change-Id: I65aabeaf1c1011e3b7077852c1b1feb85a87c0cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986074
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728609}

Bug: none
Change-Id: I7e294a89ffde321dacff2c3dd9c6bed7fbb9c373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986137Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728608}

This histogram is still used to track total user interaction with ads.

Bug: 1032110,1032111,1032112,1032113
Change-Id: Id303e5bee2a7115e85aa07d2b1d2fdada7c5f57f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986438Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728607}

Change-Id: If92ddf850a828214644f48fd087a29529d71e964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988226
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728606}