- 02 Dec, 2017 20 commits
-
-
Jungshik Shin authored
This is a reland of cd106529 after the Chrome OS side changes (2 CLs) were landed. TBR=derrat@chromium.org Original change's description: > Update Arabic font preferences > > sans-serif/standard: Noto Naskh Arabic UI => Noto Sans Arabic UI > serif: Noto Kufi Arabic => Noto Naskh Arabic . > > This is accompanied by the following CrOS-side change: > > https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/786080 > > TEST=See bug commnet 1 > > Bug: 787944 > Change-Id: Ib9555abddd7576541f918a7331a0b20b9cc617af > Reviewed-on: https://chromium-review.googlesource.com/790937 > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520235} Bug: 787944 Change-Id: Ia9481af5065915b150fe50c7826fc62c6831f940 Reviewed-on: https://chromium-review.googlesource.com/804014 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521152}
-
Jiaquan He authored
Currently search related information is composited in AppListModel and it'll be accessed in a different way from other app list model data. To makes the app list migration easier, this commit separate app list search model from the other model data. In detail, this commit: - moves //ash/app_list/model/search_* into //ash/app_list/model/search/; - moves everything about search from AppListModel to the newly created SearchModel; - initializes a SearchModel in AppListSyncableService and passes it to AppListViewDelegate; - updates users of app list search model to use SearchModel instead of AppListModel; - removes OnAppListModelStateChanged from AppListModelObserver because it's never used; Bug: 733662 Change-Id: I5042ac02651cff0259edb2fcc60ada8b882a29a9 Reviewed-on: https://chromium-review.googlesource.com/803898 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521151}
-
Jonathan authored
The Linux Mojo FYI bot is intended for testing just network services, in preparation for moving the tests to the CQ. However in the interim this can sometimes be ran on the CQ. viz_content_browsertests that run on the FYI bots are intented to sometimes fail, and are not CQ ready. Due to this I'm removing them from this config until I can find a more appropriate FYI bot. TEST=viz_content_browsertests Bug: 760181 Change-Id: Ia5a5712162d24267b8ce5414d2c1e59b73106171 Reviewed-on: https://chromium-review.googlesource.com/803800Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#521150}
-
mrefaat authored
Notable change: - define IS_BAZEL_BUILD to build as a static library instead of building a framework bundle Bug: 785248 Change-Id: Ie1aa8ff9439dcae4be1ec8c2185057b4b171b453 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/802694 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#521149}
-
Jungshik Shin authored
In ICU 60, the skeleton of 'w' is not 'vv' any more. It's just 'w'. The top domain gperf file was regenerated with ICU 60. Bug: 766816 Test: components_unittests --gtest_filter=*IDN* Change-Id: Ifde69a696f8b3062803745f8a9ad242ca4915549 Reviewed-on: https://chromium-review.googlesource.com/802765 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521148}
-
Becky Zhou authored
Adds an animation to the checkmark icon for History/Bookmark/Download. Bug: 774673 Change-Id: I72254511a5b79026d26f0bfe7bf6b2df26b37daf Reviewed-on: https://chromium-review.googlesource.com/801977 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521147}
-
Xiaohan Wang authored
Today on systems where we use AesDecryptor for Clear Key key system and MojoCdm for other key systems, the DecoderSelector will always try to see whether there is a Decryptor exposed by the CDM to decrypt the stream directly (e.g. AesDecryptor). If not, it'll fallback to MojoCdm which will typically will decrypt and decode in the remote process. Hence, "no decryptor" exposed by a CDM is normal. Previously we report this as a "debug" message in MediaLog, but it often causes confusions. This CL changes this MediaLog log to DVLOG to avoid such confusion. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If434dd7ae5bc7e76ab68c964190b465bf55d9185 Reviewed-on: https://chromium-review.googlesource.com/803671Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521146}
-
Patrick Monette authored
Fixes include: - Include what you use - Running "git cl format" - Reordering classes to be consistent Change-Id: I197eb04cb84babe0f91aa47a7f4792c6289d92ee Reviewed-on: https://chromium-review.googlesource.com/780019 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521145}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/43a5c4971235..c8947ecc4964 $ git log 43a5c4971..c8947ecc4 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 simonhatch Revert "Remove original addSeriesGroup and rename addSeriesGroup2." Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I86b55e837b4501e7611614b397ebe5625087c817 Reviewed-on: https://chromium-review.googlesource.com/803669 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521144}
-
Will Chen authored
This should speed up DevTools tests without increasing flakiness because it no longer needs to clear localStorage to reset DevTools settings since we're using a JS object as a mock localStorage. Bug: 667560 Change-Id: I1a1e06346d64855d1d8eb1d9749cc223271791fc Reviewed-on: https://chromium-review.googlesource.com/798535Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521143}
-
Joshua Bell authored
The implementation enforced IsSecureContext manually by throwing SecurityError, but per spec the API (`caches` global and the interfaces) should not even appear in non-secure contexts. Bug: 564245 Change-Id: I9f66d7398dbf6934b5b47a094c6343b57046a81a Reviewed-on: https://chromium-review.googlesource.com/802538Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521142}
-
Ilia Demianenko authored
PowerShell is a powerful command-line shell which is preinstalled on all Windows 7+ machines and is capable of issuing arbitrary network requests. This change adds two options to the network request context menu on Windows systems: "Copy as PowerShell" and "Copy all as PowerShell". Testing done: strings from the old curl-command.html and the Big List of Naughty Strings (https://github.com/minimaxir/big-list-of-naughty-strings) were submitted as request URL and bodies. Requests then were copied, submitted from PowerShell and cURL (bash) and compared on the server side. All requests got byte-for-byte match. Bug: 787693 Change-Id: I1a404e0a127cc27f154ad965661fb227232a0b08 Reviewed-on: https://chromium-review.googlesource.com/784770Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Blaise Bruer <allada@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521141}
-
James Cook authored
A previous CL left AcceleratorControllerDelegateMash empty. Most of the commands in AcceleratorControllerDelegateClassic work fine under mash, so put all the commands back in AcceleratorController. Add early exits for the few that don't work under mash. These files were split up during the WmWindow conversion, when some ash subdirectories were not allowed to use aura. Bug: 612331 Test: ash_unittests, chrome browser_tests Change-Id: Ic4ce3783c1c50ef85091bd012c7b366b26761120 Reviewed-on: https://chromium-review.googlesource.com/803054 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521140}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. TBR=sky@chromium.org Bug: 289619 Change-Id: I7a3769cfb30db3a2bb8d761f646cf23f1582f972 Reviewed-on: https://chromium-review.googlesource.com/787810Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com> Cr-Commit-Position: refs/heads/master@{#521139}
-
James Cook authored
Several tests can be re-enabled now that crbug.com/786544 is fixed Also rename a bluetooth test exclusion because the underlying bluetooth test was renamed. Bug: 786544 Test: browser_tests --mash Change-Id: I68cd79028e15636c810257a95aa64bfed6862e69 Reviewed-on: https://chromium-review.googlesource.com/803668Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521138}
-
Sarah Hu authored
Bug: 781998 Change-Id: I11a456b1341d044b1370652c337f105e0bef649a Reviewed-on: https://chromium-review.googlesource.com/803622 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#521137}
-
Gyuyoung Kim authored
base/memory/ptr_util.h includes are changed with <memory> as well. Bug: 755727 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If706c2ac4d92de45ee525aa49694827903264865 Reviewed-on: https://chromium-review.googlesource.com/802847Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#521136}
-
Zhongyi Shi authored
Bug: 790997, 774622 Change-Id: I4b254e962d8aed0c10130b891d250980f412b088 Reviewed-on: https://chromium-review.googlesource.com/803620Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521135}
-
James Cook authored
The crashes under --mash are due to heap corruption from code trying to disable multi-user switching animations. That code does not seem necessary any more. Per crrev.com/223823004 when it was added this test was reliably failing. The multi-user switch animations have been recently refactored and a shelf animation removed. The test now passes even without the animation disabling code. I cannot reproduce failures or crashes without --mash. I've done ASAN runs as well. I suspect the non-mash problem in the bug is unrelated to this test and may have been fixed separately. Bug: 787050 Test: browser_tests --gtest_filter=PreferencesTest.* --gtest_repeat=100 Change-Id: I08dc3897361440fdbd49df1a11429e06fb9bac51 Reviewed-on: https://chromium-review.googlesource.com/804401Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#521134}
-
Karan Bhatia authored
This CL removes some unused code in RulesetMatcher. BUG=None Change-Id: I233c3b59e982df380ef8345a3328765445a0b97c Reviewed-on: https://chromium-review.googlesource.com/803750Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521133}
-
- 01 Dec, 2017 20 commits
-
-
liberato@chromium.org authored
If a resource is marked to request a promotion hint, but it isn't used by any quad, then it might not be synced by GLRenderer before promotion hints are sent. In that case, locking the resource for read will DCHECK. This CL adds a check for unsynchronized resources, and skips sending hints for those that aren't synced. Bug: 788359 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I54a2d4ced392a313a56f48a1b066ca3f2f62d152 Reviewed-on: https://chromium-review.googlesource.com/794598 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#521132}
-
James Zern authored
commit 296c7dc4ac54becebec0b8f32b072becf0b94c33 Author: James Zern <jzern@google.com> Date: Wed Nov 29 16:54:23 2017 -0800 fix lossless decoding w/WEBP_REDUCE_SIZE alpha processing is still required when requesting premultiplied output since: 1b27bf8b WEBP_REDUCE_SIZE: disable all rescaler code Bug: 789665 Change-Id: I4920127e71519a1534ae84ea04b92a8e2ac271d3 Reviewed-on: https://chromium-review.googlesource.com/802399Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#521131}
-
David Tseng authored
- introduce MessageCenterScrollView and use for MessageCenterView::scroller_. We need this because the |scroller_| is the one that gets focused when a user invokes Alt+Shift+N. - remove accessibility bits from MessageCenterView including accessible data and focusability. Test: with ChromeVox, press Alt+Shift+N and tab around. Verify that the scroller gets focused and outputs correctly when first entering message center and that tabbing never reaches the MessageCenterView, but only reaches the scroller_. Previously, both were tab stops. Bug: Change-Id: I1c8b06f157bbb4749f61cdd6a4f80c5693d76f48 Reviewed-on: https://chromium-review.googlesource.com/801344 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521130}
-
Yuzhu Shen authored
This CL also changes the mojoPrivate API to be simply an async wrapper around require(). Bug: 699569, 718047 Change-Id: I271887d1cc1eb49fd2faefff47467c47be23a3be Reviewed-on: https://chromium-review.googlesource.com/783645Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521129}
-
David Benjamin authored
The new ones don't pull in a dependency on the giant OID table. This should be the last link in all of Chromium aside from WebRTC. (Also that random build tool in //net, but that's not shipped.) Bug: 706445 Change-Id: I06d0c953b829a592afeeb8399e788e8ea8e53af6 Reviewed-on: https://chromium-review.googlesource.com/804119 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521128}
-
Dirk Pranke authored
When tests were run locally on buildbot builders, we'd set CHROME_HEADLESS to tell tests that they weren't being run interactively (so we wouldn't do things like show modal dialogs that might be flaky or problematic). Apparently we never thought to propagate this over to swarming :(. This change sets the env var in test_env.py, which should take effect for all desktop gtest-based tests. It's unclear if the env var also is needed for iOS and Android, and whether we'll need to set this elsewhere as well, but this should solve at least some problems for now. R=jbudorick@chromium.org, maruel@chromium.org BUG=790985 Change-Id: I3914568c2a9e56ae5f6e450708491fecf6f57f48 Reviewed-on: https://chromium-review.googlesource.com/804398Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521127}
-
Miguel Casas authored
Fix typo in //media/test/README: s/@/2/. No new code. TBR=kcwu@chromium.org Change-Id: Iee9e1d086498d1fce340576f0d32db42920ac103 Reviewed-on: https://chromium-review.googlesource.com/804055Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#521126}
-
Dmitry Gozman authored
Converted accessibility module as an example. Bug: none Change-Id: Ib7f475c9a20a58839aa580508c130ea88027170e Reviewed-on: https://chromium-review.googlesource.com/804418Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521125}
-
Eric Lawrence authored
Manual removals for the HSTS preload list. TBR=palmer@chromium.org Change-Id: Ia222959e2307e8f61a13438b1ae824579ef103ac Reviewed-on: https://chromium-review.googlesource.com/801896 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#521124}
-
Danyao Wang authored
This is a logic bug introduced in crrev.com/c/789791. If SetWebUsageEnabled(true) is called twice consecutively, the session at the time of the first call will incorrectly be restored during the second call. The navigation history between the two calls will be lost. This was exposed in TabUsageRecorderTestCase/testColdLaunchReloadCount egtest. Bug: 781916 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f7226fb42ba7d647b9229514a574afc57703ae3 Reviewed-on: https://chromium-review.googlesource.com/803740Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#521123}
-
Karan Bhatia authored
NPAPI plugin support has been removed from chrome and the "plugins" extension manifest key is effectively deprecated. This CL deprecates the plugins requirement. Extensions which specify the plugins requirements will now get an install warning. Extensions explicitly requesting the npapi requirement (by setting requirements.plugins.npapi to true) in their manifest will get a load error. BUG=732590 Change-Id: I874ca17b5143516f1746fff90197243eb6ac2999 Reviewed-on: https://chromium-review.googlesource.com/795361Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521122}
-
Kevin Cernekee authored
Currently, if ARC++ is uninstalled while an Android VPN is running, shill will not receive a disconnection event and this will break networking on Chrome OS. Fix this by forcing ARC VPN to disconnect whenever ArcNetHostImpl shuts down. BUG=768053 TEST=uninstall ARC++ through Settings with a VPN connected Change-Id: Iccbdc20bb26bce154f8041a517b1220519a2b738 Reviewed-on: https://chromium-review.googlesource.com/778340 Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521121}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/361df070323f..76746f9bc29d $ git log 361df0703..76746f9bc --date=short --no-merges --format='%ad %ae %s' 2017-11-22 brandon1.jones Optimize Fragment Shader Type Match Validation Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I64278a9b3a17edb0810849f5d5e7d0c40a77aa0e Reviewed-on: https://chromium-review.googlesource.com/804412Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521120}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I3cee01abf6159f9e632c4929538c13554e4c2dfb Reviewed-on: https://chromium-review.googlesource.com/804147Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521119}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1f0d1fda6db8..752e9bf892ab $ git log 1f0d1fda6..752e9bf89 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 thestig Add CFX_FloatRect::ToRoundedFxRect(). 2017-12-01 thestig Add CFX_FloatRect::Scale(). 2017-12-01 thestig Rename CFX_FloatRect::Scale() to ScaleFromCenterPoint(). 2017-12-01 thestig Remove unused CFX_FloatRect::Substract4(). 2017-12-01 thestig Add some CFX_FloatRect unit tests. 2017-12-01 npm Remove unneded structs from CFX_CTTGSUBTable part 2 Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I17774bd6b170e086953b375ea5601f38689dd71a Reviewed-on: https://chromium-review.googlesource.com/804409 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521118}
-
sczs authored
Creates a ToolbarCommands protocol so the ToolbarVC can cancel the omnibox edit. Bug: 791092 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e283cfd1144b41c6f207103de153f0c6a4d7128 Reviewed-on: https://chromium-review.googlesource.com/804140 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521117}
-
Tien-Ren Chen authored
The primary objective of this CL is to ease SPv175+ implementation by making sure there's a 1:1 mapping from meta display items to property tree nodes. 1. A bunch of meta display items have been converted to embedded drawing commands in ClipPathClipper. For each layout object that has a clip-path, at most 2 effect nodes (for isolation and mask) and 1 clip node (for raster-based clip, if applicable) will be created. All meta display items that apply to individual clip-path in a nested clip-path chain are flattened into drawing commands. e.g. local transforms, and save layer that intersects nested masks. 2. Switched around the mask painting order. Before this CL it was result = mask <SrcIn> content After this CL it becomes result = content <DstIn> mask The result should be equivalent, this change is to unify with other similar usage, thus sharing code in the compositor logic. 3. Reduce the number of save layer with nested clip-path. Previously each clip-path in a chain will use 2 layers for isolation and mask application, but in fact the isolation can be shared. For example it was: result = (((mask_3 <SrcIn>(mask_2)) <SrcIn>(mask_1)) <SrcIn>(content)) using 6 save layers for a nested clip-path of 3, with this CL it becomes: result = (content <DstIn>(mask_1 <DstIn>(mask_2) <DstIn>(mask_3))) using only 4 save layers. 4. Caching logic in LayoutSVGResourceClipper has been improved. Previously if a SVG clip-path can't use raster-based clip, subsequent calls to AsPath() will attempt to compute a path again. Now it should remember it has failed from last time. 5. Previously added helper functions LayoutObject::LocalReferenceBoxForClipPath() and LayoutObject::LocalClipPathBoundingBox() has been moved to ClipPathClipper. 6. Miscellaneous coding style improvement. Prefer NRVO over output argument. BUG=769942 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9a8602bb7a8bcaf990cfa14dca77012d27c1c46c Reviewed-on: https://chromium-review.googlesource.com/770096Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521116}
-
Ken Rockot authored
Several services require "app" capability from all other services (wildcard), which is in itself probably a Bad Thing; but it's especially bad now because the catalog service exposes module directory access through its app capability. This changes the catalog manifest to move the capability to a different more specific capability, and updates two of its consumers. May break other random mash/mushrome (i.e. non-production) services depend on the blanket directory access behavior since aura mus client library code depends on it in some environments. Bug: 791003 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I81d81af8385fb1e013445a6b8c175ebf96388077 Reviewed-on: https://chromium-review.googlesource.com/804397 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521115}
-
Sammie Quon authored
Fix a bug where snapped windows in splitview while still in overview do not have their headers painted. Make CustomFrameViewAshBase look for splitview state changes, and repaint the header if the state is snap left or snap right. Test: ash_unittests CustomFrameViewAshTest.HeaderVisibility* Bug: 789378 Change-Id: I7ff65181134205544af2a717a3ee3e3797aa2ad2 Reviewed-on: https://chromium-review.googlesource.com/797681 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#521114}
-
kapishnikov authored
BUG=790776 Change-Id: I445eb3ef0dc957342ef2afc62fed3c51b06f893a Reviewed-on: https://chromium-review.googlesource.com/804059Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521113}
-