GitLab

That is to say, WebNode::m_private should be based on Persistent<Node>.
Because all of WebNode subclasses shares it, we need to change the
classes so that they can be convertible to RawPtr instead of PassRefPtr.

We need some #if ENABLE(OILPAN) because some WebCore functions
still return PassRefPtrs.


BUG=357163

Review URL: https://codereview.chromium.org/270573008

git-svn-id: svn://svn.chromium.org/blink/trunk@173622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
There are two different events that most of the time coincide: a
JavaScript wrapper for a DOMWindow is created, and a new Document is
installed on the DOMWindow.
    
Sometimes, only the former happens, e.g. an iframe with an image as src
doesn't have an document.
    
However, for the embedder, this difference doesn't matter. It's in both
cases possible (and necessary) to install additional hooks on the
windows object.
    
Last but not least, we should never notify the embedder for changes in
isolated worlds. An embedder that is interested in these signals should
listen didCreateScriptContext/willReleaseScriptContext.
    
BUG=none
R=yurys@chromium.org,dcarney@chromium.org

Review URL: https://codereview.chromium.org/146693005

git-svn-id: svn://svn.chromium.org/blink/trunk@173621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The error code can be ABORT_ERR if a operation is aborted by the browser.

BUG=369525

Review URL: https://codereview.chromium.org/267253008

git-svn-id: svn://svn.chromium.org/blink/trunk@173620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371276
TBR=yurys
NOTRY=true

Review URL: https://codereview.chromium.org/268353010

git-svn-id: svn://svn.chromium.org/blink/trunk@173619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/274453012

git-svn-id: svn://svn.chromium.org/blink/trunk@173618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/270213006

git-svn-id: svn://svn.chromium.org/blink/trunk@173617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729, 371104
TBR=enne, ojan
NOTRY=true

Review URL: https://codereview.chromium.org/277523007

git-svn-id: svn://svn.chromium.org/blink/trunk@173616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the rare data objects for Node and Elements into garbage
collected objects.

R=haraken@chromium.org,zerny@chromium.org,erik.corry@gmail.com
BUG=357163

Review URL: https://codereview.chromium.org/265793017

git-svn-id: svn://svn.chromium.org/blink/trunk@173615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I can't find any reason to do a layout when the self painting bit
changes. The code was added by hyatt a long time ago in
https://trac.webkit.org/changeset/43657 but the test he added still
passes without that code (as do the rest of the tests).

Lets just delete this layout code.

Review URL: https://codereview.chromium.org/275563002

git-svn-id: svn://svn.chromium.org/blink/trunk@173614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Recent CL broke run-bindings-tests on my machine:
Move modules-dependent IDL statements out of core by supporting 'implements' in RHS interface
https://codereview.chromium.org/270573005/

This is due to depending on order of files;
this is fixed by doing the moving/merging in a separate, global phase
(which we're already doing).

Also:
* Adds a test case.
* Fixes unaddressed nits.

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/270823002

git-svn-id: svn://svn.chromium.org/blink/trunk@173613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/274763003

git-svn-id: svn://svn.chromium.org/blink/trunk@173612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/271673005

git-svn-id: svn://svn.chromium.org/blink/trunk@173611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371264
NOTRY=true

Review URL: https://codereview.chromium.org/278583002

git-svn-id: svn://svn.chromium.org/blink/trunk@173610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=367903

Review URL: https://codereview.chromium.org/279493003

git-svn-id: svn://svn.chromium.org/blink/trunk@173609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Pass WorkerGlobalScope as a reference until we set it to RefPtr
- Wrap m_syncHelper with a function hasTerminatedPeer() for readability
- Stop holding reference on WorkerGlobalScope in
  WorkerThreadableWebSocketChannel
- Move ASSERT(m_syncHelper) to waitForMethodCompletion()
- Return a value indicating failure when waitForMethodCompletion()
  returns because of shutdown
- Make the methods not calling waitForMethodCompletion() also return
  without doing anything if the peer is already terminated
- Move task posting code into waitForMethodCompletion()
- More comments for readability

BUG=none

Review URL: https://codereview.chromium.org/265713004

git-svn-id: svn://svn.chromium.org/blink/trunk@173608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/273653003

git-svn-id: svn://svn.chromium.org/blink/trunk@173607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/273543003

git-svn-id: svn://svn.chromium.org/blink/trunk@173606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270573009

git-svn-id: svn://svn.chromium.org/blink/trunk@173605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=162783
R=ager@chromium.org

Review URL: https://codereview.chromium.org/273503006

git-svn-id: svn://svn.chromium.org/blink/trunk@173604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=371104,361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/278523003

git-svn-id: svn://svn.chromium.org/blink/trunk@173603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Batch update to remove people who've moved to the mailing list:
https://groups.google.com/a/chromium.org/forum/#!members/blink-reviews-bindings

Also remove outdated comment in Source/bindings/OWNERS
to Source/OWNERS (no longer exists, as the per-file rules didn't work).

R=haraken
NOTRY=true

Review URL: https://codereview.chromium.org/279483002

git-svn-id: svn://svn.chromium.org/blink/trunk@173602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in line with the webcrypto spec which takes CryptoOperationData as inputs throughout, and defines it as:

  typedef (ArrayBuffer or ArrayBufferView) CryptoOperationData;

BUG=369179,245025

Review URL: https://codereview.chromium.org/267133002

git-svn-id: svn://svn.chromium.org/blink/trunk@173601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CoreFoo implements ModulesBar;

To avoid layer violation, these statements are moved to the implemented (RHS) IDL files.
The code generator is updated to support this.

BUG=358074
BUG=360435

Review URL: https://codereview.chromium.org/270573005

git-svn-id: svn://svn.chromium.org/blink/trunk@173599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL handles the followings:
 - TextControlInnerContainer
 - EditingViewPortElement
 - TextControlInnerTextElement
 - SearchFieldDecorationElement
 - SearchFieldCancelButtonElement

Also, add 'explicit' to their constructors.

BUG=357163

Review URL: https://codereview.chromium.org/264333011

git-svn-id: svn://svn.chromium.org/blink/trunk@173596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add support for [Global] / [PrimaryGlobal] IDL extended attributes as per the
latest Web IDL specification:
http://heycam.github.io/webidl/#Global

The [Global] and [PrimaryGlobal] extended attributes can be used to give a name
to one or more global interfaces, which can then be referenced by the [Exposed]
extended attribute (already supported).

One slight difference with the specification is that the values for [Global]
and [PrimaryGlobal] are '&'-separated instead of comma-separated. This is
because having comma-separated here would make IDL parsing a lot harder. This
is consistent with the [Exposed] IDL extended attribute.

There is no web exposed behavior change with this CL. It just makes our IDL
closer to the specification.

R=haraken@chromium.org, nbarth@chromium.org
BUG=369115

Review URL: https://codereview.chromium.org/261243002

git-svn-id: svn://svn.chromium.org/blink/trunk@173595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The style checker tries to catch std::x references and recommends
'using namespace std;' instead. However, 'using std::swap;' is an
established idiom for swapping objects in generic code, to permit ADL.

BUG=none

Review URL: https://codereview.chromium.org/276513005

git-svn-id: svn://svn.chromium.org/blink/trunk@173594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replacing transition types to real types.

BUG=340522

Review URL: https://codereview.chromium.org/270253004

git-svn-id: svn://svn.chromium.org/blink/trunk@173593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This just updates a bunch of pointers so a WebRemoteFrame can replace a
WebLocalFrame node, or vise versa. This does not currently preserve the
JS global context, which will be addressed in future patches.

BUG=346764
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/271793002

git-svn-id: svn://svn.chromium.org/blink/trunk@173592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Make DateTimeEditElement::m_editControlOwner and DateTimeFieldElement::m_fieldOwner strong references.

We don't need to use WeakMember for them because owners never die before owned
elements.
In non-Oilpan, owners can die before owned elements because parentNode is not a
strong reference.

BUG=357163

Review URL: https://codereview.chromium.org/275513003

git-svn-id: svn://svn.chromium.org/blink/trunk@173590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature was once enabled in M35 but we had to unlaunch it (wire
format changes being under consideration). The decoder patch for the
format change is landed [1], and we are not expecting further format
change at the moment.

[1] https://code.google.com/p/ots/source/detail?r=113

> Enable Woff 2.0 font compression format by default
>
> Feature Dashboard: http://www.chromestatus.com/features/6718644721549312
> PSA: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/j27Ou4RtvQI/discussion
>
> BUG=242809, 223731
>
> Review URL: https://codereview.chromium.org/199773002

Review URL: https://codereview.chromium.org/265833004

git-svn-id: svn://svn.chromium.org/blink/trunk@173589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729,371104

Review URL: https://codereview.chromium.org/272633003

git-svn-id: svn://svn.chromium.org/blink/trunk@173588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173571

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270783003

git-svn-id: svn://svn.chromium.org/blink/trunk@173587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173571

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270803003

git-svn-id: svn://svn.chromium.org/blink/trunk@173586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Working on https://codereview.chromium.org/264183002/ I ran
into some const correctness issues with the fact that containerForRepaint
returns a non-const pointer, despite repaint being a const operation.
Fixing this before landing that patch.

BUG=320139

Review URL: https://codereview.chromium.org/276583002

git-svn-id: svn://svn.chromium.org/blink/trunk@173585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369485

Review URL: https://codereview.chromium.org/274463002

git-svn-id: svn://svn.chromium.org/blink/trunk@173584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously the animation clock was only frozen during animation frame
callbacks. This meant that the timeline was able to advance during other
tasks. 

This patch allows the clock to advance once per task, either to the
compositor supplied frame start time or to an approximation of the next
expected frame time.

http://dev.w3.org/fxtf/web-animations/#script-execution-and-live-updates-to-the-model

BUG=367903

Review URL: https://codereview.chromium.org/251183006

git-svn-id: svn://svn.chromium.org/blink/trunk@173583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173562

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/268363015

git-svn-id: svn://svn.chromium.org/blink/trunk@173582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds another speculative assert in deepestBlockContainingAllText
to check for containingBlock() returning null which it can when the
subtree is detached.

I wasn't able to hit this in a synthetic test so this patch is a
speculative fix. If this improves stability we can consider guarding
all of the containingBlock() calls.

BUG=370764

Review URL: https://codereview.chromium.org/273613002

git-svn-id: svn://svn.chromium.org/blink/trunk@173581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=364139

Review URL: https://codereview.chromium.org/268363013

git-svn-id: svn://svn.chromium.org/blink/trunk@173580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make HTMLAnchorElement.text getter behave according to specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#dom-a-text

According to the specification, the 'text' IDL attribute, on getting, must
return the same value as the textContent IDL attribute on the element. However,
Chromium was returning 'innerText' instead. Upon setting, Chromium was
correctly updating the 'textContent' attribute though.

The new behavior is consistent with Firefox 29 and IE11.

This CL is based on arv's comment at:
https://codereview.chromium.org/263353004/#msg2

R=arv@chromium.org, tkent@chromium.org
BUG=369950
TEST=fast/dom/HTMLAnchorElement/get-text.html

Review URL: https://codereview.chromium.org/272693002

git-svn-id: svn://svn.chromium.org/blink/trunk@173579 bbb929c8-8fbe-4397-9dbb-9b2b20218538