- 15 Nov, 2018 21 commits
-
-
Max Moroz authored
That flag is now always enabled by default (https://reviews.llvm.org/D51251) and the analyzer errors out when the flag is passed via command line. Also adding myself as an owner for Clang Static Analyzer and Code Coverage related files. Bug: 901486, 759794 Change-Id: I54c9988c79f13287bb0580637d1a3ae4aa46bba7 Reviewed-on: https://chromium-review.googlesource.com/c/1330758Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608199}
-
Saman Sami authored
Bug: 900373 Change-Id: Ibaaeda2fcff69b5bf45eb7de767731bf53177f56 Reviewed-on: https://chromium-review.googlesource.com/c/1336510Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#608198}
-
Aiden Benner authored
Normally custom ErrorProne checks would catch this, but they were inadvertently disabled. In preparation for for re-enabling these custom ErrorProne checks this CL fixes all the redundant field initializations that have crept into the codebase. Trivial mechanical change TBR=yfriedman@chromium.org Bug: 904524 Change-Id: I96a81a1cb3b8c67bc682728aa9035c4757ed319b Reviewed-on: https://chromium-review.googlesource.com/c/1334188 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608197}
-
Mike Frysinger authored
Trying to use --help with grit just ends in errors like: $ grit --help getopt.GetoptError: option --help not recognized Add support for it with `grit --help`. This doesn't update the subtools for now as that'll take much more work/thought. We also don't support the -h short option as it's already used for other things, and we don't want to complicate/break it. Bug: 747171 Change-Id: Ied24f810ed583d464dc2970c8e472784e22ec044 Reviewed-on: https://chromium-review.googlesource.com/c/1327421Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608196}
-
Joe Downing authored
Checking in the strings early to get a jump on localization. Bug: 902041 Change-Id: I697462486441a009b36f31955f61633946410ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1336084 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#608195}
-
Robert Kroeger authored
vector_scalar_arithmetic_inside_loop fails on Android Nvidia (N9, STV devices.) Suppress. BUG=905370 TBR=kbr@chromium.org Change-Id: I996bd3e01e680dc53267393cf345fc45988028c9 Reviewed-on: https://chromium-review.googlesource.com/c/1335989 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608194}
-
Sammie Quon authored
Do not activate quick switch when double tapping the tray, if the mru window is not activate. This was causing an unexpected window activation which was messing up the overview state, and also visually popping up and activating an unexpected window. Test: Checked that OnEndingAnimation does not get called between ToggleOverview calls Bug: 905082 Change-Id: Iaa7d3d02482d33d27ade6684ece8b92e9c270204 Reviewed-on: https://chromium-review.googlesource.com/c/1336149 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608193}
-
Theresa authored
And create a generic thumbnail_placeholder_on_white_bg color for use in Zine as well. BUG=900757 Change-Id: I8cee89a7bfc361288b4f5b0041efb6dc2d8785c7 Reviewed-on: https://chromium-review.googlesource.com/c/1336062Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#608192}
-
Evan Stade authored
Bug: 163931 Change-Id: Ia6be534c8dd82207d91a584be7a49e42545102dc Reviewed-on: https://chromium-review.googlesource.com/c/1334841 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#608191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e04de3408e65..8a878e1c2fc6 Created with: gclient setdep -r src-internal@8a878e1c2fc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie990e6d1b79bddcdf2743d9dd9a8033afbbf978d Reviewed-on: https://chromium-review.googlesource.com/c/1336222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608190}
-
Tsuyoshi Horo authored
There was a bug that service workers can inject image into favicon cache of any origins (crbug.com/422250). This is becuase the icon URL is used as a key of the "favicons" table in ThumbnailDatabase. So currently MultiResolutionImageResourceFetcher sets the SkipServiceWorker flag of all favicon requests, to make it impossible to handle the fetch event of favicon requests in service workers. Ideally we should change the data scheme of ThumbnailDatabase not to reuse the favicon which was served from a service worker. But it is complicated to change the data scheme, and also there is a performance trade-off. So this cl change MultiResolutionImageResourceFetcher to set the SkipServiceWorker flag only for cross origin favicon requests. So the service worker can handle the same origin favicon requests. Bug: 448427 Change-Id: I3237ae9c4d0cc5d2374830e2c4865a8a852d37c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333120Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#608189}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4925b069e1cf..8a6451c727a2 git log 4925b069e1cf..8a6451c727a2 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 harrytczhang@google.com Added service account email for Android metrics to whitelist. Created with: gclient setdep -r src/third_party/catapult@8a6451c727a2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4186c0fcb901238641b170e0960f198875e678cc Reviewed-on: https://chromium-review.googlesource.com/c/1336269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608188}
-
rbpotter authored
This is a reland of https://crrev.com/c/1332703, with tests omitted since they were flaking. Tests will be relanded in a followup CL. Bug: 901115 Change-Id: I77112c3640c8eddc8863da902a2e75c0723bd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/1336211Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608187}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c10b4254..8117fe38 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I526d86ab23bc67810e1b581f35ae272f0584f06e Reviewed-on: https://chromium-review.googlesource.com/c/1336427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608186}
-
Xianzhu Wang authored
Change-Id: I2c695493e682f6f3870205e03d52ec536867ca9c Reviewed-on: https://chromium-review.googlesource.com/c/1329806Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608185}
-
Antoine Labour authored
Use CheckedNumerics to prevent silent uint32_t overflow. Bug: 905336, 905459 Change-Id: Ie518def9063143ef2393be566419a209f68f0dce Reviewed-on: https://chromium-review.googlesource.com/c/1336083Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608184}
-
Xianzhu Wang authored
We should just dump all layers without culling. This will simplify paint layer dirty rect migrating to CullRect. Bug: 792577 Change-Id: I01f304f4c0166e8ecf7c1984545c3f24ac1b551c Reviewed-on: https://chromium-review.googlesource.com/c/1335007Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608183}
-
Yuri Wiitala authored
This is the replacement for GLHelper::I420Converter. It uses the new GLScaler to efficiently scale and re-format RGBA textures into I420 image planes. In a soon-upcoming CL, GLRendererCopier will be switched over to use this. Includes unit and pixel testing. Bug: 870036, 810131 Change-Id: I465eb933e7eadeb205676211432cced361a3739b Reviewed-on: https://chromium-review.googlesource.com/c/1330830Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608182}
-
Saman Sami authored
Don't send OnFirstSurfaceActivation to browser for OOPIFs when surface sync is enabled. Bug: 893850 Change-Id: I3afda38af2ade88424d28181c51294025c08dd6d Reviewed-on: https://chromium-review.googlesource.com/c/1336051 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e3b7b56f6bc3..2585eafdcba3 git log e3b7b56f6bc3..2585eafdcba3 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 tsepez@chromium.org Rename testing/resources/javascript/*_props.in to *_properties.in Created with: gclient setdep -r src/third_party/pdfium@2585eafdcba3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5a1277ec62c958d1c17244c91a0da160ba1119fa Reviewed-on: https://chromium-review.googlesource.com/c/1335845Reviewed-by:
-
ssid authored
BUG=905461 Change-Id: Idee52c3f44ca7aef6707e010b5e07bd668120109 Reviewed-on: https://chromium-review.googlesource.com/c/1330735Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608179}
-
- 14 Nov, 2018 19 commits
-
-
Mohamed Heikal authored
Currently exception messages could contain PII but are not sanitized before they are uploaded inside minidumps. This cl adds a PiiElider class to java which is used in both java and native to sanitize stacktraces before writing to the minidump. Bug: 903472 Change-Id: Iadb88a9102d15a7129ace6fae99bed10c04c8423 Reviewed-on: https://chromium-review.googlesource.com/c/1330209Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608178}
-
Pedro Amaral authored
Moving bottom toolbar classes to a new package called: org.chromium.chrome.browser.toolbar.bottom; Bug: 904997 Change-Id: Ibd552668fd2c2711b4403293a8e39e40d2098e29 Reviewed-on: https://chromium-review.googlesource.com/c/1335029Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608177}
-
David Staessens authored
Fixed a bug that would prevent using absolute input file paths. This is required by tast, since the test image data is uploaded to a custom directory. Temporary files are generated, written to a temporary file, and read into memory again. This unnecessary step has been removed. File operations introduce additional points of failure, and it can be tricky to write to temporary files when using the Tast framework. This also prevents files cluttering the temp folder when not being cleaned up on crashes. The encode output of generated images is now written to the current folder using HxW_[black|white].jpg as output file name. TEST=ran jpeg_encode_accelerator_unittest on eve BUG=899605 Change-Id: Ie3f0e299ef85ce663586b4ba4c1177e84ec7a8ca Reviewed-on: https://chromium-review.googlesource.com/c/1333011 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608176}
-
John Abd-El-Malek authored
This way it can run in the network process, similar to Network Error Logging. Bug: 853251 Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f Reviewed-on: https://chromium-review.googlesource.com/c/1334848Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb9844ef69e7..44764000b49c git log bb9844ef69e7..44764000b49c --date=short --no-merges --format='%ad %ae %s' 2018-11-14 scroggo@google.com Add SafetyNetLogging and use in SkPngCodec 2018-11-14 bsalomon@google.com Reenable GrOp chaining. 2018-11-14 mtklein@google.com Revert "remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc" 2018-11-14 reed@google.com don't use nested form of FontMetrics 2018-11-14 mtklein@google.com remove Clamp_S32_opaque_D32_nofilter_DX_shaderproc 2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d1a55e393e65..fca8fd620190 (2 commits) Created with: gclient setdep -r src/third_party/skia@44764000b49c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/117838472 TBR=rmistry@chromium.org Change-Id: I03a9d8897d0a666c50f1a97f6261257f11034a68 Reviewed-on: https://chromium-review.googlesource.com/c/1335846Reviewed-by:
-
Dmitry Gozman authored
We never use error_description coming from ContentRendererClient, so removing this parameter. Also inline LoadNavigationErrorPageForHttpStatusError to reduce the number of Load*Error* methods. TBR=boliu@chromium.org,sky@chromium.org Bug: none Change-Id: I74278b825247cb20cc71de6c6c0a5cf8850a614c Reviewed-on: https://chromium-review.googlesource.com/c/1332928 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608173}
-
Alexander Alekseev authored
Bug: 905455 Change-Id: I45beaa8dee4cd4aec6056a8e2be7df342726ae02 Reviewed-on: https://chromium-review.googlesource.com/c/1336488Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#608172}
-
Ted Choc authored
Still needed for clear tab experiment analysis. BUG=899961 Change-Id: I726ca7af1dc222067c05d0f9bb1927af0a04c76c Reviewed-on: https://chromium-review.googlesource.com/c/1334829Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#608171}
-
Sammie Quon authored
It has been on by default since M69. Test: none Bug: 828646 Change-Id: I1be9d8b588e4b42767ae09e81364e6262c7cf156 Reviewed-on: https://chromium-review.googlesource.com/c/1334507Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24643488d40a..83aa5ace99a5 git log 24643488d40a..83aa5ace99a5 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 jacadd@microsoft.com Adding Microsoft Corporation (*@microsoft.com) to WebRTC AUTHORS 2018-11-14 amithi@webrtc.org Prevent channels being set on stopped transceiver. 2018-11-14 peah@webrtc.org AEC3: Turn off the specific suppressor mode for stationary render 2018-11-14 shampson@webrtc.org Adding shampson to media/OWNERS. Created with: gclient setdep -r src/third_party/webrtc@83aa5ace99a5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:905291,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5ba53138b969632f081a87c82a5ffc63599ed0c Reviewed-on: https://chromium-review.googlesource.com/c/1336219Reviewed-by:
-
Robert Ogden authored
There was a bug server side where encoding a IPv6 URL wasn't working correctly. This is a preemptive test to make sure the encoding in Chrome is correct (it already is). Change-Id: I17dd2393133fc02f01de0b2ef381fc05067bf72d Reviewed-on: https://chromium-review.googlesource.com/c/1336508 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608168}
-
Makoto Shimazu authored
As preparation for adding FetchEvent#resultingClientId, this CL fixes the test to make it pass once resultingClientId is impelmeneted. Bug: 778497 Change-Id: I6309a13d4315e6a99149275a6d7889f14ce0d757 Reviewed-on: https://chromium-review.googlesource.com/c/1335055Reviewed-by:
-
Sergey Ulanov authored
This reverts commit b26b9d89. Reason for revert: Added static initializers, see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/37632 Original change's description: > Add X11 support for ATK key event listeners > > ATK requires us to allow it to filter all key events. Add an AtkUtil > mechanism to filter key events. > > Bug: 866334 > Change-Id: I42383479ab78242325bda0714afb60b7dcf2fe65 > Reviewed-on: https://chromium-review.googlesource.com/c/1319709 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607989} TBR=sadrul@chromium.org,dmazzoni@chromium.org,mrobinson@igalia.com Change-Id: I7cc1d2bfa85761af5c1704260646758ae3028063 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866334 Reviewed-on: https://chromium-review.googlesource.com/c/1336437Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608166}
-
edchin authored
This CL starts to separate Coordinator from UI layer in BVC. BrowserCoordinator owns BVC. BrowserViewWrangler owns the BrowserCoordinator. Bug: 904622 Change-Id: I6f259061d045584ce4d878621b083d9ebdc023c2 Reviewed-on: https://chromium-review.googlesource.com/c/1332779 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608165}
-
Zach Helfinstein authored
Bug: None Change-Id: Ic1a16a5cf023718a401404e62070203090bd3bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1320214Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#608164}
-
Christian Biesinger authored
For better test output when it fails. R=ikilpatrick@chromium.org Change-Id: I6800cba6f137ab1b87c094b08baeed8551689203 Reviewed-on: https://chromium-review.googlesource.com/c/1336549Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#608163}
-
Robert Kroeger authored
This reverts commit 7bd7f065. Reason for revert: most likely fix for a gn failure on win gpu fyi Original change's description: > Roll src/third_party/SPIRV-Tools/src a6150a3fe778..dc9d155d6216 (1 commits) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6150a3fe778..dc9d155d6216 > > > git log a6150a3fe778..dc9d155d6216 --date=short --no-merges --format='%ad %ae %s' > 2018-11-14 stevenperron@google.com Fix folding of volatile store. (#2048) > > > Created with: > gclient setdep -r src/third_party/SPIRV-Tools/src@dc9d155d6216 > > The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=dsinclair@chromium.org > > Change-Id: I0406b560139f9213b5d117496462133318f5e03c > Reviewed-on: https://chromium-review.googlesource.com/c/1335842 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#608123} TBR=dsinclair@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I20b1a38321fd39c527e5ebac99510a004649f4d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1336436Reviewed-by:
-
David Benjamin authored
A few Android-only features used kSomeBaseFeature.name rather than a constant string like the others. On other platforms, these trip a static initializer check. On Android, chrome/android/static_initializers.gni's count actually included it. Fix them and clear it. (Along the way, fix some arraysize vs base::size warnings from presubmits.) See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1334412/2/chrome/browser/about_flags.cc#b2609 An earlier iteration of this CL also switched to constexpr per that discussion, but that seems to upset Windows. Note to reviewers: it's worth double-checking I didn't copy one of the strings wrong. Change-Id: If53659e2ea93c972edba4c4246d22044a8fdd20c Reviewed-on: https://chromium-review.googlesource.com/c/1334654 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Mike Wittman authored
Frames from deduplicated samples were being left in the current sample state on the class, resulting in incorrect extra frames being added when the next sample was recorded. This change eliminates the current sample state to avoid this problem, and adds a test for this case. Bug: 905379 Change-Id: I5fe0ccd3e50675669d4c7124fb7f64ebb85fe807 Reviewed-on: https://chromium-review.googlesource.com/c/1336247Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608160}
-
