- 15 Sep, 2020 40 commits
-
-
yiyix authored
The ImageData interface has two data entries: data(array of uint8) and data_union(could be array of uint8, float16 or float32). In this cl, I deleted data and rename data_union to data. This cl prepares canvas to work with more data types, which will help us to enable canvas to work with p3 and rec2020. Note that some part of the code works with uint8 only, i have put a TODO for each of the occurrence. I will address them in the next cl. Bug: 1115317 Change-Id: Ia7f203e627547eceb6da479522b3130bc6eaef12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379653Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#807179}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06b4fb92c569..377e748714bf 2020-09-15 xinyi.he@arm.com Vulkan: Support array of array image type 2020-09-15 syoussefi@chromium.org Distinguish MSRTT renderbuffers in the front-end If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I0666a386b444e87d813c6426155ef63c454cb61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807178}
-
Wei Li authored
Change HasCheckBox() function name to HasVisibleCheckBox() as the comment states there has to be a visible checkbox to return true. The last refactoring missed that comment. Also check the checkbox's visibility for the return value. Bug: 1128078 Change-Id: I90a60662ed1e3a7aef61e8042cdc507e4ace2f1a Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411332Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#807177}
-
Vadim Shtayura authored
Will be used by chromium-swarm-dev and chromium-swarm-staging Swarming instances. R=iannucci@chromium.org, gbeaty@chromium.org Change-Id: I2e9df66d7acd991ad6b32d7ff672f7ac12b53e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411400Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807176}
-
James Vecore authored
This connects the contacts manager to the visibility component via mojo. Two new UI state are introduced on the contact list that are temporary pending final designs (contacts downloading and contacts failed). Strings, a11y, and final specs coming in a follow up CL. New UI States (temporary): Contacts pending: http://screen/7xcjKkEZJiJ325n.png Contacts failed: http://screen/4k4yajgwbMRdBsF.png Fixed: b:166503584 Change-Id: I6aa1cce4829174fb88711c637949cb322ea7ee49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408241 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807175}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ac2f01f4bd89..9eaa69c21c45 2020-09-15 laddoc@outlook.com Preprocessor related issue fix (#2378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I61e1d051a2e2486ec1d40b1fdba460f24f27337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411728Reviewed-by:
-
Abigail Klein authored
an accessibility action to keyboard. When a user opens a context menu via an accessibility action, such as Ctrl+Option+Shift+M on VoiceOver, the web menu source type should be keyboard. This causes the context menu to be populated with information relevant to the target element of the context menu action, rather than the location of the context menu. For multiline links, or links that are obscured, this ensures that the context menu will be populated with the correct options. However, the context menu may still open in a confusing location because it opens in the center coordinate of the target element. In earlier patchsets, I explored making the context menu open in the center of the first outline rect of the element (outline rects are elsewhere used to show the focus highlight of multiline links). This was abandoned because doing so would affect use cases outside of accessibility, such as touch gestures. AX-Relnotes: Context menus opened via keyboard are populated with the correct options. Bug: 1121180 Change-Id: Id5fdf35d51533fec4c76a65d840c9b36f4a2ca3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407077Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#807173}
-
Irina Fedorova authored
This CL renames and updates the CompromisedCredential dictionary to InsecureCredential in passwords_private.idl to support both weak and compromised credentials in the future. It also adds CompromisedInfo helper dictionary to passwords_private.idl. Bug: 1119752 Change-Id: I5ceadc4cc50fc423a392f559d4631d6265a17c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411931Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#807172}
-
Richard Knoll authored
OnIsCapturingDesktopChanged is called when capturing either a single window or a full screen. This CL splits those two into separate observables. This is done to be used in upcoming CLs to detect when a user is capturing the whole screen instead of just a window. Bug: None Change-Id: If6d078889fd6e0f5b28c1681f9c0c7a084095897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392459 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#807171}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6dbc5ee8027..986e74510613 2020-09-15 shyamsadhwani@fb.com Fix for unbounded increase in audio delay when no audio packets are flowing in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I570864bb044c533cdb015cb763ba6c1392f40c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412593Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies the WellKnownChangePasswordNavigationThrottle to set the request initiator and correct NetworkIsolationKey on the request to the non-existing resource. Bug: 1127520 Change-Id: I3b24611be316a56ea64a5bb2cc4cd23d0b619c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410869Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#807169}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d6bf6eee8b5..49bec88c936e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com,iclelland@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127469 Tbr: collinbaker@google.com,iclelland@google.com Change-Id: Iad421aca691db2201a497bc750c45f8a5d916abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412358Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807168}
-
My Nguyen authored
This adds ability to search by input method names and languages. It's better for C++ side to provide the details for settings page in view of future intention of adding search by countries. Mock: http://go/cros-lang-settings-ux-slide#slide=24 Current view: http://screen/94X7dcUcj5J2zxe Bug: 1113439 Change-Id: Ia76974e6cee4ecec5ce1bab9428b79ca9022df6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402861 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This can be used to test functionality implemented in https://chromium-review.googlesource.com/c/chromium/src/+/2410762. Bug: 1106937 Change-Id: I7900440cc56599ae164cc8c318992f19f220017f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412255 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807166}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I3df7737031e8aecc9463b8f42fb5bcf8b5722693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410841 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Matt Menke authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2394155, I merged URLRequestJobFactoryImpl info URLRequestJobFactory, but failed to update the fuzzer, which depended on URLRequestJobFactoryImpl. This CL fixes that. It's unclear why none of the bots failed to build the fuzzer. Bug: 354158 Change-Id: Id5607076213af4f9837e2283e439ee490ce47719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412636 Auto-Submit: Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#807164}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I128378fe4144a474c9c0b264b787a0a61b9145c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411425Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#807163}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8b1a5e7995a5..a1f84f4a7300 2020-09-15 sigurds@chromium.org Make e2e test more flake resilient on Mac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I77c6d1210b6c375c3784088729a4c0f8b3070e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412591Reviewed-by:
-
Morten Stenshorne authored
If the block-size of a multicol container is constrained, we need to pay attention to space already used by preceding content. Bug: 829028 Change-Id: Ie27bbf0b4a587716690a1bbd5a67cfa595ada7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410247Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807161}
-
Keren Zhu authored
Subprocesses spawned in the same process group with their parent are killed when the parent test process exits. This CL makes BrowserUiTest always wait on the subprocess so that those tests in the subprocess are actually run. Bug: 1128222, 688534, 1094369 Change-Id: I2ee1059fa4968be2c2c62a3834e5f70e883f7caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412690Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807160}
-
Christopher Cameron authored
On macOS, a GpuMemoryBuffer pool (CVPixelBufferPool, to be specific) is managed internally by AVCaptureVideoDataOutput. It will burp up a new CMSampleBuffer (which may have a CVPixelBuffer, which may have an IOSurface) every frame. In the case that there is an IOSurface, we will want to send that surface to the receiver (encoder, compositor, etc), rather than copy it a bunch of times. This does not mesh well with the VideoCaptureDevice structure, where the pool of buffers is managed by the VideoCapturePool, and handed to the capturer to populate. Fix this situation with the following changes. To VideoCapturePool, add a method to reserve a buffer id that will not conflict with other buffer ids from the pool. External buffers will use these ids. To VideoCaptureDevice::Client add a OnIncomingCapturedExternalBuffer method, which takes a gfx::GpuMemoryBufferHandle. This method will scope the external buffer's lifetime in the receiver to the receiver's use of the buffer. Bug: 1125879 Change-Id: Ic6cfb7e0e91a97d4489b37cfc7e013b91db369f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406717 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807159}
-
Tom Anderson authored
Some distros (eg. Gentoo) use a non-default libXcursor path, so the path (which was previously hardcoded) must now be obtained from libXcursor. This patch uses dlopen()/dlsym() to get the path when available. BUG=1127712 R=sky Change-Id: Ib99dff0448c521c1a6cf8ad03bfe981572b9627c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410305 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This reverts commit f46065ea. Reason for revert: crbug.com/1128563 Original change's description: > Remove RuntimeFeatureEnableOptions::kEnableOnlyIfOverriddenFromCommandLine > > It was used by only one feature (Portals). It has been agreed that > kDefault can meet the requirement of the feature. > > kDefault is very much like kEnableOnlyIfOverriddenFromCommandLine. The > difference is that kDefault also respects status overridden from finch > and from --disable-features command line switch (in case the feature is > enabled by default at blink side). > > Bug: 1048656 > Change-Id: Ibb946dbdcc5ece7c5f5a08822b80825345c170e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411231 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jason Chase <chasej@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807045} TBR=wangxianzhu@chromium.org,chasej@chromium.org,lfg@chromium.org Change-Id: I9c8933123308e38f8bb0c822b17b47965a71bfc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048656, 1128563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412557Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807157}
-
Jimmy Gong authored
ConnectionScheduler is responsible for kicking off the connection. It will retry with initial backoff of 10 seconds with exponential retry times for each failure. Bug: 1106937 Test: unittest Change-Id: If59aed0129743402b65bb5765e0e946d69278579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402165Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: If056b07757368a65e9f7c02c67939b53bb4fcb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410495 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807155}
-
Dan Harrington authored
Bug: 1119406 Change-Id: Ib6e64db692a264036d48ca168f434cfe38f534b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412549 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807154}
-
Ahmed Fakhry authored
This CL adds the necessary changes before Capture Mode is hooked to the recording servcie. It handles starting and stopping the recording, cursor-compositing state, as well as the stop-recording button visibility. BUG=1126586 TEST=Added a new test. Change-Id: I324ec678d15da877be89b7e3178c98868cdc7b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407452 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#807153}
-
Adlai Holler authored
GrContext is going away, and GrRecordingContext can do the job. Change-Id: Id0108ea8336fb6e2acb82261a8a80fa618fcf9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411648 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807152}
-
Mustaq Ahmed authored
Spec discussion: https://github.com/w3c/pointerevents/issues/325 Change-Id: I7c690043c2af0a80b946bc4270febde0405994a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339923 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#807151}
-
Bettina authored
Previously, the ClientPhishingRequest was passed as a raw pointer into SendClientPhishingRequest and then converted back to a unique_ptr when passed into StartClientPhishingRequest. When using a raw pointer,it has to be made sure to be deleted otherwise there is a memory leak. To make this easier to maintain, it is switched to a unique_ptr. Bug: 1122226 Change-Id: Ia344ea26661eec202cd27224889ba398f8264835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379252Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807150}
-
Dave Tapuska authored
Move the notification of DidCommitAndDrawCompositorFrame inside blink. This avoids having to iterate on the render_frames_ inside RenderWidget. BUG=1097816 Change-Id: Ia785f8482b5d420668edcbb10e2aba944b456aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410338 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Ken Rockot authored
All typemaps listed here are deleted and their configurations are merged into their respective mojom targets. Bug: 1059389 Change-Id: I94cd40f48f7ee80de7f284bf446d4e9e80939810 Tbr: xiyuan@chromium.org Tbr: estade@chromium.org Tbr: changwan@chromium.org Tbr: engedy@chromium.org Tbr: dschuff@chromium.org Tbr: jdoerrie@chromium.org Tbr: jds@chromium.org Tbr: megjablon@chromium.org Tbr: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405438Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#807148}
-
Julie Jeongeun Kim authored
This CL introduces AddToFixedOrStickyNodeList and InvalidateBoundingBoxForFixedOrStickyPosition to AXObjectCacheImpl to update the bounds for fixed or sticky positioned nodes on scrolling. AXObjectCacheImpl owns |fixed_or_sticky_node_ids_|, updates when AX objects retrieve their relative bounds, and clears it when layout is completed. Once the scroll position is updated, it invalidates the bounds for the fixed or sticky positioned nodes by calling InvalidateBoundingBoxForFixedOrStickyPosition and ScrollPositionChanged event sends location changes to the browser. AX-Relnotes: n/a. Bug: 1027542 Change-Id: I29a6fd1584b64f0c597f44bdacda18e6540f6d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402928 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Ken Rockot authored
This makes it so optional mojom values can only be read from their DataView into a destination type that supports nullability when read with the common Read[FieldName] methods. Attempting to violate this constraint will result in a compile-time assertion failure at the site of the Read[FieldName] call. Prior to this change, such instances were non-obvious and could instead result in surprising runtime behavior. Types that support nullability include anything wrapped with base::Optional, or any type for which there exists an appropriate {Struct,Union,Array,String}Traits definition with a SetToNull method. Pre-existing violations of the new constraint are corrected here either by making fields non-optional, deserializing to a base::Optional, or doing something more specialized to fix traits logic. Finally, this also removes the IsNull and SetToNull methods from StringTraits<std::string> since: (a) optional string fields are generated as base::Optional<std::string> and (b) it was not intentional for null strings and empty strings to be treated as equivalent in meaning. Fixed: 1124639 Change-Id: I0569b4b8420b4b416bd889417d9723307a880454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404478 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807146}
-
Patrick Noland authored
The accessibility attributes were placed on the wrong View, leading to the button not being clickable via accessibility events. In concordance with other instances of MenuButton, this CL moves the accessibility description and focusable/clickable attributes to the ImageButton child. Bug: 1127217 Change-Id: If71a7a328602ca31c4d3afb72ade8ad12b7ed4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405442Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807145}
-
David Bienvenu authored
This reverts commit d01e1075. Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29> Original change's description: > [mathml] Use post.underlineThickness for the default fraction rulethickness > > MathML Core currently defines fallback values to use when no MATH table > is available. This CL performs the remaining work to ensure fractions > align with the specification. It also adds WPT test to check these > fraction fallback parameters, although testing them extensively is > difficult. > > Bug: 6606, 1058369 > Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384 > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807083} TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 6606 Bug: 1058369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#807144}
-
Xi Han authored
The crash was caused by registering a listener to a null feedStream. Bug: 1127854 Change-Id: Ic040cf6620718e72b7f8a3faac115f7fb8799f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407093Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807143}
-
Alexander Cooper authored
Bug: 1126786 Change-Id: I8e3bd1c9bb938a54dd7bc058ae92620b15cf9f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412629 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807142}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It lays the groundwork for hooking up more KeystoreServices APIs. Change-Id: Ic5925cdf4ce110601c2cab01d1bfdd5504d4ed12 Bug: 1127505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Native Java Unittests have all been removed, and so it's time to revert the infra changes they required. Reverted: https://crrev.com/ea65b1a1577f1fbba45e035f43e1c898a9874f9b https://crrev.com/26dc9eefadac5e70cf3789abbfb1eead7c9f7b68 https://crrev.com/1265cac9f769d0460a84e3f906b93f62290fd117 https://crrev.com/d46596b1702517799459d4b6a9a26669b187c94b https://crrev.com/04c511fd08177c915d5c267835110d0194bdd671 Bug: 1103344 Change-Id: I12ea68454c118de7860be6ba23c6e8263baceb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406692 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
