- 21 Jul, 2015 40 commits
-
-
penghuang authored
BUG=None Review URL: https://codereview.chromium.org/1249713004 Cr-Commit-Position: refs/heads/master@{#339733}
-
gunsch authored
Most functionality should be in cast_shell_common target for things like cast_service_unittests to run. R=slan@chromium.org,halliwell@chromium.org BUG=internal b/22465963 Review URL: https://codereview.chromium.org/1232313008 Cr-Commit-Position: refs/heads/master@{#339732}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/0278197..ae3714f CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Commits in this roll: ae3714f caryclark@google.com make varied_text* gm portable Review URL: https://codereview.chromium.org/1250703002 Cr-Commit-Position: refs/heads/master@{#339731}
-
krstnmnlsn authored
ConstructWithoutDefaultAdapter, and ConstructFakeAdapter tests now pass on Mac as well as Android. BUG=511008 Review URL: https://codereview.chromium.org/1232613004 Cr-Commit-Position: refs/heads/master@{#339730}
-
aurimas authored
- Roll to Android Support Library 22.2.1 - Add gyp target for multidex support library. - Revert the workaround for KEYCODE_MENU as 22.2.1 has the bug for it again. BUG=510128,272790 TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/1226373010 Cr-Commit-Position: refs/heads/master@{#339729}
-
dongseong.hwang authored
Mac Developer Library [1] notes "In general, you should not include this header directly. Instead, include <IOSurface/IOSurface.h>." [1] https://developer.apple.com/library/mac/documentation/Miscellaneous/Reference/IOSurfaceAPI_header_reference/#//apple_ref/c/tdef/IOSurfaceRef Review URL: https://codereview.chromium.org/1227363005 Cr-Commit-Position: refs/heads/master@{#339728}
-
varkha authored
The CL that was supposed to fix that collided in CQ with https://codereview.chromium.org/1209033008. After that CL apps launched in a window have SHOW_STATE_DEFAULT initially and not SHOW_STATE_NORMAL as was assumed in https://codereview.chromium.org/1221193009. This patch makes the code path for docked state similar to maximized state and updates that unit test. BUG=271582 Review URL: https://codereview.chromium.org/1240393005 Cr-Commit-Position: refs/heads/master@{#339727}
-
oshima authored
BUG=512482 TEST=manual. Tab dragging works correctly with --force-device-scale-factor=2 Review URL: https://codereview.chromium.org/1247813002 Cr-Commit-Position: refs/heads/master@{#339726}
-
kalman authored
BUG=503402 R=rdevlin.cronin@chromium.org,asvitkine@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1245113005 Cr-Commit-Position: refs/heads/master@{#339725}
-
davidben authored
$ git log 7f15ff53d..209b25622 --date=short --format='%ad %ae %s' 2015-07-20 davidben Fix o2i_ECPublicKey documentation. 2015-07-20 davidben Surround immintrin.h includes with warning pragmas. 2015-07-12 davidben Simplify the AMD-specific codepath. 2015-07-11 davidben Replace cpuid assembly with C code. 2015-06-29 davidben Reserve ex_data index zero for app_data. 2015-07-11 davidben Remove incorrect TODO(fork). 2015-07-11 davidben Extra documentation. 2015-07-16 agl Fix typo in |HMAC_CTX_cleanup|. 2015-06-29 davidben ERR_LIB_USER should be the last error. 2015-06-29 davidben Remove the func parameter to OPENSSL_PUT_ERROR. 2015-06-28 davidben Get rid of err function codes. BUG=none Review URL: https://codereview.chromium.org/1244093002 Cr-Commit-Position: refs/heads/master@{#339724}
-
wfh authored
BUG=508738 TEST=components_unittests --gtest_filter=StorageMonitorWinTest.* Review URL: https://codereview.chromium.org/1250713002 Cr-Commit-Position: refs/heads/master@{#339723}
-
msw authored
Revert of Make AXProviderTest.HelloWorld bail without oopifs. (patchset #1 id:1 of https://codereview.chromium.org/1224103002/) Reason for revert: Sadrul landed a fix for the flaky timeouts: https://codereview.chromium.org/1228173003 Bailing didn't resolve these flakes anyway. Original issue's description: > Make AXProviderTest.HelloWorld bail without oopifs. > > This test times out flakily without oopifs enabled. > Effectively disable the test without oopifs for now. > This should unblock running apptests on the CQ/main. > > BUG=504917 > TEST=Test isn't run without oopifs for now... > R=jam@chromium.org > TBR=sky@chromium.org > > Committed: https://crrev.com/427c2f36770711c369a85f56c4a63b4036e735a9 > Cr-Commit-Position: refs/heads/master@{#338073} TBR=jam@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504917 Review URL: https://codereview.chromium.org/1248873002 Cr-Commit-Position: refs/heads/master@{#339722}
-
sandersd authored
This should move the investigation of bug 495185 closer to the root cause. BUG=495185 Review URL: https://codereview.chromium.org/1246783003 Cr-Commit-Position: refs/heads/master@{#339721}
-
sbc authored
Initializing a pthread_t to NULL (or any value really) is not valid. This causes a compiler warning with the new arm glibc toolchain so needs to be fixed because we enable the new toolchain. Turns out the pid_ member was not even needed so this change removes it and adds a pthread_detach call which allows for freeing on the thread's resources (in the absence of pthread_join). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk BUG=505885 Review URL: https://codereview.chromium.org/1243123002 Cr-Commit-Position: refs/heads/master@{#339720}
-
jyasskin authored
BUG=420284 Review URL: https://codereview.chromium.org/1248573002 Cr-Commit-Position: refs/heads/master@{#339719}
-
pkotwicz authored
BUG=505040 TEST=None TBR=aurimas Review URL: https://codereview.chromium.org/1250683002 Cr-Commit-Position: refs/heads/master@{#339718}
-
dbeam authored
R=esprehn@chromium.org BUG=511486 Review URL: https://codereview.chromium.org/1249623003 Cr-Commit-Position: refs/heads/master@{#339717}
-
jzern authored
msvc: fix pointer type warning in BitsLog2Floor _BitScanReverse() takes an unsigned long* http://msdn.microsoft.com/en-us/library/fbxyd7zd.aspx fixes: C4057: 'function': 'unsigned long *' differs in indirection to slightly different base types from 'uint32_t *' and -Wincompatible-pointer-types warning on Clang on Windows https://code.google.com/p/webp/issues/detail?id=253 Review URL: https://codereview.chromium.org/1245063002 Cr-Commit-Position: refs/heads/master@{#339716}
-
lalitm authored
Add plumbing code in content layer to allow revocation of permissions. NOTE: this is a part of a three sided patch: https://codereview.chromium.org/1234023002 https://codereview.chromium.org/1238673002 (this) https://codereview.chromium.org/1241133002 BUG=510405 Review URL: https://codereview.chromium.org/1238673002 Cr-Commit-Position: refs/heads/master@{#339715}
-
edwardjung authored
Tracks usage: + of promoted 'Google cached copy' link doctor button. + on each of the two button label variants. BUG=474848 Review URL: https://codereview.chromium.org/1214303003 Cr-Commit-Position: refs/heads/master@{#339714}
-
wittman authored
Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test (patchset #1 id:1 of https://codereview.chromium.org/1222193006/) Reason for revert: Breaks linux clang tot bot (https://crbug.com/512506) and causes flakiness on Vista Tests bot (https://crbug.com/512431). BUG=512506, 512431 Original issue's description: > Remove race in DeclarativeContentApiTest.RulesPersistence test > > BUG= > > Committed: https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b > Cr-Commit-Position: refs/heads/master@{#339432} TBR=battre@chromium.org,matthewtff@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1247743004 Cr-Commit-Position: refs/heads/master@{#339713}
-
boliu authored
Allow SyncPointManager instance to be set, and set the same instance in Android WebView. Also remove ref-counting and just guarantee SyncPointManager outlives running message loop. Also make SyncPointManager thread safe, and callbacks are no longer guaranteed to happen on the same thread. Make sure command buffer implementations handle it correctly. BUG=509702 Review URL: https://codereview.chromium.org/1231263003 Cr-Commit-Position: refs/heads/master@{#339712}
-
mariakhomenko authored
On Android, when merge tabs and apps is enabled, we need to ensure a new activity has been started before loading URL in web contents since the web contents delegate is not ready until then. We already have a code path to handle this for window.open() scenario. This completes the code path for when a link with noreferrer is clicked by saving OpenURLParams of the pending load and resuming the load when the activity is ready. BUG=508366 Review URL: https://codereview.chromium.org/1233453003 Cr-Commit-Position: refs/heads/master@{#339711}
-
nyquist authored
Currently the AccountManagerHelper always checks the GET_ACCOUNTS permission. This should instead be done directly by the AccountManagerDelegate. BUG=509826 Review URL: https://codereview.chromium.org/1247053002 Cr-Commit-Position: refs/heads/master@{#339710}
-
brettw authored
Adds manifest data for content shell. The result matches the GYP build. Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome. BUG=510612 TBR=dpranke@chromium.org Reland of https://codereview.chromium.org/1240893004/ with no cloud print or remoting changes Review URL: https://codereview.chromium.org/1238293005 Cr-Commit-Position: refs/heads/master@{#339709}
-
avayvod authored
BUG=412331 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1228863005 Cr-Commit-Position: refs/heads/master@{#339708}
-
mvanouwerkerk authored
Currently Teardown is called twice on shutdown. The ServiceProcess is on the stack. It will call Teardown from its destructor when ServiceProcessMain returns. It looks like this redundancy has been there since the service process was first introduced in: https://codereview.chromium.org/2001009/ Review URL: https://codereview.chromium.org/1242873004 Cr-Commit-Position: refs/heads/master@{#339707}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/add18ed2..49d3837a Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1245103003 Cr-Commit-Position: refs/heads/master@{#339706}
-
lazyboy authored
Browser Side Navigation Linux bot. TBR=jam@chromium.org BUG=507223 Test=None. Review URL: https://codereview.chromium.org/1250663002 Cr-Commit-Position: refs/heads/master@{#339705}
-
vmpstr authored
This patch changes the interest rect calculation from using number of tiles to screen space distance (3k as the initial setting). The problem with using the number of tiles is that on devices like mac book pro, we end up having very little prepainting area in software and way too large of a prepainting area with ganesh, since the sizes of tiles differ drastically. BUG=483520 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1236533004 Cr-Commit-Position: refs/heads/master@{#339704}
-
dyen authored
There is an ongoing issue with failures on Mac OSX causing crashes on the renderer side. All we know so far is that it has something to do with failures with our usage of GL_COMMANDS_COMPLETED_CHROMIUM. We suspect it has something to do with multiple GPUs but it is hard to tell for sure. This will at least let us know what is going on for the GPU side. BUG=467678 Review URL: https://codereview.chromium.org/1242913003 Cr-Commit-Position: refs/heads/master@{#339703}
-
sullivan authored
BUG=511273 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect Review URL: https://codereview.chromium.org/1250453005 Cr-Commit-Position: refs/heads/master@{#339702}
-
krstnmnlsn authored
Giving BluetoothAdapterMac ownership of the CBCentralManager (the discovery manager retains a pointer) and separating the CBCentralManagerDelegate class from the BluetoothLowEnergyDiscoveryManagerMac file, as it will soon support non- discovery callbacks from CoreBluetooth as well. BUG=510491 Review URL: https://codereview.chromium.org/1226133006 Cr-Commit-Position: refs/heads/master@{#339701}
-
tfarina authored
This reverts commit cc83d2d6. Tested on Linux with the following command lines: $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' $ gn check out-gn/Release //components/omnibox/* BUG=367595, 376000 TEST=see above R=brettw@chromium.org Review URL: https://codereview.chromium.org/1242973003 Cr-Commit-Position: refs/heads/master@{#339700}
-
bhanudev authored
This metric records the CERT_COMMON_NAME_INVALID errors when the hostname entered and one of the dns names of the certificate have same effective domain name (eTLD+1).This helps us see if the certificate is completely random or if it is related to the current hostname. BUG=507715 Review URL: https://codereview.chromium.org/1227173006 Cr-Commit-Position: refs/heads/master@{#339699}
-
dmazzoni authored
BUG=488693 Review URL: https://codereview.chromium.org/1232643003 Cr-Commit-Position: refs/heads/master@{#339698}
-
lalitm authored
In the past we simply retrieved the name and short name and picked the latter to be the title if it existed or otherwise we used the former. The user was then able to edit the title and save the web app on their homescreen. This title was then used on the launcher as well as in recents. However, with the new splash screen which might be up soon, we need the long name from the website to display on the splash screen. It also looks better if recents utilizes the short name which is specified by the website rather than a user specified title which is used on the launcher. Because of all this, this CL propogates the info through various C++ and Java classes to allow the above usage. Now the user title is used just for the home screen icon. The name is used on the splash screen and the short name is used in recents. A note on backward compatibility: current webapps will simply use the user specified title which is currently saved in the intent - this CL only affects new webapps which the user adds after it lands. BUG=508628 Review URL: https://codereview.chromium.org/1224273003 Cr-Commit-Position: refs/heads/master@{#339697}
-
sdefresne authored
Reland of https://codereview.chromium.org/1242373002/ but correctly rebased on ToT. BUG=511570 Review URL: https://codereview.chromium.org/1242743003 Cr-Commit-Position: refs/heads/master@{#339696}
-
brianderson authored
Instead of inferring if the main thread is in a high latency mode or not based on many other variables, track it explicitly at the end of the BeginImplFrame deadline. Also rename MainThreadIsHighLatency to main_thread_missed_last_deadline so it's clearer what that variable means exactly. BUG=406158 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1229573004 Cr-Commit-Position: refs/heads/master@{#339695}
-
dsinclair authored
Review URL: https://codereview.chromium.org/1248703003 Cr-Commit-Position: refs/heads/master@{#339694}
-