GitLab

The outcome is: if device authorization for a renderer is taking too long
it will be interupted. Page load will continue normally, some of the audio
playback on it may not work.

BUG=647498

Review-Url: https://codereview.chromium.org/2862823002
Cr-Commit-Position: refs/heads/master@{#469308}

Swarming has only a single Win10-10240 bot but about 30-40 Win10-10586
bots.

TBR=dpranke@chromium.org,mcgreevy@chromium.org
BUG=718379,717347
NOTRY=true

Review-Url: https://codereview.chromium.org/2857213004
Cr-Commit-Position: refs/heads/master@{#469307}

BUG=709042

Review-Url: https://codereview.chromium.org/2854143002
Cr-Commit-Position: refs/heads/master@{#469306}

Extracts a SuggestionsEventReporter out of SnippetsBridge, that is
responsible for recording backend metrics and sending events used by
the fetch scheduler.

BUG=710268

Review-Url: https://codereview.chromium.org/2844033002
Cr-Commit-Position: refs/heads/master@{#469305}

A test suite that depends on a test suite base that provides a
base::test::ScopedTaskEnvironment may need browser threads. Currently,
the test suite cannot use content::TestBrowserThreadBundle to get
these browser threads because base::test::ScopedTaskEnvironment and
content::TestBrowserThreadBundle both set the main MessageLoop and
the TaskScheduler. With this CL, content::TestBrowserThreadBundle
doesn't set the main MessageLoop and the TaskScheduler if they
already exist.

E.g.
Test suite: ToolbarActionViewUnitTest
            Needs BrowserThreads
Base test suite: views::ViewsTestBase
                 Provides a ScopedTaskEnvironment

BUG=

Review-Url: https://codereview.chromium.org/2860533002
Cr-Commit-Position: refs/heads/master@{#469304}

Parse Server-Timing response headers and make the metric name(s), value(s), and
description(s) available as PerformanceServerTiming entries on the global
performance timeline and to PerformanceObservers. This feature is behind the
"ServerTiming" experimental-features flag.

To test, turn the flag on
(chrome://flags/#enable-experimental-web-platform-features) and explore to
https://server-timing.now.sh/. Execute `performance.getEntriesByType('server')`
in DevTools to inspect the 4 entries for the base page, as per the response
header:
server-timing:db=100; "Database metric", api=200; "HTTP/API metric", cache=300; "cache metric", total=0.000297322; "Total Response Time"

To inspect the 4 entries for the favicon.ico, you will need to set up a
PerformanceObserver (I use TamperMonkey to inject a content script) like this:
new PerformanceObserver(function(list, observer) {
  console.info(list.getEntries())
  observer.disconnect()
}).observe({entryTypes: ['server']})

Spec: https://w3c.github.io/server-timing/
Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/y3qwr490Fc4/boGoo41-BwAJ

BUG=702760

Review-Url: https://codereview.chromium.org/2839683003
Cr-Commit-Position: refs/heads/master@{#469303}

A speculative change that might help mitigate problems with
WTF::Deque::expandCapacity which sometimes takes over a second
due to heavy load on PartitionAlloc.

I'm hoping in normal operation the default_tq doesn't get more
than a handful of tasks (a quick trace of handouts on a high end
pc suggests the queue depth is <= 3) which would let us avoid
dynamic allocations entirely.

BUG=710245

Review-Url: https://codereview.chromium.org/2860813004
Cr-Commit-Position: refs/heads/master@{#469302}

In this CL, support is added to all unit tests targets and the Showcase
Earl Grey tests.

BUG=676034
R=sdefresne@chromium.org,marq@chromium.org,lindsayw@chromium.org

Review-Url: https://codereview.chromium.org/2789433004
Cr-Commit-Position: refs/heads/master@{#469301}

The origin whitelist may well be empty, so check that first
before taking on the stringification of the security origin.

R=
BUG=

Review-Url: https://codereview.chromium.org/2855133005
Cr-Commit-Position: refs/heads/master@{#469300}

BUG=none

Review-Url: https://codereview.chromium.org/2854973005
Cr-Commit-Position: refs/heads/master@{#469299}

This makes the UI consistent with the settings UI.

Screenshots:
before: http://imgur.com/cze5exI
after: http://imgur.com/1Z43yGW

BUG=602666

Review-Url: https://codereview.chromium.org/2855183002
Cr-Commit-Position: refs/heads/master@{#469298}

 * Adding perl (needed for CGI scripts).
 * cygwin (possibly needed?)

BUG=717347
TBR=mcgreevy@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2856283003
Cr-Commit-Position: refs/heads/master@{#469297}

BUG=160920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2860653003
Cr-Commit-Position: refs/heads/master@{#469296}

All calls to LayoutText::AbsoluteQuadsForRange don't use use_selection_height,
so use_selection_height is removed from LayoutText::AbsoluteQuadsForRange and
its callee functions.

BUG=691198

Review-Url: https://codereview.chromium.org/2853343003
Cr-Commit-Position: refs/heads/master@{#469295}

This CL adds missing timeout handling functionality [1]. When user
provides timeout value for the push operation, and NFC tag is not
in proximity for the duration of timeout value, operation must be
rejected with timeout error. Unit test is added to test new
functionality.

https://w3c.github.io/web-nfc/#the-push-method (Step 14).

BUG=714037

Review-Url: https://codereview.chromium.org/2851453004
Cr-Commit-Position: refs/heads/master@{#469294}

local_ntp_browsertest.cc was actually part of the interactive_ui_tests
target, but most tests there don't need the "interactive" part. This CL
moves the one test that *does* need it into a separate _uitest.cc file,
and moves the _browsertest.cc file into the browser_tests target.

To do this, the uitest-specific parts of InstantTestBase were split out
into a new class InstantUITestBase.

BUG=none

Review-Url: https://codereview.chromium.org/2857023003
Cr-Commit-Position: refs/heads/master@{#469293}

This is in preparation for beta and stable Finch configs.

BUG=676655

Review-Url: https://codereview.chromium.org/2854293002
Cr-Commit-Position: refs/heads/master@{#469292}

* Adds a new DefaultSearchEngineFirstRunFragment that's
  immediately after data saver and before account sign-in.
  It was put here because the sign-in logic is scary and
  doesn't normally allow a user to back up into it, which
  a user could do if the search engine dialog came after
  it.

* Updates/adds tests to see if the search engine dialog
  appears in the correct spot and allows recording a
  search engine.

Screenshots: go/eabws

BUG=712836,712833

Review-Url: https://codereview.chromium.org/2844323003
Cr-Commit-Position: refs/heads/master@{#469291}

This CL prevents items or non-existent IDs from being navigated to. In
order to achieve this, we add support for 'deferred actions', which
allow actions to be created asynchronously. Deferred actions are currently
only used for selecting folders from the Router, but will be used to
simplify search in a follow-up CL.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2813503002
Cr-Commit-Position: refs/heads/master@{#469290}

FakeCentral allows clients to simulate events that a device
in the Central/Observer role would receive as well as monitor the operations
performed by the device in the Central/Observer role.

BUG=569709

Review-Url: https://codereview.chromium.org/2853433002
Cr-Commit-Position: refs/heads/master@{#469289}

Move the WebEntities class out of web/ and into platform/, since it has
no other dependencies inside web/.

BUG=712963

Review-Url: https://codereview.chromium.org/2859123002
Cr-Commit-Position: refs/heads/master@{#469288}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0d00147b4f72..18b10cbe616e

$ git log 0d00147b4..18b10cbe6 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 dskiba symbolize_trace: support new heap dump format.

Created with:
  roll-dep src/third_party/catapult
BUG=708930


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6f4ede67585683d8a723daae7684c81e123e4dde
Reviewed-on: https://chromium-review.googlesource.com/495372
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469287}

This patch adds the fieldwise_diff macro and then uses it to generate
the diff functions on the groups that have been generated so far
(StyleSurroundData) in ComputedStyleBase.

Please note that it can only be used for memebers of those groups too
that have already been generated. This is why the diffing for
BorderData has been left to a later CL.

Diff: https://gist.github.com/nainar/04f49165c4cb5ecb30371fbde1491ddf/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2858863002
Cr-Commit-Position: refs/heads/master@{#469286}

https://skia.googlesource.com/skia.git/+log/0356714916c3..64dbb89efc9d

$ git log 035671491..64dbb89ef --date=short --no-merges --format='%ad %ae %s'
2017-05-03 senorblanco GrTessellator: fix for vertex coincident with enclosing edge.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ia9db0a51e7f984fcf3a36cbb81ebae5bee5d218d
Reviewed-on: https://chromium-review.googlesource.com/495591Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469285}

Network traffic annotation is added to network request of
components/translate/core/browser/translate_url_fetcher.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2796323002
Cr-Commit-Position: refs/heads/master@{#469284}

This CL ensures that the NOT_STARTED state is recorded separately from
the STOPPED_BEFORE_COMPLETION state in the installability menu-open
check metrics.

BUG=704369

Review-Url: https://codereview.chromium.org/2844383004
Cr-Commit-Position: refs/heads/master@{#469283}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontFeatureSettings from the switch statement in
parseSingleValue, and calls the API instead.

This patch:
- Adds CSSPropertyAPIFontFeatureSettings.cpp to the BUILD.gn file.
- Adds parseSingleValue to font-feature-settings in CSSProperties.json5 so that it will be added to the generated files for the api.
- Moves the parsing logic for font-feature-settings from CSSPropertyParser.cpp to
  CSSPropertyAPIFontFeatureSettings.cpp, which implements CSSPropertyAPI.h.

Diff: https://gist.github.com/jm318/db6da170e28cb7fefa0056a364f164f0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2861633002
Cr-Commit-Position: refs/heads/master@{#469282}

This CL makes the context menu for bookmark items appear when an item is
clicked.

BUG=692837
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2814023004
Cr-Commit-Position: refs/heads/master@{#469281}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2855393002
Cr-Commit-Position: refs/heads/master@{#469280}

[Cleanup] Use IsStandaloneExtensionProcess in ChromeContentRendererClient::ShouldGatherSiteIsolationStats()

BUG=None

Review-Url: https://codereview.chromium.org/2863523002
Cr-Commit-Position: refs/heads/master@{#469279}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2860023002
Cr-Commit-Position: refs/heads/master@{#469278}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2860943002
Cr-Commit-Position: refs/heads/master@{#469277}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2862773002
Cr-Commit-Position: refs/heads/master@{#469276}

Since its introduction in Canary I became a big fan of the CSS rule usage
tracker and I'm looking forward to its introduction in Chrome stable.

I also thought it would be a great idea to run it periodically as part of the
e2e tests at work to collect the (un)used CSS rules instead of during manual
testing.

I then decided to implement a POC [1] to run the CSS tracker with Protractor.
This of course required some changes in Chromedriver, Protractor and WebDriver
JS Extender.
In particular, I had to change the Chromedriver so that I could send the
commands to start and stop the CSS rule usage tracking
(CSS.startRuleUsageTracking/CSS.stopRuleUsageTracking) to the remote debugger.

I thought of 3 possible implementations:
1) as part of the performance logging [2];
2) as a new endpoint of the Chromedriver to start/stop the CSS rule usage
tracking;
3) as a new endpoint of the Chromedriver to send any command directly to the
debugger, hence opening up the road to a whole series of tools able to send
commands directly to the debugger through the Chromedriver.

Of these 3 options, I implemented option 2 and 3 in this change.

If this change is acceptable, I'll proceed with the tests and fixing the linter issues.

Thanks,

EM.

[1] https://github.com/ventuno/css-usage-recorder/tree/ftr-css-recording
[2]
https://sites.google.com/a/chromium.org/chromedriver/logging/performance-log

BUG=

Review-Url: https://codereview.chromium.org/2743013002
Cr-Commit-Position: refs/heads/master@{#469275}

If xvfb dies or fails to start correctly while checking xdpyinfo, we
should exit straight away rather than continuing to try and probe with
xdpyinfo and waiting to time out.

BUG=708681,713597

Review-Url: https://codereview.chromium.org/2848833002
Cr-Commit-Position: refs/heads/master@{#469274}

r413783 introduced renderer load level monitoring and introduced the
RendererScheduler.[Background/ForegroundRendererMainThreadLoad] histograms.
r423509 changed how often these histograms were recorded without updating the
histogram descriptions. This CL updates the descriptions to correctly reflect
that these are recorded at most once per minute per renderer.

BUG=None

Review-Url: https://codereview.chromium.org/2856273003
Cr-Commit-Position: refs/heads/master@{#469273}

BUG=None

Review-Url: https://codereview.chromium.org/2856023003
Cr-Commit-Position: refs/heads/master@{#469272}

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2857963004
Cr-Commit-Position: refs/heads/master@{#469271}

On some Linux systems (like Ubuntu 14.04.5 or Ubuntu 16.04) with
4.8.0-49-generic kernel there's no /proc/<pid>/sched file. Or it exists
but doesn't have the required se.statistics.nr_wakeups field.
This causes TaskManagerBrowserTest.IdleWakeups test to fail and in
Chrome Task Manager all the Idle Wakeups counts are 0.

After some research I found out that the voluntary_ctxt_switches field
in file /proc/<pid>/status is practically the same as the previous
one. Using that field helps the test to pass.

BUG=717863

Review-Url: https://codereview.chromium.org/2859763002
Cr-Commit-Position: refs/heads/master@{#469270}

Review-Url: https://codereview.chromium.org/2856413002
Cr-Commit-Position: refs/heads/master@{#469269}