- 09 Jul, 2018 40 commits
-
-
Alex Newcomer authored
MenuSeparator is being reused in Ash, but to do this VIEWS_EXPORT needs to be added to views::MenuSeparator. Else we have linker failures: std::__1::allocator<char> > const&): error: undefined reference to 'vtable for views::MenuSeparator' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function Bug: 861885 Change-Id: I787fe6bf1d62518d03e52007b792481251ae4174 Reviewed-on: https://chromium-review.googlesource.com/1129999Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573477}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8b9db90d117d0877c70e1b30b6af1e56cea46535 Reviewed-on: https://chromium-review.googlesource.com/1124925 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573476}
-
Xiaohui Chen authored
Bug: b:79879196 Change-Id: Ia118af06bf2efba9ae850795109a555434a76f84 Reviewed-on: https://chromium-review.googlesource.com/1130108Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#573475}
-
Yaron Friedman authored
Internal change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/649731 Change-Id: Ia98d8714494e05837274a7d69863647107ba2f87 Reviewed-on: https://chromium-review.googlesource.com/1129394Reviewed-by:
Ran Ji <ranj@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573474}
-
Kent Tamura authored
computed_style.h is used in 1,300+ compilation units, and this CL reduces its pre-processed size by 1.09MB. * Avoid including image_resource_content.h image_resource_content.h is large due to dependency to mojom files. Stop inlining ShapeValue::IsImageValid(). * Avoid including style_svg_resource.h style_svg_resource.h and svg_resource.h are large due to dependency to mojom files. - Stop inlining many functions using StyleSVGResource and SVGResource. - Move ReferenceClipPathOperation and ShapeClipPathOperation to their own files. - Fix make_css_property_subclasses.py for generated core/css/properties/longhands/marker_*.h, which depend on StyleSVGResource. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I907a7772283b282a410fb47f457c447d5417f650 Reviewed-on: https://chromium-review.googlesource.com/1128794 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#573473}
-
Nico Weber authored
Mac doesn't have touch UI, and the test doesn't really make too much sense on cast, but the code under test is built there and the test is small and fast, so might as well run it. Maybe one day the test should move to chromium_gtests_for_devices_with_graphical_output instead. Bug: 843511 Change-Id: I792e8ed5bb419346b23a3e7432a7681e797b244d Reviewed-on: https://chromium-review.googlesource.com/1129719Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573472}
-
David Black authored
Change made in response to spec clarification by UX. Bug: b:78138093 Change-Id: Ie4b642d593f51051ea3f116f73954283e8475345 Reviewed-on: https://chromium-review.googlesource.com/1129553 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#573471}
-
chrome://reset-passwordJialiu Lin authored
Minor css style changes to make its style closer to other interstitials. Bug: 848023 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie575267fd6b424dd302fb3caf6db23669a778e92 Reviewed-on: https://chromium-review.googlesource.com/1129635Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573470}
-
jdoerrie authored
This change fixes runtime errors introduced by the recent Autofill Home change. Bug: 861732 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia445d198ea4f4945b213df3e0f4d76509032c895 Reviewed-on: https://chromium-review.googlesource.com/1122616Reviewed-by:
-
Ryan Daum authored
If the magnification gesture is enabled, the AccessibilityManager will listen for triple-tap events and turn on (or off) the PartialMagnificationController. Bug: internal b/110532350 Bug: internal b/110481596 Test: manual Change-Id: I3e1ed53fddb1c525c0cc3b238e243f59b737323d Reviewed-on: https://chromium-review.googlesource.com/1125038 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#573468}
-
Robbie McElrath authored
This is a copy of https://crrev.com/c/1067424 but with tests fixed. Bug: 844932 Change-Id: I77239bf76a673b33d56b8b7fe584a78ec319bc24 Reviewed-on: https://chromium-review.googlesource.com/1114253 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#573467}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6618d3f745e..21acb2a82232 git log f6618d3f745e..21acb2a82232 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 mheikal@google.com Throw exception instead of dying in get_device_sdk_version Created with: gclient setdep -r src/third_party/catapult@21acb2a82232 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2c995ae2a28dd2ca5b25582fe9d8d3ad0435ea8b Reviewed-on: https://chromium-review.googlesource.com/1129881Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573466}
-
Jun Cai authored
This CL adds a VariationsHeaderURLLoaderThrottle on renderer to fix the VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromSubresourceRequest. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6120ca42d7aeee9fe721a5af7c93c4047416225b Reviewed-on: https://chromium-review.googlesource.com/1103451Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#573465}
-
Fady Samuel authored
Bug: 854256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I83ff040664e008108e8265a6b21069e270dac981 Reviewed-on: https://chromium-review.googlesource.com/1128209Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573464}
-
Chris Mumford authored
Delete the explicit DownloadSaveInfo move constructor in favor of using the default move constructor. This simplifies the code and makes it less likely that a future additional member will be overlooked. Also initializing members in the declaration. This Simplifies documentation and allows the default constructor to be used. Bug: none Change-Id: I6a5ccb895d074f13e7a5aaae6cabbec4d1e7809a Reviewed-on: https://chromium-review.googlesource.com/1129214Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#573463}
-
Harald Alvestrand authored
This is a mitigation of a crash with an unknown cause, which seems to be causing peer_handler_ to be NULL at an unexpected time. It returns a rejected promise instead of crashing. Bug: chromium:855161 Change-Id: Icbb4f42780ae0969ad4d0eff2ef1e9f66a129c11 Reviewed-on: https://chromium-review.googlesource.com/1128972 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#573462}
-
Etienne Pierre-doray authored
Labels are not assigned to targets anymore, so the definition is now meaningless. Instead, target affinity is defined. This should allow us to finally close tracking bug. Bug: 760614 Change-Id: Id705837bd502ae0e6333b9fc8cab250bc590ff11 Reviewed-on: https://chromium-review.googlesource.com/1119388 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#573461}
-
Xing Liu authored
This reverts commit 30c71bac. Reason for revert: This CL needs to be cherry picked to m68 branch, but some testing function is changed in other CLs and breaks the build. So I'll revert this for now, check in a CL with production code only, and later land another for test. Original change's description: > Download: Fix an issue that download percentage can move backwards. > > On certain Android devices, when disconnecting from WIFI, the network > code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger > auto download resumption. And we erase the data downloaded by parallel > requests, so the download percentage will go backwards. > > Instead, we should keep the slice info when resume with an error. > > Bug: 837128 > Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e > Reviewed-on: https://chromium-review.googlesource.com/1112754 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571286} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837128 Change-Id: Id514b0f01b950d9940933fd17cb10d962ed69d85 Reviewed-on: https://chromium-review.googlesource.com/1129660 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573460}
-
Philip Rogers authored
This reverts commit 147c8df5. Reason for revert: Test failure, see crbug.com/861893 Original change's description: > [Mac] Replace Editing Word with Selected Suggestion from Touch Bar > > WebContents::Replace() replaces the current text selection with a given > string. Currently, SuggestedTextTouchBarController replaces the > current user selection when a suggestion is chosen from the touch bar. > > SuggestedTextTouchBarController now calculates a range that > encompasses the word in which the cursor resides. If the cursor is not > in or at the end of a word, the range representing the editing word > starts at the cursor position and has length 0. > > When a suggestion is chosen from the touch bar, the selection within > the textfield is modified to encompass the word currently being > edited (which may be only a cursor position) and then > WebContents::Replace() is called to replace the selection. > > A unit test was written to test that > editingWordFromText:cursorPosition: properly calculates the range > encompassing the current editing word for various combinations of word > and non-word characters. > > Bug: 717553 > Change-Id: I4fe1fbaf2e19f8b33177e07789dca3a30bb7d88e > Reviewed-on: https://chromium-review.googlesource.com/1123226 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Cr-Commit-Position: refs/heads/master@{#573362} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: I8e79b608aab37f7fda5e09f6fbd3d16c0d19a384 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1130120Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573459}
-
Dominic Battre authored
The WebFormElementObserverImpl made an incorrect but also totally unnecessary cast of a Node to an HTMLElement. This edge case was discovered by the fuzzer where a form was inside an <svg> element, whose style attribute was changed, but which could not be casted to HTMLElement. Bug: 861571 Change-Id: I62c8238e25ef39e662dc154a1f2bd772667ec52f Reviewed-on: https://chromium-review.googlesource.com/1128973Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#573458}
-
Fredrik Söderquist authored
Per the spec[1][2], when 'auto' is specified for 'rx' or 'ry' the used value of said property will be the used value of the other property ('rx' for 'ry' and vice versa.) [1] https://svgwg.org/svg2-draft/geometry.html#RX [2] https://svgwg.org/svg2-draft/geometry.html#RY Bug: 861585 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec0a9179527a5b0e99cc6a0ec671e5b6d92f828b Reviewed-on: https://chromium-review.googlesource.com/1128885Reviewed-by:Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#573457}
-
Emily Hanley authored
This enables deletion of the telemetry_perf_tests isolate and the recipe code that supports it. Bug: 757933 Change-Id: I82198ff98e3d7dc189761f1468bc88b591f2a5b1 Reviewed-on: https://chromium-review.googlesource.com/1129364Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#573456}
-
Mounir Lamouri authored
Bug: None Change-Id: Idafa3fbc6214dbb15bad5c28d177296bed1926b8 Reviewed-on: https://chromium-review.googlesource.com/1129828Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#573455}
-
Kevin McNee authored
While it's still not clear why this is happening, this DumpWithoutCrashing is not providing any further information. Bug: 851958 Change-Id: Ib8066c525c94b8503caf35251c12cc804af20dc6 Reviewed-on: https://chromium-review.googlesource.com/1129858Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#573454}
-
Ryan Daum authored
- Adds a new event rewriter which (when enabled) intercepts press and release events and detects triple-tap type events. Bug: internal b/110532350 Test: unit test and manual Change-Id: I29eacc2e2402f304b534c94799d0f67f1cbc01f6 Reviewed-on: https://chromium-review.googlesource.com/1124865 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573453}
-
Daniel Murphy authored
There has been a bunch of memory-corruption-smelling crashes around this area. Changing the container to a std::map should give us more information about where this is happening, and maybe cause it to crash somewhere else. R=mek@chromium.org Bug: 845400,821371,857464 Change-Id: Ife8cb10336a4f0752db89e2bca836ed873f7c711 Reviewed-on: https://chromium-review.googlesource.com/1129849Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573452}
-
Becca Hughes authored
Do not create DisplayCutoutHostImpl automatically in WebContentsImpl BUG=859241 Change-Id: I1dff20d653d1712f529f595c3fb9d0ce08eaceeb Reviewed-on: https://chromium-review.googlesource.com/1129557Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#573451}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/916c76140064..5f2d58f235b1 git log 916c76140064..5f2d58f235b1 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 treehugger-gerrit@google.com Merge "Remove manual reference to exe_and_shlib_deps" 2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps Created with: gclient setdep -r src/third_party/perfetto@5f2d58f235b1 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845700 TBR=perfetto-bugs@google.com Change-Id: Iaf9846fbb79fc0c82c07cbf875147fef14f36374 Reviewed-on: https://chromium-review.googlesource.com/1129880 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573450}
-
Wez authored
Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky, potentially causing unexpected early-exits if run under a different RunLoop to the one intended. Bug: 844016, 859151 Change-Id: Ib38310c0feeec09dbaac6cb74ffd061476e30cf3 Reviewed-on: https://chromium-review.googlesource.com/1123763 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573449}
-
bsheedy authored
Re-adds the former VR controller deadzone as a test-only option. This should allow the tests to avoid failures due to controller noise while preventing the grid-like movement from applying the deadzone all the time. Bug: 861667 Change-Id: Ic5badf59374fa236e8b462379bf53b214328d80d Reviewed-on: https://chromium-review.googlesource.com/1129386Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573448}
-
Ran Ji authored
The message loop has to be started to post tasks on Android. Previously the message loop is started on PreEarlyInitialization(). Now we need to post tasks earlier than that. This change starts the message loop when it being created on Android. For files: android_webview/browser/aw_browser_main_parts.cc, chrome/browser/chrome_browser_main_android.cc, chromecast/browser/cast_browser_main_parts.cc, components/cronet/android/cronet_library_loader.cc, content/shell/browser/shell_browser_main_parts.cc, remoting/client/chromoting_client_runtime.cc TBR=boliu@chromium.org,yfriedman@chromium.org,halliwell@chromium.org,kapishnikov@chromium.org,mkwst@chromium.org,garykac@chromium.org Bug: 848615, 729596 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b2a2afb570096cc56339978ef8e4ba3f3f9ecc7 Reviewed-on: https://chromium-review.googlesource.com/1112958 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573447}
-
David Black authored
Screen context requests are initiated and sent to the server when: - UI is shown (when not using stylus input modality). - Metalayer session is complete (when using stylus input modality). Still TODO: - Initially inactivate widget and activate after request callback runs. - Cache/show server response. Bug: b:111008970 Change-Id: Ibc2934be60bccc62e63a523384c2739a4ecfdabd Reviewed-on: https://chromium-review.googlesource.com/1129390 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1208cbb3ec07..7219d053d56a git log 1208cbb3ec07..7219d053d56a --date=short --no-merges --format='%ad %ae %s' 2018-07-09 saza@webrtc.org Split aec and aecm into separate build targets 2018-07-09 mbonadei@webrtc.org Removing /wd4703 from rtc_base:rtc_base_generic. 2018-07-09 brandtr@webrtc.org Add unit test for JavaToNativeVideoCodecInfo. 2018-07-09 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before RTCRtpTranceiver in ObjC 2018-07-09 brandtr@webrtc.org Support injecting custom native codecs from Java. 2018-07-09 sakal@webrtc.org Change test VideoProcessor kMaxBufferedInputFrames from 10 to 20. Created with: gclient setdep -r src/third_party/webrtc@7219d053d56a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e2b918edc020c2484e1dce31855a51cd601dd24 Reviewed-on: https://chromium-review.googlesource.com/1129339Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573445}
-
Michael Thiessen authored
Looks like some code that was commented as being for autopresentation wasn't actually for autopresentation :) Code was erroneously removed in https://chromium-review.googlesource.com/c/chromium/src/+/1127850 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieb871d92ed97f6df814d51f0a508f9b7d5b1456c Reviewed-on: https://chromium-review.googlesource.com/1129855Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#573444}
-
Erik Luo authored
Stepping multiple times within 1000ms while paused can result in multiple setTimeouts scheduled to clear the inline value previews. This may result in disappearing value previews. Also, we need to clear stale value widgets after generating new ones, to ensure that values are shown for the current scope only. This CL ensures there is only one 'clear' setTimeout at any time, and that we properly clear old ones before rendering new ones. Screenshot: https://imgur.com/a/rDnzGiv Bug: 844665 Change-Id: I86178a0d825ebae2820170d666b85f3b6d09a745 Reviewed-on: https://chromium-review.googlesource.com/1066708Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#573443}
-
Nicolas Pena authored
This CL makes PerformanceEntry::entryType() a pure virtual method instead of storing |entry_type_|. It also changes the usage from String to AtomicString. Only PerformanceEventTiming keeps |entry_type_| since it can be 'event' or 'firstInput'. Since the entry type is no longer available from the PerformanceEntry constructor, we change EntryTypeEnum() to pure virtual too. Bug: 852050 Change-Id: Ie02040b52cf17c7563667ef440bbb78ae97e64c7 Reviewed-on: https://chromium-review.googlesource.com/1113671 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#573442}
-
Fredrik Söderquist authored
This flag should be a copy of the same flag in an associated HitTestLocation. In all cases where it is used we have said HitTestLocation and can use the flag from there instead. The most complicated case - HitTestResult::ResolveRectBasedTest - will return a HitTestLocation with the flag cleared, which should mean that the state invariant is maintained. EventHandlingUtil::HitTestResultInFrame as changed to take a HitTestLocation to be able to maintain this invariant a little easier. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8b8d17a4fabca725ec089f18550523a19b677c75 Reviewed-on: https://chromium-review.googlesource.com/1127939 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573441}
-
Wenzhao Zang authored
Bug: 859232 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7a2e298b8c2bab9f8e67cfd3ae6f10f0b5768963 Reviewed-on: https://chromium-review.googlesource.com/1121422Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#573440}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee7c8c3f3769..245c7310a74e git log ee7c8c3f3769..245c7310a74e --date=short --no-merges --format='%ad %ae %s' 2018-07-09 thestig@chromium.org Roll third_party/freetype/src/ 125b84800..b532d7ce7 (64 commits) Created with: gclient setdep -r src/third_party/pdfium@245c7310a74e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78acf3fd21e79b2380262aff4a87d4755e35d54d Reviewed-on: https://chromium-review.googlesource.com/1129559Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573439}
-
Kenneth Russell authored
Allow jobs to run on both 10.12.6 and 10.13.5. Bug: 856799 Tbr: ynovikov@chromium.org Change-Id: Iaec9bd5229af369aec58ae44b9bef036210ba163 Reviewed-on: https://chromium-review.googlesource.com/1129539 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
