- 12 Aug, 2019 40 commits
-
-
Xiaohan Wang authored
This is useful for encrypted AV1 testing on platforms that doesn't not support component updated CDM (where codec support is read from CDM manifest). Bug: 953507 Change-Id: If43dc7d5fcbb8a8e69777831a9a3e52593f77ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747232Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686184}
-
Tommy Li authored
Flaking on Linux Debug: virtual/audio-service/media/controls/doubletap-to-jump-backwards.html Bug: 783154 Change-Id: I89bfdfdcf14f3af52142020c9fd1f76d4182622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747976Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca9e187dfaa7..f815301b1ad2 git log ca9e187dfaa7..f815301b1ad2 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 mtklein@google.com add GM for skbug.com/9331 2019-08-12 egdaniel@google.com For non-ccpr draws make sure all inputs to GrGPUCommandBuffer are long lived. 2019-08-12 halcanary@google.com gm: GMFactory returns a unique_ptr<> 2019-08-12 bsalomon@google.com Remove some uses of GrSurface::config() 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f815301b1ad2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ibfc239c0c22312dc0f0d5d0d2167e65fcd6aff47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686182}
-
Pete Williamson authored
Bug: 986504 Change-Id: I64ec4341235914687c9bc8ec2d7c8ce905e3ef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747378Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686181}
-
Mike Dougherty authored
This reverts commit 58978f33. Reason for revert: Breaks the following tests. It appears that the content is loaded beneath the top toolbar after this change landed: ExternalURLTestCase/testSearchByImageWith404Image ExternalURLTestCase/testSearchByImage See first failure at https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/3202 Original change's description: > [iOS] Update FullscreenWebStateListObserver logic. > > The FullscreenWebStateListObserver's WebStateList is reset to nullptr > when in the tab switcher, so it was missing changes to the active > WebState that occurs when switching tabs using the tab grid. This CL > updates SetWebStateList() to move the page content below the header if > the active WebState in the list has not previously been activated. > > Also in this CL: > - Decomposes repeated FullscreenWebStateListObserver logic. > - Sets the FullscreenController's WebStateList after updating broadcast > values in BVC so that the toolbar insets are correct when the content > is moved below the header. > > Bug: 992354 > Change-Id: I4ab9d2245ec662dcd167b5178d4abf2395889ed9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745809 > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Chris Lu <thegreenfrog@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685800} TBR=kkhorimoto@chromium.org,thegreenfrog@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992354 Change-Id: Ia41267619af9e257bff106b112796390070d43b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746710Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#686180}
-
Maksim Ivanov authored
According to the crbug, the implementation described in the browser_view_resizer.md doc was reverted a few years ago, and the crbug was WontFix'ed. Bug: 458 Change-Id: Ibd28339f1f4c57dbcbf379058ffa178c438352ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749962 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#686179}
-
Meilin Wang authored
This change modifies the thinking dots dimensions for embedded UI while keeps the spec unchanged for standalone. Bug: b/128914298. Test: manually test. Change-Id: Id9976d82c4446eb64ff34efa4020a2ee5d4f5b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731297 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686178}
-
Sophie Chang authored
Bug: 969558 Change-Id: Ia3d2240b8fb3444f1ed2f43c34a79caf6a9066ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747136Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686177}
-
Nicolás Peña Moreno authored
This change adds a map |background_image_timestamps_| of load timestamps of background images tracked by StyleFetchedImage, which are the background images with url. The map only tracks the load time, as |images_notified_| must still be used to track the background image paints. Otherwise we'd only report an entry per background image even when applied to multiple elements. This change also makes computations a bit more efficient by only calling base::TimeTicks::Now() on the first time we load an entry. It also fixes a problem of calling Set() in between usages of an iterator, which is not allowed. Before this change, the added test would crash due to this problem. Bug: 879270, 986891 Change-Id: I86640f5587f69f94e13c429f3e55b3d5d6978cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745497Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686176}
-
https://crrev.com/c/1715553Bo Cupp authored
Revert: https://crrev.com/c/1735548 Issue leading to revert: https://crbug.com/990672 The original change introduced use of uninitialized memory. This change adds the missing initialization. The update is limited to native_theme_base.cc which can be seen in patchset 2. TBR'ing the original reviewers except Elly (owner for the fix under native_theme). Bug: 987292 Change-Id: Ia091807203df5a17a240238dd4968dc031aa1476 TBR=chrishtr@chromium.org,masonfreed@chromium.org,haraken@chromium.org,tkent@chromium.org Change-Id: Ia091807203df5a17a240238dd4968dc031aa1476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747855Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Bo Cupp <pcupp@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686175}
-
Ben Kelly authored
Bug: 985379 Change-Id: I97fec3bf531e32ea8c8fc30693db59f22dee7a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746767Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44d77e47f726..6ef342fb6645 Created with: gclient setdep -r src-internal@6ef342fb6645 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I9836ea19d44598b476129bca580460415c620248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686173}
-
Chris Lu authored
If a currently active web state is replaced, the delegate of the InfobarBadgeTabHelper associated with the new web state needs to be set. Bug: 976901 Change-Id: I7a564c3c38628ad1700cae372a14c26f700bdd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747383 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686172}
-
Jared Saul authored
This is a followup CL to add tests for https://chromium-review.googlesource.com/c/chromium/src/+/1676674 which is being requested for merge. Bug: 978514 Change-Id: Id6b8bc88454f27f9e1ca584f27b4e04e3894f325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676831 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686171}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef773214..4b56460d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic661924f99174a5b21215ac3f0e0903b7cb67b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749623Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686170}
-
Matthew Cary authored
This change wraps the FD-based protected buffers in a base::subtle::PlatformSharedMemoryRegion rather than the legacy SharedMemoryHandle. Aside from a couple of new validation checks, functionality is unchanged. Bug: 849207 Change-Id: I2df619dc58c6313393e41eef7e4807edf340875e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697183 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686169}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I3cf54a38e569cb109d8465fed57c6bc2788e4152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747860 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#686168}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I14a63161ad7c37da12d6c2ed79e18e10c0dac6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749742Reviewed-by:
-
Henrik Grunell authored
Enables features AudioServiceOutOfProcess and AudioServiceOutOfProcessKillAtHang by default on Mac. Also * Fixes audio process study names for Win and Linux in field trial config. * Sets default audio service teardown to 15 minutes on all platforms since it has been launched on all platforms (corrects a miss in some of the previous launches). This change is similar to the previous launch for Linux: https://chromium-review.googlesource.com/c/chromium/src/+/1648499 Bug: 974450 Change-Id: I6aae36d0635266187cee2081c1105a7b323aa244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745992Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/36eb20a7aba8..aba68fe5a5cc git log 36eb20a7aba8..aba68fe5a5cc --date=short --no-merges --format='%ad %ae %s' 2019-08-12 cjmcdonald@chromium.org parallel_emerge_old: Set both SYSROOT and ROOT via --board arg Created with: gclient setdep -r src/third_party/chromite@aba68fe5a5cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibaa6f0213629c87cb79f3dc6c9636d0db0235ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749605Reviewed-by:
-
Josh Nohle authored
Adds metrics to track the result--success, failure, timeout--of async function calls during the CryptAuth v2 Enrollment flow. Bug: 899080, 936273 Change-Id: Id60e1025e012e04b5bc8d984559a313fa0aedff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
ProfileManager doesn't need its own boolean tracking whether all browsers are being shut down as it can just check browser_shutdown::IsTryingToQuit(). Thus it doesn't need to listen to NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and NOTIFICATION_BROWSER_CLOSE_CANCELLED. It also doesn't need to save the active profiles when those notifications are sent out because saving the profiles when a browser is opened or closed should be sufficient. Bug: 268984 Change-Id: I2a81be1c1f04440ee4e8fc05375742d52cac9169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730191Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686163}
-
Robert Ogden authored
Bug: 969163 Change-Id: I3e437c9927a339a5d5fe5be68e8d057434d893c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748081Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#686162}
-
Hector Carmona authored
Refactored how the toolbar shows toast to avoid having two toasts. Also noticed bug in cr-toast-manager that would try to announce an element instead of its textContent. Bug: 27175 Change-Id: I1128106498f159242c5e0011d5e879641cf863fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740652Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#686161}
-
Andrew Grieve authored
Wasn't quite unused - but was used only for Android Studio's layout previewer. I don't know of a good way to have non-shipped resources, so deleting is probably the best option for now. Bug: 988047 Change-Id: Ic002ed2cbf2408100b70110436c01a9922a0fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749705 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686160}
-
Adrian Taylor authored
Also, pointing at a chromium.org copy of the source document which is accessible outside Google without individual access requests. Change-Id: I4caef90f2a77127173251d014adef4b6f72be801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747790 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#686159}
-
Kristyn Hamasaki authored
Adds test coverage for toggling bubble locking and debug rectangles, and sources. Change-Id: Id03f45888467a8791c113dece1d4648db88e41a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747147 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#686158}
-
Sammie Quon authored
Test: manual Bug: 991933 Change-Id: I0215fc86997fe17f07fec11263f358b9b3cf756c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743877Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686157}
-
behdad authored
Values used in this patch are the 99 percentile of the last 200 perf results of runs of GPU fyi bots. https://docs.google.com/spreadsheets/d/1vYnVrG0QnBl5_zQ9fVuzYW80xPhIGsXowOMiNtn0DGc/edit?usp=sharing Bug: chromium:982769 Change-Id: Iad3c2bd99714f9ffb9eae11619b5447c9d40809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748793Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686156}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31fc760897f7..c90cf387b1a9 git log 31fc760897f7..c90cf387b1a9 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 tsepez@chromium.org Remove unused cpdf_formcontrol.h from cpwl_wnd.h. 2019-08-12 thestig@chromium.org Remove unused CPDF_CMapManager* parameters. 2019-08-12 tsepez@chromium.org Remove some spurious includes from fpdfsdk/cpdfsdk_interactiveform.cpp 2019-08-12 tsepez@chromium.org Fix some IWYU of cba_fontmap.h in cffl layer. 2019-08-12 tsepez@chromium.org Replace FWL timer infrastructure with CFX_Timer. Created with: gclient setdep -r src/third_party/pdfium@c90cf387b1a9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iffa83c9cf398de23d2b54ebc53a5814cdcb62251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749478Reviewed-by:
-
Roger Tawa authored
WebRtcVideoDisplayPerfBrowserTests/WebRtcVideoDisplayPerfBrowserTest.MANUAL_TestVideoDisplayPerfH264/2 WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp9/0 Bug: 993020 Change-Id: Ica9095a50096f9b7667e8d4f7774ed249460537b TBR: tommicli@chromuim.org, hbos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749626Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686154}
-
Ella Ge authored
This reverts commit b24859d8. Reason for revert: fixing the test and reland Original change's description: > Revert "Make touchevent timestamp update on every non Stationary touch points" > > This reverts commit 2131ec3a. > > Reason for revert: Seems to have broken WebKit Linux Leak build. > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2981 > > Original change's description: > > Make touchevent timestamp update on every non Stationary touch points > > > > Touch event's timestamp is set from the |first_touch_pointer_event|'s > > timestamp. But in the case that this touch point is not changing but > > the others changed, this timestamp is not the latest pointerevent's > > timestamp. > > This CL changes it to use the the latest timestamp of the pointerevents > > in |touch_attribute_map|. > > > > Bug: 973545 > > Change-Id: I08be3f58e886f40eca17d515b36ec3a6424a38ef > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705051 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#685612} > > TBR=bokan@chromium.org,nzolghadr@chromium.org,eirage@chromium.org > > Change-Id: Id5a4657d566006597c9b6db06e3736240899e8ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 973545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746789 > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685638} TBR=bokan@chromium.org,sclittle@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973545 Change-Id: Ia6ba0e493f8f0c495c462c2dbe5cdf4cdfa50171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747736Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#686153}
-
Khushal authored
This reverts commit 677de3b2. Reason for revert: Investigation done. Original change's description: > Revert "viz: Defer BeginFrame throttling everywhere." > > This reverts commit 86f28deb. > > Reason for revert: Temporary revert to confirm this is responsible for crbug.com/982863 > > Original change's description: > > viz: Defer BeginFrame throttling everywhere. > > > > The initial change [1] restricted the delay in BeginFrame throttling to > > SurfaceControl to allow the change to be merged to M76. But this > > throttling policy is better in general so enable it everywhere. > > > > [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1675464 > > R=ericrk@chromium.org > > > > Bug: 973703 > > Change-Id: Ia26c23786b1e827fa22126c06a474fca65d20280 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684216 > > Auto-Submit: Khushal <khushalsagar@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Reviewed-by: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#673856} > > TBR=khushalsagar@chromium.org,ericrk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 973703,982863 > Change-Id: I3a042f8f2bdc721c0c5a20472156679d373a7bbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740731 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684647} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973703, 982863, 991855 Change-Id: I3d16236e4d7199fe2080200d897dd6c1bfb4f24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748082Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686152}
-
Maksim Ivanov authored
This CL builds the missing integration between the C++ code (starting from the handler of the PIN requests made by extensions) and the JavaScript code on the SAML sign-in page: * dynamically enabling/disabling this UI when the SAML sign-in begins/ends; * sending the PIN request parameters from C++ to JS; * replying with the entered PIN from JS to C++. The proper error displaying and other UI improvements will be done in follow-up CLs. Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, check that the PIN dialog appears on top of the SAML page, enter the smart card PIN, check that the login completes Change-Id: I95c2d5e5110a967ca6b7d8f957bbc8422f62d758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742233Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686151}
-
Chris Lu authored
Bug: 976901 Change-Id: I0751d935e2aa0307bd354b888e78408810d1f195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746601 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#686150}
-
Virender Singh authored
Accessibility actions like scroll and click are not forwarded to plugin. In this CL we create a pipeline between mimehandler and plugin process to pass accessibility actions. This will enable plugins to receive and handle actions. This CL focuses on enabling just kScrollToMakeVisible for PDF. This pipeline can be extended to handle other Accessibility actions. Note: RenderAccessibilityImpl::ScrollPlugin method is removed because of three reasons - It was not used by anyone at this moment. - It does not give correct scroll behavior because it is only able to scroll an embed tag in view port. However, we require scrolling within the Plugin content. - The action handling pipeline being introduced here is different from the HTML path ScrollPlugin uses to scroll. Bug: 769940 Change-Id: I6f04467e2798c4a60ae08329b271480134427f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692574 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686149}
-
Wez authored
Add bug numbers in TODO comments, for easier tracking. Bug: 953958 Change-Id: Ia6a40836aa06339af0651851fea7c993ab194d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747803 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686148}
-
Sammie Quon authored
On entering overview, windows that are stacked above the snapped window need to stacked underneath, otherwise when we scroll it will scroll over it. Also changed the aspect ratio maintaining codes to account for the overview margin and overview header. Test: manual, added test Bug: 981188 Change-Id: I99c368d5ab50931a1eabe7bc70bf8a5b738c2bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747027 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686147}
-
Cammie Smith Barnes authored
We walk up the render frame tree via RenderFrameHostImpl::GetParent() and then use GetLastCommittedOrigin() of the frame tree's root as top-frame origin for the network isolation key. This change is to address a potential race condition where the root frame tree node may have been now associated with a different document. Bug: 986167 Change-Id: I9196f70939f82c6c9ac62d5828329688db97bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741644 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#686146}
-
Tommy Li authored
This reverts commit 116a3030. Reason for revert: Failures here: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/28076 Original change's description: > Adding metric to track the source of empty automatic setup events > > In order to track down the root cause of https://crbug.com/964120 this > metric is being added. In this case we're concerned with printers > somehow being configured with a PPD while not having any make and model > information filled in. If an automatic setup meets this "empty" > criteria, then we track from which of the following 4 possible sources > it may have come from: > > 1. Print Preview > 2. Printer Settings > 3. Arc Print Service > 4. Automatic USB Printer Configurer > > BUG=chromium:964120 > TEST=None > > Change-Id: If49d58663f254b726ede57754f8dbc4a17793de4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732029 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Commit-Queue: David Valleau <valleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686078} TBR=stevenjb@chromium.org,bcwhite@chromium.org,skau@chromium.org,valleau@chromium.org Change-Id: I397d417239094941fc006c6485ad3b6b1804908b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:964120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749729Reviewed-by:
-
