GitLab

This test (for unknown reasons) depends on the frame being visible and
currently only passes because of an artificial delay in the compositor when
going invisible. This is probably way it is already disabled on Mac and
Windows.

The patch at http://crrev.com/1051123002 removes this delay causing this test
to become extremely flaky. See http://crbug.com/282116

BUG=282116
R=lazyboy,fsamuel

Review URL: https://codereview.chromium.org/1069803003

Cr-Commit-Position: refs/heads/master@{#324387}

BUG=455366
TBR=mmenke@chromium.org,gunsch@chromium.org

Review URL: https://codereview.chromium.org/1070893002

Cr-Commit-Position: refs/heads/master@{#324386}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a6ad902..7557b3f

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1071763004

Cr-Commit-Position: refs/heads/master@{#324385}

This adds tests for a search in Downloads. It first performs a basic search,
it then checks that the search is case-insensitive and performs a search that
should match no files and checks the correct error string is displayed.

TEST=browser_tests --gtest_filter="*FileDisplay/FileManagerBrowserTest/{4,5,6}*"
BUG=None

Review URL: https://codereview.chromium.org/1067983002

Cr-Commit-Position: refs/heads/master@{#324384}

When becoming invisible we are going to abort any pending draw / activate. We
should do that right now rather then waking up sometime in the future and doing
it. This increases the speed at which we become idle after going invisible.

A minor side effect is we will do more work if we become invisible and then
visible within a single frame, but this case is extremely unlikely while the
case compared to becoming invisible for a longer period.

Related to http://crrev.com/1050833002

BUG=371747
R=brianderson,jdduke

Committed: https://crrev.com/c7c617b8619518568d2267015a5ee32aed7df883
Cr-Commit-Position: refs/heads/master@{#323397}

Review URL: https://codereview.chromium.org/1051123002

Cr-Commit-Position: refs/heads/master@{#324383}

zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread only

Add many thread check to clarify it.

BUG=473125

Review URL: https://codereview.chromium.org/1050923003

Cr-Commit-Position: refs/heads/master@{#324382}

Change the name and move it to a more generic place so that it can be used
by ChromeMobileApplication.

BUG=428860

Review URL: https://codereview.chromium.org/1063033002

Cr-Commit-Position: refs/heads/master@{#324381}

This CL refactors VideoCaptureBufferPool, and in
particular its inner class Buffer, to allow pooling
GpuMemoryBuffers. For that, Buffer is renamed to
Tracker, and turned into a base class, where SharedMemory
specifics are implemented in SharedMemoryTracker.

In ToT, VideoCaptureDeviceClient calculates the
linear size in bytes needed for holding the captured
VideoFrame. This responsability is shifted into the
VCBPool, so in the inmediate future, GpuMemoryBuffers
can be allocated. To support this, VCBP::ReserveForProducer()
gets the pixel format and dimensions.

VideoCaptureDevice::Client::ReserveOutputBuffer()
goes through the same parameter upgrade.

(In the next CL, a GpuMemoryBufferTracker class
is introduced, allowing VCBP::ReserveForProducer()
will allocate GMBs if so instructed via the pixel
format.)

BUG=440843

Review URL: https://codereview.chromium.org/1064703002

Cr-Commit-Position: refs/heads/master@{#324380}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b06aa90..a6ad902

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1073703002

Cr-Commit-Position: refs/heads/master@{#324379}

Tested on Linux with the following command lines:

$ rm -rf out/
$ ./build/gyp_chromium
$ ninja -C out/Debug sandbox_linux_unittests
$ out/Debug/sandbox_linux_unittests

BUG=138542
TEST=see above
R=jln@chromium.org,mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1062223002

Cr-Commit-Position: refs/heads/master@{#324378}

Stop the daemon process from repeatedly starting up and shutting down the network process when the host has been unregistered.

We have two bugs in the chromoting host that caused the repeated startup and shutdown of the network process when the host has be unregistered:
1. The host process never exits naturally. As a result, the WorkerProcessLauncher in the daemon process never receives the exit code and thus isn't aware that a "permanent" error occured.
2. If a host has service account enabled, it gets kInvalidOauthCredentialsExitCode instead of kInvalidHostIdExitCode if the host has been unregistered in the service directory. But we only disable the service upon the latter.

Issue 1 is a regression from https://codereview.chromium.org/891663005 which added a dangling reference to the UrlRequestContextGetterin HostProcessMain. This leaked object will also keep the Network task runner, and thus the UI task runner alive. So the message loop in HostProcessMain never quits.

I created crbug.com/475213 to track the original DCHECK.

BUG=472884

Review URL: https://codereview.chromium.org/1061903002

Cr-Commit-Position: refs/heads/master@{#324377}

This currently breaks at runtime both cast_shell and cast_shell_apk
and I wasn't able to find an easy fix. I'd like to unblock our other development in the meantime.

Half-revert of https://codereview.chromium.org/1019123002/

TBR=jochen@chromium.org
R=rmcilroy@chromium.org,lcwu@chromium.org
BUG=421063

Review URL: https://codereview.chromium.org/1073583004

Cr-Commit-Position: refs/heads/master@{#324376}

- DRP NetworkDelegate/BypassStats are no longer aware of the UI thread.
- Add thread hopping functionality to DRP IOData/Service, using the
  correct WeakPtr to post tasks safely.
- Construct BypassStats in the IOData constructor.

BUG=472290

Review URL: https://codereview.chromium.org/1054363002

Cr-Commit-Position: refs/heads/master@{#324375}

BUG=469409
TEST=Test on Nyan, which has both H.264 and VP8 HW encoder.
     It should choose VP8 instead of H.264.

Review URL: https://codereview.chromium.org/1034433002

Cr-Commit-Position: refs/heads/master@{#324374}

BUG=474876

Review URL: https://codereview.chromium.org/1064393002

Cr-Commit-Position: refs/heads/master@{#324373}

Both cmake310_Linux.tgz and cmake310_Darwin.tgz exist now.
I'll remove the poorly named cmake310.tgz when this has landed.

BUG=452726

Review URL: https://codereview.chromium.org/1073673002

Cr-Commit-Position: refs/heads/master@{#324372}

The header is included for __NR_SYSCALL_BASE and __ARM_NR_BASE.
Some toolchain (in particular, PNaCl toolchain) does not provide
asm/unistd.h (so that neither __NR_SYSCALL_BASE nor __ARM_NR_BASE
is provided).
This CL removes the dependency to asm/unistd.h from linux_syscall_ranges.h,
instead define the values if necessary.

Also, this CL removes the include from syscall.cc, too, which is
unused.

TEST=Ran bots.
BUG=358465

Review URL: https://codereview.chromium.org/1071653002

Cr-Commit-Position: refs/heads/master@{#324371}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a0219f1..35f5576

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1068243004

Cr-Commit-Position: refs/heads/master@{#324370}

This is safe to do because the custom action is only executed if the startup type was already auto at the beginning of the installation.

BUG=472887

Review URL: https://codereview.chromium.org/1071013002

Cr-Commit-Position: refs/heads/master@{#324369}

BUG=473077

Review URL: https://codereview.chromium.org/1072643002

Cr-Commit-Position: refs/heads/master@{#324368}

BUG=474701

Review URL: https://codereview.chromium.org/1078523002

Cr-Commit-Position: refs/heads/master@{#324367}

This is a retry CL for https://codereview.chromium.org/1024583003/ with
a slight change.

UserActivityDetector used to be an EventHandler triggered when the pre-
target event handlers are triggered. When a menu is present, the
MenuEventDispatcher doesn't trigger pre-target handlers and hence user
activity is not detected.
With this change the UserActivityDetector is made a PlatformEventObserver
to make sure it's always triggered.

R=sadrul@chromium.org, jamescook@chromium.org
BUG=462735
TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.*

Review URL: https://codereview.chromium.org/1074543002

Cr-Commit-Position: refs/heads/master@{#324366}

sql::Connection::Delete() covers associated journal files.

BUG=none

Review URL: https://codereview.chromium.org/1064523002

Cr-Commit-Position: refs/heads/master@{#324365}

Symlinks aren't very common on Windows anyway.

BUG=467287

Review URL: https://codereview.chromium.org/1069853004

Cr-Commit-Position: refs/heads/master@{#324364}

Note: You can still launch and test using either --force-immersive command line or by pressing Shift+F11 magic key just after launching chrome through shortcut.

BUG=470227
R=cpu,ananta

Review URL: https://codereview.chromium.org/1015533014

Cr-Commit-Position: refs/heads/master@{#324363}

current NO_RESOURCE_IDENTIFIER usage is aganinst style guidelines.
Made a class in content_settings.h and using function to get std::string()
To get rid of NO_RESOURCE_IDENTIFIER.
Now no need to add content_settings_provider.h in places like
desktop_notification_profile_util.cc and other places.

BUG=399592

Review URL: https://codereview.chromium.org/1034143002

Cr-Commit-Position: refs/heads/master@{#324362}

Running this example is consistently failing under host mac
build and occasionally failing on linux as well.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
BUG=475255

Review URL: https://codereview.chromium.org/1076573004

Cr-Commit-Position: refs/heads/master@{#324361}

Refactored web_app::ShortcutInfo so it is always passed via a scoped_ptr
(always having exactly one owner). This allows it to be safely passed
between threads without having a data race on the favicon image's
reference count.

Removed TSan suppression on ImageFamily.

BUG=364006

Review URL: https://codereview.chromium.org/1038573002

Cr-Commit-Position: refs/heads/master@{#324360}

HSTS/HPKP headers should only be parsed when the host is not an IP
address. This change requires fixing the HSTS/HPKP tests to use
localhost test server URLs instead of 127.0.0.1, with a corresponding
cert.

BUG=456712

Committed: https://crrev.com/8488b5886ccec4820578905acd42f95cf42f5b17
Cr-Commit-Position: refs/heads/master@{#323913}

Review URL: https://codereview.chromium.org/1059303002

Cr-Commit-Position: refs/heads/master@{#324359}

The metrics don't have much to do with prerender. Move them out into a
dedicated file.

BUG=none

Review URL: https://codereview.chromium.org/1051463003

Cr-Commit-Position: refs/heads/master@{#324358}

The java ViewAndroid class was only surving two purposes:

1) Implement content::PowerSaveBlocker with anchor views.
This is only used from content, and is mostly implemented
in content already, so just move the entire implementation
to content PowerSaveBlocker without going through a ui
layer interface.

2) Hold the ViewAndroidDelegate. Just have the native class
hold this object directly instead.

Other required changes:
* Updated to one anchor view per PowerSaveBlocker instead
  one per ContentViewCore and keeping a count.
* PowerSaveBlockerImpl::Delegate is made a
  WebContentsObserver to observer WebContents destruction.
* Removed an instrumentation test that's no longer
  relevant.

BUG=469803

Review URL: https://codereview.chromium.org/1041823004

Cr-Commit-Position: refs/heads/master@{#324357}

In  "cc: Only send a BeginMainFrame inside an BeginImplFrame."
https://codereview.chromium.org/798323003/ a commit can only occur inside an
impl frame - this means BeginFrames are *needed* if we want to commit.

We also want to proactively request BeginFrames if a commit is pending (for
performance), but it is not actually required.

BUG=346230

Review URL: https://codereview.chromium.org/792803008

Cr-Commit-Position: refs/heads/master@{#324356}

BUG=101717

Review URL: https://codereview.chromium.org/1066203003

Cr-Commit-Position: refs/heads/master@{#324355}

Currently, remoting.Clipboard is exposed as a global, such that it can hook
events across different files, e.g. remoting.js, client_plugin_impl.js, application.js

This CL moves clean up the file by:
1. Only create an instance of the clipboard when a session is connected.  This removes
   the startSession() method on the clipboard.
2. Hook all events (copy/paste/focus changes) from within remoting.clipboard, which
   eliminates the need to have a global and effectively makes all its methods private.
3. Style cleanups, use single quotes for strings, make sure private variables are
   post-fixed with underscores.

BUG=475317

Review URL: https://codereview.chromium.org/1078563002

Cr-Commit-Position: refs/heads/master@{#324354}

ShowSigninScreenForCreds is used to automatically fill-in sign-in
forms and submit it. WebviewLoginTest.Basic does that manually
thus should not call it. Otherwise, /_/embedded/signin/challenge
is called multiple times with wrong email (empty) and could trigger
FakeGaia failures.

BUG=472095

Review URL: https://codereview.chromium.org/1069423004

Cr-Commit-Position: refs/heads/master@{#324353}

BUG=441441
TEST=build/android/test_runner.py gtest -s components_unittests --gtest_filter=HistogramManager*

Review URL: https://codereview.chromium.org/1075503002

Cr-Commit-Position: refs/heads/master@{#324352}

Discrete layouts will have a matching channel layout, but may have
any number of channels. We were incorrectly skipping the channel
mixer setup based only on layout.

BUG=473688
TEST=new unittest.

Review URL: https://codereview.chromium.org/1070923002

Cr-Commit-Position: refs/heads/master@{#324351}

BUG=456354

Review URL: https://codereview.chromium.org/1068933003

Cr-Commit-Position: refs/heads/master@{#324350}

Ensure that the Windows system font information and the scrollbar metrics are synced with the ViewMsg_SetRendererPrefs IPC

The patch to sync the font and scrollbar metrics from the browser to the renderer was sending these values only during
RenderView creation and not along with the ViewMsg_SetRendererPrefs IPC which caused scrollbars to disappear and other bad
things.

BUG=474871

Review URL: https://codereview.chromium.org/1069683006

Cr-Commit-Position: refs/heads/master@{#324349}

Also reenabled appcontainer for renderer and fixed policy use after free case.

BUG=468922,473715
R=cpu,jschuh@chromium.org, wfh

Review URL: https://codereview.chromium.org/1058373003

Cr-Commit-Position: refs/heads/master@{#324348}