- 10 Mar, 2020 40 commits
-
-
Ken Rockot authored
This is a reland of aa7438aa Unmodified from the original CL, as breakage was from a precursor that has since been fixed and relanded. Original change's description: > Convert some mojo_base typemaps to GN targets > > Uses new GN-based typemap definitions to replace some typemap files in > mojo/public/cpp/base. > > Bug: 1059389 > Change-Id: If1389c9ceec8ae90df753895af0abd9f72c704a0 > Tbr: dtapuska@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090723 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#748056} Bug: 1059389 Change-Id: I5bbe5afff09493b3394f8922c3fe190e731305b7 Tbr: dcheng@chromium.org Tbr: tsepez@chromium.org Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095929Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#748569}
-
Mitsuru Oshima authored
This is a speculative fix for crbug.com/1041932 Bug: 1041932 Change-Id: I0dfe7479967729dc242f32eba4772107fcc3f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093073 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748568}
-
Abhijeet Singh authored
Add a user-consent view informing the users about the Quick-Answers functionality. The quick-answers will only be enabled if the user grants her consent by acknowledging this view. The view will be shown to the users a maximum of 3 times or until an accumulated of 8 seconds it is impressed. Bug: b:148956341 Test: Tested locally on atlas device Change-Id: I46d0cfd5d82ced03ef610ab8624b909fa1403223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077589 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748567}
-
Hirokazu Honda authored
Unless this is specified, pre-submit checks warns the test-only code is used in product code. Bug: None Test: Build tests Change-Id: I9dac62a4a5079a46a12e9e8e716bd33449f17610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094521 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#748566}
-
Sven Zheng authored
This should reduce the flakiness. Deactivated dialog pixel outputs should be more predictable than activated dialog. https://chrome-gold.skia.org/detail?test=BrowserUiDialog_TabGroupEditorBubbleViewDialogBrowserTest_InvokeUi_default&digest=45c8d0767462989beefdc816a729c3ad https://chrome-gold.skia.org/detail?test=BrowserUiDialog_TabGroupEditorBubbleViewDialogBrowserTest_InvokeUi_default&digest=f0f4b37daa5fc41c5481163af8fc079e Bug: 1059469 Change-Id: I1f7ebe20b4c58d4ba7481e4bcba9b177b205b91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095769 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#748565}
-
sczs authored
Bug: 1029067 Change-Id: I4fdd0da6e1294bd8057e4f47afa446caa05d9a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093133 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748564}
-
Jeremy Roman authored
Bug: 794320 Change-Id: If5776962746a12481fd89426f5e13a3ab6b79214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095779Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748563}
-
Bo Liu authored
Currently WebContents visibility is only dependent on whether it is the active tab in a browser. This means the active tab will always be marked visible, even if the fragment or activity is hidden. Instead compute visibility has being the active tab in a visible (ie onStart-ed) fragment. Override Fragment.onStart/onStop, and keep the state in BrowserImpl. Keep the active state in TabImpl. When either changes, recompute visibility for the tab's WebContents. Bug: 1058510 Change-Id: I726144afee2a28f97cf0d9d2ecf6f1d028973c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094455Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748562}
-
Toni Barzic authored
Oobe dialog elements have show() method that focuses the default element in the dialog, and updates the dialog scroll. Use it in gesture navigation dialog to show pages (which are oobe dialogs). This fixes the issue where the scroll background is show on the intro page (as the scroll is calculated using obsolete bounds). Upadating scroll also made the animation pages scrollable, so this tweaks the animation positioning in the screen. While here, mark next buttons with focus-on-show class, so they get focused when a screen page is shown. BUG=1058885 Change-Id: I23c44cb03afd713c35aa0a83f9fc59081a8a7b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092948 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#748561}
-
Olivier Yiptong authored
Implements the enumeration of system fonts on Mac. This change calls the CoreText APIs to enumerate the list of fonts installed on a system. It has been implemented in FontCache so that it is accessible in the renderer process due to concerns about expensive I/O if implemented browser-side. Caching code will come in a subsequent CL. Bug: 1043306 Change-Id: Iae9ce6c08174d8b4ced80eda07c795444998c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091597 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748560}
-
Xinghui Lu authored
The flags were used for launches on Android in M79. They were set to enable by default in M81. They will be removed in this CL in M82. Bug: 995926 Change-Id: I8035064bafd38e3eb239c345e5cde0c5074a6402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095703Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748559}
-
Sophie Chang authored
Bug: 1056843 Change-Id: Ic8667c5ae2921a2b0743fa2a2f31109fce444b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079859 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748558}
-
Pavel Yatsuk authored
InfoBar provides an accessor method to get to SnackbarManager. TranslateCompactInfoBar is the only infobar that uses this method. Having this method means that InfoBar needs to know how to get to SnackbarManager instance. Modularized InfoBar shouldn't have access to ChromeActivity. This CL removes InfoBar dependency on SnackbarManager and makes obtaining reference to SnackbarManager a responsibility of the calling component (in this case TranslateCompactInfoBar). BUG=1056346 R=mdjones@chromium.org Change-Id: I33f366ed49dfd6ad51c406a7a6d0e8ffea056d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095708Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#748557}
-
Keita Suzuki authored
This commit updates blink web_tests to use pywebsocket3. It updates blinkpy/server/pywebsocket to import pywebsocket3 for its path. This commit also fixes the websocket handlers in web_tests. It update the handlers to use pywebsocket3 functions instead of old ones, and also updates the websocket handlers that use chr() to generate bytes string, to use util.pack_byte(), since chr() does not generate bytes in python 3. Change-Id: I2fbc365571b2ca0ee947355a2f95700350675fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059705Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#748556}
-
Anand K. Mistry authored
Call with super.handleClick() instead to follow the class prototype chain. Bug: 1060061 Change-Id: Ib63980978124b62a7a6201f7737b8eda27b1e925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094851Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748555}
-
Peng Huang authored
With this CL, SkiaOutputSurfaceImpl will create SkSurfaceCharazation on viz thread directlly instead of ask gpu thread to create it for us. But for WebView, we still need to ask GPU thread to get necessary info, so we can create SkSurfaceCharazation on viz thread. Bug: 1041949 Change-Id: Id6bb23e63d5191b67b446a8f843ca06c1e63b18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088343 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Theresa Wellington authored
Patchset 1 of 3 to introduce new target and switch upstream dependencies. Patchset 2 will update downstream build targets. Patchset 3 will remove the old //chrome/lib/ directory. BUG=1052382 Change-Id: Ia17859f630003eded43ee1b928e8ddc2ab22814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095444Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#748553}
-
Jared Saul authored
This CL cleans up AutofillUpstreamEditableCardholderName and AutofillUpstreamAlwaysRequestCardholderName now that the cardholder name fix flow is fully launched to all platforms, including iOS. Bug: 907355 Change-Id: I201c9a29104b369b90fcc25cf9fcaa5f0f45e265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095921Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#748552}
-
Domenic Denicola authored
This plumbs the origin policy IDs from the net-side OriginPolicyContents through to the renderer, where they get exposed on Window. This does not yet tackle WorkerGlobalScope, but it does add idlharness tests for it, which fail for now. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2089994 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2093453. The re-land adds MSAN test expectations per https://crbug.com/856601. Bug: 1057123 Change-Id: I30053986f3dfc634399c8e0f3fc1578e062c67f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095706 Auto-Submit: Domenic Denicola <domenic@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748551}
-
Nicolás Peña Moreno authored
This CL allows LCP to use the first input or scroll on the page to invalidate LCP values from any frame. Doc describing the logic: https://docs.google.com/document/d/1uOLW-uAZwvBLrH5ST0OgdAJMmqY37MqBJEZRzTBKgp4/edit Bug: 1050727 Change-Id: Id9ad7c06750af110d6b7f3eec8637a9615f270b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083861Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748550}
-
Tal Pressman authored
1. Introduce HeapMojoUniqueReceiverSet and unit test (based on HeapMojoReceiverSet). 2. Change usages of mojo::{Remote, UniqueReceiverSet} to HeapMojo{Remote, UniqueReceiverSet}. Bug: 1049056 Change-Id: I821aebfb6bd48082543dce0e2d224ebc6e31bb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079721 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748549}
-
Will Harris authored
BUG=767906 Change-Id: If0c7c542cb19c5997be1d417a9e4df24c170ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095964Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748548}
-
Kent Tamura authored
Add two functions for the beginning and the end of TruncateLine(). These functions will be used by 'middle-ellipsis' feature. This CL has no behavior changes. Bug: 1060022 Change-Id: I87146ccad6637f18f297066cfb67e49abfccdfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094919Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#748547}
-
John Lee authored
Bug: 1027373 Change-Id: I68f544db08731ec3c02213258dc0709589c27292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095559Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748546}
-
Jeevan Shikaram authored
This reverts commit b5046a36. Reason for revert: system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:tech:discourse_infinite_scroll:2018 is failing. Original change's description: > Changed infinite iterations's representation from -1 to infinity(). > > In blink we use -1 to represent infinite iterations for historical > reasons. Rather, we should use std::numeric_limits<double>::infinity() > to be more specification-complaint. > > CL based on crrev.com/c/1373409. > > Bug: 913662 > Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Annie Liu <t-hunliu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#748383} TBR=vollick@chromium.org,majidvp@chromium.org,yigu@chromium.org,dlibby@microsoft.com,t-hunliu@microsoft.com Change-Id: Ic85093b6bb9f0d15a45cf65dbefa410e66b43346 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094489Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#748545}
-
Martin Kreichgauer authored
The IsUserVerifyingPlatformAuthenticator() WebAuthn API call needlessly required the content embedder to provide their own implementation in an AuthenticatorRequestClientDelegate specialization. This change moves the ChromeAuthenticatorRequestDelegate implementation into the content layer (AuthenticatorCommon). The implementation is general enough to be useful for other embedders and it doesn't depend on any state internal to the delegate. Concretly, IsUVPAA() - on Windows returns the corresponding value from the native WebAuthn API; - on macOS reflects TouchIdAuthenticator availability as long as the embedder provides an implementation of GetTouchIdAuthenticatorConfig. Also collapse methods in AuthenticatorCommon that determine which transports to instantiate discoveries for, and also add a safeguard against instantiating platform discoveries in contexts where IsUVPAA() returns false. Change-Id: I8eb68ca6f8cd17fae61d9d0294b872ef0cfb3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083936 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748544}
-
David Munro authored
Test: None Bug: None Change-Id: Ia7cd6efe90968e06c0a4a96f7e2104e05ee9e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091091 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#748543}
-
Victor Costan authored
Replacing includes with forward declarations helps reduce compilation time. To be clear, I doubt that the CQ time burnt by this CL will ever be recovered by the tiny savings in compilation time over all future Chromium builds. However, I point folks building new APIs to the Cookie Store API as an example of reasonably modern code, so I think there's value in getting the details right. Change-Id: I00ff2885b331bdd23fac392372e127c2e3817896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093398 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#748542}
-
Shakti Sahu authored
Bug: 1054552 Change-Id: I7fc3d29498aec9a429e792145f865f0e6898d542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090606 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cdb673f91738..3e017d50fe09 Created with: gclient setdep -r src-internal@3e017d50fe09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1052460,chromium:1054944 Tbr: jbudorick@google.com Change-Id: I4adc846c99b94e127e2ee6ab66970463796d7e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748540}
-
Callistus authored
- For some of the flags, I've extended HelpAppUIDelegate to contain logic that depends on code in "chrome/". - Moved existing code to obtain board name, customization id and version to HelpAppUIDelegate. Bug: b/140150028 Change-Id: Ie2cbbdacf84692724a69c2b106f703ceadeb7a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073438 Commit-Queue: Callistus Tan <callistus@google.com> Auto-Submit: Callistus Tan <callistus@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#748539}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/34d7ff92..a0a3e1a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5becd8addba186eac8f4631faf1ca7a5f01d523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095901Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748538}
-
Jeevan Shikaram authored
Flaky on Mac 10.11, 10.12, 10.14 TBR=ellyjones@chromium.org Bug: 1060063 Change-Id: I79f7ef374d582b8c585a663ed71cc99a1530db9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094487Reviewed-by:
-
Long Cheng authored
1. Move html out of string resources 2. polymer binding for UI properties most elements. 3. polymer binding for learn more callbacks 4. Move onNext/overlays to arc_terms_of_service for future reuse for in session opt-in extension. 5. Use multiple popup overlays with multiple <p> to support overlay text with multiple paragragh. 6. Remove skip button as it's no more supported for user. Add TODO for clean up. Not all work is done with this cl. Things need follow up 1. Handle string loading before login. 2. Better handling webview. 3. Terms of service webview loading uses adding class to set display: none. 4. Large group of text are still not broken into blocks. Bug: 1047807 Test: Update browser tests Test: Manual Change-Id: If627f6680d416a134aa429359fb7352fe0cc5de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081252Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#748536}
-
Sammie Quon authored
This patch does the following: 1) Converts RectHighlightPathGenerator to use RoundRect struct, which will mean clipping on the ink drop layer will be done instead of masking. 2) Introduces EmptyHighlightPathGenerator which is equivalent to overriding CreateInkDropMask to explicitly return nullptr. Test: manual Bug: 1056490 Change-Id: I4d17f148c719fce8dd6ded58e388369f2fe9aa19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079433Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#748535}
-
Mitsuru Oshima authored
This reduces the repainting during hotseat animation. Bug: 1049355 Change-Id: I36cbdb73f7417494b224c0d71f2efb1a6929c5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088972Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748534}
-
Curtis McMullan authored
This commit enables resize for the virtual keyboard by default. BUG=1019990 Change-Id: I4d4e24560a8cb6bc9adc157381ed598607fd01b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094379Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748533}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea3ddc9aefde..8a44af5cbad5 git log ea3ddc9aefde..8a44af5cbad5 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 reed@google.com remove unused isAPicture from shaderbase 2020-03-09 fmalita@chromium.org SkShaders::Blend/GPU: treat null inputs as input color 2020-03-09 mtklein@google.com add missing license line to SkVM_opts.h 2020-03-09 fmalita@chromium.org Remove SkMaskFilter::makeWithMatrix() 2020-03-09 nifong@google.com Add a canvas test to make and draw SkVertices 2020-03-09 scroggo@google.com Reland "Split building encoding from decoding" 2020-03-09 egdaniel@google.com Add d3d support for creating command lists. 2020-03-09 fmalita@chromium.org [skottie] Defibrillate wipe effects Created with: gclient setdep -r src/third_party/skia@8a44af5cbad5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ida1c5b5c95dfa74ce1c8b46f00f44eea5558e61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748532}
-
Luciano Pacheco authored
When files in a folder are majority images, Grid View was hiding the file name. This feature shouldn't be enabled in the new design, this CL fixes this. Bug: 1059664 Change-Id: I85c5ec0b29358bf141ccb831dd2071a37b991178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094380 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748531}
-
Ovidio Henriquez authored
This is a reland of e19d9ff7 Original change's description: > bluetooth: Implement FakeBluetoothDelegate > > This change implements FakeBluetoothDelegate which fakes the behavior of > the new Web Bluetooth permissions implemented behied the > WebBluetoothNewPermissionsBackend flag. Therefore, the > web-bluetooth-new-permissions-backend virtual test suite runs the Web > Bluetooth tests with this flag enabled. > > Design doc: > https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/ > > Bug: 577953 > Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813 > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746429} Bug: 577953 Change-Id: I7442aca2e2bb816a93873d0bb76c3ec7e153b6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087904Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#748530}
-
