GitLab

BUG=670817
TBR=kbr@chromium.org,jmadill@chromium.org
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577803002
Cr-Commit-Position: refs/heads/master@{#438631}

Follow up to https://codereview.chromium.org/2551283002/

BUG=none
R=lushnikov

Review-Url: https://codereview.chromium.org/2566463003
Cr-Commit-Position: refs/heads/master@{#438630}

This is a code clean up CL, in which we remove the code for old UI of
desktop capture picker. As we found the new UI works well.

BUG=644811

Review-Url: https://codereview.chromium.org/2560333002
Cr-Commit-Position: refs/heads/master@{#438629}

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562123002
Cr-Commit-Position: refs/heads/master@{#438628}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3ca06164..285b9f5a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2576803002
Cr-Commit-Position: refs/heads/master@{#438627}

BUG=673855

Review-Url: https://codereview.chromium.org/2529043003
Cr-Commit-Position: refs/heads/master@{#438626}

Avoid an "Unable to thaw renderers." LOG(FATAL) in
RendererFreezer if freezing the renderers also failed
earlier. This is a workaround for unexplained EBADF and
ENOENT errors seen when writing to cgroups.

BUG=chromium:661310
TEST=manual: log in and chmod freezer.state in
     /sys/fs/cgroup/freezer/chrome_renderers/to_be_frozen
     to 444; suspend and resume and check that chrome
     doesn't abort

Review-Url: https://codereview.chromium.org/2575933002
Cr-Commit-Position: refs/heads/master@{#438625}

BUG=555865

Review-Url: https://codereview.chromium.org/2436023002
Cr-Commit-Position: refs/heads/master@{#438624}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2574773002
Cr-Commit-Position: refs/heads/master@{#438623}

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576023002
Cr-Commit-Position: refs/heads/master@{#438622}

This is a debugging feature that will be used on the official Win64 continuous builder to get a repro for some linker failures that we're observing. Having a link repro is the only way for us to report this kind of error to Microsoft in order for them to fix it (we haven't been able to reproduce this linker failure locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2570483004
Cr-Commit-Position: refs/heads/master@{#438621}

This change introduces SyncServiceBase as a base class of PSS and
consolidates engine initialization logic into it from PSS and SBHI.

This new class will enable us to siphon logic out of SBHI until it can
become SyncEngineProxy (no business logic). This change also begins
aligning SBHC with the SyncEngine interface, so it can eventually become
SyncEngineImpl.

BUG=669967

Review-Url: https://codereview.chromium.org/2559123002
Cr-Commit-Position: refs/heads/master@{#438620}

BUG=669096

Review-Url: https://codereview.chromium.org/2565343005
Cr-Commit-Position: refs/heads/master@{#438619}

BUG=674182
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2565283010
Cr-Commit-Position: refs/heads/master@{#438618}

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2570613002
Cr-Commit-Position: refs/heads/master@{#438617}

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Review-Url: https://codereview.chromium.org/2571893003
Cr-Original-Commit-Position: refs/heads/master@{#438533}
Cr-Commit-Position: refs/heads/master@{#438616}

Currently FetchHeaderList::sortAndCombine() only sorts the list and does not
combine values for the same key. This CL implements the missing part in the
function.

BUG=670439, 667376

Review-Url: https://codereview.chromium.org/2559273005
Cr-Commit-Position: refs/heads/master@{#438615}

The only button that shouldn't be draggable is the app list.
(arc deferred items were incorrectly marked non-draggable)
Remove the item delegate function to simplify shelf view code.

Add test support for trying to drag the app list button.
Update and expand the related unit test.

BUG=557406
TEST=Automated; no shelf dragging behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2575613002
Cr-Commit-Position: refs/heads/master@{#438614}

https://skia.googlesource.com/skia.git/+log/7a1cc6766d07..e305cc1f2a44

$ git log 7a1cc6766..e305cc1f2 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 robertphillips Partially defer GrSWMaskHelper
2016-12-14 scroggo Remove SkKTXImageEncoder
2016-12-14 fmalita SK_API-export SkCodec
2016-12-08 scroggo Add SkCodec::FrameInfo::fFullyReceived
2016-12-14 reed remove PLAIN_ENUM flag for SkClipOp
2016-12-14 reed add tests/bench for dynamicwstream

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2574323003
Cr-Commit-Position: refs/heads/master@{#438613}

BUG=664488
TEST=content_unittests,gpu is enabled in win/NVidia
R=kbr@chromium.org,kkinnunen@nvidia.com

Review-Url: https://codereview.chromium.org/2569413002
Cr-Commit-Position: refs/heads/master@{#438612}

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
Cr-Commit-Position: refs/heads/master@{#438611}

No intended behavior change.

BUG=

Review-Url: https://codereview.chromium.org/2569013003
Cr-Commit-Position: refs/heads/master@{#438610}

This is done by storing the source RenderViewHost and RenderProcessHost for each dragstart. Then, for other drag events (like dragover), if the target frame for that event is in the same RenderViewHost, but different RenderProcessHost, than the source, then the event is not fired.

Note that this patch will not affect behavior on Mac, and a subsequent CL will enforce the same thing for Mac.

BUG=666858

Review-Url: https://codereview.chromium.org/2568893002
Cr-Commit-Position: refs/heads/master@{#438609}

These 3 tests are flaky when run in random order or even alone.
As a first step in improving them, modify the tests to get away
from setTimeout and to verify that the pauseAnimationAPI is working.

This is unlikely to resolve the flakiness, but it will help narrow
the cause.

R=chrishtr
BUG=653722

Review-Url: https://codereview.chromium.org/2569063002
Cr-Commit-Position: refs/heads/master@{#438608}

BUG=663349

Review-Url: https://codereview.chromium.org/2568003005
Cr-Commit-Position: refs/heads/master@{#438607}

Replaces links that toggled a single accessibility mode with a set of
checkboxes representing more fine-grained control over accessibility
support.

Adds some more help text to the UI to explain to users what this is for.

There's more to be done but I don't want to completely overhaul the UI in
this change, I'd like to just make a good incremental step and most
importantly add support for all of the possible accessibility modes.

Depends on: https://codereview.chromium.org/2558933002/

BUG=672205

Review-Url: https://codereview.chromium.org/2552203005
Cr-Commit-Position: refs/heads/master@{#438606}

BUG=672950

Review-Url: https://codereview.chromium.org/2575823003
Cr-Commit-Position: refs/heads/master@{#438605}

[Mojo Video Capture] Decouple VideoCaptureController from VideoCaptureBufferPool and VideoCaptureDeviceClient

Decouple VideoCaptureController from VideoCaptureBufferPool and
VideoCaptureDeviceClient. This is needed in order to prepare
VideoCaptureController for working with both the (legacy) in-process video
capture and the new video_capture Mojo service.

List of changes:
* Introduce an abstraction FrameBufferHost for the VideoCaptureController to
  talk to the VideoCaptureBufferPool.
* Move VideoFrameReceiverOnIOThread to separate file.
* Move factory logic for creating and connecting
  VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
  VideoCaptureController and into VideoCaptureManager as well as the tests.
* Update OWNERS to include new file and include chfremer as owner.
* In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.8

BUG=584797
TEST=
  content_unittests,
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2551193002
Cr-Commit-Position: refs/heads/master@{#438604}

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2578623002
Cr-Commit-Position: refs/heads/master@{#438603}

Reason for revert: crashing on android, spike in datatype errors across
platforms. See crbug.com/673618

Reland of [Sync] Put session tracker in charge of maintaining local state.

Previously, the session tracker was only updated when local tabs were
available in the TabModel. It was not updated with sync data from a previous
session (and as a result, we had to pass around the restored_data list
at association time in order to handle restoring placeholder tabs).

The session tracker now gets updated at startup of previous local state,
which is then used when reassociating restored tabs. This is a purely
refactoring change that should not introduce user visible changes
(although internally the data is managed in a different way).

To make this happen, InitFromSyncModel now treats local tabs and remote
tabs the same. In addition, the SyncedSessionTracker now has a
ReassociateTab method that can be called to update the tab id of a
SessionTab. To make this work, the TabNodePool has been moved into
the SyncedSessionTracker, and in general data ownership has been
simplified (with quite a few new tests added).

This is all necessary in order to enable preserving tabs from a previous
session when they're not present in the TabModel (which can happen on
Android when a custom tab is opened, but the main tabbed activity is not
loaded).

BUG=639009, 673618
Committed: https://crrev.com/159246f269b561bf931fa56a35b2704fab7dcc96
Cr-Commit-Position: refs/heads/master@{#436786}

TBR=skym@chromium.org

Review-Url: https://codereview.chromium.org/2575773003
Cr-Commit-Position: refs/heads/master@{#438602}

https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7

create*() methods, fenceSync() method, and getTransformFeedbackVarying()
method cause no change in generated files

BUG=662005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2568743009
Cr-Commit-Position: refs/heads/master@{#438601}

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742

Review-Url: https://codereview.chromium.org/2571623002
Cr-Commit-Position: refs/heads/master@{#438600}

BUG=630181

Review-Url: https://codereview.chromium.org/2573533003
Cr-Commit-Position: refs/heads/master@{#438599}

BUG=672263

Review-Url: https://codereview.chromium.org/2570383002
Cr-Commit-Position: refs/heads/master@{#438598}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/editing/.
There are too many references to change them all at once, so this CL is
part 5 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2571953004
Cr-Commit-Position: refs/heads/master@{#438597}

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.

Review-Url: https://codereview.chromium.org/2570013003
Cr-Commit-Position: refs/heads/master@{#438596}

Without this, the test seems to fail after clang roll
https://codereview.chromium.org/2577523002
Since there's already a workaround, this is likely triggering
the same existing bug that already has a workaround, and not
due to a new compiler bug.

BUG=673463,674194
TBR=tkent

Review-Url: https://codereview.chromium.org/2569763006
Cr-Commit-Position: refs/heads/master@{#438595}

In Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses the TabCapture API for the first time, we show the user a dialog where they can choose whether to allow the extension access to the API.

This CL will also whitelist desktopCapture manifest permission feature as it's already safe in its current form (user is prompted) together with tabCapture.

BUG=672093

Review-Url: https://codereview.chromium.org/2558843002
Cr-Commit-Position: refs/heads/master@{#438594}

BUG=673058

Review-Url: https://codereview.chromium.org/2577683002
Cr-Commit-Position: refs/heads/master@{#438593}

Today, even if domain admins set a wallpaper policy, every device
shows up with the branding of the OEM until a user logs into the
device (and then the user wallpaper policy kicks in). We introduce
a new device policy in this CL for domain admins to set a device
level policy rather than a user level policy for setting a wallpaper.
That way the wallpaper will change after being enrolled to the domain
without requiring users to log in. This only impacts the startscreen
wallpaper, if the domain admin has set a different wallpaper in the
user policy or has allowed the users to select their own wallpaper,
that one will be displayed within a session.

Note this CL only introduces the policy, the implementation to reflect
the policy is addressed in another CL:
https://codereview.chromium.org/2572793003/.

BUG=475998

Review-Url: https://codereview.chromium.org/2544693002
Cr-Commit-Position: refs/heads/master@{#438592}